Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

fix: Order categories by name in CategoryGroup model (#472)

Júnior Almeida03e223e0cfaa
diff --git a/backend/app/models/category_group.py b/backend/app/models/category_group.py
index cb6df34a..a6fbcf19 100644
--- a/backend/app/models/category_group.py
+++ b/backend/app/models/category_group.py
@@ -27,4 +27,7 @@ class CategoryGroup(Base):
is_system: Mapped[bool] = mapped_column(Boolean, default=False)
user: Mapped["User"] = relationship(back_populates="category_groups")
- categories: Mapped[list["Category"]] = relationship(back_populates="group")
+ categories: Mapped[list["Category"]] = relationship(
+ back_populates="group",
+ order_by="Category.name",
+ )
diff --git a/backend/tests/test_category_service.py b/backend/tests/test_category_service.py
index c998116f..bb58d71f 100644
--- a/backend/tests/test_category_service.py
+++ b/backend/tests/test_category_service.py
@@ -7,6 +7,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.models.category import Category
from app.models.category_group import CategoryGroup
from app.schemas.category import CategoryCreate, CategoryUpdate
+from app.services.category_group_service import get_groups
from app.services.category_service import (
DEFAULT_CATEGORIES_I18N,
create_category,
@@ -158,6 +159,17 @@ async def test_get_categories_ordered(session: AsyncSession, test_user, test_wor
assert system_idx < custom_idx
+async def test_get_categories_group_ordered_by_name(session: AsyncSession, test_user, test_workspace):
+ await create_default_categories(session, test_user.id, lang="pt-BR")
+
+ groups = await get_groups(session, test_workspace.id)
+ food_group = [g for g in groups if g.name == "Alimentação"][0]
+
+ names = [c.name for c in food_group.categories]
+ assert names == sorted(names)
+
+
@pytest.mark.asyncio
async def test_get_categories_excludes_other_users(
session: AsyncSession, test_user, test_workspace, test_categories