Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

feat(categories): create categories and payees without leaving the form (#1007)

Tássio Noronha33d43e46ee9a
diff --git a/frontend/src/components/category-select.test.tsx b/frontend/src/components/category-select.test.tsx
new file mode 100644
index 00000000..93df65ff
--- /dev/null
+++ b/frontend/src/components/category-select.test.tsx
@@ -0,0 +1,109 @@
+import { useState, type ReactNode } from 'react'
+import { screen, waitFor } from '@testing-library/react'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+import { renderWithProviders, t } from '@/test/utils'
+import { WorkspaceContext } from '@/contexts/workspace-context'
+import type { Category } from '@/types'
+
+const { create } = vi.hoisted(() => ({ create: vi.fn() }))
+vi.mock('@/lib/api', () => ({ categories: { create } }))
+vi.mock('sonner', () => ({ toast: { success: vi.fn(), error: vi.fn() } }))
+
+import { CategorySelect } from './category-select'
+
+const groceries = {
+ id: 'cat-1',
+ name: 'Groceries',
+ icon: 'shopping-cart',
+ color: '#10b981',
+ group_id: null,
+} as unknown as Category
+
+function withRole(canWrite: boolean) {
+ return function Workspace({ children }: { children: ReactNode }) {
+ return (
+ <WorkspaceContext.Provider
+ value={{ canWrite } as unknown as React.ContextType<typeof WorkspaceContext>}
+ >
+ {children}
+ </WorkspaceContext.Provider>
+ )
+ }
+}
+
+function renderSelect({ canWrite = true, creatable = true } = {}) {
+ const onChange = vi.fn()
+ const Workspace = withRole(canWrite)
+ // Holds the value like a real form does, so a test sees what the trigger
+ // shows after a change rather than only that a callback ran.
+ function Harness() {
+ const [value, setValue] = useState('')
+ return (
+ <CategorySelect
+ value={value}
+ onChange={(v) => { setValue(v); onChange(v) }}
+ categories={[groceries]}
+ groups={[]}
+ allowNone
+ creatable={creatable}
+ />
+ )
+ }
+ const utils = renderWithProviders(
+ <Workspace>
+ <Harness />
+ </Workspace>,
+ )
+ return { ...utils, onChange }
+}
+
+async function openAndType(user: ReturnType<typeof renderWithProviders>['user'], text: string) {
+ await user.click(screen.getByRole('button'))
+ await user.type(screen.getByPlaceholderText(t('transactions.searchCategory')), text)
+}
+
+describe('CategorySelect inline creation', () => {
+ beforeEach(() => {
+ create.mockReset()
+ })
+
+ it('creates the searched category and selects it', async () => {
+ create.mockResolvedValue({ ...groceries, id: 'cat-new', name: 'Pet food', color: '#6366f1' })
+ const { user, onChange, queryClient } = renderSelect()
+ const invalidate = vi.spyOn(queryClient, 'invalidateQueries')
+
+ await openAndType(user, 'Pet food')
+ await user.click(screen.getByText(t('common.createNamed', { name: 'Pet food' })))
+
+ await waitFor(() => expect(onChange).toHaveBeenCalledWith('cat-new'))
+ // The supplied list has not refetched, yet the trigger shows the new category.
+ expect(screen.getByRole('button', { name: 'Pet food' })).toBeInTheDocument()
+ expect(create).toHaveBeenCalledWith({ name: 'Pet food', icon: 'circle-help', color: '#6366f1' })
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ['categories'] })
+ })
+
+ it('does not offer to create a name that already exists', async () => {
+ const { user } = renderSelect()
+
+ await openAndType(user, 'groceries')
+
+ expect(screen.queryByText(t('common.createNamed', { name: 'groceries' }))).not.toBeInTheDocument()
+ })
+
+ it('never offers creation to a viewer', async () => {
+ const { user } = renderSelect({ canWrite: false })
+
+ await openAndType(user, 'Pet food')
+
+ expect(screen.queryByText(t('common.createNamed', { name: 'Pet food' }))).not.toBeInTheDocument()
+ })
+
+ it('does not offer creation unless the picker opts in', async () => {
+ const { user } = renderSelect({ creatable: false })
+
+ await openAndType(user, 'Pet food')
+
+ expect(screen.queryByText(t('common.createNamed', { name: 'Pet food' }))).not.toBeInTheDocument()
+ })
+})
diff --git a/frontend/src/components/category-select.tsx b/frontend/src/components/category-select.tsx
index 72dc78c0..d73701db 100644
--- a/frontend/src/components/category-select.tsx
+++ b/frontend/src/components/category-select.tsx
@@ -1,8 +1,15 @@
-import { useState, useMemo } from 'react'
+import { useState, useMemo, useContext } from 'react'
import { useTranslation } from 'react-i18next'
-import { ChevronDownIcon, CheckIcon } from 'lucide-react'
+import { useMutation, useQueryClient } from '@tanstack/react-query'
+import { toast } from 'sonner'
+import { ChevronDownIcon, CheckIcon, PlusIcon } from 'lucide-react'
import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover'
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '@/components/ui/command'
+import { WorkspaceContext } from '@/contexts/workspace-context'
+import { categories as categoriesApi } from '@/lib/api'
+import { extractApiError } from '@/lib/api-errors'
+import { invalidateCategoryQueries } from '@/lib/invalidate-queries'
+import { inlineCreateItemValue, inlineCreateName } from '@/lib/inline-create'
import type { Category, CategoryGroup } from '@/types'
import { cn, normalizeText } from '@/lib/utils'
import {
@@ -10,6 +17,11 @@ import {
resolveSelectedCategory,
} from '@/lib/category-selection-utils'
+// Same starting look the categories page gives a new category, so one made
+// from a picker is indistinguishable from one made there.
+const NEW_CATEGORY_ICON = 'circle-help'
+const NEW_CATEGORY_COLOR = '#6366f1'
+
interface CategorySelectProps {
value: string
onChange: (value: string) => void
@@ -20,6 +32,11 @@ interface CategorySelectProps {
disabled?: boolean
className?: string
allowNone?: boolean
+ /**
+ * Offer to create a category named after the search text when nothing
+ * matches it. Only shown to members who can write to the workspace.
+ */
+ creatable?: boolean
contentProps?: React.ComponentProps<typeof PopoverContent>
}
@@ -34,10 +51,44 @@ export function CategorySelect({
disabled = false,
className,
allowNone = false,
+ creatable = false,
contentProps,
}: CategorySelectProps) {
const [open, setOpen] = useState(false)
+ const [search, setSearch] = useState('')
+ // The category just created here. The list catches up once the refetch
+ // lands; until then this keeps the trigger showing the new name.
+ const [created, setCreated] = useState<Category | null>(null)
const { t } = useTranslation()
+ const queryClient = useQueryClient()
+ // Read the context directly rather than through useWorkspace, so the
+ // picker still renders (without creation) outside a workspace provider.
+ const canWrite = useContext(WorkspaceContext)?.canWrite ?? false
+ const canCreate = creatable && canWrite
+
+ const createMutation = useMutation({
+ mutationFn: (name: string) =>
+ categoriesApi.create({ name, icon: NEW_CATEGORY_ICON, color: NEW_CATEGORY_COLOR }),
+ onSuccess: (category) => {
+ // Only the category lists refetch. Whatever form hosts this picker
+ // (an import preview, a half-filled transaction) keeps its state.
+ invalidateCategoryQueries(queryClient)
+ setCreated(category)
+ onChange(category.id)
+ handleOpenChange(false)
+ toast.success(t('categories.created'))
+ },
+ onError: (err: unknown) => toast.error(extractApiError(err, t('common.error'))),
+ })
+
+ function handleOpenChange(next: boolean) {
+ setOpen(next)
+ if (!next) setSearch('')
+ }
+
+ const createName = canCreate
+ ? inlineCreateName(search, (categories ?? []).map((c) => c.name))
+ : null
const resolvedPlaceholder = placeholder ?? t('transactions.selectCategory', 'Select category')
@@ -56,15 +107,16 @@ export function CategorySelect({
}, [categories, groups, t])
const selectedCategory = useMemo(() => {
- return resolveSelectedCategory(categories ?? [], value, currentCategory)
- }, [categories, currentCategory, value])
- const selectedCategoryIsHidden = isCategoryHiddenFromSelection(
- categories ?? [],
- selectedCategory
- )
+ const fallback = created && created.id === value ? created : currentCategory
+ return resolveSelectedCategory(categories ?? [], value, fallback)
+ }, [categories, created, currentCategory, value])
+ // A category created a moment ago is not hidden, only not refetched yet.
+ const selectedCategoryIsHidden =
+ selectedCategory !== created
+ && isCategoryHiddenFromSelection(categories ?? [], selectedCategory)
return (
- <Popover open={open} onOpenChange={setOpen}>
+ <Popover open={open} onOpenChange={handleOpenChange}>
<PopoverTrigger asChild>
<button
type="button"
@@ -109,7 +161,11 @@ export function CategorySelect({
return normalizeText(itemValue).includes(normalizeText(search)) ? 1 : 0
}}
>
- <CommandInput placeholder={t('transactions.searchCategory')} />
+ <CommandInput
+ placeholder={t('transactions.searchCategory')}
+ value={search}
+ onValueChange={setSearch}
+ />
<CommandList>
<CommandEmpty>{t('transactions.noCategoryFound')}</CommandEmpty>
{allowNone && (
@@ -118,7 +174,7 @@ export function CategorySelect({
value={`none ${t('transactions.noCategory')}`}
onSelect={() => {
onChange('')
- setOpen(false)
+ handleOpenChange(false)
}}
className="italic text-muted-foreground cursor-pointer"
>
@@ -138,7 +194,7 @@ export function CategorySelect({
value={`${group.name} ${cat.name}`}
onSelect={() => {
onChange(cat.id)
- setOpen(false)
+ handleOpenChange(false)
}}
className="cursor-pointer"
>
@@ -156,6 +212,19 @@ export function CategorySelect({
))}
</CommandGroup>
))}
+ {createName && (
+ <CommandGroup>
+ <CommandItem
+ value={inlineCreateItemValue(search)}
+ disabled={createMutation.isPending}
+ onSelect={() => createMutation.mutate(createName)}
+ className="cursor-pointer"
+ >
+ <PlusIcon className="size-4 shrink-0 text-muted-foreground" />
+ <span className="truncate">{t('common.createNamed', { name: createName })}</span>
+ </CommandItem>
+ </CommandGroup>
+ )}
</CommandList>
</Command>
</PopoverContent>
diff --git a/frontend/src/components/import-review-table.tsx b/frontend/src/components/import-review-table.tsx
index bca4baf6..05db4cd9 100644
--- a/frontend/src/components/import-review-table.tsx
+++ b/frontend/src/components/import-review-table.tsx
@@ -197,6 +197,7 @@ export function ImportReviewTable({
groups={groups}
placeholder={t('import.noCategory')}
allowNone
+ creatable
className="w-full border border-border rounded-md px-2 py-1 text-xs bg-card focus:outline-none focus-visible:ring-ring/30 focus-visible:ring-[2px]"
/>
</TableCell>
diff --git a/frontend/src/components/payee-select.test.tsx b/frontend/src/components/payee-select.test.tsx
new file mode 100644
index 00000000..caa127ab
--- /dev/null
+++ b/frontend/src/components/payee-select.test.tsx
@@ -0,0 +1,107 @@
+import { useState, type ReactNode } from 'react'
+import { screen, waitFor } from '@testing-library/react'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+import { renderWithProviders, t } from '@/test/utils'
+import { WorkspaceContext } from '@/contexts/workspace-context'
+import type { Payee } from '@/types'
+
+const { create } = vi.hoisted(() => ({ create: vi.fn() }))
+vi.mock('@/lib/api', () => ({ payees: { create } }))
+vi.mock('sonner', () => ({ toast: { success: vi.fn(), error: vi.fn() } }))
+
+import { PayeeSelect } from './payee-select'
+
+const acme = { id: 'payee-1', name: 'Acme Market' } as Payee
+const bakery = { id: 'payee-2', name: 'Corner Bakery' } as Payee
+
+function Workspace({ canWrite, children }: { canWrite: boolean; children: ReactNode }) {
+ return (
+ <WorkspaceContext.Provider
+ value={{ canWrite } as unknown as React.ContextType<typeof WorkspaceContext>}
+ >
+ {children}
+ </WorkspaceContext.Provider>
+ )
+}
+
+// Holds the value like a real form does, so a test sees what the trigger
+// shows after a change rather than only that a callback ran.
+function Harness({ initial, onChange }: { initial: string; onChange: (v: string) => void }) {
+ const [value, setValue] = useState(initial)
+ return (
+ <PayeeSelect
+ value={value}
+ onChange={(v) => { setValue(v); onChange(v) }}
+ payees={[bakery, acme]}
+ creatable
+ />
+ )
+}
+
+function renderSelect({ canWrite = true, value = '' } = {}) {
+ const onChange = vi.fn()
+ const utils = renderWithProviders(
+ <Workspace canWrite={canWrite}>
+ <Harness initial={value} onChange={onChange} />
+ </Workspace>,
+ )
+ return { ...utils, onChange }
+}
+
+async function openAndType(user: ReturnType<typeof renderWithProviders>['user'], text: string) {
+ await user.click(screen.getByRole('button'))
+ await user.type(screen.getByPlaceholderText(t('payees.searchPlaceholder')), text)
+}
+
+describe('PayeeSelect', () => {
+ beforeEach(() => {
+ create.mockReset()
+ })
+
+ it('names the trigger after the selected payee', () => {
+ renderSelect({ value: 'payee-2' })
+ expect(screen.getByRole('button', { name: 'Corner Bakery' })).toBeInTheDocument()
+ })
+
+ it('names the trigger "no payee" when none is selected', () => {
+ renderSelect()
+ expect(screen.getByRole('button', { name: t('payees.noPayee') })).toBeInTheDocument()
+ })
+
+ it('filters payees by name and selects one', async () => {
+ const { user, onChange } = renderSelect()
+
+ await openAndType(user, 'acme')
+
+ expect(screen.queryByText('Corner Bakery')).not.toBeInTheDocument()
+ await user.click(screen.getByText('Acme Market'))
+ expect(onChange).toHaveBeenCalledWith('payee-1')
+ })
+
+ it('creates the searched payee and selects it', async () => {
+ create.mockResolvedValue({ id: 'payee-new', name: 'Dog Groomer' })
+ const { user, onChange, queryClient } = renderSelect()
+ const invalidate = vi.spyOn(queryClient, 'invalidateQueries')
+
+ await openAndType(user, 'Dog Groomer')
+ await user.click(screen.getByText(t('common.createNamed', { name: 'Dog Groomer' })))
+
+ await waitFor(() => expect(onChange).toHaveBeenCalledWith('payee-new'))
+ // The supplied list has not refetched, yet the trigger shows the new payee.
+ expect(screen.getByRole('button', { name: 'Dog Groomer' })).toBeInTheDocument()
+ expect(create).toHaveBeenCalledWith({ name: 'Dog Groomer' })
+ expect(invalidate).toHaveBeenCalledWith({ queryKey: ['payees'] })
+ })
+
+ it('does not offer to create an existing payee or to a viewer', async () => {
+ const { user, unmount } = renderSelect()
+ await openAndType(user, 'ACME MARKET')
+ expect(screen.queryByText(t('common.createNamed', { name: 'ACME MARKET' }))).not.toBeInTheDocument()
+ unmount()
+
+ const viewer = renderSelect({ canWrite: false })
+ await openAndType(viewer.user, 'Dog Groomer')
+ expect(screen.queryByText(t('common.createNamed', { name: 'Dog Groomer' }))).not.toBeInTheDocument()
+ })
+})
diff --git a/frontend/src/components/payee-select.tsx b/frontend/src/components/payee-select.tsx
new file mode 100644
index 00000000..9ae6257b
--- /dev/null
+++ b/frontend/src/components/payee-select.tsx
@@ -0,0 +1,161 @@
+import { useContext, useMemo, useState } from 'react'
+import { useTranslation } from 'react-i18next'
+import { useMutation, useQueryClient } from '@tanstack/react-query'
+import { toast } from 'sonner'
+import { CheckIcon, ChevronDownIcon, PlusIcon } from 'lucide-react'
+import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover'
+import { Command, CommandEmpty, CommandGroup, CommandInput, CommandItem, CommandList } from '@/components/ui/command'
+import { WorkspaceContext } from '@/contexts/workspace-context'
+import { payees as payeesApi } from '@/lib/api'
+import { inlineCreateItemValue, inlineCreateName } from '@/lib/inline-create'
+import { payeeErrorMessage } from '@/lib/payee-error-message'
+import { cn, normalizeText } from '@/lib/utils'
+import type { Payee } from '@/types'
+
+interface PayeeSelectProps {
+ value: string
+ onChange: (value: string) => void
+ payees: Payee[]
+ disabled?: boolean
+ className?: string
+ /**
+ * Offer to create a payee named after the search text when nothing
+ * matches it. Only shown to members who can write to the workspace.
+ */
+ creatable?: boolean
+}
+
+/** Searchable payee picker. An empty value means "no payee". */
+export function PayeeSelect({
+ value,
+ onChange,
+ payees,
+ disabled = false,
+ className,
+ creatable = false,
+}: PayeeSelectProps) {
+ const { t } = useTranslation()
+ const queryClient = useQueryClient()
+ const [open, setOpen] = useState(false)
+ const [search, setSearch] = useState('')
+ // The payee just created here, shown until the refetched list has it.
+ const [created, setCreated] = useState<Payee | null>(null)
+ const canWrite = useContext(WorkspaceContext)?.canWrite ?? false
+ const canCreate = creatable && canWrite
+
+ const sortedPayees = useMemo(
+ () => [...(payees ?? [])].sort((a, b) => a.name.localeCompare(b.name)),
+ [payees],
+ )
+
+ const selected = useMemo(
+ () => sortedPayees.find((p) => p.id === value)
+ ?? (created && created.id === value ? created : undefined),
+ [sortedPayees, created, value],
+ )
+
+ function handleOpenChange(next: boolean) {
+ setOpen(next)
+ if (!next) setSearch('')
+ }
+
+ const createMutation = useMutation({
+ mutationFn: (name: string) => payeesApi.create({ name }),
+ onSuccess: (payee) => {
+ queryClient.invalidateQueries({ queryKey: ['payees'] })
+ setCreated(payee)
+ onChange(payee.id)
+ handleOpenChange(false)
+ toast.success(t('payees.created'))
+ },
+ onError: (err: unknown) => toast.error(payeeErrorMessage(err, t) ?? t('common.error')),
+ })
+
+ const createName = canCreate
+ ? inlineCreateName(search, sortedPayees.map((p) => p.name))
+ : null
+
+ return (
+ <Popover open={open} onOpenChange={handleOpenChange}>
+ <PopoverTrigger asChild>
+ <button
+ type="button"
+ disabled={disabled}
+ className={cn(
+ "flex w-full items-center justify-between gap-2 rounded-md border border-input bg-card px-3 py-2 text-sm text-left shadow-xs transition-[color,box-shadow] outline-hidden focus-visible:border-ring focus-visible:ring-[3px] focus-visible:ring-ring/50 disabled:cursor-not-allowed disabled:opacity-50 dark:bg-input/30 dark:hover:bg-input/50 h-9 cursor-pointer",
+ className,
+ )}
+ >
+ <span className="min-w-0 truncate">
+ {selected ? (
+ selected.name
+ ) : (
+ <span className="text-muted-foreground">{t('payees.noPayee')}</span>
+ )}
+ </span>
+ <ChevronDownIcon className="size-4 shrink-0 opacity-50" />
+ </button>
+ </PopoverTrigger>
+ <PopoverContent align="start" className="w-[var(--radix-popover-trigger-width)] p-0 overflow-hidden">
+ <Command
+ filter={(itemValue, query, keywords) => {
+ // Payee rows match on their name (keywords), never on the id
+ // that only keeps their cmdk value unique.
+ const text = keywords?.length ? keywords.join(' ') : itemValue
+ return normalizeText(text).includes(normalizeText(query)) ? 1 : 0
+ }}
+ >
+ <CommandInput
+ placeholder={t('payees.searchPlaceholder')}
+ value={search}
+ onValueChange={setSearch}
+ />
+ <CommandList>
+ <CommandEmpty>{t('payees.noPayeeFound')}</CommandEmpty>
+ <CommandGroup>
+ <CommandItem
+ value={`__none__ ${t('payees.noPayee')}`}
+ onSelect={() => {
+ onChange('')
+ handleOpenChange(false)
+ }}
+ className="italic text-muted-foreground cursor-pointer"
+ >
+ <span className="flex-1">{t('payees.noPayee')}</span>
+ {value === '' && <CheckIcon className="size-4 shrink-0" />}
+ </CommandItem>
+ {sortedPayees.map((payee) => (
+ <CommandItem
+ key={payee.id}
+ value={payee.id}
+ keywords={[payee.name]}
+ onSelect={() => {
+ onChange(payee.id)
+ handleOpenChange(false)
+ }}
+ className="cursor-pointer"
+ >
+ <span className="flex-1 truncate">{payee.name}</span>
+ {value === payee.id && <CheckIcon className="size-4 shrink-0" />}
+ </CommandItem>
+ ))}
+ </CommandGroup>
+ {createName && (
+ <CommandGroup>
+ <CommandItem
+ value={inlineCreateItemValue(search)}
+ disabled={createMutation.isPending}
+ onSelect={() => createMutation.mutate(createName)}
+ className="cursor-pointer"
+ >
+ <PlusIcon className="size-4 shrink-0 text-muted-foreground" />
+ <span className="truncate">{t('common.createNamed', { name: createName })}</span>
+ </CommandItem>
+ </CommandGroup>
+ )}
+ </CommandList>
+ </Command>
+ </PopoverContent>
+ </Popover>
+ )
+}
diff --git a/frontend/src/components/rule-dialog.tsx b/frontend/src/components/rule-dialog.tsx
index 3af577cd..4c986ad5 100644
--- a/frontend/src/components/rule-dialog.tsx
+++ b/frontend/src/components/rule-dialog.tsx
@@ -707,6 +707,7 @@ export function RuleDialog({
(category) => category.id === action.value
)}
placeholder={t('rules.selectCategory')}
+ creatable
className={`${SELECT_CLASS} w-full`}
/>
</div>
diff --git a/frontend/src/components/transaction-dialog.tsx b/frontend/src/components/transaction-dialog.tsx
index 7078f49b..4eadd4cc 100644
--- a/frontend/src/components/transaction-dialog.tsx
+++ b/frontend/src/components/transaction-dialog.tsx
@@ -35,6 +35,7 @@ import {
DropdownMenuTrigger,
} from '@/components/ui/dropdown-menu'
import { CategorySelect } from '@/components/category-select'
+import { PayeeSelect } from '@/components/payee-select'
import { RuleDialog, type RuleDialogInitialData } from '@/components/rule-dialog'
import { TransactionAttachments } from '@/components/transaction-attachments'
import type { AttachmentPreview } from '@/components/transaction-attachments'
@@ -1116,6 +1117,7 @@ function TransactionForm({
groups={displayCategoryGroups}
currentCategory={seed?.category}
allowNone={true}
+ creatable
className="bg-card"
/>
</div>
@@ -1123,16 +1125,12 @@ function TransactionForm({
<div className={cn("grid gap-4", isSynced ? "grid-cols-1" : "grid-cols-2")}>
<div className="space-y-2">
<Label>{t('payees.payee')}</Label>
- <select
- className="w-full border border-border rounded-md px-3 py-2 text-sm bg-card focus:outline-none focus-visible:ring-ring/30 focus-visible:ring-[2px]"
+ <PayeeSelect
value={payeeId}
- onChange={(e) => setPayeeId(e.target.value)}
- >
- <option value="">{t('payees.noPayee')}</option>
- {(payeesList ?? []).map((p) => (
- <option key={p.id} value={p.id}>{p.name}</option>
- ))}
- </select>
+ onChange={setPayeeId}
+ payees={payeesList ?? []}
+ creatable
+ />
{isSynced && transaction?.payee && (
<p className="text-xs text-muted-foreground">{t('payees.rawPayee')}: {transaction.payee}</p>
)}
diff --git a/frontend/src/lib/inline-create.test.ts b/frontend/src/lib/inline-create.test.ts
new file mode 100644
index 00000000..3e845732
--- /dev/null
+++ b/frontend/src/lib/inline-create.test.ts
@@ -0,0 +1,28 @@
+import { describe, expect, it } from 'vitest'
+
+import { inlineCreateItemValue, inlineCreateName } from './inline-create'
+
+describe('inlineCreateName', () => {
+ it('offers the trimmed search text when nothing has that name', () => {
+ expect(inlineCreateName(' Pet food ', ['Groceries'])).toBe('Pet food')
+ })
+
+ it('offers nothing for a blank search', () => {
+ expect(inlineCreateName(' ', ['Groceries'])).toBeNull()
+ })
+
+ it('treats names that differ only in case or accents as the same', () => {
+ expect(inlineCreateName('GROCERIES', ['Groceries'])).toBeNull()
+ expect(inlineCreateName('saude', ['Saúde'])).toBeNull()
+ })
+
+ it('still offers a name that only partially matches', () => {
+ expect(inlineCreateName('Groc', ['Groceries'])).toBe('Groc')
+ })
+})
+
+describe('inlineCreateItemValue', () => {
+ it('contains the search text so the picker filter keeps the row', () => {
+ expect(inlineCreateItemValue('Pet food ')).toContain('Pet food ')
+ })
+})
diff --git a/frontend/src/lib/inline-create.ts b/frontend/src/lib/inline-create.ts
new file mode 100644
index 00000000..b91a5299
--- /dev/null
+++ b/frontend/src/lib/inline-create.ts
@@ -0,0 +1,20 @@
+import { normalizeText } from '@/lib/utils'
+
+/**
+ * The name a searchable picker should offer to create, or null when it
+ * should not offer anything: the search is blank, or an existing option
+ * already carries that name (ignoring case and accents), so creating it
+ * would only make a duplicate.
+ */
+export function inlineCreateName(search: string, existingNames: string[]): string | null {
+ const name = search.trim()
+ if (!name) return null
+ const wanted = normalizeText(name)
+ return existingNames.some((existing) => normalizeText(existing.trim()) === wanted) ? null : name
+}
+
+/** cmdk value for the "Create" row. It carries the search text so the
+ * picker's own filter always keeps the row visible. */
+export function inlineCreateItemValue(name: string): string {
+ return `__create__ ${name}`
+}
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index 5875c6ab..d4d561b7 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -1837,6 +1837,7 @@
"loadError": "Bericht konnte nicht geladen werden"
},
"payees": {
+ "noPayeeFound": "Kein Zahlungsempfänger gefunden.",
"addFavorite": "Zu Favoriten hinzufügen",
"removeFavorite": "Aus Favoriten entfernen",
"favoriteError": "Favorit konnte nicht aktualisiert werden",
@@ -1943,6 +1944,7 @@
"anyCountry": "Anderswo"
},
"common": {
+ "createNamed": "„{{name}}“ erstellen",
"view": "Ansehen",
"add": "Hinzufügen",
"save": "Speichern",
diff --git a/frontend/src/locales/el.json b/frontend/src/locales/el.json
index 458c22c1..dbea9332 100644
--- a/frontend/src/locales/el.json
+++ b/frontend/src/locales/el.json
@@ -1760,6 +1760,7 @@
"regenerate": "Επανυπολογισμός"
},
"payees": {
+ "noPayeeFound": "Δεν βρέθηκε δικαιούχος.",
"addFavorite": "Προσθήκη στα αγαπημένα",
"removeFavorite": "Αφαίρεση από τα αγαπημένα",
"title": "Δικαιούχοι",
@@ -1942,6 +1943,7 @@
"anyCountry": "Οπουδήποτε αλλού"
},
"common": {
+ "createNamed": "Δημιουργία «{{name}}»",
"view": "Προβολή",
"add": "Προσθήκη",
"save": "Αποθήκευση",
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 3aff81cf..83b422f7 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -1836,6 +1836,7 @@
"loadError": "Failed to load report"
},
"payees": {
+ "noPayeeFound": "No payee found.",
"addFavorite": "Add to favorites",
"removeFavorite": "Remove from favorites",
"favoriteError": "Could not update favorite",
@@ -1942,6 +1943,7 @@
"anyCountry": "Anywhere else"
},
"common": {
+ "createNamed": "Create \"{{name}}\"",
"view": "View",
"add": "Add",
"save": "Save",
diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.json
index f99dac18..43357281 100644
--- a/frontend/src/locales/es.json
+++ b/frontend/src/locales/es.json
@@ -1837,6 +1837,7 @@
"loadError": "No se pudo cargar el informe"
},
"payees": {
+ "noPayeeFound": "No se encontró ningún beneficiario.",
"addFavorite": "Añadir a favoritos",
"removeFavorite": "Quitar de favoritos",
"favoriteError": "No se pudo actualizar el favorito",
@@ -1943,6 +1944,7 @@
"anyCountry": "Cualquier otro lugar"
},
"common": {
+ "createNamed": "Crear \"{{name}}\"",
"view": "Ver",
"add": "Añadir",
"save": "Guardar",
diff --git a/frontend/src/locales/fr.json b/frontend/src/locales/fr.json
index 807c6cb3..23aaca49 100644
--- a/frontend/src/locales/fr.json
+++ b/frontend/src/locales/fr.json
@@ -1837,6 +1837,7 @@
"loadError": "Échec du chargement du rapport"
},
"payees": {
+ "noPayeeFound": "Aucun bénéficiaire trouvé.",
"addFavorite": "Ajouter aux favoris",
"removeFavorite": "Retirer des favoris",
"favoriteError": "Impossible de mettre à jour le favori",
@@ -1943,6 +1944,7 @@
"anyCountry": "Ailleurs"
},
"common": {
+ "createNamed": "Créer « {{name}} »",
"view": "Voir",
"add": "Ajouter",
"save": "Enregistrer",
diff --git a/frontend/src/locales/hi.json b/frontend/src/locales/hi.json
index 9353b499..b11bb4e5 100644
--- a/frontend/src/locales/hi.json
+++ b/frontend/src/locales/hi.json
@@ -1836,6 +1836,7 @@
"loadError": "रिपोर्ट लोड करने में विफल"
},
"payees": {
+ "noPayeeFound": "कोई प्राप्तकर्ता नहीं मिला।",
"addFavorite": "पसंदीदा में जोड़ें",
"removeFavorite": "पसंदीदा से हटाएँ",
"title": "प्राप्तकर्ता",
@@ -1942,6 +1943,7 @@
"anyCountry": "और कहीं भी"
},
"common": {
+ "createNamed": "\"{{name}}\" बनाएं",
"view": "देखें",
"add": "जोड़ें",
"save": "सहेजें",
diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.json
index 6f53fffd..5d422de1 100644
--- a/frontend/src/locales/it.json
+++ b/frontend/src/locales/it.json
@@ -1837,6 +1837,7 @@
"loadError": "Impossibile caricare il report"
},
"payees": {
+ "noPayeeFound": "Nessun beneficiario trovato.",
"addFavorite": "Aggiungi ai preferiti",
"removeFavorite": "Rimuovi dai preferiti",
"favoriteError": "Impossibile aggiornare il preferito",
@@ -1943,6 +1944,7 @@
"anyCountry": "Qualsiasi altro luogo"
},
"common": {
+ "createNamed": "Crea \"{{name}}\"",
"view": "Visualizza",
"add": "Aggiungi",
"save": "Salva",
diff --git a/frontend/src/locales/ja.json b/frontend/src/locales/ja.json
index 2b241e47..d17561f4 100644
--- a/frontend/src/locales/ja.json
+++ b/frontend/src/locales/ja.json
@@ -1836,6 +1836,7 @@
"loadError": "レポートの読み込みに失敗しました"
},
"payees": {
+ "noPayeeFound": "取引相手が見つかりません。",
"addFavorite": "お気に入りに追加",
"removeFavorite": "お気に入りから削除",
"title": "取引相手",
@@ -1942,6 +1943,7 @@
"anyCountry": "その他すべての国"
},
"common": {
+ "createNamed": "「{{name}}」を作成",
"view": "表示",
"add": "追加",
"save": "保存",
diff --git a/frontend/src/locales/nl.json b/frontend/src/locales/nl.json
index a38beff1..46e6b977 100644
--- a/frontend/src/locales/nl.json
+++ b/frontend/src/locales/nl.json
@@ -1838,6 +1838,7 @@
"loadError": "Rapport laden mislukt"
},
"payees": {
+ "noPayeeFound": "Geen begunstigde gevonden.",
"addFavorite": "Toevoegen aan favorieten",
"removeFavorite": "Verwijderen uit favorieten",
"favoriteError": "Kan favoriet niet bijwerken",
@@ -1944,6 +1945,7 @@
"anyCountry": "Ergens anders"
},
"common": {
+ "createNamed": "\"{{name}}\" aanmaken",
"view": "Bekijk",
"add": "Toevoegen",
"save": "Opslaan",
diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.json
index 7c7e2a28..d1964f87 100644
--- a/frontend/src/locales/pl.json
+++ b/frontend/src/locales/pl.json
@@ -1921,6 +1921,7 @@
"loadError": "Nie udało się załadować raportu"
},
"payees": {
+ "noPayeeFound": "Nie znaleziono odbiorcy.",
"addFavorite": "Dodaj do ulubionych",
"removeFavorite": "Usuń z ulubionych",
"favoriteError": "Nie udało się zaktualizować ulubionych",
@@ -2033,6 +2034,7 @@
"anyCountry": "Gdziekolwiek indziej"
},
"common": {
+ "createNamed": "Utwórz „{{name}}”",
"view": "Zobacz",
"add": "Dodaj",
"save": "Zapisz",
diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.json
index 01de6f3f..3a06d637 100644
--- a/frontend/src/locales/pt-BR.json
+++ b/frontend/src/locales/pt-BR.json
@@ -1837,6 +1837,7 @@
"loadError": "Falha ao carregar o relatório"
},
"payees": {
+ "noPayeeFound": "Nenhuma pessoa encontrada.",
"addFavorite": "Adicionar aos favoritos",
"removeFavorite": "Remover dos favoritos",
"favoriteError": "Não foi possível atualizar o favorito",
@@ -1943,6 +1944,7 @@
"anyCountry": "Qualquer outro lugar"
},
"common": {
+ "createNamed": "Criar \"{{name}}\"",
"view": "Ver",
"add": "Adicionar",
"save": "Salvar",
diff --git a/frontend/src/locales/pt-PT.json b/frontend/src/locales/pt-PT.json
index c35bfa7d..0776f0b3 100644
--- a/frontend/src/locales/pt-PT.json
+++ b/frontend/src/locales/pt-PT.json
@@ -1837,6 +1837,7 @@
"loadError": "Falha ao carregar o relatório"
},
"payees": {
+ "noPayeeFound": "Nenhuma entidade encontrada.",
"addFavorite": "Adicionar aos favoritos",
"removeFavorite": "Remover dos favoritos",
"favoriteError": "Não foi possível atualizar o favorito",
@@ -1943,6 +1944,7 @@
"anyCountry": "Qualquer outro lugar"
},
"common": {
+ "createNamed": "Criar \"{{name}}\"",
"view": "Ver",
"add": "Adicionar",
"save": "Guardar",
diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.json
index ccfc6db8..4491b158 100644
--- a/frontend/src/locales/ru.json
+++ b/frontend/src/locales/ru.json
@@ -1849,6 +1849,7 @@
"loadError": "Не удалось загрузить отчёт"
},
"payees": {
+ "noPayeeFound": "Получатель не найден.",
"addFavorite": "Добавить в избранное",
"removeFavorite": "Удалить из избранного",
"favoriteError": "Не удалось обновить избранное",
@@ -1955,6 +1956,7 @@
"anyCountry": "Где-либо ещё"
},
"common": {
+ "createNamed": "Создать «{{name}}»",
"view": "Просмотр",
"add": "Добавить",
"save": "Сохранить",
diff --git a/frontend/src/locales/sk.json b/frontend/src/locales/sk.json
index 48a33306..113aad61 100644
--- a/frontend/src/locales/sk.json
+++ b/frontend/src/locales/sk.json
@@ -1948,6 +1948,7 @@
"loadError": "Nepodarilo sa načítať prehľad"
},
"payees": {
+ "noPayeeFound": "Príjemca sa nenašiel.",
"addFavorite": "Pridať do obľúbených",
"removeFavorite": "Odstrániť z obľúbených",
"title": "Príjemcovia",
@@ -2062,6 +2063,7 @@
"anyCountry": "Kdekoľvek inde"
},
"common": {
+ "createNamed": "Vytvoriť „{{name}}“",
"view": "Zobraziť",
"add": "Pridať",
"save": "Uložiť",
diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.json
index e23b89f2..e5ab7d9b 100644
--- a/frontend/src/locales/uk.json
+++ b/frontend/src/locales/uk.json
@@ -1849,6 +1849,7 @@
"loadError": "Не вдалося завантажити звіт"
},
"payees": {
+ "noPayeeFound": "Отримувача не знайдено.",
"addFavorite": "Додати до обраного",
"removeFavorite": "Видалити з обраного",
"favoriteError": "Не вдалося оновити обране",
@@ -1955,6 +1956,7 @@
"anyCountry": "Будь-де інде"
},
"common": {
+ "createNamed": "Створити «{{name}}»",
"view": "Переглянути",
"add": "Додати",
"save": "Зберегти",