Open-source personal finance manager. Self-hosted, privacy-first.
fix(import): report malformed QIF and CAMT records in the import preview (#1220)
Tássio Noronha460093498a3d
diff --git a/backend/app/api/import_transactions.py b/backend/app/api/import_transactions.pyindex 1ab8e9a1..5975aa4d 100644--- a/backend/app/api/import_transactions.py+++ b/backend/app/api/import_transactions.py@@ -69,10 +69,10 @@ async def preview_import(transactions = import_service.parse_ofx(content)detected_format = "ofx"elif filename.lower().endswith('.qif'):- transactions = import_service.parse_qif(content, date_format=date_format)+ transactions, failed_rows = import_service.parse_qif(content, date_format=date_format)detected_format = "qif"elif filename.lower().endswith('.xml') or filename.lower().endswith('.camt'):- transactions = import_service.parse_camt(content)+ transactions, failed_rows = import_service.parse_camt(content)detected_format = "camt"elif filename.lower().endswith('.csv'):detected_format = "csv"@@ -100,11 +100,11 @@ async def preview_import(detected_format = "ofx"except Exception:try:- transactions = import_service.parse_qif(content, date_format=date_format)+ transactions, failed_rows = import_service.parse_qif(content, date_format=date_format)detected_format = "qif"except Exception:try:- transactions = import_service.parse_camt(content)+ transactions, failed_rows = import_service.parse_camt(content)detected_format = "camt"except Exception:transactions, failed_rows = import_service.parse_csv(content)diff --git a/backend/app/services/import_service.py b/backend/app/services/import_service.pyindex 20cbdb3e..5de55ebf 100644--- a/backend/app/services/import_service.py+++ b/backend/app/services/import_service.py@@ -5,6 +5,7 @@ import reimport uuidimport warningsimport xml.etree.ElementTree as ET+from xml.parsers import expatfrom datetime import datetimefrom decimal import Decimal@@ -303,11 +304,66 @@ def _qif_date_formats(date_format: str | None, raw_dates: list[str]) -> list[strreturn list(_QIF_FALLBACK_DATE_FORMATS)-def parse_qif(content: bytes, date_format: str | None = None) -> list[TransactionImport]:+# QIF sections whose blocks describe something other than a transaction:+# account headers, category and class lists, memorized entries, securities+# and prices. Their fields reuse transaction tags ("TBank" is an account+# type, not an amount), so reading them as records would report errors for+# rows that were never meant to be imported.+_QIF_NON_TRANSACTION_HEADERS = (+ '!account', '!type:cat', '!type:class', '!type:memorized',+ '!type:security', '!type:prices', '!type:template',+)+++def _qif_records(text: str) -> list[tuple[int, list[str]]]:+ """Split QIF text into transaction records, line by line.++ Each record is (1-based line of its first field, its stripped field+ lines). A record ends at a line that starts with "^"; a "^" inside a+ payee or memo is part of that field, not a separator. Header lines+ ("!Type:Bank", "!Option:AutoSwitch") are not fields, and blocks under a+ non-transaction header are left out.+ """+ records: list[tuple[int, list[str]]] = []+ current: list[str] = []+ start = 0+ skip = False++ def close() -> None:+ if current and not skip:+ records.append((start, list(current)))+ current.clear()++ for number, raw in enumerate(text.splitlines(), start=1):+ line = raw.strip()+ if not line:+ continue+ if line.startswith('^'):+ close()+ continue+ if line.startswith('!'):+ lower = line.lower()+ if lower.startswith(('!option', '!clear')):+ continue+ close()+ skip = lower.startswith(_QIF_NON_TRANSACTION_HEADERS)+ continue+ if not current:+ start = number+ current.append(line)+ close()+ return records+++def parse_qif(content: bytes, date_format: str | None = None) -> tuple[list[TransactionImport], list[FailedRow]]:"""Parse QIF file content and return transactions.date_format: optional explicit format (see DATE_FORMAT_MAP keys); whenomitted, the day/month order is inferred from the whole file.++ Malformed records (missing/unreadable date or amount, or amount fields+ that disagree) are not guessed at: they come back in the second element+ so the preview can show them per line, like the CSV path does."""# Try UTF-8 first, fall back to Latin-1 for legacy software (e.g. Microsoft Money)try:@@ -315,34 +371,29 @@ def parse_qif(content: bytes, date_format: str | None = None) -> list[Transactioexcept UnicodeDecodeError:text = content.decode('latin-1')transactions = []+ failed_rows = []- # Split into transaction blocks by "^"- blocks = text.split('^')-+ records = _qif_records(text)raw_dates = [- stripped[1:].strip()- for block in blocks- for stripped in (line.strip() for line in block.strip().splitlines())- if stripped.startswith('D')+ line[1:].strip()+ for _, lines in records+ for line in lines+ if line.startswith('D')]date_formats = _qif_date_formats(date_format, raw_dates)- for block in blocks:- lines = block.strip().splitlines()- if not lines:- continue-+ for record_line, lines in records:txn_date = None- amount = None+ date_raw = None+ amount_raws: list[str] = []+ amounts: list[Decimal] = []payee = Nonememo = Nonefor line in lines:- line = line.strip()- if not line:- continuetag, value = line[0], line[1:]if tag == 'D':+ date_raw = value.strip()for fmt in date_formats:try:txn_date = datetime.strptime(value.strip(), fmt).date()@@ -350,8 +401,10 @@ def parse_qif(content: bytes, date_format: str | None = None) -> list[Transactioexcept ValueError:continueelif tag == 'T' or tag == 'U':+ raw = value.strip().replace(',', '')+ amount_raws.append(raw)try:- amount = Decimal(value.strip().replace(',', ''))+ amounts.append(Decimal(raw))except Exception:passelif tag == 'P':@@ -359,23 +412,65 @@ def parse_qif(content: bytes, date_format: str | None = None) -> list[Transactioelif tag == 'M':memo = value.strip()- if txn_date is None or amount is None:+ # A block with neither an amount field nor a parseable date is not+ # a record (e.g. a "Date:January 2026" preamble line, whose tag is+ # 'D' but whose value is not a date).+ if not amount_raws and txn_date is None:+ continue++ description = payee or memo or ""++ if txn_date is None:+ failed_rows.append(FailedRow(line_number=record_line, description=description, raw_value=date_raw or "", error_reason="invalid_date"))+ continue+ if not amount_raws:+ failed_rows.append(FailedRow(line_number=record_line, description=description, raw_value="", error_reason="no_amount"))+ continue+ if not amounts:+ failed_rows.append(FailedRow(line_number=record_line, description=description, raw_value=amount_raws[-1], error_reason="invalid_amount"))+ continue+ if len(set(amounts)) > 1:+ # Two amount fields that disagree: "the last one that parsed"+ # used to win, which may not be the real value of the record.+ failed_rows.append(FailedRow(line_number=record_line, description=description, raw_value=", ".join(amount_raws), error_reason="conflicting_amount"))continue- description = payee or memo or "Unknown"+ amount = amounts[-1]transactions.append(TransactionImport(- description=description,+ description=payee or memo or "Unknown",amount=abs(amount),date=txn_date,type="credit" if amount > 0 else "debit",payee_raw=payee,))- return transactions+ return transactions, failed_rows-def parse_camt(content: bytes) -> list[TransactionImport]:- """Parse CAMT.052/CAMT.053 (ISO 20022) XML file content and return transactions."""+def _camt_entry_lines(content: bytes) -> list[int]:+ """1-based source line of every <Ntry> start tag, in document order."""+ lines: list[int] = []+ parser = expat.ParserCreate()++ def start(name: str, _attrs: dict) -> None:+ if name.rsplit(':', 1)[-1] == 'Ntry':+ lines.append(parser.CurrentLineNumber)++ parser.StartElementHandler = start+ try:+ parser.Parse(content, True)+ except expat.ExpatError:+ return []+ return lines+++def parse_camt(content: bytes) -> tuple[list[TransactionImport], list[FailedRow]]:+ """Parse CAMT.052/CAMT.053 (ISO 20022) XML file content.++ Returns the parsed transactions plus the entries that had to be+ dropped, each with a reason, so the preview can show them per record+ instead of the file coming back short with no explanation.+ """root = ET.fromstring(content)# Detect namespace dynamically@@ -402,6 +497,20 @@ def parse_camt(content: bytes) -> list[TransactionImport]:el = find(element, path)return el.text if el is not None else None+ # Failed rows are labelled "Line" in the preview, so an entry is reported+ # by the line of its opening <Ntry> tag. Only when the raw scan and the+ # parsed tree disagree on the entry count (which should not happen) does+ # it fall back to the entry's position in the file.+ entry_lines = _camt_entry_lines(content)+ entry_total = sum(1 for el in root.iter() if el.tag.rsplit('}', 1)[-1] == 'Ntry')++ def line_of(n: int) -> int:+ if len(entry_lines) == entry_total:+ return entry_lines[n - 1]+ return n++ failed_rows = []+ entry_no = 0transactions = []# Navigate: Document > BkToCstmrStmt > Stmt > Ntry (CAMT.053, end-of-day statement)@@ -411,6 +520,18 @@ def parse_camt(content: bytes) -> list[TransactionImport]:stmts = findall(root, 'BkToCstmrStmt/Stmt') or findall(root, 'BkToCstmrAcctRpt/Rpt')for stmt in stmts:for ntry in findall(stmt, 'Ntry'):+ entry_no += 1++ # Description up front so a dropped entry can carry it in its+ # failure report.+ description = (+ find_text(ntry, 'NtryDtls/TxDtls/RmtInf/Ustrd')+ or find_text(ntry, 'NtryDtls/TxDtls/RltdPties/Cdtr/Nm')+ or find_text(ntry, 'NtryDtls/TxDtls/RltdPties/Dbtr/Nm')+ or find_text(ntry, 'AddtlNtryInf')+ or "Unknown"+ )+# Entry status: BOOK (final) vs. PDNG/INFO (pending/informational).# CAMT.052 intraday reports commonly include PDNG entries for# transactions that haven't settled yet; the same transaction is@@ -427,34 +548,35 @@ def parse_camt(content: bytes) -> list[TransactionImport]:# Amountamt_el = find(ntry, 'Amt')if amt_el is None:+ failed_rows.append(FailedRow(line_number=line_of(entry_no), description=description, raw_value="", error_reason="no_amount"))continuetry:amount = Decimal(amt_el.text)except Exception:+ failed_rows.append(FailedRow(line_number=line_of(entry_no), description=description, raw_value=(amt_el.text or '').strip(), error_reason="invalid_amount"))continue# Credit/Debit indicator- cdt_dbt = find_text(ntry, 'CdtDbtInd')+ cdt_dbt = (find_text(ntry, 'CdtDbtInd') or '').strip().upper()+ # Anything that is neither CRDT nor DBIT is not a direction:+ # importing it as a debit would flip the amount's sign, so skip+ # the entry like the other malformed ones above.+ if cdt_dbt not in ('CRDT', 'DBIT'):+ failed_rows.append(FailedRow(line_number=line_of(entry_no), description=description, raw_value=cdt_dbt, error_reason="invalid_direction"))+ continuetxn_type = "credit" if cdt_dbt == "CRDT" else "debit"# Date: try BookgDt/Dt then ValDt/Dtdate_str = find_text(ntry, 'BookgDt/Dt') or find_text(ntry, 'ValDt/Dt')if not date_str:+ failed_rows.append(FailedRow(line_number=line_of(entry_no), description=description, raw_value="", error_reason="invalid_date"))continuetry:txn_date = datetime.strptime(date_str.strip(), '%Y-%m-%d').date()except ValueError:+ failed_rows.append(FailedRow(line_number=line_of(entry_no), description=description, raw_value=date_str.strip(), error_reason="invalid_date"))continue- # Description from various paths- description = (- find_text(ntry, 'NtryDtls/TxDtls/RmtInf/Ustrd')- or find_text(ntry, 'NtryDtls/TxDtls/RltdPties/Cdtr/Nm')- or find_text(ntry, 'NtryDtls/TxDtls/RltdPties/Dbtr/Nm')- or find_text(ntry, 'AddtlNtryInf')- or "Unknown"- )-# Extract currency from Ccy attribute on Amt elementtxn_currency = amt_el.get('Ccy') or None@@ -466,7 +588,7 @@ def parse_camt(content: bytes) -> list[TransactionImport]:currency=txn_currency,))- return transactions+ return transactions, failed_rowsDATE_FORMAT_MAP = {diff --git a/backend/tests/test_import_service.py b/backend/tests/test_import_service.pyindex 083647d2..d1985bfe 100644--- a/backend/tests/test_import_service.py+++ b/backend/tests/test_import_service.py@@ -516,7 +516,7 @@ class TestParseQif:"MSalary\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 2@@ -538,7 +538,7 @@ class TestParseQif:"PLandlord\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"), date_format="DD/MM/YYYY")+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"), date_format="DD/MM/YYYY")assert len(transactions) == 1assert transactions[0].date == date(2026, 3, 7)@@ -548,7 +548,7 @@ class TestParseQif:"T-100.00\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"), date_format="MM/DD/YYYY")+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"), date_format="MM/DD/YYYY")assert transactions[0].date == date(2026, 7, 3)def test_parse_qif_infers_day_first_from_whole_file(self):@@ -562,7 +562,7 @@ class TestParseQif:"T-20.00\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert transactions[0].date == date(2026, 3, 25)assert transactions[1].date == date(2026, 3, 7)@@ -573,7 +573,7 @@ class TestParseQif:"T-20.00\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert transactions[0].date == date(2026, 7, 3)def test_parse_qif_explicit_format_two_digit_year(self):@@ -582,7 +582,7 @@ class TestParseQif:"T-100.00\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"), date_format="DD/MM/YYYY")+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"), date_format="DD/MM/YYYY")assert transactions[0].date == date(2026, 3, 7)def test_parse_qif_memo_as_description(self):@@ -593,7 +593,7 @@ class TestParseQif:"MGrocery purchase\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].description == "Grocery purchase"@@ -604,7 +604,7 @@ class TestParseQif:"T-10.00\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].description == "Unknown"@@ -616,7 +616,7 @@ class TestParseQif:"PTest\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].date == date(2026, 3, 15)@@ -632,7 +632,7 @@ class TestParseQif:"PValid\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].description == "Valid"@@ -645,7 +645,7 @@ class TestParseQif:"MCompra em São Paulo\n""^\n")- transactions = parse_qif(qif_text.encode("cp1252"))+ transactions, failed_rows = parse_qif(qif_text.encode("cp1252"))assert len(transactions) == 1assert transactions[0].description == "Pagamento cartão"@@ -660,7 +660,7 @@ class TestParseQif:"PBig Purchase\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].amount == Decimal("1250.00")@@ -673,7 +673,7 @@ class TestParseQif:"PCaf\u00e9 Fran\u00e7ais\n""^\n")- transactions = parse_qif(qif_content.encode("latin-1"))+ transactions, failed_rows = parse_qif(qif_content.encode("latin-1"))assert len(transactions) == 1assert transactions[0].description == "Caf\u00e9 Fran\u00e7ais"assert transactions[0].amount == Decimal("75.00")@@ -687,7 +687,7 @@ class TestParseQif:"PTest\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].date == date(2026, 1, 15)@@ -699,7 +699,7 @@ class TestParseQif:"PTest\n""^\n")- transactions = parse_qif(qif_content.encode("utf-8"))+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))assert len(transactions) == 1assert transactions[0].date == date(2026, 1, 15)@@ -734,7 +734,7 @@ class TestParseCamt:'<NtryDtls><TxDtls><RmtInf><Ustrd>Electric Bill</Ustrd></RmtInf></TxDtls></NtryDtls>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 2@@ -758,7 +758,7 @@ class TestParseCamt:'<NtryDtls><TxDtls><RmtInf><Ustrd>Test</Ustrd></RmtInf></TxDtls></NtryDtls>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 1assert transactions[0].date == date(2026, 2, 20)@@ -773,7 +773,7 @@ class TestParseCamt:'<NtryDtls><TxDtls><RltdPties><Cdtr><Nm>Store ABC</Nm></Cdtr></RltdPties></TxDtls></NtryDtls>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 1assert transactions[0].description == "Store ABC"@@ -786,7 +786,7 @@ class TestParseCamt:'<BookgDt><Dt>2026-01-01</Dt></BookgDt>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 1assert transactions[0].description == "Unknown"@@ -804,7 +804,7 @@ class TestParseCamt:'<NtryDtls><TxDtls><RmtInf><Ustrd>Valid</Ustrd></RmtInf></TxDtls></NtryDtls>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 1assert transactions[0].description == "Valid"@@ -823,7 +823,7 @@ class TestParseCamt:'</Stmt></BkToCstmrStmt>''</Document>').encode('utf-8')- transactions = parse_camt(xml)+ transactions, failed_rows = parse_camt(xml)assert len(transactions) == 1assert transactions[0].description == "No NS"assert transactions[0].amount == Decimal("300.00")@@ -846,7 +846,7 @@ class TestParseCamt:'</Rpt></BkToCstmrAcctRpt>''</Document>').encode('utf-8')- transactions = parse_camt(xml)+ transactions, failed_rows = parse_camt(xml)assert len(transactions) == 1assert transactions[0].description == "Supermarket"assert transactions[0].amount == Decimal("42.50")@@ -880,7 +880,7 @@ class TestParseCamt:'</Rpt></BkToCstmrAcctRpt>''</Document>').encode('utf-8')- transactions = parse_camt(xml)+ transactions, failed_rows = parse_camt(xml)assert len(transactions) == 1assert transactions[0].description == "Supermarket (booked)"@@ -908,7 +908,7 @@ class TestParseCamt:' </BkToCstmrStmt>\n''</Document>\n').encode('utf-8')- transactions = parse_camt(xml)+ transactions, failed_rows = parse_camt(xml)assert len(transactions) == 1assert transactions[0].description == "Booked"assert transactions[0].amount == Decimal("42.50")@@ -1391,7 +1391,7 @@ class TestCamtCurrencyParsing:'<NtryDtls><TxDtls><RmtInf><Ustrd>Euro Payment</Ustrd></RmtInf></TxDtls></NtryDtls>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 2assert transactions[0].currency == "USD"@@ -1407,7 +1407,7 @@ class TestCamtCurrencyParsing:'<NtryDtls><TxDtls><RmtInf><Ustrd>Test</Ustrd></RmtInf></TxDtls></NtryDtls>''</Ntry>')- transactions = parse_camt(self._make_camt_xml(entries))+ transactions, failed_rows = parse_camt(self._make_camt_xml(entries))assert len(transactions) == 1assert transactions[0].currency is None@@ -3128,6 +3128,329 @@ async def test_import_posted_status_rule_applies_to_matched_recurring_placeholdeassert rows[0].notes == "Rule applied"+# ---------------------------------------------------------------------------+# QIF and CAMT records reported instead of dropped (issue #850)+# ---------------------------------------------------------------------------+++class TestCamtCdtDbtIndValidation:+ """A CAMT entry whose CdtDbtInd is neither CRDT nor DBIT is not a+ direction: importing it as a debit would flip the amount's sign, so the+ entry is skipped like the other malformed ones (issue #850)."""++ def _wrap(self, entries: str) -> bytes:+ return (+ '<?xml version="1.0" encoding="UTF-8"?>'+ '<Document xmlns="urn:iso:std:iso:20022:tech:xsd:camt.053.001.02">'+ '<BkToCstmrStmt><Stmt>'+ f'{entries}'+ '</Stmt></BkToCstmrStmt>'+ '</Document>'+ ).encode("utf-8")++ def test_invalid_indicator_skipped(self):+ entries = (+ '<Ntry><Amt Ccy="BRL">100.00</Amt>'+ '<CdtDbtInd>CRDT</CdtDbtInd>'+ '<BookgDt><Dt>2026-01-16</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>Valid credit</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ '<Ntry><Amt Ccy="BRL">200.00</Amt>'+ '<CdtDbtInd>CREDIT</CdtDbtInd>'+ '<BookgDt><Dt>2026-01-17</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>Wrong word</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ )+ transactions, failed_rows = parse_camt(self._wrap(entries))+ assert [t.description for t in transactions] == ["Valid credit"]+ assert transactions[0].type == "credit"+ assert [r.error_reason for r in failed_rows] == ["invalid_direction"]+ assert failed_rows[0].description == "Wrong word"+ assert failed_rows[0].raw_value == "CREDIT"++ def test_missing_indicator_skipped(self):+ entries = (+ '<Ntry><Amt Ccy="BRL">300.00</Amt>'+ '<BookgDt><Dt>2026-01-18</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>No direction</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ )+ transactions, failed_rows = parse_camt(self._wrap(entries))+ assert transactions == []+ # A missing indicator is no direction either, and it now shows up+ # in the preview instead of vanishing.+ assert [r.error_reason for r in failed_rows] == ["invalid_direction"]+ assert failed_rows[0].description == "No direction"++ def test_missing_amount_reported(self):+ entries = (+ '<Ntry><CdtDbtInd>CRDT</CdtDbtInd>'+ '<BookgDt><Dt>2026-01-18</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>No amount</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ )+ transactions, failed_rows = parse_camt(self._wrap(entries))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["no_amount"]++ def test_bad_amount_reported(self):+ entries = (+ '<Ntry><Amt Ccy="BRL">abc</Amt>'+ '<CdtDbtInd>DBIT</CdtDbtInd>'+ '<BookgDt><Dt>2026-01-18</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>Bad amount</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ )+ transactions, failed_rows = parse_camt(self._wrap(entries))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["invalid_amount"]+ assert failed_rows[0].raw_value == "abc"++ def test_bad_date_reported(self):+ entries = (+ '<Ntry><Amt Ccy="BRL">100.00</Amt>'+ '<CdtDbtInd>CRDT</CdtDbtInd>'+ '<BookgDt><Dt>not-a-date</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>Bad date</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ )+ transactions, failed_rows = parse_camt(self._wrap(entries))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["invalid_date"]+ assert failed_rows[0].raw_value == "not-a-date"++ def test_pending_entries_stay_silent(self):+ # PDNG entries are deliberately invisible (they reappear as BOOK);+ # they must not show up as failed rows.+ entries = (+ '<Ntry><Sts><Cd>PDNG</Cd></Sts>'+ '<Amt Ccy="BRL">100.00</Amt>'+ '<CdtDbtInd>CRDT</CdtDbtInd>'+ '<BookgDt><Dt>2026-01-18</Dt></BookgDt>'+ '</Ntry>'+ '<Ntry><Sts><Cd>BOOK</Cd></Sts>'+ '<Amt Ccy="BRL">100.00</Amt>'+ '<CdtDbtInd>CRDT</CdtDbtInd>'+ '<BookgDt><Dt>2026-01-18</Dt></BookgDt>'+ '<NtryDtls><TxDtls><RmtInf><Ustrd>Settled</Ustrd></RmtInf></TxDtls></NtryDtls>'+ '</Ntry>'+ )+ transactions, failed_rows = parse_camt(self._wrap(entries))+ assert [t.description for t in transactions] == ["Settled"]+ assert failed_rows == []+++class TestQifMalformedRecords:+ """QIF records that used to be dropped or silently resolved now come+ back as failed rows (issue #850)."""++ def test_conflicting_amount_fields_reported(self):+ qif_content = (+ "!Type:bank\n"+ "Date:January 2026\n"+ "^\n"+ "D01/15/2026\n"+ "T100.00\n"+ "U-200.00\n"+ "PConflict\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["conflicting_amount"]+ assert failed_rows[0].description == "Conflict"+ assert failed_rows[0].raw_value == "100.00, -200.00"++ def test_repeated_same_amount_still_imports(self):+ qif_content = (+ "!Type:bank\n"+ "^\n"+ "D01/15/2026\n"+ "T100.00\n"+ "T100.00\n"+ "PRepeat\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert len(transactions) == 1+ assert transactions[0].amount == Decimal("100.00")+ assert failed_rows == []++ def test_unparseable_amount_reported(self):+ qif_content = (+ "!Type:bank\n"+ "^\n"+ "D01/21/2026\n"+ "Tbad\n"+ "PBad value\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["invalid_amount"]+ assert failed_rows[0].raw_value == "bad"+ # line_number points at the record start (its D tag), line 3+ assert failed_rows[0].line_number == 3++ def test_missing_date_reported(self):+ qif_content = (+ "!Type:bank\n"+ "^\n"+ "T50.00\n"+ "PNo date\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["invalid_date"]+ assert failed_rows[0].description == "No date"++ def test_missing_amount_reported(self):+ qif_content = (+ "!Type:bank\n"+ "^\n"+ "D01/15/2026\n"+ "PNo money\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert transactions == []+ assert [r.error_reason for r in failed_rows] == ["no_amount"]++ def test_preamble_stays_silent(self):+ # The file preamble ("!Type:bank", "Date:January 2026" - whose tag+ # looks like a date line but is not) must not be reported.+ qif_content = (+ "!Type:bank\n"+ "Date:January 2026\n"+ "^\n"+ "D01/15/2026\n"+ "T-250.00\n"+ "PElectric Company\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert len(transactions) == 1+ assert transactions[0].description == "Electric Company"+ assert failed_rows == []++ def test_good_file_unchanged_with_line_numbers(self):+ qif_content = (+ "!Type:bank\n"+ "^\n"+ "D01/15/2026\n"+ "T-250.00\n"+ "PElectric Company\n"+ "^\n"+ "D01/16/2026\n"+ "T-30.00\n"+ "PMilk store\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert [t.description for t in transactions] == ["Electric Company", "Milk store"]+ assert failed_rows == []++ def test_account_header_blocks_are_not_records(self):+ # An account header block reuses transaction tags ("TBank" is the+ # account type), so it must be skipped, not reported as a failed+ # row with an invalid date.+ qif_content = (+ "!Option:AutoSwitch\n"+ "!Account\n"+ "NChecking\n"+ "TBank\n"+ "^\n"+ "!Clear:AutoSwitch\n"+ "!Account\n"+ "NChecking\n"+ "TBank\n"+ "^\n"+ "!Type:Bank\n"+ "D01/15/2026\n"+ "T-250.00\n"+ "PElectric Company\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert [t.description for t in transactions] == ["Electric Company"]+ assert failed_rows == []++ def test_category_list_blocks_are_not_records(self):+ qif_content = (+ "!Type:Cat\n"+ "NGroceries\n"+ "DFood and supplies\n"+ "E\n"+ "^\n"+ "!Type:Memorized\n"+ "KC\n"+ "T-50.00\n"+ "PGym\n"+ "^\n"+ "!Type:Bank\n"+ "D01/15/2026\n"+ "T-250.00\n"+ "PElectric Company\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert [t.description for t in transactions] == ["Electric Company"]+ assert failed_rows == []++ def test_caret_inside_a_field_does_not_split_the_record(self):+ # "^" only ends a record on a line of its own; inside a payee or memo+ # it is text. A malformed record after it still gets its own line.+ qif_content = (+ "!Type:Bank\n"+ "D01/15/2026\n"+ "T-250.00\n"+ "PSTORE ^A^B^\n"+ "MRef ^ 42\n"+ "^\n"+ "D01/16/2026\n"+ "Tbad\n"+ "PBad value\n"+ "^\n"+ )+ transactions, failed_rows = parse_qif(qif_content.encode("utf-8"))+ assert [t.description for t in transactions] == ["STORE ^A^B^"]+ assert transactions[0].amount == Decimal("250.00")+ assert [(r.error_reason, r.line_number) for r in failed_rows] == [+ ("invalid_amount", 7),+ ]+++class TestCamtFailedRowLineNumbers:+ """CAMT failed rows carry the line of the entry's <Ntry> tag, matching+ the "Line" column of the preview."""++ def test_line_points_at_the_entry(self):+ xml = (+ '<?xml version="1.0" encoding="UTF-8"?>\n'+ '<Document xmlns="urn:iso:std:iso:20022:tech:xsd:camt.053.001.02">\n'+ ' <BkToCstmrStmt>\n'+ ' <Stmt>\n'+ ' <Ntry>\n'+ ' <Amt Ccy="EUR">10.00</Amt>\n'+ ' <CdtDbtInd>DBIT</CdtDbtInd>\n'+ ' <BookgDt><Dt>2026-01-15</Dt></BookgDt>\n'+ ' </Ntry>\n'+ ' <Ntry>\n'+ ' <Amt Ccy="EUR">20.00</Amt>\n'+ ' <CdtDbtInd>XXXX</CdtDbtInd>\n'+ ' <BookgDt><Dt>2026-01-16</Dt></BookgDt>\n'+ ' <NtryDtls><TxDtls><RmtInf><Ustrd>Second</Ustrd></RmtInf></TxDtls></NtryDtls>\n'+ ' </Ntry>\n'+ ' </Stmt>\n'+ ' </BkToCstmrStmt>\n'+ '</Document>\n'+ ).encode("utf-8")+ transactions, failed_rows = parse_camt(xml)+ assert len(transactions) == 1+ assert [(r.description, r.line_number) for r in failed_rows] == [("Second", 10)]++# ---------------------------------------------------------------------------# Split-mode amount and fx_rate validation (issue #850)# ---------------------------------------------------------------------------diff --git a/frontend/src/locales/cs.json b/frontend/src/locales/cs.jsonindex 32ce5b98..c6fbfe47 100644--- a/frontend/src/locales/cs.json+++ b/frontend/src/locales/cs.json@@ -1830,7 +1830,9 @@"no_amount": "Chybí částka příjmu nebo výdaje","invalid_amount": "Neplatný formát částky","invalid_fx_rate": "Neplatná měnová sazba",- "ambiguous_amount": "Vyplněny příjem i výdaj"+ "ambiguous_amount": "Vyplněny příjem i výdaj",+ "conflicting_amount": "Konfliktní pole částek",+ "invalid_direction": "Neplatný indikátor příjmu/výdaje"},"selectAll": "Vybrat vše","incomeCount_one": "{{count}} příjem",diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.jsonindex 174fc8eb..1a5f1f95 100644--- a/frontend/src/locales/de.json+++ b/frontend/src/locales/de.json@@ -1723,7 +1723,9 @@"no_amount": "Kein Zu- oder Abflussbetrag","invalid_amount": "Ungültiges Betragsformat","invalid_fx_rate": "Ungültiger Wechselkurs",- "ambiguous_amount": "Zu- und Abflussbetrag ausgefüllt"+ "ambiguous_amount": "Zu- und Abflussbetrag ausgefüllt",+ "conflicting_amount": "Widersprüchliche Betragfelder",+ "invalid_direction": "Ungültiges Gutschrift-/Lastschriftkennzeichen"},"selectAll": "Alle auswählen"},diff --git a/frontend/src/locales/el.json b/frontend/src/locales/el.jsonindex 402786c6..3f522b48 100644--- a/frontend/src/locales/el.json+++ b/frontend/src/locales/el.json@@ -1722,7 +1722,9 @@"no_amount": "Χωρίς ποσό εισροής ή εκροής","invalid_amount": "Μη έγκυρη μορφή ποσού","invalid_fx_rate": "Μη έγκυρη ισοτιμία",- "ambiguous_amount": "Συμπληρωμένες εισροή και εκροή"+ "ambiguous_amount": "Συμπληρωμένες εισροή και εκροή",+ "conflicting_amount": "Αντιφατικά πεδία ποσών",+ "invalid_direction": "Μη έγκυρος δείκτης πίστωσης/χρέωσης"},"selectAll": "Επιλογή όλων"},diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.jsonindex 4f35fb2e..549f591e 100644--- a/frontend/src/locales/en.json+++ b/frontend/src/locales/en.json@@ -1722,7 +1722,9 @@"no_amount": "No Inflow or Outflow Amount","invalid_amount": "Invalid Amount Format","invalid_fx_rate": "Invalid Exchange Rate",- "ambiguous_amount": "Both Inflow and Outflow Filled"+ "ambiguous_amount": "Both Inflow and Outflow Filled",+ "conflicting_amount": "Conflicting Amount Fields",+ "invalid_direction": "Invalid Credit or Debit Indicator"},"selectAll": "Select all"},diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.jsonindex 3d9f55c1..ca831d2c 100644--- a/frontend/src/locales/es.json+++ b/frontend/src/locales/es.json@@ -1726,7 +1726,9 @@"no_amount": "Sin importe de entrada o salida","invalid_amount": "Formato de importe no válido","invalid_fx_rate": "Tipo de cambio no válido",- "ambiguous_amount": "Entrada y salida con valor"+ "ambiguous_amount": "Entrada y salida con valor",+ "conflicting_amount": "Campos de importe en conflicto",+ "invalid_direction": "Indicador de crédito/débito no válido"},"selectAll": "Seleccionar todo"},diff --git a/frontend/src/locales/fr.json b/frontend/src/locales/fr.jsonindex 083d7d81..cb5844cf 100644--- a/frontend/src/locales/fr.json+++ b/frontend/src/locales/fr.json@@ -1726,7 +1726,9 @@"no_amount": "Aucun montant d'entrée ou de sortie","invalid_amount": "Format de montant invalide","invalid_fx_rate": "Taux de change invalide",- "ambiguous_amount": "Entrée et sortie renseignées"+ "ambiguous_amount": "Entrée et sortie renseignées",+ "conflicting_amount": "Champs de montant contradictoires",+ "invalid_direction": "Indicateur crédit/débit invalide"},"selectAll": "Tout sélectionner"},diff --git a/frontend/src/locales/hi.json b/frontend/src/locales/hi.jsonindex 90be0188..f4c82659 100644--- a/frontend/src/locales/hi.json+++ b/frontend/src/locales/hi.json@@ -1722,7 +1722,9 @@"no_amount": "कोई आवक या जावक राशि नहीं","invalid_amount": "अमान्य राशि प्रारूप","invalid_fx_rate": "अमान्य विनिमय दर",- "ambiguous_amount": "आवक और जावक दोनों भरी हैं"+ "ambiguous_amount": "आवक और जावक दोनों भरी हैं",+ "conflicting_amount": "टकराव में राशि फ़ील्ड",+ "invalid_direction": "अमान्य क्रेडिट/डेबिट संकेतक"},"selectAll": "सभी चुनें"},diff --git a/frontend/src/locales/hu.json b/frontend/src/locales/hu.jsonindex 7010f666..bb2cd119 100644--- a/frontend/src/locales/hu.json+++ b/frontend/src/locales/hu.json@@ -1722,7 +1722,9 @@"no_amount": "Nincs bejövő vagy kimenő összeg","invalid_amount": "Érvénytelen összegformátum","invalid_fx_rate": "Érvénytelen árfolyam",- "ambiguous_amount": "Bemenő és kimenő összeg is megvan"+ "ambiguous_amount": "Bemenő és kimenő összeg is megvan",+ "conflicting_amount": "Ütköző összegmezők",+ "invalid_direction": "Érvénytelen jóváírás/levonás jelző"},"selectAll": "Összes kijelölése"},diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.jsonindex 8ed43b29..d6186a07 100644--- a/frontend/src/locales/it.json+++ b/frontend/src/locales/it.json@@ -1726,7 +1726,9 @@"no_amount": "Nessun importo in entrata o in uscita","invalid_amount": "Formato importo non valido","invalid_fx_rate": "Tasso di cambio non valido",- "ambiguous_amount": "Entrata e uscita entrambe compilate"+ "ambiguous_amount": "Entrata e uscita entrambe compilate",+ "conflicting_amount": "Campi di importo in conflitto",+ "invalid_direction": "Indicatore accredito/addebito non valido"},"selectAll": "Seleziona tutto"},diff --git a/frontend/src/locales/ja.json b/frontend/src/locales/ja.jsonindex bc178fb3..1904daf9 100644--- a/frontend/src/locales/ja.json+++ b/frontend/src/locales/ja.json@@ -1722,7 +1722,9 @@"no_amount": "入金/出金金額なし","invalid_amount": "無効な金額形式","invalid_fx_rate": "無効な為替レート",- "ambiguous_amount": "入金と出金の両方が入力されています"+ "ambiguous_amount": "入金と出金の両方が入力されています",+ "conflicting_amount": "金額フィールドの競合",+ "invalid_direction": "無効な貸借区分"},"selectAll": "すべて選択"},diff --git a/frontend/src/locales/nl.json b/frontend/src/locales/nl.jsonindex efb0fb0a..6364517b 100644--- a/frontend/src/locales/nl.json+++ b/frontend/src/locales/nl.json@@ -1724,7 +1724,9 @@"no_amount": "Geen in- of uitstroombedrag","invalid_amount": "Ongeldig bedragformaat","invalid_fx_rate": "Ongeldige wisselkoers",- "ambiguous_amount": "In- en uitstroombedrag ingevuld"+ "ambiguous_amount": "In- en uitstroombedrag ingevuld",+ "conflicting_amount": "Tegensprekende bedragsvelden",+ "invalid_direction": "Ongeldige credit/debet-indicator"},"selectAll": "Alles selecteren"},diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.jsonindex d74dc194..de5a2610 100644--- a/frontend/src/locales/pl.json+++ b/frontend/src/locales/pl.json@@ -1811,7 +1811,9 @@"no_amount": "Brak kwoty wpływu lub wypływu","invalid_amount": "Nieprawidłowy format kwoty","invalid_fx_rate": "Nieprawidłowy kurs walutowy",- "ambiguous_amount": "Wpływ i wypływ uzupełnione"+ "ambiguous_amount": "Wpływ i wypływ uzupełnione",+ "conflicting_amount": "Konfliktowe pola kwot",+ "invalid_direction": "Nieprawidłowy wskaźnik uznania/obciążenia"},"selectAll": "Zaznacz wszystko"},diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.jsonindex 25bcde27..841ec5b5 100644--- a/frontend/src/locales/pt-BR.json+++ b/frontend/src/locales/pt-BR.json@@ -1726,7 +1726,9 @@"no_amount": "Nenhum valor de entrada ou saída","invalid_amount": "Formato de valor inválido","invalid_fx_rate": "Câmbio inválido",- "ambiguous_amount": "Entrada e saída preenchidas"+ "ambiguous_amount": "Entrada e saída preenchidas",+ "conflicting_amount": "Campos de valor conflitantes",+ "invalid_direction": "Indicador de crédito/débito inválido"},"selectAll": "Selecionar todos"},diff --git a/frontend/src/locales/pt-PT.json b/frontend/src/locales/pt-PT.jsonindex eb4d893c..1b410fa1 100644--- a/frontend/src/locales/pt-PT.json+++ b/frontend/src/locales/pt-PT.json@@ -1726,7 +1726,9 @@"no_amount": "Nenhum valor de entrada ou saída","invalid_amount": "Formato de valor inválido","invalid_fx_rate": "Câmbio inválido",- "ambiguous_amount": "Entrada e saída preenchidas"+ "ambiguous_amount": "Entrada e saída preenchidas",+ "conflicting_amount": "Campos de valor contraditórios",+ "invalid_direction": "Indicador de crédito/débito inválido"},"selectAll": "Selecionar todos"},diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.jsonindex 8e8c6c2c..8e5faaba 100644--- a/frontend/src/locales/ru.json+++ b/frontend/src/locales/ru.json@@ -1739,7 +1739,9 @@"no_amount": "Нет суммы прихода или расхода","invalid_amount": "Неверный формат суммы","invalid_fx_rate": "Неверный курс валюты",- "ambiguous_amount": "Заполнены приход и расход"+ "ambiguous_amount": "Заполнены приход и расход",+ "conflicting_amount": "Конфликтующие поля сумм",+ "invalid_direction": "Неверный индикатор кредита/дебета"},"selectAll": "Выбрать все"},diff --git a/frontend/src/locales/sk.json b/frontend/src/locales/sk.jsonindex fbf0a290..143c5777 100644--- a/frontend/src/locales/sk.json+++ b/frontend/src/locales/sk.json@@ -1838,7 +1838,9 @@"no_amount": "Chýba suma príjmu alebo výdaja","invalid_amount": "Neplatný formát sumy","invalid_fx_rate": "Neplatný kurz",- "ambiguous_amount": "Vyplnené príjmy aj výdavky"+ "ambiguous_amount": "Vyplnené príjmy aj výdavky",+ "conflicting_amount": "Konfliktné polia sumy",+ "invalid_direction": "Neplatný indikátor príjmu/výdavku"},"selectAll": "Vybrať všetko"},diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.jsonindex 567f12f5..06c0bd1a 100644--- a/frontend/src/locales/uk.json+++ b/frontend/src/locales/uk.json@@ -1739,7 +1739,9 @@"no_amount": "Немає суми надходження або витрати","invalid_amount": "Недійсний формат суми","invalid_fx_rate": "Недійсний курс валют",- "ambiguous_amount": "Заповнено надходження і витрати"+ "ambiguous_amount": "Заповнено надходження і витрати",+ "conflicting_amount": "Конфліктні поля сум",+ "invalid_direction": "Некоректний індикатор кредиту/дебету"},"selectAll": "Вибрати все"},