Open-source personal finance manager. Self-hosted, privacy-first.
fix: make external MCP server URL configurable (#384) (#399)
Tássio Noronha5390f6fb94ae
diff --git a/.env.example b/.env.exampleindex 4b498b5e..d1130d97 100644--- a/.env.example+++ b/.env.example@@ -50,4 +50,9 @@ ENABLE_BANKING_OAUTH_REDIRECT_URI=http://localhost:${FRONTEND_PORT:-3000}/oauth/# 1) the feature flag# 2) COMPOSE_PROFILES so `docker compose up` starts the mcp-server container# AGENTS_ENABLED=true-# COMPOSE_PROFILES=agents\ No newline at end of file+# COMPOSE_PROFILES=agents+# Public URL external agents use to reach the built-in MCP server, shown in the+# UI token panel. Leave unset to derive it from the browser (host:8765). Set it+# when the MCP server is exposed behind an ingress/reverse proxy on a custom+# host, subpath, or standard 80/443 port instead of :8765.+# AGENTS_EXTERNAL_MCP_URL=https://securo.example.com/mcp\ No newline at end of filediff --git a/backend/app/agents/api/info.py b/backend/app/agents/api/info.pyindex e0272696..67d4c5d0 100644--- a/backend/app/agents/api/info.py+++ b/backend/app/agents/api/info.py@@ -19,4 +19,6 @@ async def get_agents_info():"default_similarity_threshold": s.default_similarity_threshold,"extra_mcp_servers_configured": bool(s.extra_mcp_servers.strip()),"mcp_external_ttl_days": s.mcp_external_ttl_days,+ # Empty string means "let the frontend derive it from window.location".+ "external_mcp_url": s.external_mcp_url.strip(),}diff --git a/backend/app/agents/config.py b/backend/app/agents/config.pyindex cab92525..9faae635 100644--- a/backend/app/agents/config.py+++ b/backend/app/agents/config.py@@ -9,8 +9,17 @@ class AgentSettings(BaseSettings):enabled: bool = False# Built-in MCP server URL. The mcp-server container speaks JSON-RPC 2.0.+ # This is the internal address the backend uses to reach the container.builtin_mcp_url: str = "http://mcp-server:8765/mcp"+ # Public URL external agents use to reach the built-in MCP server, shown+ # in the UI token panel. Leave blank to have the frontend derive it from+ # the browser location (``<protocol>//<hostname>:8765/mcp``). Set this+ # when the MCP server is exposed behind an ingress/reverse proxy on a+ # custom host, subpath, or standard 80/443 port instead of ``:8765``.+ # Example: "https://securo.example.com/mcp".+ external_mcp_url: str = ""+# Comma-separated extra MCP servers users can plug in (URL[|name]).# Example: "http://my-tools:9000/mcp|my-tools,http://other:9001/mcp"extra_mcp_servers: str = ""diff --git a/backend/tests/test_agents_api.py b/backend/tests/test_agents_api.pyindex 518fa0ff..db788d16 100644--- a/backend/tests/test_agents_api.py+++ b/backend/tests/test_agents_api.py@@ -84,6 +84,31 @@ async def test_agents_info_exposes_mcp_external_ttl(client: AsyncClient, auth_heassert body["mcp_external_ttl_days"] >= 1+async def test_agents_info_exposes_external_mcp_url(client: AsyncClient, auth_headers: dict):+ """The frontend uses external_mcp_url (empty by default) so deployments+ behind an ingress can override the hardcoded :8765 endpoint."""+ r = await client.get("/api/agents/info", headers=auth_headers)+ body = r.json()+ assert "external_mcp_url" in body+ assert isinstance(body["external_mcp_url"], str)+++async def test_agents_info_returns_configured_external_mcp_url(+ client: AsyncClient, auth_headers: dict, monkeypatch+):+ """When AGENTS_EXTERNAL_MCP_URL is set, it is surfaced verbatim (trimmed)."""+ from app.agents import config++ config.get_agent_settings.cache_clear()+ monkeypatch.setenv("AGENTS_EXTERNAL_MCP_URL", " https://securo.example.com/mcp ")+ try:+ r = await client.get("/api/agents/info", headers=auth_headers)+ assert r.json()["external_mcp_url"] == "https://securo.example.com/mcp"+ finally:+ monkeypatch.delenv("AGENTS_EXTERNAL_MCP_URL", raising=False)+ config.get_agent_settings.cache_clear()++# --- External MCP tokens ---------------------------------------------------async def test_mcp_tokens_requires_auth(client: AsyncClient):diff --git a/docker-compose.yml b/docker-compose.ymlindex 398fb36c..ba75f7a9 100644--- a/docker-compose.yml+++ b/docker-compose.yml@@ -45,6 +45,10 @@ x-backend-env: &backend-env# zero cost. Run `docker compose --profile agents up` after enabling.AGENTS_ENABLED: ${AGENTS_ENABLED:-false}AGENTS_BUILTIN_MCP_URL: ${AGENTS_BUILTIN_MCP_URL:-http://mcp-server:8765/mcp}+ # Public URL external agents use to reach the built-in MCP server, shown in+ # the "External MCP access" panel. Blank → the UI derives it from the browser+ # (host:8765). Set when the MCP server sits behind an ingress/reverse proxy.+ AGENTS_EXTERNAL_MCP_URL: ${AGENTS_EXTERNAL_MCP_URL:-}AGENTS_EXTRA_MCP_SERVERS: ${AGENTS_EXTRA_MCP_SERVERS:-}AGENTS_MCP_JWT_SECRET: ${AGENTS_MCP_JWT_SECRET:-dev-mcp-secret-change-in-production}# TTL for tokens minted from /agents/connections → "External MCP access".diff --git a/frontend/src/components/agents/mcp-external-panel.tsx b/frontend/src/components/agents/mcp-external-panel.tsxindex ecd0ccad..744aa038 100644--- a/frontend/src/components/agents/mcp-external-panel.tsx+++ b/frontend/src/components/agents/mcp-external-panel.tsx@@ -94,7 +94,13 @@ export function McpExternalPanel() {if (!info) return null- const url = `${window.location.protocol}//${window.location.hostname}:8765/mcp`+ // Prefer the backend-configured URL (AGENTS_EXTERNAL_MCP_URL) so deployments+ // behind an ingress/reverse proxy can point at a custom host/subpath/port.+ // Fall back to the direct :8765 endpoint derived from the browser location,+ // which matches the default Docker Compose setup.+ const url =+ info.external_mcp_url ||+ `${window.location.protocol}//${window.location.hostname}:8765/mcp`// The first three snippets are universal regardless of client choice.const universalSnippets: Snippet[] = resultdiff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.tsindex a7a4a286..e28a7c33 100644--- a/frontend/src/lib/api.ts+++ b/frontend/src/lib/api.ts@@ -1382,6 +1382,7 @@ export const agents = {default_similarity_threshold: numberextra_mcp_servers_configured: booleanmcp_external_ttl_days: number+ external_mcp_url: string}},mcpTokens: {