Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

fix(transactions): sync the list across tabs when data changes (#1217)

Tássio Noronha6a588172ed62
diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx
index 8d6bf285..e838865f 100644
--- a/frontend/src/App.tsx
+++ b/frontend/src/App.tsx
@@ -8,6 +8,7 @@ import { AuthProvider } from '@/contexts/auth-provider'
import { WorkspaceProvider } from '@/contexts/workspace-provider'
import { CollectionFilterProvider } from '@/contexts/collection-filter-provider'
import { SidebarStateProvider } from '@/contexts/sidebar-state-provider'
+import { useCrossTabRefresh } from '@/hooks/use-cross-tab-refresh'
import { ProtectedRoute } from '@/components/protected-route'
import { AdminRoute } from '@/components/admin-route'
import { AgentsRoute } from '@/components/agents-route'
@@ -64,10 +65,21 @@ function LoadingFallback() {
)
}
+/**
+ * Renders nothing; exists so `useCrossTabRefresh` can run where the
+ * `queryClient` is in scope: lists change in another tab and this tab
+ * refetches instead of serving the stale cache (issue #763).
+ */
+function CrossTabRefresh() {
+ useCrossTabRefresh()
+ return null
+}
+
function App() {
return (
<ThemeProvider>
<QueryClientProvider client={queryClient}>
+ <CrossTabRefresh />
<TooltipProvider>
<BrowserRouter>
<AuthProvider>
diff --git a/frontend/src/components/transactions-page-actions.test.tsx b/frontend/src/components/transactions-page-actions.test.tsx
new file mode 100644
index 00000000..6a3404cd
--- /dev/null
+++ b/frontend/src/components/transactions-page-actions.test.tsx
@@ -0,0 +1,47 @@
+import { describe, expect, it, vi } from 'vitest'
+import { screen } from '@testing-library/react'
+import { TransactionsPageActions } from '@/components/transactions-page-actions'
+import { renderWithProviders } from '@/test/utils'
+
+const base = {
+ month: { value: '2026-10-01', onChange: () => {}, locale: 'en', prevLabel: 'Prev', nextLabel: 'Next' },
+ view: { value: 'list' as const, onChange: () => {}, listLabel: 'List', calendarLabel: 'Calendar' },
+ columnPicker: null,
+ exportLabel: 'Export CSV',
+ exporting: false,
+ onExport: () => {},
+}
+
+describe('TransactionsPageActions refresh action', () => {
+ it('shows the refresh action and refetches on click', async () => {
+ const onRefresh = vi.fn()
+ const { user } = renderWithProviders(
+ <TransactionsPageActions {...base} onRefresh={onRefresh} />,
+ )
+ const button = screen.getByRole('button', { name: 'Refresh' })
+ await user.click(button)
+ expect(onRefresh).toHaveBeenCalledTimes(1)
+ })
+
+ it('disables the refresh action while a fetch is running', () => {
+ renderWithProviders(
+ <TransactionsPageActions {...base} onRefresh={() => {}} refreshing />,
+ )
+ expect(screen.getByRole('button', { name: 'Refresh' })).toBeDisabled()
+ })
+
+ it('shows the refresh item in the mobile menu and refetches on click', async () => {
+ const onRefresh = vi.fn()
+ const { user } = renderWithProviders(
+ <TransactionsPageActions {...base} onRefresh={onRefresh} />,
+ )
+ await user.click(screen.getByRole('button', { name: 'More actions' }))
+ await user.click(await screen.findByRole('menuitem', { name: 'Refresh' }))
+ expect(onRefresh).toHaveBeenCalledTimes(1)
+ })
+
+ it('omits the refresh action when no handler is given', () => {
+ renderWithProviders(<TransactionsPageActions {...base} />)
+ expect(screen.queryByRole('button', { name: 'Refresh' })).toBeNull()
+ })
+})
diff --git a/frontend/src/components/transactions-page-actions.tsx b/frontend/src/components/transactions-page-actions.tsx
index 2cb3e92e..63f08c29 100644
--- a/frontend/src/components/transactions-page-actions.tsx
+++ b/frontend/src/components/transactions-page-actions.tsx
@@ -1,5 +1,5 @@
import type { ReactNode } from 'react'
-import { ArrowLeftRight, CalendarDays, Copy, Download, List, MoreHorizontal } from 'lucide-react'
+import { ArrowLeftRight, CalendarDays, Copy, Download, List, MoreHorizontal, RefreshCw } from 'lucide-react'
import { useTranslation } from 'react-i18next'
import { MonthStepper } from '@/components/month-stepper'
import { TransactionsViewSwitcher, type TransactionsViewSwitcherProps } from '@/components/transactions-view-switcher'
@@ -34,6 +34,9 @@ export type TransactionsPageActionsProps = {
onAdd?: () => void
onDuplicate?: () => void
onTransfer?: () => void
+ /** Refetch the current list; `refreshing` spins the icon while it runs. */
+ onRefresh?: () => void
+ refreshing?: boolean
testId?: string
}
@@ -51,6 +54,19 @@ function DesktopSecondaryActions(props: TransactionsPageActionsProps) {
<div className="hidden sm:contents">
<TransactionsViewSwitcher {...props.view} />
{props.columnPicker}
+ {props.onRefresh && (
+ <Button
+ variant="outline"
+ size="icon"
+ className="!size-9"
+ aria-label={t('transactions.refresh')}
+ data-testid="refresh-transactions"
+ disabled={props.refreshing}
+ onClick={props.onRefresh}
+ >
+ <RefreshCw size={16} className={props.refreshing ? 'animate-spin' : ''} />
+ </Button>
+ )}
<Button variant="outline" disabled={props.exporting} onClick={props.onExport}>
<Download size={16} className="mr-1.5" />{props.exportLabel}
</Button>
@@ -90,6 +106,7 @@ function MobileSecondaryMenu(props: TransactionsPageActionsProps) {
</DropdownMenuRadioGroup>
<DropdownMenuSeparator />
<DropdownMenuItem disabled={props.exporting} onClick={props.onExport}><Download size={16} className="mr-2" />{props.exportLabel}</DropdownMenuItem>
+ {props.onRefresh && <DropdownMenuItem onClick={props.onRefresh}><RefreshCw size={16} className="mr-2" />{t('transactions.refresh')}</DropdownMenuItem>}
{props.onDuplicate && <DropdownMenuItem onClick={props.onDuplicate}><Copy size={16} className="mr-2" />{t('transactions.duplicate')}</DropdownMenuItem>}
{props.onTransfer && <DropdownMenuItem onClick={props.onTransfer}><ArrowLeftRight size={16} className="mr-2" />{t('transactions.transfer')}</DropdownMenuItem>}
</DropdownMenuContent>
diff --git a/frontend/src/hooks/use-cross-tab-refresh.test.tsx b/frontend/src/hooks/use-cross-tab-refresh.test.tsx
new file mode 100644
index 00000000..64c51ad5
--- /dev/null
+++ b/frontend/src/hooks/use-cross-tab-refresh.test.tsx
@@ -0,0 +1,78 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { renderHook, waitFor } from '@testing-library/react'
+import type { ReactNode } from 'react'
+import { QueryClient, QueryClientProvider, useQuery } from '@tanstack/react-query'
+import { useCrossTabRefresh } from '@/hooks/use-cross-tab-refresh'
+import { DATA_CHANGED_KEY } from '@/lib/data-changed'
+
+function wrapper({ children }: { children: ReactNode }) {
+ // staleTime 0 + no retry: only the invalidation this test triggers can
+ // refetch the query, which is exactly what is under test.
+ const client = new QueryClient({
+ defaultOptions: { queries: { retry: false, staleTime: 0 } },
+ })
+ return <QueryClientProvider client={client}>{children}</QueryClientProvider>
+}
+
+/** Dispatch what other tabs produce when they write the signal key. */
+function fireStorageEvent(key: string | null) {
+ const evt = new Event('storage') as Event & { key: string | null }
+ Object.defineProperty(evt, 'key', { value: key })
+ window.dispatchEvent(evt)
+}
+
+function renderSubject(fetchFn: () => Promise<string>) {
+ return renderHook(
+ () => {
+ const query = useQuery({ queryKey: ['transactions'], queryFn: fetchFn })
+ useCrossTabRefresh()
+ return query
+ },
+ { wrapper },
+ )
+}
+
+describe('useCrossTabRefresh', () => {
+ beforeEach(() => localStorage.clear())
+
+ it('refetches active queries when another tab changes data', async () => {
+ const fetchFn = vi
+ .fn()
+ .mockResolvedValueOnce('stale')
+ .mockResolvedValue('fresh')
+ const { result, unmount } = renderSubject(fetchFn)
+
+ await waitFor(() => expect(result.current.data).toBe('stale'))
+
+ fireStorageEvent(DATA_CHANGED_KEY)
+
+ await waitFor(() => expect(result.current.data).toBe('fresh'))
+ unmount()
+ })
+
+ it('ignores storage events for other keys', async () => {
+ const fetchFn = vi.fn().mockResolvedValue('same')
+ const { result, unmount } = renderSubject(fetchFn)
+
+ await waitFor(() => expect(result.current.data).toBe('same'))
+
+ fireStorageEvent('token')
+
+ // A refetch would raise the call count; give it a moment to (not) happen.
+ await new Promise((resolve) => setTimeout(resolve, 100))
+ expect(fetchFn).toHaveBeenCalledTimes(1)
+ unmount()
+ })
+
+ it('stops listening after unmount', async () => {
+ const fetchFn = vi.fn().mockResolvedValue('same')
+ const { result, unmount } = renderSubject(fetchFn)
+
+ await waitFor(() => expect(result.current.data).toBe('same'))
+ unmount()
+
+ fireStorageEvent(DATA_CHANGED_KEY)
+ await new Promise((resolve) => setTimeout(resolve, 100))
+ expect(fetchFn).toHaveBeenCalledTimes(1)
+ })
+})
diff --git a/frontend/src/hooks/use-cross-tab-refresh.ts b/frontend/src/hooks/use-cross-tab-refresh.ts
new file mode 100644
index 00000000..e9275bef
--- /dev/null
+++ b/frontend/src/hooks/use-cross-tab-refresh.ts
@@ -0,0 +1,26 @@
+import { useEffect } from 'react'
+import { useQueryClient } from '@tanstack/react-query'
+
+import { DATA_CHANGED_KEY } from '@/lib/data-changed'
+
+/**
+ * Refetches the cached queries when data changes in another tab.
+ *
+ * The `storage` event only fires in tabs that did not write, so this
+ * complements the per-mutation `invalidateQueries` calls that already keep
+ * the current tab in sync (issue #763): a rule re-applied from another tab
+ * used to leave this tab's transaction lists stale until the 5-minute
+ * staleTime expired.
+ */
+export function useCrossTabRefresh(): void {
+ const queryClient = useQueryClient()
+
+ useEffect(() => {
+ const onStorage = (event: StorageEvent) => {
+ if (event.key !== DATA_CHANGED_KEY) return
+ queryClient.invalidateQueries()
+ }
+ window.addEventListener('storage', onStorage)
+ return () => window.removeEventListener('storage', onStorage)
+ }, [queryClient])
+}
diff --git a/frontend/src/lib/api.test.ts b/frontend/src/lib/api.test.ts
new file mode 100644
index 00000000..1eba90fb
--- /dev/null
+++ b/frontend/src/lib/api.test.ts
@@ -0,0 +1,57 @@
+/** @vitest-environment jsdom */
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import type { InternalAxiosRequestConfig } from 'axios'
+import { api, rules } from '@/lib/api'
+import { DATA_CHANGED_KEY } from '@/lib/data-changed'
+
+// The interceptor under test only looks at method + success, so a fake
+// adapter that always resolves 200 is all the transport it needs.
+const okAdapter = (config: InternalAxiosRequestConfig) =>
+ Promise.resolve({ data: {}, status: 200, statusText: 'OK', headers: {}, config })
+
+describe('api data-change signal (issue #763)', () => {
+ beforeEach(() => {
+ localStorage.clear()
+ api.defaults.adapter = okAdapter
+ vi.restoreAllMocks()
+ })
+
+ it('bumps the signal after a successful mutation', async () => {
+ await api.post('/transactions', { description: 'x' })
+ expect(localStorage.getItem(DATA_CHANGED_KEY)).toBeTruthy()
+ })
+
+ it('bumps with a new value on each mutation, so repeated changes both notify', async () => {
+ vi.spyOn(Date, 'now').mockReturnValue(1000)
+ await api.patch('/transactions/1', { description: 'a' })
+ const first = localStorage.getItem(DATA_CHANGED_KEY)
+ await api.delete('/transactions/1')
+ const second = localStorage.getItem(DATA_CHANGED_KEY)
+ expect(first).toBeTruthy()
+ expect(second).not.toBe(first)
+ })
+
+ it('does not bump on reads', async () => {
+ await api.get('/transactions')
+ expect(localStorage.getItem(DATA_CHANGED_KEY)).toBeNull()
+ })
+
+ it('does not bump on a read-only POST such as the rule preview', async () => {
+ await rules.preview({ conditions: [], actions: [] } as unknown as Parameters<typeof rules.preview>[0])
+ expect(localStorage.getItem(DATA_CHANGED_KEY)).toBeNull()
+ })
+
+ it('still bumps on a real POST mutation that sits next to the preview', async () => {
+ await rules.applyAll()
+ expect(localStorage.getItem(DATA_CHANGED_KEY)).toBeTruthy()
+ })
+
+ it('does not bump when the mutation fails', async () => {
+ api.defaults.adapter = (config: InternalAxiosRequestConfig) =>
+ Promise.reject(
+ Object.assign(new Error('boom'), { config, response: { status: 500 } }),
+ )
+ await expect(api.post('/transactions', {})).rejects.toThrow()
+ expect(localStorage.getItem(DATA_CHANGED_KEY)).toBeNull()
+ })
+})
diff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.ts
index 2a8f68b8..452eacf5 100644
--- a/frontend/src/lib/api.ts
+++ b/frontend/src/lib/api.ts
@@ -1,4 +1,6 @@
import axios from 'axios'
+import type { AxiosResponse } from 'axios'
+import { markDataChanged } from '@/lib/data-changed'
import type { NumberFormat, DateFormat } from '@/lib/format'
import type {
User,
@@ -106,6 +108,7 @@ import type {
const api = axios.create({
baseURL: '/api',
})
+export { api }
// Storage key for the currently-selected workspace ID. Lives in
// localStorage so reloads + new tabs stay on the same workspace until
@@ -137,6 +140,31 @@ api.interceptors.response.use(
}
)
+declare module 'axios' {
+ interface AxiosRequestConfig {
+ /** Set on POSTs that only read (previews, sign-in, tokens, tests) so
+ * they do not tell other tabs that data changed. */
+ skipDataChanged?: boolean
+ }
+}
+
+/** Request config for a POST that changes nothing on the server. */
+const readOnly = { skipDataChanged: true } as const
+
+// A successful mutation here changes data that other tabs may be showing.
+// The bump fires the `storage` event in those tabs, where
+// `useCrossTabRefresh` turns it into a cache invalidation (issue #763).
+// Read-only POSTs opt out: a preview query re-run by that invalidation would
+// otherwise bump again and make two open tabs refresh each other forever.
+api.interceptors.response.use(
+ (response: AxiosResponse) => {
+ const method = (response.config.method ?? 'get').toLowerCase()
+ if (method !== 'get' && !response.config.skipDataChanged) markDataChanged()
+ return response
+ },
+ (error: unknown) => Promise.reject(error)
+)
+
// Workspaces
export const workspaces = {
list: async (): Promise<Workspace[]> => {
@@ -214,6 +242,7 @@ export const auth = {
formData.append('username', email)
formData.append('password', password)
const { data } = await api.post('/auth/login', formData, {
+ ...readOnly,
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
})
return data
@@ -245,7 +274,7 @@ export const auth = {
await api.post('/auth/2fa/disable', { password, code })
},
verify2fa: async (tempToken: string, code: string): Promise<{ access_token: string; token_type: string }> => {
- const { data } = await api.post('/auth/2fa/verify', { temp_token: tempToken, code })
+ const { data } = await api.post('/auth/2fa/verify', { temp_token: tempToken, code }, readOnly)
return data
},
listPasskeys: async (): Promise<Passkey[]> => {
@@ -272,7 +301,7 @@ export const auth = {
await api.delete(`/auth/passkeys/${id}`)
},
passkeyAuthenticationOptions: async (email?: string): Promise<PasskeyOptionsResponse> => {
- const { data } = await api.post('/auth/passkeys/authenticate/options', { email })
+ const { data } = await api.post('/auth/passkeys/authenticate/options', { email }, readOnly)
return data
},
verifyPasskeyAuthentication: async (
@@ -282,11 +311,11 @@ export const auth = {
const { data } = await api.post('/auth/passkeys/authenticate/verify', {
challenge_id: challengeId,
credential,
- })
+ }, readOnly)
return data
},
passkeySecondFactorOptions: async (tempToken: string): Promise<PasskeyOptionsResponse> => {
- const { data } = await api.post('/auth/passkeys/2fa/options', { temp_token: tempToken })
+ const { data } = await api.post('/auth/passkeys/2fa/options', { temp_token: tempToken }, readOnly)
return data
},
verifyPasskeySecondFactor: async (
@@ -298,7 +327,7 @@ export const auth = {
temp_token: tempToken,
challenge_id: challengeId,
credential,
- })
+ }, readOnly)
return data
},
oidcConfig: async (): Promise<{ enabled: boolean; provider_name: string; local_auth_enabled: boolean }> => {
@@ -383,11 +412,11 @@ export const connections = {
return data.providers
},
getConnectToken: async (provider = 'pluggy'): Promise<string> => {
- const { data } = await api.post('/connections/connect-token', { provider })
+ const { data } = await api.post('/connections/connect-token', { provider }, readOnly)
return data.access_token
},
getOAuthUrl: async (provider: string, flow_params?: Record<string, unknown>): Promise<string> => {
- const { data } = await api.post('/connections/oauth/url', { provider, flow_params })
+ const { data } = await api.post('/connections/oauth/url', { provider, flow_params }, readOnly)
return data.url
},
listInstitutions: async (
@@ -428,7 +457,7 @@ export const connections = {
return data
},
getReauthUrl: async (connectionId: string): Promise<string> => {
- const { data } = await api.post(`/connections/${connectionId}/oauth/reauth-url`)
+ const { data } = await api.post(`/connections/${connectionId}/oauth/reauth-url`, undefined, readOnly)
return data.url
},
sync: async (id: string): Promise<SyncResult> => {
@@ -436,7 +465,7 @@ export const connections = {
return data
},
getReconnectToken: async (connectionId: string): Promise<string> => {
- const { data } = await api.post(`/connections/${connectionId}/reconnect-token`)
+ const { data } = await api.post(`/connections/${connectionId}/reconnect-token`, undefined, readOnly)
return data.access_token
},
updateSettings: async (
@@ -688,7 +717,7 @@ export const transactions = {
if (options?.column_mapping && Object.keys(options.column_mapping).length > 0) {
formData.append('column_mapping', JSON.stringify(options.column_mapping))
}
- const { data } = await api.post('/transactions/import/preview', formData)
+ const { data } = await api.post('/transactions/import/preview', formData, readOnly)
return data
},
import: async (
@@ -1060,7 +1089,7 @@ export const rules = {
limit?: number
offset?: number
}): Promise<RulePreviewResponse> => {
- const { data } = await api.post('/rules/preview', draft)
+ const { data } = await api.post('/rules/preview', draft, readOnly)
return data
},
applyAll: async (): Promise<{ applied: number }> => {
@@ -1423,7 +1452,7 @@ export const assets = {
if (options?.column_mapping && Object.keys(options.column_mapping).length > 0) {
formData.append('column_mapping', JSON.stringify(options.column_mapping))
}
- const { data } = await api.post('/assets/import/preview', formData)
+ const { data } = await api.post('/assets/import/preview', formData, readOnly)
return data
},
importOrders: async (
@@ -1589,7 +1618,7 @@ export const backup = {
const { data } = await api.post(
'/export/backup',
password ? { password } : {},
- { responseType: 'blob' },
+ { ...readOnly, responseType: 'blob' },
)
const blob = new Blob([data], { type: 'application/zip' })
const url = URL.createObjectURL(blob)
@@ -1949,7 +1978,7 @@ export const agents = {
await api.delete(`/agents/connections/${id}`)
},
test: async (id: string): Promise<LlmConnectionTestResult> => {
- const { data } = await api.post(`/agents/connections/${id}/test`)
+ const { data } = await api.post(`/agents/connections/${id}/test`, undefined, readOnly)
return data
},
},
diff --git a/frontend/src/lib/data-changed.test.ts b/frontend/src/lib/data-changed.test.ts
new file mode 100644
index 00000000..385c34eb
--- /dev/null
+++ b/frontend/src/lib/data-changed.test.ts
@@ -0,0 +1,32 @@
+/** @vitest-environment jsdom */
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { DATA_CHANGED_KEY, markDataChanged } from '@/lib/data-changed'
+
+describe('markDataChanged', () => {
+ beforeEach(() => {
+ localStorage.clear()
+ vi.restoreAllMocks()
+ })
+
+ it('writes a value under the signal key', () => {
+ markDataChanged()
+ expect(localStorage.getItem(DATA_CHANGED_KEY)).toBeTruthy()
+ })
+
+ it('writes a new value on each call, even within the same millisecond', () => {
+ vi.spyOn(Date, 'now').mockReturnValue(1)
+ vi.spyOn(Math, 'random').mockReturnValue(0.5)
+ markDataChanged()
+ const first = localStorage.getItem(DATA_CHANGED_KEY)
+ markDataChanged()
+ const second = localStorage.getItem(DATA_CHANGED_KEY)
+ expect(second).not.toBe(first)
+ })
+
+ it('does not throw when storage is unavailable', () => {
+ vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
+ throw new Error('blocked')
+ })
+ expect(() => markDataChanged()).not.toThrow()
+ })
+})
diff --git a/frontend/src/lib/data-changed.ts b/frontend/src/lib/data-changed.ts
new file mode 100644
index 00000000..ec16bbf2
--- /dev/null
+++ b/frontend/src/lib/data-changed.ts
@@ -0,0 +1,33 @@
+/**
+ * Cross-tab data-change signal.
+ *
+ * The query cache is per tab: a change made in another tab (a rule
+ * re-applied to existing transactions, an edited transaction) never reaches
+ * this tab's cache, so its lists keep showing the stale data until the
+ * global staleTime runs out. The response interceptor in `api.ts` bumps this
+ * key after every successful mutation, and the browser's `storage` event
+ * (which fires in every other tab, never in the one that wrote) is what
+ * `useCrossTabRefresh` listens for.
+ */
+export const DATA_CHANGED_KEY = 'securo.data-changed'
+
+let sequence = 0
+
+/**
+ * Record that a mutation succeeded in this tab.
+ *
+ * A new value on every call so even two quick changes both notify the other
+ * tabs: the timestamp alone repeats within the same millisecond, and writing
+ * an unchanged value fires no `storage` event. The per-tab counter keeps this
+ * tab's writes distinct, the random part keeps two tabs from colliding. No-op where storage is unavailable (private mode): cross-tab refresh
+ * is a convenience, and the same-tab invalidations still apply.
+ */
+export function markDataChanged(): void {
+ try {
+ sequence += 1
+ const value = `${Date.now()}-${sequence}-${Math.random().toString(36).slice(2)}`
+ localStorage.setItem(DATA_CHANGED_KEY, value)
+ } catch {
+ // Ignore: nothing to do when localStorage throws.
+ }
+}
diff --git a/frontend/src/lib/transactions-refresh.test.ts b/frontend/src/lib/transactions-refresh.test.ts
new file mode 100644
index 00000000..bc664cdc
--- /dev/null
+++ b/frontend/src/lib/transactions-refresh.test.ts
@@ -0,0 +1,32 @@
+import { describe, expect, it, vi } from 'vitest'
+import { refreshTransactionsView } from '@/lib/transactions-refresh'
+
+const ok = { isError: false, error: null }
+
+describe('refreshTransactionsView', () => {
+ it('refetches the list query in list view', async () => {
+ const refetchList = vi.fn().mockResolvedValue(ok)
+ const refetchCalendar = vi.fn().mockResolvedValue(ok)
+ const onError = vi.fn()
+ await refreshTransactionsView({ viewMode: 'list', refetchList, refetchCalendar, onError })
+ expect(refetchList).toHaveBeenCalledTimes(1)
+ expect(refetchCalendar).not.toHaveBeenCalled()
+ expect(onError).not.toHaveBeenCalled()
+ })
+
+ it('refetches the calendar query in calendar view', async () => {
+ const refetchList = vi.fn().mockResolvedValue(ok)
+ const refetchCalendar = vi.fn().mockResolvedValue(ok)
+ await refreshTransactionsView({ viewMode: 'calendar', refetchList, refetchCalendar, onError: vi.fn() })
+ expect(refetchCalendar).toHaveBeenCalledTimes(1)
+ expect(refetchList).not.toHaveBeenCalled()
+ })
+
+ it('reports the API error message when the request fails', async () => {
+ const error = { response: { data: { detail: 'Account not found' } } }
+ const refetchList = vi.fn().mockResolvedValue({ isError: true, error })
+ const onError = vi.fn()
+ await refreshTransactionsView({ viewMode: 'list', refetchList, refetchCalendar: vi.fn(), onError })
+ expect(onError).toHaveBeenCalledWith('Account not found')
+ })
+})
diff --git a/frontend/src/lib/transactions-refresh.ts b/frontend/src/lib/transactions-refresh.ts
new file mode 100644
index 00000000..37f89b35
--- /dev/null
+++ b/frontend/src/lib/transactions-refresh.ts
@@ -0,0 +1,25 @@
+import { extractApiError } from '@/lib/api-errors'
+
+interface RefetchResult {
+ isError: boolean
+ error: unknown
+}
+
+export interface RefreshTransactionsViewOptions {
+ viewMode: 'list' | 'calendar'
+ refetchList: () => Promise<RefetchResult>
+ refetchCalendar: () => Promise<RefetchResult>
+ onError: (message: string) => void
+}
+
+/**
+ * Refetch the query behind the view on screen (the calendar renders its own
+ * query, not the list) and report a failed request with the API's message.
+ */
+export async function refreshTransactionsView(
+ options: RefreshTransactionsViewOptions,
+): Promise<void> {
+ const refetch = options.viewMode === 'calendar' ? options.refetchCalendar : options.refetchList
+ const result = await refetch()
+ if (result.isError) options.onError(extractApiError(result.error))
+}
diff --git a/frontend/src/locales/cs.json b/frontend/src/locales/cs.json
index 97973654..af86b405 100644
--- a/frontend/src/locales/cs.json
+++ b/frontend/src/locales/cs.json
@@ -973,6 +973,7 @@
"searchPlaceholder": "Hledat transakce...",
"clearFilters": "Zrušit filtry",
"exportCsv": "Exportovat CSV",
+ "refresh": "Obnovit",
"exportSelected": "Exportovat vybrané ({{count}})",
"exportSelected_one": "Exportovat vybranou ({{count}})",
"exportSelected_few": "Exportovat vybrané ({{count}})",
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index 47548242..54073215 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -941,6 +941,7 @@
"searchPlaceholder": "Transaktionen suchen...",
"clearFilters": "Filter löschen",
"exportCsv": "Als CSV exportieren",
+ "refresh": "Aktualisieren",
"exportSelected": "Ausgewählte exportieren ({{count}})",
"exporting": "Exportieren...",
"exportSuccess": "Transaktionen erfolgreich exportiert",
diff --git a/frontend/src/locales/el.json b/frontend/src/locales/el.json
index 1d2ef74f..f1daf76a 100644
--- a/frontend/src/locales/el.json
+++ b/frontend/src/locales/el.json
@@ -1127,6 +1127,7 @@
"searchPlaceholder": "Αναζήτηση συναλλαγών...",
"clearFilters": "Εκκαθάριση φίλτρων",
"exportCsv": "Εξαγωγή σε CSV",
+ "refresh": "Ανανέωση",
"exportSelected": "Εξαγωγή επιλεγμένων ({{count}})",
"exporting": "Εξαγωγή...",
"exportSuccess": "Οι συναλλαγές εξήχθησαν επιτυχώς",
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 597f5ed1..d39cd6d9 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -941,6 +941,7 @@
"searchPlaceholder": "Search transactions...",
"clearFilters": "Clear filters",
"exportCsv": "Export CSV",
+ "refresh": "Refresh",
"exportSelected": "Export Selected ({{count}})",
"exporting": "Exporting...",
"exportSuccess": "Transactions exported successfully",
diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.json
index 58ff5537..070bba11 100644
--- a/frontend/src/locales/es.json
+++ b/frontend/src/locales/es.json
@@ -943,6 +943,7 @@
"searchPlaceholder": "Buscar transacciones...",
"clearFilters": "Borrar filtros",
"exportCsv": "Exportar CSV",
+ "refresh": "Actualizar",
"exportSelected": "Exportar seleccionadas ({{count}})",
"exporting": "Exportando...",
"exportSuccess": "Transacciones exportadas correctamente",
diff --git a/frontend/src/locales/fr.json b/frontend/src/locales/fr.json
index f1c708db..31964cbd 100644
--- a/frontend/src/locales/fr.json
+++ b/frontend/src/locales/fr.json
@@ -943,6 +943,7 @@
"searchPlaceholder": "Rechercher des transactions...",
"clearFilters": "Effacer les filtres",
"exportCsv": "Exporter en CSV",
+ "refresh": "Actualiser",
"exportSelected": "Exporter la sélection ({{count}})",
"exporting": "Exportation...",
"exportSuccess": "Transactions exportées avec succès",
diff --git a/frontend/src/locales/hi.json b/frontend/src/locales/hi.json
index e164a62d..277ca485 100644
--- a/frontend/src/locales/hi.json
+++ b/frontend/src/locales/hi.json
@@ -941,6 +941,7 @@
"searchPlaceholder": "लेन-देन खोजें...",
"clearFilters": "फ़िल्टर हटाएँ",
"exportCsv": "CSV एक्सपोर्ट करें",
+ "refresh": "रिफ्रेश करें",
"exportSelected": "चयनित एक्सपोर्ट करें ({{count}})",
"exporting": "एक्सपोर्ट हो रहा है...",
"exportSuccess": "लेन-देन सफलतापूर्वक एक्सपोर्ट हुए",
diff --git a/frontend/src/locales/hu.json b/frontend/src/locales/hu.json
index 053fb9c8..4060bd3c 100644
--- a/frontend/src/locales/hu.json
+++ b/frontend/src/locales/hu.json
@@ -941,6 +941,7 @@
"searchPlaceholder": "Tranzakciók keresése...",
"clearFilters": "Szűrők törlése",
"exportCsv": "CSV exportálása",
+ "refresh": "Frissítés",
"exportSelected": "Kijelöltek exportálása ({{count}})",
"exporting": "Exportálás...",
"exportSuccess": "Tranzakciók sikeresen exportálva",
diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.json
index 92588017..9fe922ae 100644
--- a/frontend/src/locales/it.json
+++ b/frontend/src/locales/it.json
@@ -943,6 +943,7 @@
"searchPlaceholder": "Cerca transazioni...",
"clearFilters": "Cancella filtri",
"exportCsv": "Esporta CSV",
+ "refresh": "Aggiorna",
"exportSelected": "Esporta selezionate ({{count}})",
"exporting": "Esportazione...",
"exportSuccess": "Transazioni esportate con successo",
diff --git a/frontend/src/locales/ja.json b/frontend/src/locales/ja.json
index f98a8fd1..3ff6806d 100644
--- a/frontend/src/locales/ja.json
+++ b/frontend/src/locales/ja.json
@@ -941,6 +941,7 @@
"searchPlaceholder": "取引を検索...",
"clearFilters": "フィルタをクリア",
"exportCsv": "CSVエクスポート",
+ "refresh": "更新",
"exportSelected": "選択をエクスポート({{count}}件)",
"exporting": "エクスポート中...",
"exportSuccess": "取引をエクスポートしました",
diff --git a/frontend/src/locales/nl.json b/frontend/src/locales/nl.json
index d184fad9..35cb38fb 100644
--- a/frontend/src/locales/nl.json
+++ b/frontend/src/locales/nl.json
@@ -941,6 +941,7 @@
"searchPlaceholder": "Transacties zoeken...",
"clearFilters": "Filters wissen",
"exportCsv": "CSV exporteren",
+ "refresh": "Vernieuwen",
"exportSelected": "Geselecteerde export ({{count}})",
"exporting": "Exporteren...",
"exportSuccess": "Transacties zijn succesvol geëxporteerd",
diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.json
index 207ea944..18c9371d 100644
--- a/frontend/src/locales/pl.json
+++ b/frontend/src/locales/pl.json
@@ -955,6 +955,7 @@
"searchPlaceholder": "Szukaj transakcji...",
"clearFilters": "Wyczyść filtry",
"exportCsv": "Eksportuj CSV",
+ "refresh": "Odśwież",
"exportSelected_one": "Eksportuj zaznaczone ({{count}})",
"exportSelected_few": "Eksportuj zaznaczone ({{count}})",
"exportSelected_many": "Eksportuj zaznaczone ({{count}})",
diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.json
index 45f66e93..abbc6c89 100644
--- a/frontend/src/locales/pt-BR.json
+++ b/frontend/src/locales/pt-BR.json
@@ -943,6 +943,7 @@
"searchPlaceholder": "Buscar transações...",
"clearFilters": "Limpar filtros",
"exportCsv": "Exportar CSV",
+ "refresh": "Atualizar",
"exportSelected": "Exportar Selecionadas ({{count}})",
"exporting": "Exportando...",
"exportSuccess": "Transações exportadas com sucesso",
diff --git a/frontend/src/locales/pt-PT.json b/frontend/src/locales/pt-PT.json
index 5e42afcb..ae107761 100644
--- a/frontend/src/locales/pt-PT.json
+++ b/frontend/src/locales/pt-PT.json
@@ -943,6 +943,7 @@
"searchPlaceholder": "Procurar transações...",
"clearFilters": "Limpar filtros",
"exportCsv": "Exportar CSV",
+ "refresh": "Atualizar",
"exportSelected": "Exportar Selecionadas ({{count}})",
"exporting": "A exportar...",
"exportSuccess": "Transações exportadas com sucesso",
diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.json
index c9a4158b..bbc559de 100644
--- a/frontend/src/locales/ru.json
+++ b/frontend/src/locales/ru.json
@@ -949,6 +949,7 @@
"searchPlaceholder": "Поиск транзакций...",
"clearFilters": "Сбросить фильтры",
"exportCsv": "Экспорт CSV",
+ "refresh": "Обновить",
"exportSelected": "Экспортировать выбранные ({{count}})",
"exporting": "Экспорт...",
"exportSuccess": "Транзакции успешно экспортированы",
diff --git a/frontend/src/locales/sk.json b/frontend/src/locales/sk.json
index f3d6507a..b0794308 100644
--- a/frontend/src/locales/sk.json
+++ b/frontend/src/locales/sk.json
@@ -957,6 +957,7 @@
"searchPlaceholder": "Hľadať transakcie...",
"clearFilters": "Zrušiť filtre",
"exportCsv": "Exportovať CSV",
+ "refresh": "Obnoviť",
"exportSelected": "Exportovať vybrané ({{count}})",
"exportSelected_one": "Exportovať vybranú ({{count}})",
"exportSelected_few": "Exportovať vybrané ({{count}})",
diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.json
index 8a23e2e5..45ab08c6 100644
--- a/frontend/src/locales/uk.json
+++ b/frontend/src/locales/uk.json
@@ -949,6 +949,7 @@
"searchPlaceholder": "Пошук транзакцій...",
"clearFilters": "Скинути фільтри",
"exportCsv": "Експорт CSV",
+ "refresh": "Оновити",
"exportSelected": "Експортувати обрані ({{count}})",
"exporting": "Експорт...",
"exportSuccess": "Транзакції успішно експортовано",
diff --git a/frontend/src/pages/transactions.tsx b/frontend/src/pages/transactions.tsx
index 662f2055..b9bb1613 100644
--- a/frontend/src/pages/transactions.tsx
+++ b/frontend/src/pages/transactions.tsx
@@ -46,6 +46,7 @@ import { CategoryIcon } from '@/components/category-icon'
import { CategorySelect } from '@/components/category-select'
import { TransactionDialog, type SaveAction, type TransactionSavePayload } from '@/components/transaction-dialog'
import { extractApiError } from '@/lib/api-errors'
+import { refreshTransactionsView } from '@/lib/transactions-refresh'
import { TransactionsColumnPicker } from '@/components/transactions-column-picker'
import { TransactionsPageActions } from '@/components/transactions-page-actions'
import { MobileBulkSelectionActions } from '@/components/mobile-bulk-selection-actions'
@@ -383,7 +384,7 @@ export default function TransactionsPage() {
const noAccounts = filterAccountIds.length === 0
&& activeAccountIds !== null && activeAccountIds.length === 0
- const { data, isLoading } = useQuery({
+ const { data, isLoading, isFetching, refetch } = useQuery({
queryKey: ['transactions', page, limit, effectiveAccountIds, filterCategoryIds, filterUncategorized, filterPayee, filterGroupId, filterType, filterStatus, filterFrom, filterTo, filterMinAmount, filterMaxAmount, hideIgnored, searchQuery, tagFilters, isMobile ? 'date' : grid.sortBy, isMobile ? 'desc' : grid.sortDir],
enabled: !noAccounts,
queryFn: () =>
@@ -412,7 +413,7 @@ export default function TransactionsPage() {
const calendarMonth = steppedMonth
const calendarAccountIds = filterAccountIds.length === 1 ? filterAccountIds : []
- const { data: calendarData, isLoading: calendarLoading } = useQuery({
+ const { data: calendarData, isLoading: calendarLoading, isFetching: calendarFetching, refetch: refetchCalendar } = useQuery({
queryKey: ['transactions', 'calendar', calendarMonth, calendarAccountIds],
enabled: viewMode === 'calendar',
queryFn: () => transactions.calendar({
@@ -1377,6 +1378,16 @@ export default function TransactionsPage() {
onAdd={canWrite ? () => { setEditingTx(null); setDialogOpen(true) } : undefined}
onDuplicate={duplicableTx ? () => handleDuplicateTransaction(duplicableTx) : undefined}
onTransfer={canWrite ? () => setTransferDialogOpen(true) : undefined}
+ onRefresh={noAccounts ? undefined : () => {
+ void refreshTransactionsView({
+ viewMode,
+ refetchList: refetch,
+ refetchCalendar,
+ onError: (message) => toast.error(message),
+ })
+ }}
+ refreshing={viewMode === 'calendar' ? calendarFetching : isFetching}
+ testId="transactions-page-actions"
/>
}
/>