Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

feat: add Hong Kong dollar (HKD) and New Taiwan dollar (TWD) currency support (#1190)

Vijay Misal7e7e3cb30b56
diff --git a/backend/app/api/currencies.py b/backend/app/api/currencies.py
index 254729fd..222fa109 100644
--- a/backend/app/api/currencies.py
+++ b/backend/app/api/currencies.py
@@ -52,6 +52,8 @@ CURRENCY_META = {
"JMD": {"symbol": "J$", "name": "Jamaican Dollar", "flag": "\U0001F1EF\U0001F1F2"},
"RSD": {"symbol": "RSD", "name": "Serbian Dinar", "flag": "\U0001F1F7\U0001F1F8"},
"MKD": {"symbol": "ден", "name": "Macedonian Denar", "flag": "\U0001F1F2\U0001F1F0"},
+ "HKD": {"symbol": "HK$", "name": "Hong Kong Dollar", "flag": "\U0001F1ED\U0001F1F0"},
+ "TWD": {"symbol": "NT$", "name": "New Taiwan Dollar", "flag": "\U0001F1F9\U0001F1FC"},
}
diff --git a/backend/app/core/config.py b/backend/app/core/config.py
index 1c7e5c39..d40802ba 100644
--- a/backend/app/core/config.py
+++ b/backend/app/core/config.py
@@ -72,7 +72,7 @@ class Settings(BaseSettings):
# FX Rates
openexchangerates_app_id: str = ""
- supported_currencies: str = "USD,EUR,GBP,BRL,CAD,AUD,CHF,ARS,JPY,MXN,INR,SEK,DKK,NOK,PLN,CZK,HUF,RON,CRC,IDR,COP,CLP,DOP,KZT,RUB,GTQ,PHP,UAH,NZD,VND,SGD,AZN,TRY,PKR,MDL,AED,THB,EGP,MYR,CNY,SAR,QAR,JMD,RSD,MKD" # comma-separated list
+ supported_currencies: str = "USD,EUR,GBP,BRL,CAD,AUD,CHF,ARS,JPY,MXN,INR,SEK,DKK,NOK,PLN,CZK,HUF,RON,CRC,IDR,COP,CLP,DOP,KZT,RUB,GTQ,PHP,UAH,NZD,VND,SGD,AZN,TRY,PKR,MDL,AED,THB,EGP,MYR,CNY,SAR,QAR,JMD,RSD,MKD,HKD,TWD" # comma-separated list
fx_sync_mode: str = "on_demand" # "on_demand" or "scheduled"
# Storage
diff --git a/backend/tests/test_currencies_api.py b/backend/tests/test_currencies_api.py
index cef954da..ed44b482 100644
--- a/backend/tests/test_currencies_api.py
+++ b/backend/tests/test_currencies_api.py
@@ -251,3 +251,27 @@ async def test_currencies_include_mkd_with_metadata(client: AsyncClient):
assert mkd["symbol"] == "ден"
assert mkd["name"] == "Macedonian Denar"
assert mkd["flag"] == "🇲🇰"
+
+
+async def test_currencies_include_hkd_with_metadata(client: AsyncClient):
+ response = await client.get("/api/currencies")
+ data = response.json()
+ hkd = next((currency for currency in data if currency["code"] == "HKD"), None)
+
+ assert hkd is not None
+ assert hkd["symbol"] == "HK$"
+ assert hkd["name"] == "Hong Kong Dollar"
+ assert hkd["flag"] == "🇭🇰"
+
+
+async def test_currencies_include_twd_with_metadata(client: AsyncClient):
+ response = await client.get("/api/currencies")
+ data = response.json()
+ twd = next((currency for currency in data if currency["code"] == "TWD"), None)
+
+ assert twd is not None
+ assert twd["symbol"] == "NT$"
+ assert twd["name"] == "New Taiwan Dollar"
+ assert twd["flag"] == "🇹🇼"
diff --git a/frontend/src/components/currency-select.tsx b/frontend/src/components/currency-select.tsx
index 93f450c6..e0141e61 100644
--- a/frontend/src/components/currency-select.tsx
+++ b/frontend/src/components/currency-select.tsx
@@ -55,6 +55,8 @@ export const CURRENCIES = [
{ code: 'JMD', flag: '\u{1F1EF}\u{1F1F2}', symbol: 'J$' },
{ code: 'RSD', flag: '\u{1F1F7}\u{1F1F8}', symbol: 'RSD' },
{ code: 'MKD', flag: '\u{1F1F2}\u{1F1F0}', symbol: 'ден' },
+ { code: 'HKD', flag: '\u{1F1ED}\u{1F1F0}', symbol: 'HK$' },
+ { code: 'TWD', flag: '\u{1F1F9}\u{1F1FC}', symbol: 'NT$' },
] as const
interface CurrencySelectProps {
diff --git a/frontend/src/lib/format.test.ts b/frontend/src/lib/format.test.ts
index 7a945200..75c266cc 100644
--- a/frontend/src/lib/format.test.ts
+++ b/frontend/src/lib/format.test.ts
@@ -34,6 +34,8 @@ describe('resolveDisplayLocale', () => {
expect(resolveDisplayLocale('auto', 'INR')).toBe('en-IN')
expect(resolveDisplayLocale('auto', 'RSD')).toBe('sr-RS')
expect(resolveDisplayLocale('auto', 'MKD')).toBe('mk-MK')
+ expect(resolveDisplayLocale('auto', 'HKD')).toBe('zh-HK')
+ expect(resolveDisplayLocale('auto', 'TWD')).toBe('zh-TW')
})
it('treats a missing number format like auto', () => {
diff --git a/frontend/src/lib/format.ts b/frontend/src/lib/format.ts
index 5fb32078..e083a2c4 100644
--- a/frontend/src/lib/format.ts
+++ b/frontend/src/lib/format.ts
@@ -77,6 +77,8 @@ const CURRENCY_LOCALE: Record<string, string> = {
JMD: 'en-JM',
RSD: 'sr-RS',
MKD: 'mk-MK',
+ HKD: 'zh-HK',
+ TWD: 'zh-TW',
}
/**