Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

fix(a11y): add hover/accessible labels to icon-only buttons (#405)

Rodrigo Maia888fe7674991
diff --git a/frontend/src/components/agents/knowledge-section.tsx b/frontend/src/components/agents/knowledge-section.tsx
index 7bfd8c2a..3b82aa38 100644
--- a/frontend/src/components/agents/knowledge-section.tsx
+++ b/frontend/src/components/agents/knowledge-section.tsx
@@ -122,7 +122,7 @@ export function KnowledgeSection({ agentId }: { agentId: string }) {
>
{d.pinned ? <Pin className="h-4 w-4 text-amber-500" /> : <PinOff className="h-4 w-4" />}
</Button>
- <Button size="icon" variant="ghost" onClick={() => remove.mutate(d.id)}>
+ <Button size="icon" variant="ghost" onClick={() => remove.mutate(d.id)} title={t('common.delete')}>
<Trash2 className="h-4 w-4 text-rose-500" />
</Button>
</>
diff --git a/frontend/src/components/transaction-drill-down.tsx b/frontend/src/components/transaction-drill-down.tsx
index 704a4cd6..0fa06dd1 100644
--- a/frontend/src/components/transaction-drill-down.tsx
+++ b/frontend/src/components/transaction-drill-down.tsx
@@ -208,6 +208,7 @@ export function TransactionDrillDown({
<button
onClick={onClose}
className="w-8 h-8 flex items-center justify-center rounded-lg hover:bg-muted text-muted-foreground hover:text-foreground transition-colors shrink-0"
+ title={t('common.close')}
>
<X size={16} />
</button>
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index db899b1d..b07cc089 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -1149,6 +1149,8 @@
"range30d": "30T"
},
"payees": {
+ "addFavorite": "Zu Favoriten hinzufügen",
+ "removeFavorite": "Aus Favoriten entfernen",
"title": "Zahlungsempfänger",
"section": "Einrichtung",
"payee": "Zahlungsempfänger",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Nur Favoriten"
},
"common": {
+ "view": "Ansehen",
"save": "Speichern",
"cancel": "Abbrechen",
"close": "Schließen",
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 9aa5f0b0..a04ecd7c 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -1149,6 +1149,8 @@
"range30d": "30D"
},
"payees": {
+ "addFavorite": "Add to favorites",
+ "removeFavorite": "Remove from favorites",
"title": "Payees",
"section": "Setup",
"payee": "Payee",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Favorites Only"
},
"common": {
+ "view": "View",
"save": "Save",
"cancel": "Cancel",
"close": "Close",
diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.json
index 37648525..238658e8 100644
--- a/frontend/src/locales/es.json
+++ b/frontend/src/locales/es.json
@@ -1149,6 +1149,8 @@
"range30d": "30D"
},
"payees": {
+ "addFavorite": "Añadir a favoritos",
+ "removeFavorite": "Quitar de favoritos",
"title": "Beneficiarios",
"section": "Configuración",
"payee": "Beneficiario",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Solo favoritos"
},
"common": {
+ "view": "Ver",
"save": "Guardar",
"cancel": "Cancelar",
"close": "Cerrar",
diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.json
index e5628352..2310479d 100644
--- a/frontend/src/locales/it.json
+++ b/frontend/src/locales/it.json
@@ -1149,6 +1149,8 @@
"range30d": "30D"
},
"payees": {
+ "addFavorite": "Aggiungi ai preferiti",
+ "removeFavorite": "Rimuovi dai preferiti",
"title": "Beneficiari",
"section": "Configurazione",
"payee": "Beneficiario",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Solo preferiti"
},
"common": {
+ "view": "Visualizza",
"save": "Salva",
"cancel": "Annulla",
"close": "Chiudi",
diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.json
index c90964ec..04de909b 100644
--- a/frontend/src/locales/pl.json
+++ b/frontend/src/locales/pl.json
@@ -1218,6 +1218,8 @@
"range30d": "30D"
},
"payees": {
+ "addFavorite": "Dodaj do ulubionych",
+ "removeFavorite": "Usuń z ulubionych",
"title": "Odbiorcy",
"section": "Konfiguracja",
"payee": "Odbiorca",
@@ -1259,6 +1261,7 @@
"favoritesOnly": "Tylko ulubione"
},
"common": {
+ "view": "Zobacz",
"save": "Zapisz",
"cancel": "Anuluj",
"close": "Zamknij",
diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.json
index 62de0f3b..1aa9947e 100644
--- a/frontend/src/locales/pt-BR.json
+++ b/frontend/src/locales/pt-BR.json
@@ -1149,6 +1149,8 @@
"range30d": "30D"
},
"payees": {
+ "addFavorite": "Adicionar aos favoritos",
+ "removeFavorite": "Remover dos favoritos",
"title": "Beneficiários",
"section": "Configuração",
"payee": "Beneficiário",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Apenas favoritos"
},
"common": {
+ "view": "Ver",
"save": "Salvar",
"cancel": "Cancelar",
"close": "Fechar",
diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.json
index 012ee962..0d94de65 100644
--- a/frontend/src/locales/ru.json
+++ b/frontend/src/locales/ru.json
@@ -1149,6 +1149,8 @@
"range30d": "30D"
},
"payees": {
+ "addFavorite": "Добавить в избранное",
+ "removeFavorite": "Удалить из избранного",
"title": "Получатели",
"section": "Настройка",
"payee": "Получатель",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Только избранные"
},
"common": {
+ "view": "Просмотр",
"save": "Сохранить",
"cancel": "Отмена",
"close": "Закрыть",
diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.json
index fd62076f..28951491 100644
--- a/frontend/src/locales/uk.json
+++ b/frontend/src/locales/uk.json
@@ -1149,6 +1149,8 @@
"range30d": "30Д"
},
"payees": {
+ "addFavorite": "Додати до обраного",
+ "removeFavorite": "Видалити з обраного",
"title": "Отримувачі",
"section": "Налаштування",
"payee": "Отримувач",
@@ -1184,6 +1186,7 @@
"favoritesOnly": "Тільки обрані"
},
"common": {
+ "view": "Переглянути",
"save": "Зберегти",
"cancel": "Скасувати",
"close": "Закрити",
diff --git a/frontend/src/pages/accounts.tsx b/frontend/src/pages/accounts.tsx
index 77d86eca..64f21bda 100644
--- a/frontend/src/pages/accounts.tsx
+++ b/frontend/src/pages/accounts.tsx
@@ -385,6 +385,7 @@ export default function AccountsPage() {
size="sm"
className="h-8 w-8 p-0 text-muted-foreground hover:text-foreground"
onClick={() => setSettingsConnection(conn)}
+ title={t('connections.settings')}
>
<Settings size={14} />
</Button>
@@ -417,6 +418,7 @@ export default function AccountsPage() {
className="h-8 w-8 p-0 text-muted-foreground hover:text-rose-500"
onClick={() => setDisconnectingConnection(conn)}
disabled={disconnectMutation.isPending}
+ title={t('accounts.disconnect')}
>
<Unlink size={14} />
</Button>
diff --git a/frontend/src/pages/admin/settings.tsx b/frontend/src/pages/admin/settings.tsx
index db04755d..7023c539 100644
--- a/frontend/src/pages/admin/settings.tsx
+++ b/frontend/src/pages/admin/settings.tsx
@@ -353,6 +353,7 @@ export default function AdminSettingsPage() {
role="button"
onClick={(e) => { e.stopPropagation(); setDeleteUser(u) }}
className="p-1.5 rounded-md text-muted-foreground/40 hover:text-destructive hover:bg-destructive/10 transition-colors"
+ title={t('common.delete')}
>
<Trash2 size={14} />
</span>
diff --git a/frontend/src/pages/agent-connections.tsx b/frontend/src/pages/agent-connections.tsx
index eac4fbcb..51d5c7a0 100644
--- a/frontend/src/pages/agent-connections.tsx
+++ b/frontend/src/pages/agent-connections.tsx
@@ -138,6 +138,7 @@ export default function AgentConnectionsPage() {
type="button"
onClick={() => setEditing(c)}
className="p-1.5 rounded-md text-muted-foreground hover:text-primary hover:bg-primary/5 transition-colors"
+ title={t('common.edit')}
>
<Edit2 className="h-4 w-4" />
</button>
@@ -149,6 +150,7 @@ export default function AgentConnectionsPage() {
}
}}
className="p-1.5 rounded-md text-muted-foreground hover:text-rose-500 hover:bg-rose-50 dark:hover:bg-rose-950/30 transition-colors"
+ title={t('common.delete')}
>
<Trash2 className="h-4 w-4" />
</button>
diff --git a/frontend/src/pages/agent-detail.tsx b/frontend/src/pages/agent-detail.tsx
index fcc69269..a2599324 100644
--- a/frontend/src/pages/agent-detail.tsx
+++ b/frontend/src/pages/agent-detail.tsx
@@ -77,7 +77,7 @@ export default function AgentDetailPage() {
// overflow-hidden ensures only the messages div inside ChatPanel scrolls.
<div className="flex flex-col h-[calc(100dvh-6.5rem)] lg:h-[calc(100dvh-3rem)] overflow-hidden">
<div className="border-b px-4 py-3 flex items-center gap-3">
- <Button size="icon" variant="ghost" onClick={() => navigate('/agents')}>
+ <Button size="icon" variant="ghost" onClick={() => navigate('/agents')} title={t('common.back')} aria-label={t('common.back')}>
<ArrowLeft className="h-4 w-4" />
</Button>
<div
diff --git a/frontend/src/pages/agents-list.tsx b/frontend/src/pages/agents-list.tsx
index 03068a65..ab7a6303 100644
--- a/frontend/src/pages/agents-list.tsx
+++ b/frontend/src/pages/agents-list.tsx
@@ -166,6 +166,8 @@ export default function AgentsListPage() {
<Link
to={`/agents/${a.id}`}
className="shrink-0 text-muted-foreground/60 hover:text-muted-foreground"
+ aria-label={t('common.view')}
+ title={t('common.view')}
>
<ChevronRight className="h-4 w-4" />
</Link>
diff --git a/frontend/src/pages/assets.tsx b/frontend/src/pages/assets.tsx
index 5edf10b5..e3912e82 100644
--- a/frontend/src/pages/assets.tsx
+++ b/frontend/src/pages/assets.tsx
@@ -812,10 +812,10 @@ export default function AssetsPage() {
<button onClick={(e) => { e.stopPropagation(); setMovingAsset(asset) }} title={t('assets.moveToWallet')} className="p-1 rounded text-muted-foreground hover:text-foreground hover:bg-muted transition-colors">
<FolderInput size={13} />
</button>
- <button onClick={(e) => { e.stopPropagation(); if (!isProviderOwned) openEdit(asset) }} disabled={isProviderOwned} title={isProviderOwned ? t('assets.syncedReadOnly') : undefined} className="p-1 rounded text-muted-foreground hover:text-foreground hover:bg-muted transition-colors disabled:opacity-30 disabled:cursor-not-allowed">
+ <button onClick={(e) => { e.stopPropagation(); if (!isProviderOwned) openEdit(asset) }} disabled={isProviderOwned} title={isProviderOwned ? t('assets.syncedReadOnly') : t('common.edit')} className="p-1 rounded text-muted-foreground hover:text-foreground hover:bg-muted transition-colors disabled:opacity-30 disabled:cursor-not-allowed">
<Pencil size={13} />
</button>
- <button onClick={(e) => { e.stopPropagation(); if (!isProviderOwned) setDeletingId(asset.id) }} disabled={isProviderOwned} title={isProviderOwned ? t('assets.syncedReadOnly') : undefined} className="p-1 rounded text-muted-foreground hover:text-rose-600 hover:bg-rose-50 transition-colors disabled:opacity-30 disabled:cursor-not-allowed">
+ <button onClick={(e) => { e.stopPropagation(); if (!isProviderOwned) setDeletingId(asset.id) }} disabled={isProviderOwned} title={isProviderOwned ? t('assets.syncedReadOnly') : t('common.delete')} className="p-1 rounded text-muted-foreground hover:text-rose-600 hover:bg-rose-50 transition-colors disabled:opacity-30 disabled:cursor-not-allowed">
<Trash2 size={13} />
</button>
</>
@@ -2195,6 +2195,7 @@ function AssetDetail({ assetId, currency, locale: loc, dateLocale: dateLoc, purc
onClick={() => deleteValueMutation.mutate(v.id)}
className="p-1 rounded text-muted-foreground/40 hover:text-rose-600 transition-colors"
disabled={deleteValueMutation.isPending}
+ title={t('common.delete')}
>
<Trash2 size={12} />
</button>
@@ -2697,6 +2698,7 @@ function HoldingLedger({
onClick={() => deleteMutation.mutate(tx.id)}
disabled={deleteMutation.isPending}
className="p-1 rounded text-muted-foreground/50 hover:text-rose-600 transition-colors"
+ title={t('common.delete')}
>
<Trash2 size={12} />
</button>
diff --git a/frontend/src/pages/budgets.tsx b/frontend/src/pages/budgets.tsx
index f2490835..cb5c60bb 100644
--- a/frontend/src/pages/budgets.tsx
+++ b/frontend/src/pages/budgets.tsx
@@ -217,6 +217,7 @@ export default function BudgetsPage() {
<button
className="p-1.5 rounded-md text-muted-foreground hover:text-primary hover:bg-primary/5 transition-colors"
onClick={() => { setEditing(budget); setDialogOpen(true) }}
+ title={t('common.edit')}
>
<Pencil size={13} />
</button>
@@ -224,6 +225,7 @@ export default function BudgetsPage() {
className="p-1.5 rounded-md text-muted-foreground hover:text-rose-500 hover:bg-rose-50 transition-colors"
onClick={() => deleteMutation.mutate(budget.id)}
disabled={deleteMutation.isPending}
+ title={t('common.delete')}
>
<Trash2 size={13} />
</button>
diff --git a/frontend/src/pages/goals.tsx b/frontend/src/pages/goals.tsx
index fcdb7fba..7d08f2b4 100644
--- a/frontend/src/pages/goals.tsx
+++ b/frontend/src/pages/goals.tsx
@@ -390,6 +390,7 @@ export default function GoalsPage() {
<button
className="p-1.5 rounded-md text-muted-foreground hover:text-primary hover:bg-primary/5 transition-colors"
onClick={() => openEditDialog(goal)}
+ title={t('common.edit')}
>
<Pencil size={13} />
</button>
@@ -397,6 +398,7 @@ export default function GoalsPage() {
className="p-1.5 rounded-md text-muted-foreground hover:text-rose-500 hover:bg-rose-50 dark:hover:bg-rose-500/10 transition-colors"
onClick={() => deleteMutation.mutate(goal.id)}
disabled={deleteMutation.isPending}
+ title={t('common.delete')}
>
<Trash2 size={13} />
</button>
diff --git a/frontend/src/pages/group-detail.tsx b/frontend/src/pages/group-detail.tsx
index 2521bcb5..e0d7abe6 100644
--- a/frontend/src/pages/group-detail.tsx
+++ b/frontend/src/pages/group-detail.tsx
@@ -952,6 +952,8 @@ export default function GroupDetailPage() {
variant="ghost"
size="sm"
onClick={() => deleteSettlementMutation.mutate(s.id)}
+ title={t('common.delete')}
+ aria-label={t('common.delete')}
>
<Trash2 size={14} />
</Button>
diff --git a/frontend/src/pages/payees.tsx b/frontend/src/pages/payees.tsx
index 8954d8b6..3052dd1f 100644
--- a/frontend/src/pages/payees.tsx
+++ b/frontend/src/pages/payees.tsx
@@ -514,6 +514,7 @@ export default function PayeesPage() {
favoriteMutation.mutate({ id: payee.id, is_favorite: !payee.is_favorite })
}}
className="p-1 rounded hover:bg-accent"
+ title={payee.is_favorite ? t('payees.removeFavorite') : t('payees.addFavorite')}
>
<Star
size={14}
diff --git a/frontend/src/pages/recurring.tsx b/frontend/src/pages/recurring.tsx
index 5ab251ac..b4db6625 100644
--- a/frontend/src/pages/recurring.tsx
+++ b/frontend/src/pages/recurring.tsx
@@ -216,6 +216,7 @@ function RecurringTab() {
<button
className="p-1.5 rounded-md text-muted-foreground hover:text-primary hover:bg-primary/5 transition-colors"
onClick={() => { setEditing(rt); setDialogOpen(true) }}
+ title={t('common.edit')}
>
<Pencil size={13} />
</button>
@@ -223,6 +224,7 @@ function RecurringTab() {
className="p-1.5 rounded-md text-muted-foreground hover:text-rose-500 hover:bg-rose-50 transition-colors"
onClick={() => deleteMutation.mutate(rt.id)}
disabled={deleteMutation.isPending}
+ title={t('common.delete')}
>
<Trash2 size={13} />
</button>
diff --git a/frontend/src/pages/rules.tsx b/frontend/src/pages/rules.tsx
index f146a5bb..9d7a58bb 100644
--- a/frontend/src/pages/rules.tsx
+++ b/frontend/src/pages/rules.tsx
@@ -417,6 +417,7 @@ export default function RulesPage() {
className="p-1.5 rounded-md text-muted-foreground hover:text-rose-500 hover:bg-rose-50 transition-colors"
onClick={(e) => { e.stopPropagation(); deleteMutation.mutate(rule.id) }}
disabled={deleteMutation.isPending}
+ title={t('common.delete')}
>
<Trash2 size={13} />
</button>
diff --git a/frontend/src/pages/setup.tsx b/frontend/src/pages/setup.tsx
index d925459d..926792bf 100644
--- a/frontend/src/pages/setup.tsx
+++ b/frontend/src/pages/setup.tsx
@@ -206,6 +206,7 @@ export default function SetupPage() {
<button
type="button"
onClick={() => setTheme('light')}
+ title={t('settings.themeLight')}
className={cn(
'p-1.5 rounded transition-colors',
theme === 'light'
@@ -218,6 +219,7 @@ export default function SetupPage() {
<button
type="button"
onClick={() => setTheme('dark')}
+ title={t('settings.themeDark')}
className={cn(
'p-1.5 rounded transition-colors',
theme === 'dark'