Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

feat: added bulk delete for payees (#475)

jorishaenseler159526aa0ab80f
diff --git a/backend/app/api/payees.py b/backend/app/api/payees.py
index feb01b34..00c6b629 100644
--- a/backend/app/api/payees.py
+++ b/backend/app/api/payees.py
@@ -11,7 +11,7 @@ from app.core.workspace_context import (
current_workspace,
current_writable_workspace,
)
-from app.schemas.payee import PayeeCreate, PayeeMergeRequest, PayeeRead, PayeeSummary, PayeeUpdate
+from app.schemas.payee import PayeeCreate, PayeeMergeRequest, PayeeRead, PayeeSummary, PayeeUpdate, PayeeBulkDeleteRequest
from app.schemas.category import CategoryRead
from app.services import payee_service
@@ -115,3 +115,13 @@ async def merge_payees(
return {"merged": len(data.source_ids), "transactions_reassigned": reassigned}
except ValueError as e:
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=str(e))
+
+
[email protected]("/bulk-delete", status_code=status.HTTP_200_OK)
+async def bulk_delete_payees(
+ data: PayeeBulkDeleteRequest,
+ ctx: WorkspaceContext = Depends(current_writable_workspace),
+ session: AsyncSession = Depends(get_async_session),
+):
+ deleted_count = await payee_service.bulk_delete_payees(session, ctx.workspace.id, data.ids)
+ return {"deleted": deleted_count}
diff --git a/backend/app/schemas/payee.py b/backend/app/schemas/payee.py
index f285536e..481d62db 100644
--- a/backend/app/schemas/payee.py
+++ b/backend/app/schemas/payee.py
@@ -46,3 +46,7 @@ class PayeeSummary(BaseModel):
class PayeeMergeRequest(BaseModel):
source_ids: list[uuid.UUID]
target_id: uuid.UUID
+
+
+class PayeeBulkDeleteRequest(BaseModel):
+ ids: list[uuid.UUID]
diff --git a/backend/app/services/payee_service.py b/backend/app/services/payee_service.py
index 04e09373..c6c4f665 100644
--- a/backend/app/services/payee_service.py
+++ b/backend/app/services/payee_service.py
@@ -180,6 +180,37 @@ async def delete_payee(session: AsyncSession, payee_id: uuid.UUID, workspace_id:
return True
+async def bulk_delete_payees(session: AsyncSession, workspace_id: uuid.UUID, payee_ids: list[uuid.UUID]) -> int:
+ # Check which payees exist in this workspace first
+ payees_query = await session.execute(
+ select(Payee.id).where(Payee.id.in_(payee_ids), Payee.workspace_id == workspace_id)
+ )
+ valid_ids = [row[0] for row in payees_query.all()]
+
+ if not valid_ids:
+ return 0
+
+ # Null out transaction references
+ await session.execute(
+ update(Transaction)
+ .where(Transaction.payee_id.in_(valid_ids))
+ .values(payee_id=None)
+ )
+
+ # Delete mappings pointing to this payee
+ await session.execute(
+ delete(PayeeMapping).where(PayeeMapping.target_id.in_(valid_ids))
+ )
+
+ # Delete payees
+ result = await session.execute(
+ delete(Payee).where(Payee.id.in_(valid_ids))
+ )
+
+ await session.commit()
+ return result.rowcount
+
+
async def merge_payees(
session: AsyncSession,
workspace_id: uuid.UUID,
diff --git a/backend/tests/test_payee_service.py b/backend/tests/test_payee_service.py
index 5c658a98..f8ac9820 100644
--- a/backend/tests/test_payee_service.py
+++ b/backend/tests/test_payee_service.py
@@ -19,6 +19,7 @@ from app.services.payee_service import (
get_payee_summary,
merge_payees,
update_payee,
+ bulk_delete_payees,
)
@@ -282,6 +283,75 @@ async def test_delete_payee_nulls_transaction_refs(session: AsyncSession, test_u
assert tx.payee_id is None
+async def test_bulk_delete_payees(session: AsyncSession, test_user, test_workspace):
+ p1 = await create_payee(session, test_workspace.id, test_user.id, PayeeCreate(name="Bulk1"))
+ p2 = await create_payee(session, test_workspace.id, test_user.id, PayeeCreate(name="Bulk2"))
+ p3 = await create_payee(session, test_workspace.id, test_user.id, PayeeCreate(name="Bulk3"))
+
+ account = await _make_account(session, test_user)
+
+ tx = Transaction(
+ id=uuid.uuid4(), user_id=test_user.id, account_id=account.id,
+ description="Linked Tx", amount=Decimal("50"), date=date.today(),
+ type="debit", source="manual", payee_id=p1.id,
+ created_at=datetime.now(timezone.utc),
+ )
+ session.add(tx)
+ await session.commit()
+
+ deleted = await bulk_delete_payees(session, test_workspace.id, [p1.id, p2.id])
+ assert deleted == 2
+
+ assert await get_payee(session, p1.id, test_workspace.id) is None
+ assert await get_payee(session, p2.id, test_workspace.id) is None
+ assert await get_payee(session, p3.id, test_workspace.id) is not None
+
+ await session.refresh(tx)
+ assert tx.payee_id is None
+
+
+async def test_bulk_delete_payees_invalid_ids(session: AsyncSession, test_user, test_workspace):
+ deleted = await bulk_delete_payees(session, test_workspace.id, [uuid.uuid4(), uuid.uuid4()])
+ assert deleted == 0
+
+
+async def test_bulk_delete_payees_workspace_isolation(session: AsyncSession, test_user, test_workspace):
+ from app.models.workspace import Workspace
+
+ other_workspace = Workspace(id=uuid.uuid4(), name="Other")
+ session.add(other_workspace)
+ await session.commit()
+
+ p = await create_payee(session, other_workspace.id, test_user.id, PayeeCreate(name="OtherWS"))
+ deleted = await bulk_delete_payees(session, test_workspace.id, [p.id])
+ assert deleted == 0
+
+ assert await get_payee(session, p.id, other_workspace.id) is not None
+
+
+async def test_delete_payee_cleans_up_mappings(session: AsyncSession, test_user, test_workspace):
+ from sqlalchemy import select
+
+ p = await create_payee(session, test_workspace.id, test_user.id, PayeeCreate(name="Mapped"))
+ mapping = PayeeMapping(
+ id=uuid.uuid4(),
+ user_id=test_user.id,
+ workspace_id=test_workspace.id,
+ target_id=p.id,
+ )
+ session.add(mapping)
+ await session.commit()
+
+ await delete_payee(session, p.id, test_workspace.id)
+
+ result = await session.execute(select(PayeeMapping).where(PayeeMapping.target_id == p.id))
+ assert result.scalar_one_or_none() is None
+
+
# ---------------------------------------------------------------------------
# merge_payees
# ---------------------------------------------------------------------------
diff --git a/backend/tests/test_payees_api.py b/backend/tests/test_payees_api.py
index 2909445c..f15d6a9d 100644
--- a/backend/tests/test_payees_api.py
+++ b/backend/tests/test_payees_api.py
@@ -229,6 +229,42 @@ async def test_delete_payee_not_found(client: AsyncClient, auth_headers):
assert resp.status_code == 404
+# ---------------------------------------------------------------------------
+# Bulk Delete
+# ---------------------------------------------------------------------------
+
+
+async def test_bulk_delete_payees(client: AsyncClient, auth_headers):
+ created1 = await _create_payee(client, auth_headers, "BulkDelete1")
+ created2 = await _create_payee(client, auth_headers, "BulkDelete2")
+ created3 = await _create_payee(client, auth_headers, "BulkDelete3")
+
+ resp = await client.post(
+ "/api/payees/bulk-delete", headers=auth_headers,
+ json={"ids": [created1['id'], created2['id']]},
+ )
+ assert resp.status_code == 200
+ assert resp.json()["deleted"] == 2
+
+ # Confirm deleted
+ assert (await client.get(f"/api/payees/{created1['id']}", headers=auth_headers)).status_code == 404
+ assert (await client.get(f"/api/payees/{created2['id']}", headers=auth_headers)).status_code == 404
+
+ # Confirm not deleted
+ assert (await client.get(f"/api/payees/{created3['id']}", headers=auth_headers)).status_code == 200
+
+
+async def test_bulk_delete_payees_empty(client: AsyncClient, auth_headers):
+ resp = await client.post(
+ "/api/payees/bulk-delete", headers=auth_headers,
+ json={"ids": []},
+ )
+ assert resp.status_code == 200
+ assert resp.json()["deleted"] == 0
+
+
# ---------------------------------------------------------------------------
# Merge
# ---------------------------------------------------------------------------
diff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.ts
index 6ae887de..5da2916a 100644
--- a/frontend/src/lib/api.ts
+++ b/frontend/src/lib/api.ts
@@ -692,6 +692,10 @@ export const payees = {
const { data } = await api.post('/payees/merge', { target_id: targetId, source_ids: sourceIds })
return data
},
+ bulkDelete: async (ids: string[]): Promise<{ deleted: number }> => {
+ const { data } = await api.post('/payees/bulk-delete', { ids })
+ return data
+ },
}
// Groups (split transactions)
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index cc4b6701..fc3a1838 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Unternehmen",
"allTypes": "Alle Typen",
"filterByType": "Nach Typ filtern",
- "favoritesOnly": "Nur Favoriten"
+ "favoritesOnly": "Nur Favoriten",
+ "deletedMultiple": "{{count}} Zahlungsempfänger gelöscht",
+ "deleteTitle": "Zahlungsempfänger löschen",
+ "deleteConfirm": "Möchten Sie diesen Zahlungsempfänger wirklich löschen? Dadurch wird der Zahlungsempfänger auch aus allen zugehörigen Transaktionen entfernt.",
+ "deleteMultipleTitle": "Zahlungsempfänger löschen",
+ "deleteMultipleConfirm": "Möchten Sie die {{count}} ausgewählten Zahlungsempfänger wirklich löschen? Dadurch werden sie auch aus allen zugehörigen Transaktionen entfernt."
},
"common": {
"view": "Ansehen",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index a04794e6..5185e48e 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Company",
"allTypes": "All Types",
"filterByType": "Filter by Type",
- "favoritesOnly": "Favorites Only"
+ "favoritesOnly": "Favorites Only",
+ "deleteTitle": "Delete Payee",
+ "deleteConfirm": "Are you sure you want to delete this payee? This will also remove the payee from any associated transactions.",
+ "deleteMultipleTitle": "Delete Payees",
+ "deleteMultipleConfirm": "Are you sure you want to delete the {{count}} selected payees? This will also remove them from any associated transactions.",
+ "deletedMultiple": "{{count}} payees deleted"
},
"common": {
"view": "View",
diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.json
index 1a75e789..210a4336 100644
--- a/frontend/src/locales/es.json
+++ b/frontend/src/locales/es.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Empresa",
"allTypes": "Todos los tipos",
"filterByType": "Filtrar por tipo",
- "favoritesOnly": "Solo favoritos"
+ "favoritesOnly": "Solo favoritos",
+ "deletedMultiple": "{{count}} beneficiarios eliminados",
+ "deleteTitle": "Eliminar beneficiario",
+ "deleteConfirm": "¿Estás seguro de que quieres eliminar este beneficiario? Esto también lo eliminará de cualquier transacción asociada.",
+ "deleteMultipleTitle": "Eliminar beneficiarios",
+ "deleteMultipleConfirm": "¿Estás seguro de que quieres eliminar los {{count}} beneficiarios seleccionados? Esto también los eliminará de cualquier transacción asociada."
},
"common": {
"view": "Ver",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/fr.json b/frontend/src/locales/fr.json
index 28f99caf..cbecf13a 100644
--- a/frontend/src/locales/fr.json
+++ b/frontend/src/locales/fr.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Entreprise",
"allTypes": "Tous les types",
"filterByType": "Filtrer par type",
- "favoritesOnly": "Favoris uniquement"
+ "favoritesOnly": "Favoris uniquement",
+ "deletedMultiple": "{{count}} bénéficiaires supprimés",
+ "deleteTitle": "Supprimer le bénéficiaire",
+ "deleteConfirm": "Êtes-vous sûr de vouloir supprimer ce bénéficiaire ? Cela le supprimera également de toutes les transactions associées.",
+ "deleteMultipleTitle": "Supprimer les bénéficiaires",
+ "deleteMultipleConfirm": "Êtes-vous sûr de vouloir supprimer les {{count}} bénéficiaires sélectionnés ? Cela les supprimera également de toutes les transactions associées."
},
"common": {
"view": "Voir",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.json
index e21b2642..06eeb736 100644
--- a/frontend/src/locales/it.json
+++ b/frontend/src/locales/it.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Azienda",
"allTypes": "Tutti i tipi",
"filterByType": "Filtra per tipo",
- "favoritesOnly": "Solo preferiti"
+ "favoritesOnly": "Solo preferiti",
+ "deletedMultiple": "{{count}} beneficiari eliminati",
+ "deleteTitle": "Elimina beneficiario",
+ "deleteConfirm": "Sei sicuro di voler eliminare questo beneficiario? Questo lo rimuoverà anche da tutte le transazioni associate.",
+ "deleteMultipleTitle": "Elimina beneficiari",
+ "deleteMultipleConfirm": "Sei sicuro di voler eliminare i {{count}} beneficiari selezionati? Questo li rimuoverà anche da tutte le transazioni associate."
},
"common": {
"view": "Visualizza",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.json
index 02447a84..832407f9 100644
--- a/frontend/src/locales/pl.json
+++ b/frontend/src/locales/pl.json
@@ -1309,7 +1309,12 @@
"typeCompany": "Firma",
"allTypes": "Wszystkie typy",
"filterByType": "Filtruj według typu",
- "favoritesOnly": "Tylko ulubione"
+ "favoritesOnly": "Tylko ulubione",
+ "deletedMultiple": "Usunięto {{count}} odbiorców",
+ "deleteTitle": "Usuń odbiorcę",
+ "deleteConfirm": "Czy na pewno chcesz usunąć tego odbiorcę? Usunie to również odbiorcę ze wszystkich powiązanych transakcji.",
+ "deleteMultipleTitle": "Usuń odbiorców",
+ "deleteMultipleConfirm": "Czy na pewno chcesz usunąć {{count}} wybranych odbiorców? Usunie to ich również ze wszystkich powiązanych transakcji."
},
"common": {
"view": "Zobacz",
@@ -1829,4 +1834,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.json
index 19532c98..fc54bf9d 100644
--- a/frontend/src/locales/pt-BR.json
+++ b/frontend/src/locales/pt-BR.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Empresa",
"allTypes": "Todos os tipos",
"filterByType": "Filtrar por tipo",
- "favoritesOnly": "Apenas favoritos"
+ "favoritesOnly": "Apenas favoritos",
+ "deletedMultiple": "{{count}} beneficiários excluídos",
+ "deleteTitle": "Excluir beneficiário",
+ "deleteConfirm": "Tem certeza de que deseja excluir este beneficiário? Isso também o removerá de todas as transações associadas.",
+ "deleteMultipleTitle": "Excluir beneficiários",
+ "deleteMultipleConfirm": "Tem certeza de que deseja excluir os {{count}} beneficiários selecionados? Isso também os removerá de todas as transações associadas."
},
"common": {
"view": "Ver",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/pt-PT.json b/frontend/src/locales/pt-PT.json
index 69deb952..b149c62f 100644
--- a/frontend/src/locales/pt-PT.json
+++ b/frontend/src/locales/pt-PT.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Empresa",
"allTypes": "Todos os tipos",
"filterByType": "Filtrar por tipo",
- "favoritesOnly": "Apenas favoritos"
+ "favoritesOnly": "Apenas favoritos",
+ "deletedMultiple": "{{count}} beneficiários excluídos",
+ "deleteTitle": "Eliminar beneficiário",
+ "deleteConfirm": "Tem a certeza que deseja eliminar este beneficiário? Isto também o irá remover de quaisquer transações associadas.",
+ "deleteMultipleTitle": "Eliminar beneficiários",
+ "deleteMultipleConfirm": "Tem a certeza que deseja eliminar os {{count}} beneficiários selecionados? Isto também os irá remover de quaisquer transações associadas."
},
"common": {
"view": "Ver",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.json
index 3e9cc4e9..4de871e5 100644
--- a/frontend/src/locales/ru.json
+++ b/frontend/src/locales/ru.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Компания",
"allTypes": "Все типы",
"filterByType": "Фильтровать по типу",
- "favoritesOnly": "Только избранные"
+ "favoritesOnly": "Только избранные",
+ "deletedMultiple": "Удалено {{count}} получателей",
+ "deleteTitle": "Удалить получателя",
+ "deleteConfirm": "Вы уверены, что хотите удалить этого получателя? Это также удалит его из всех связанных транзакций.",
+ "deleteMultipleTitle": "Удалить получателей",
+ "deleteMultipleConfirm": "Вы уверены, что хотите удалить {{count}} выбранных получателей? Это также удалит их из всех связанных транзакций."
},
"common": {
"view": "Просмотр",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.json
index c7e0ff73..dbdb2cb5 100644
--- a/frontend/src/locales/uk.json
+++ b/frontend/src/locales/uk.json
@@ -1234,7 +1234,12 @@
"typeCompany": "Компанія",
"allTypes": "Всі типи",
"filterByType": "Фільтрувати за типом",
- "favoritesOnly": "Тільки обрані"
+ "favoritesOnly": "Тільки обрані",
+ "deletedMultiple": "Видалено {{count}} одержувачів",
+ "deleteTitle": "Видалити одержувача",
+ "deleteConfirm": "Ви впевнені, що хочете видалити цього одержувача? Це також видалить його з усіх пов'язаних транзакцій.",
+ "deleteMultipleTitle": "Видалити одержувачів",
+ "deleteMultipleConfirm": "Ви впевнені, що хочете видалити {{count}} вибраних одержувачів? Це також видалить їх з усіх пов'язаних транзакцій."
},
"common": {
"view": "Переглянути",
@@ -1739,4 +1744,4 @@
}
}
}
-}
+}
\ No newline at end of file
diff --git a/frontend/src/pages/payees.tsx b/frontend/src/pages/payees.tsx
index 3052dd1f..87c50405 100644
--- a/frontend/src/pages/payees.tsx
+++ b/frontend/src/pages/payees.tsx
@@ -41,7 +41,7 @@ import {
import { cn } from '@/lib/utils'
import { PageHeader } from '@/components/page-header'
import { calculateRangeSelection } from '@/lib/selection-utils'
-import { Search, Star, Merge, Trash2, ArrowRight, ListFilter, X, Check } from 'lucide-react'
+import { Search, Star, Merge, Trash2, ArrowRight, ListFilter, X, Check, Pencil } from 'lucide-react'
import { usePrivacyMode } from '@/hooks/use-privacy-mode'
import { useAuth } from '@/contexts/auth-context'
import { useWorkspace } from '@/contexts/workspace-context'
@@ -79,6 +79,8 @@ export default function PayeesPage() {
const [mergeTargetId, setMergeTargetId] = useState<string>('')
const [filterType, setFilterType] = useState(() => searchParams.get('type') ?? '')
const [filterFavorites, setFilterFavorites] = useState(() => searchParams.get('is_favorite') === 'true')
+ const [deleteDialogOpen, setDeleteDialogOpen] = useState(false)
+ const [payeesToDelete, setPayeesToDelete] = useState<string[]>([])
const prevSearchRef = useRef<string | null>(null)
// Sync state from URL when navigating
@@ -180,7 +182,10 @@ export default function PayeesPage() {
invalidateFinancialQueries(queryClient)
queryClient.invalidateQueries({ queryKey: ['payees'] })
setDialogOpen(false)
- setEditingPayee(null)
+ setDeleteDialogOpen(false)
+ if (editingPayee?.id === id) {
+ setEditingPayee(null)
+ }
setSelectedIds(prev => {
const next = new Set(prev)
next.delete(id)
@@ -220,6 +225,22 @@ export default function PayeesPage() {
onError: () => toast.error(t('common.error')),
})
+ const bulkDeleteMutation = useMutation({
+ mutationFn: (ids: string[]) => payeesApi.bulkDelete(ids),
+ onSuccess: (result, deletedIds) => {
+ invalidateFinancialQueries(queryClient)
+ queryClient.invalidateQueries({ queryKey: ['payees'] })
+ setDeleteDialogOpen(false)
+ setSelectedIds(new Set())
+ setLastSelectedId(null)
+ if (summaryPayee && deletedIds.includes(summaryPayee)) {
+ setSummaryPayee(null)
+ }
+ toast.success(t('payees.deletedMultiple', { count: result.deleted, defaultValue: `${result.deleted} payees deleted` }))
+ },
+ onError: () => toast.error(t('common.error')),
+ })
+
const openCreate = () => {
setEditingPayee(null)
setFormName('')
@@ -275,10 +296,19 @@ export default function PayeesPage() {
canWrite ? (
<div className="flex items-center gap-2">
{selectedIds.size >= 2 && (
- <Button variant="outline" onClick={() => { setMergeTargetId(''); setMergeDialogOpen(true) }}>
- <Merge size={16} className="mr-1.5" />
- {t('payees.merge')} ({selectedIds.size})
- </Button>
+ <div className="flex items-center gap-2">
+ <Button variant="outline" onClick={() => { setMergeTargetId(''); setMergeDialogOpen(true) }}>
+ <Merge size={16} className="mr-1.5" />
+ {t('payees.merge')} ({selectedIds.size})
+ </Button>
+ <Button variant="destructive" onClick={() => {
+ setPayeesToDelete(Array.from(selectedIds))
+ setDeleteDialogOpen(true)
+ }} disabled={bulkDeleteMutation.isPending}>
+ <Trash2 size={16} className="mr-1.5" />
+ {t('common.delete')} ({selectedIds.size})
+ </Button>
+ </div>
)}
<Button onClick={openCreate}>
+ {t('payees.add')}
@@ -478,7 +508,7 @@ export default function PayeesPage() {
<TableHead className="text-xs font-medium text-muted-foreground py-3">{t('payees.name')}</TableHead>
<TableHead className="hidden md:table-cell text-xs font-medium text-muted-foreground py-3 w-[120px]">{t('payees.type')}</TableHead>
<TableHead className="text-xs font-medium text-muted-foreground py-3 text-right w-[120px]">{t('payees.transactionCount')}</TableHead>
- {canWrite && <TableHead className="w-[60px]" />}
+ {canWrite && <TableHead className="w-[100px]" />}
</TableRow>
</TableHeader>
<TableBody>
@@ -541,14 +571,28 @@ export default function PayeesPage() {
<span className="text-sm tabular-nums text-muted-foreground">{payee.transaction_count}</span>
</TableCell>
{canWrite && (
- <TableCell className="py-2.5 pr-4">
- <Button
- variant="ghost"
- size="sm"
- onClick={(e) => { e.stopPropagation(); openEdit(payee) }}
- >
- {t('common.edit')}
- </Button>
+ <TableCell className="py-2.5 pr-4 sm:pr-5">
+ <div className="flex items-center justify-end gap-1">
+ <button
+ className="p-1.5 rounded-md text-muted-foreground hover:text-primary hover:bg-primary/5 transition-colors"
+ onClick={(e) => { e.stopPropagation(); openEdit(payee) }}
+ title={t('common.edit')}
+ >
+ <Pencil size={13} />
+ </button>
+ <button
+ className="p-1.5 rounded-md text-muted-foreground hover:text-rose-500 hover:bg-rose-50 transition-colors"
+ onClick={(e) => {
+ e.stopPropagation();
+ setPayeesToDelete([payee.id])
+ setDeleteDialogOpen(true)
+ }}
+ disabled={deleteMutation.isPending || bulkDeleteMutation.isPending}
+ title={t('common.delete')}
+ >
+ <Trash2 size={13} />
+ </button>
+ </div>
</TableCell>
)}
</TableRow>
@@ -754,6 +798,41 @@ export default function PayeesPage() {
</DialogFooter>
</DialogContent>
</Dialog>
+
+ {/* Delete Confirmation Dialog */}
+ <Dialog open={deleteDialogOpen} onOpenChange={setDeleteDialogOpen}>
+ <DialogContent className="sm:max-w-md">
+ <DialogHeader>
+ <DialogTitle>
+ {payeesToDelete.length > 1 ? t('payees.deleteMultipleTitle') : t('payees.deleteTitle')}
+ </DialogTitle>
+ </DialogHeader>
+ <div className="space-y-4">
+ <p className="text-sm text-muted-foreground">
+ {payeesToDelete.length > 1 ? t('payees.deleteMultipleConfirm', { count: payeesToDelete.length }) : t('payees.deleteConfirm')}
+ </p>
+ </div>
+ <DialogFooter>
+ <Button variant="outline" onClick={() => setDeleteDialogOpen(false)}>
+ {t('common.cancel')}
+ </Button>
+ <Button
+ variant="destructive"
+ disabled={deleteMutation.isPending || bulkDeleteMutation.isPending}
+ onClick={() => {
+ if (payeesToDelete.length === 1) {
+ deleteMutation.mutate(payeesToDelete[0])
+ } else if (payeesToDelete.length > 1) {
+ bulkDeleteMutation.mutate(payeesToDelete)
+ }
+ }}
+ >
+ <Trash2 size={14} className="mr-1" />
+ {t('common.delete')}
+ </Button>
+ </DialogFooter>
+ </DialogContent>
+ </Dialog>
</div>
)
}