Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

Fix SimpleFIN stale access URL reconnect flow (#396)

Romulo Gatto9840da42c9ce
diff --git a/backend/app/api/connections.py b/backend/app/api/connections.py
index 7d74d400..778fc1be 100644
--- a/backend/app/api/connections.py
+++ b/backend/app/api/connections.py
@@ -107,6 +107,7 @@ async def oauth_callback(
provider_name=data.provider,
state=data.state,
sync_assets=data.sync_assets,
+ reconnect_connection_id=data.reconnect_connection_id,
)
return connection
except ProviderUserActionRequired as e:
@@ -176,6 +177,17 @@ async def sync_connection(
return {**result.model_dump(mode="json"), "merged_count": merged_count}
except ValueError as e:
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))
+ except ProviderUserActionRequired as e:
+ raise HTTPException(
+ status_code=status.HTTP_409_CONFLICT,
+ detail={
+ "message": str(e),
+ "code": e.code,
+ "help_url": e.help_url,
+ },
+ )
+ except SessionExpiredError as e:
+ raise HTTPException(status_code=status.HTTP_410_GONE, detail=str(e))
except Exception as e:
raise HTTPException(
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
diff --git a/backend/app/schemas/bank_connection.py b/backend/app/schemas/bank_connection.py
index 08a79020..d081c3fa 100644
--- a/backend/app/schemas/bank_connection.py
+++ b/backend/app/schemas/bank_connection.py
@@ -38,6 +38,7 @@ class OAuthCallbackRequest(BaseModel):
state: Optional[str] = None
provider: Optional[str] = None
sync_assets: Optional[bool] = None
+ reconnect_connection_id: Optional[uuid.UUID] = None
class ReauthUrlResponse(BaseModel):
diff --git a/backend/app/services/connection_service.py b/backend/app/services/connection_service.py
index d438fd13..07fbecb6 100644
--- a/backend/app/services/connection_service.py
+++ b/backend/app/services/connection_service.py
@@ -501,6 +501,7 @@ async def handle_oauth_callback(
provider_name: Optional[str] = None,
state: Optional[str] = None,
sync_assets: Optional[bool] = None,
+ reconnect_connection_id: Optional[uuid.UUID] = None,
) -> BankConnection:
state_payload: dict = {}
if state:
@@ -514,29 +515,38 @@ async def handle_oauth_callback(
raise ValueError("OAuth state workspace does not match active workspace")
state_payload = consumed
provider_name = consumed.get("provider") or provider_name
+ reconnect_id = state_payload.get("reconnect_connection_id") or reconnect_connection_id
+ existing_reconnect: BankConnection | None = None
+ if reconnect_id:
+ existing_reconnect = await session.get(BankConnection, uuid.UUID(str(reconnect_id)))
+ if not existing_reconnect or existing_reconnect.workspace_id != workspace_id:
+ raise ValueError("Reconnect target connection not found")
+ # Token reconnects do not carry OAuth state, so the request body may be
+ # the only source of provider_name. Never allow a pasted token for one
+ # provider to overwrite another provider's stored credentials.
+ if provider_name and provider_name != existing_reconnect.provider:
+ raise ValueError("Reconnect provider does not match target connection")
+ provider_name = existing_reconnect.provider
+
if not provider_name:
raise ValueError("OAuth callback missing provider")
provider = get_provider(provider_name)
connection_data = await provider.handle_oauth_callback(code)
- reconnect_id = state_payload.get("reconnect_connection_id")
- if reconnect_id:
- existing = await session.get(BankConnection, uuid.UUID(reconnect_id))
- if not existing or existing.workspace_id != workspace_id:
- raise ValueError("Reconnect target connection not found")
- existing.external_id = connection_data.external_id
- existing.institution_name = (
- connection_data.institution_name or existing.institution_name
+ if existing_reconnect:
+ existing_reconnect.external_id = connection_data.external_id
+ existing_reconnect.institution_name = (
+ connection_data.institution_name or existing_reconnect.institution_name
)
- existing.logo_url = _clean_logo_url(connection_data.logo_url) or existing.logo_url
- existing.credentials = connection_data.credentials
- existing.status = "active"
+ existing_reconnect.logo_url = _clean_logo_url(connection_data.logo_url) or existing_reconnect.logo_url
+ existing_reconnect.credentials = connection_data.credentials
+ existing_reconnect.status = "active"
# Re-sync from current data on next sync cycle.
- existing.last_sync_at = None
+ existing_reconnect.last_sync_at = None
await session.commit()
- await session.refresh(existing)
- return existing
+ await session.refresh(existing_reconnect)
+ return existing_reconnect
flow_params = dict(state_payload.get("flow_params") or {})
flow_sync_assets = flow_params.pop("sync_assets", None)
@@ -1470,10 +1480,15 @@ async def sync_connection(
conn.status = "expired"
raise
except ProviderUserActionRequired:
- # User must act in the provider's portal (e.g. EB restricted-mode
- # account linking). Don't mark the connection errored — propagate
- # so the API layer can surface the specific code to the UI.
+ # Stale/revoked provider credentials require a non-destructive
+ # reconnect path. Mark the connection unhealthy so the accounts page
+ # shows the reconnect banner, then let the API return a typed 409
+ # instead of a generic 500.
await session.rollback()
+ async with session.begin():
+ conn = await session.get(BankConnection, connection_id)
+ if conn:
+ conn.status = "error"
raise
except ProviderRateLimited:
# The bank/aggregator is throttling data requests (PSD2 caps unattended
diff --git a/backend/tests/test_connection_service.py b/backend/tests/test_connection_service.py
index b2d9fc92..dae6b201 100644
--- a/backend/tests/test_connection_service.py
+++ b/backend/tests/test_connection_service.py
@@ -7,6 +7,7 @@ import pytest
from sqlalchemy import select
from sqlalchemy.ext.asyncio import AsyncSession
+from app.models.account import Account
from app.models.asset import Asset
from app.models.bank_connection import BankConnection
from app.models.category import Category
@@ -17,6 +18,7 @@ from app.providers.base import (
ConnectionData,
ConnectTokenData,
HoldingData,
+ ProviderUserActionRequired,
TransactionData,
)
from app.services.connection_service import (
@@ -352,6 +354,81 @@ async def test_oauth_callback_respects_state_asset_sync_opt_out(
mock_provider.get_holdings.assert_not_awaited()
+async def test_token_reconnect_updates_existing_connection_without_deleting_accounts(
+ session: AsyncSession, test_user, test_workspace
+):
+ """SimpleFIN token reconnect refreshes credentials in place."""
+ existing = await _make_connection(session, test_user.id, "Old SimpleFIN")
+ existing.provider = "simplefin"
+ existing.external_id = "old-simplefin-conn"
+ existing.credentials = {"access_url_enc": "old-encrypted-url"}
+ existing.status = "error"
+ existing.last_sync_at = datetime.now(timezone.utc)
+ account = Account(
+ id=uuid.uuid4(),
+ user_id=test_user.id,
+ connection_id=existing.id,
+ external_id="existing-account",
+ name="Checking",
+ type="checking",
+ balance=Decimal("10.00"),
+ currency="USD",
+ )
+ session.add(account)
+ await session.commit()
+
+ mock_provider = AsyncMock()
+ mock_provider.handle_oauth_callback = AsyncMock(return_value=ConnectionData(
+ external_id="new-simplefin-conn",
+ institution_name="New SimpleFIN Bank",
+ credentials={"access_url_enc": "new-encrypted-url"},
+ accounts=[],
+ ))
+
+ with patch("app.services.connection_service.get_provider", return_value=mock_provider):
+ reconnected = await handle_oauth_callback(
+ session,
+ test_workspace.id,
+ test_user.id,
+ "fresh-setup-token",
+ provider_name="simplefin",
+ reconnect_connection_id=existing.id,
+ )
+
+ assert reconnected.id == existing.id
+ assert reconnected.external_id == "new-simplefin-conn"
+ assert reconnected.institution_name == "New SimpleFIN Bank"
+ assert reconnected.credentials == {"access_url_enc": "new-encrypted-url"}
+ assert reconnected.status == "active"
+ assert reconnected.last_sync_at is None
+ remaining_accounts = (
+ await session.execute(select(Account).where(Account.connection_id == existing.id))
+ ).scalars().all()
+ assert [a.external_id for a in remaining_accounts] == ["existing-account"]
+ mock_provider.handle_oauth_callback.assert_awaited_once_with("fresh-setup-token")
+
+
+async def test_token_reconnect_rejects_provider_mismatch(
+ session: AsyncSession, test_user, test_workspace
+):
+ existing = await _make_connection(session, test_user.id, "SimpleFIN")
+ existing.provider = "simplefin"
+ existing.status = "error"
+ await session.commit()
+
+ with pytest.raises(ValueError, match="provider does not match"):
+ await handle_oauth_callback(
+ session,
+ test_workspace.id,
+ test_user.id,
+ "fresh-setup-token",
+ provider_name="pluggy",
+ reconnect_connection_id=existing.id,
+ )
+
+
@pytest.mark.asyncio
async def test_update_settings_ignores_none(session: AsyncSession, test_user, test_workspace):
"""None values in settings_update are not written."""
@@ -675,6 +752,29 @@ async def test_sync_connection_error_raises(session: AsyncSession, test_user, te
await sync_connection(session, conn.id, test_workspace.id, test_user.id)
+async def test_sync_connection_user_action_marks_error(
+ session: AsyncSession, test_user, test_workspace
+):
+ conn = await _make_connection(session, test_user.id, "SimpleFIN Auth Error")
+ mock_provider = AsyncMock()
+ mock_provider.refresh_credentials = AsyncMock(return_value={"access_url_enc": "stale"})
+ mock_provider.get_accounts = AsyncMock(
+ side_effect=ProviderUserActionRequired(
+ "SimpleFIN refused the request (403)",
+ code="credentials_invalid",
+ help_url="https://bridge.simplefin.org/",
+ )
+ )
+
+ with patch("app.services.connection_service.get_provider", return_value=mock_provider):
+ with pytest.raises(ProviderUserActionRequired):
+ await sync_connection(session, conn.id, test_workspace.id, test_user.id)
+
+ refreshed = await session.get(BankConnection, conn.id)
+ assert refreshed.status == "error"
+
+
@pytest.mark.asyncio
async def test_sync_connection_skips_pending(session: AsyncSession, test_user, test_workspace):
conn = await _make_connection(
diff --git a/backend/tests/test_connection_service_coverage.py b/backend/tests/test_connection_service_coverage.py
index 1c502e0f..13cc4185 100644
--- a/backend/tests/test_connection_service_coverage.py
+++ b/backend/tests/test_connection_service_coverage.py
@@ -334,7 +334,7 @@ async def test_sync_session_expired_marks_expired(session: AsyncSession, test_us
@pytest.mark.asyncio
-async def test_sync_user_action_required_propagates_without_error_status(
+async def test_sync_user_action_required_marks_error_status(
session: AsyncSession, test_user, test_workspace,
):
conn = await _make_connection(session, test_user.id, "ActionBank")
@@ -348,11 +348,11 @@ async def test_sync_user_action_required_propagates_without_error_status(
with pytest.raises(ProviderUserActionRequired):
await sync_connection(session, conn_id, test_workspace.id, test_user.id)
- # Connection status NOT flipped to error for this case.
+ # User-action failures are visible in the UI via the reconnect banner.
refreshed = (await session.execute(
select(BankConnection).where(BankConnection.id == conn_id)
)).scalar_one()
- assert refreshed.status == "active"
+ assert refreshed.status == "error"
# ---------------------------------------------------------------------------
diff --git a/backend/tests/test_connections_api.py b/backend/tests/test_connections_api.py
index b475c2d9..d1465f07 100644
--- a/backend/tests/test_connections_api.py
+++ b/backend/tests/test_connections_api.py
@@ -8,6 +8,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.models.bank_connection import BankConnection
from app.models.user import User
+from app.providers.base import ProviderUserActionRequired, SessionExpiredError
@pytest.mark.asyncio
@@ -176,6 +177,48 @@ async def test_oauth_callback_success(client: AsyncClient, auth_headers):
assert resp.json()["institution_name"] == "Test Bank"
+async def test_oauth_callback_token_reconnect_updates_existing(
+ client: AsyncClient, auth_headers, session: AsyncSession, test_user: User
+):
+ conn = BankConnection(
+ id=uuid.uuid4(), user_id=test_user.id, provider="simplefin",
+ external_id="old-simplefin", institution_name="Old SimpleFIN",
+ credentials={"access_url_enc": "old"}, status="error",
+ last_sync_at=datetime.now(timezone.utc),
+ created_at=datetime.now(timezone.utc),
+ )
+ session.add(conn)
+ await session.commit()
+
+ conn_data = MagicMock()
+ conn_data.external_id = "new-simplefin"
+ conn_data.institution_name = "New SimpleFIN"
+ conn_data.logo_url = None
+ conn_data.credentials = {"access_url_enc": "new"}
+ conn_data.accounts = []
+
+ with patch("app.services.connection_service.get_provider") as mock_gp:
+ mock_gp.return_value.handle_oauth_callback = AsyncMock(return_value=conn_data)
+ resp = await client.post(
+ "/api/connections/oauth/callback",
+ json={
+ "code": "fresh-simplefin-setup-token",
+ "provider": "simplefin",
+ "reconnect_connection_id": str(conn.id),
+ },
+ headers=auth_headers,
+ )
+
+ assert resp.status_code == 200
+ body = resp.json()
+ assert body["id"] == str(conn.id)
+ assert body["external_id"] == "new-simplefin"
+ assert body["status"] == "active"
+ await session.refresh(conn)
+ assert conn.credentials == {"access_url_enc": "new"}
+
+
@pytest.mark.asyncio
async def test_oauth_callback_failure(client: AsyncClient, auth_headers):
with patch("app.services.connection_service.get_provider") as mock_gp:
@@ -198,6 +241,42 @@ async def test_sync_connection_not_found(client: AsyncClient, auth_headers):
assert resp.status_code == 404
+async def test_sync_connection_user_action_returns_conflict(
+ client: AsyncClient, auth_headers
+):
+ with patch("app.services.connection_service.sync_connection") as mock_sync:
+ mock_sync.side_effect = ProviderUserActionRequired(
+ "SimpleFIN refused the request (403)",
+ code="credentials_invalid",
+ help_url="https://bridge.simplefin.org/",
+ )
+ resp = await client.post(
+ f"/api/connections/{uuid.uuid4()}/sync", headers=auth_headers,
+ )
+
+ assert resp.status_code == 409
+ assert resp.json()["detail"] == {
+ "message": "SimpleFIN refused the request (403)",
+ "code": "credentials_invalid",
+ "help_url": "https://bridge.simplefin.org/",
+ }
+
+
+async def test_sync_connection_session_expired_returns_gone(
+ client: AsyncClient, auth_headers
+):
+ with patch("app.services.connection_service.sync_connection") as mock_sync:
+ mock_sync.side_effect = SessionExpiredError("SimpleFIN access URL is missing")
+ resp = await client.post(
+ f"/api/connections/{uuid.uuid4()}/sync", headers=auth_headers,
+ )
+
+ assert resp.status_code == 410
+ assert resp.json()["detail"] == "SimpleFIN access URL is missing"
+
+
@pytest.mark.asyncio
async def test_reconnect_token_not_found(client: AsyncClient, auth_headers):
resp = await client.post(
diff --git a/docs/pr-332-simplefin-reconnect/simplefin-reconnect-action.png b/docs/pr-332-simplefin-reconnect/simplefin-reconnect-action.png
new file mode 100644
index 00000000..4b00bc36
Binary files /dev/null and b/docs/pr-332-simplefin-reconnect/simplefin-reconnect-action.png differ
diff --git a/docs/pr-332-simplefin-reconnect/simplefin-token-reconnect-dialog.png b/docs/pr-332-simplefin-reconnect/simplefin-token-reconnect-dialog.png
new file mode 100644
index 00000000..a201baed
Binary files /dev/null and b/docs/pr-332-simplefin-reconnect/simplefin-token-reconnect-dialog.png differ
diff --git a/frontend/src/components/token-connect-dialog.tsx b/frontend/src/components/token-connect-dialog.tsx
index d8a27ce5..e3e23be3 100644
--- a/frontend/src/components/token-connect-dialog.tsx
+++ b/frontend/src/components/token-connect-dialog.tsx
@@ -20,13 +20,20 @@ interface TokenConnectDialogProps {
onClose: () => void
provider: string
supportsAssetSync?: boolean
+ reconnectConnectionId?: string
}
const PROVIDER_BRIDGE_URLS: Record<string, string> = {
simplefin: 'https://bridge.simplefin.org/simplefin/create',
}
-export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync = false }: TokenConnectDialogProps) {
+export function TokenConnectDialog({
+ open,
+ onClose,
+ provider,
+ supportsAssetSync = false,
+ reconnectConnectionId,
+}: TokenConnectDialogProps) {
const { t } = useTranslation()
const queryClient = useQueryClient()
const [token, setToken] = useState('')
@@ -43,6 +50,7 @@ export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync
const bridgeUrl = PROVIDER_BRIDGE_URLS[provider]
const i18nKey = `accounts.tokenConnect.${provider}`
+ const isReconnect = Boolean(reconnectConnectionId)
const handleSubmit = async () => {
if (!token.trim()) return
@@ -52,11 +60,12 @@ export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync
token.trim(),
provider,
undefined,
- supportsAssetSync ? { sync_assets: syncAssets } : undefined,
+ supportsAssetSync && !isReconnect ? { sync_assets: syncAssets } : undefined,
+ reconnectConnectionId,
)
invalidateFinancialQueries(queryClient)
queryClient.invalidateQueries({ queryKey: ['connections'] })
- toast.success(t('accounts.connected'))
+ toast.success(t(isReconnect ? 'accounts.reconnected' : 'accounts.connected'))
onClose()
} catch (err) {
const detail =
@@ -75,9 +84,15 @@ export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync
<Dialog open={open} onOpenChange={(v) => !v && !submitting && onClose()}>
<DialogContent className="sm:max-w-md">
<DialogHeader>
- <DialogTitle>{t(`${i18nKey}.title`, t('accounts.tokenConnect.defaultTitle'))}</DialogTitle>
+ <DialogTitle>
+ {isReconnect
+ ? t(`${i18nKey}.reconnectTitle`, t('accounts.tokenConnect.reconnectTitle'))
+ : t(`${i18nKey}.title`, t('accounts.tokenConnect.defaultTitle'))}
+ </DialogTitle>
<p className="text-sm text-muted-foreground">
- {t(`${i18nKey}.description`, t('accounts.tokenConnect.defaultDescription'))}
+ {isReconnect
+ ? t(`${i18nKey}.reconnectDescription`, t('accounts.tokenConnect.reconnectDescription'))
+ : t(`${i18nKey}.description`, t('accounts.tokenConnect.defaultDescription'))}
</p>
</DialogHeader>
@@ -90,7 +105,7 @@ export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync
</Button>
)}
- {supportsAssetSync && (
+ {supportsAssetSync && !isReconnect && (
<div className="flex items-start justify-between gap-4 rounded-lg border border-border p-3">
<div className="space-y-1">
<label htmlFor="token-sync-assets" className="text-sm font-medium text-foreground">
@@ -135,7 +150,7 @@ export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync
<Button onClick={handleSubmit} disabled={!token.trim() || submitting}>
{submitting
? t('accounts.tokenConnect.connecting')
- : t('accounts.tokenConnect.connect')}
+ : t(isReconnect ? 'accounts.tokenConnect.reconnect' : 'accounts.tokenConnect.connect')}
</Button>
</DialogFooter>
</DialogContent>
diff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.ts
index e28a7c33..12cb0277 100644
--- a/frontend/src/lib/api.ts
+++ b/frontend/src/lib/api.ts
@@ -332,11 +332,13 @@ export const connections = {
provider: string,
state?: string,
settings?: Pick<ConnectionSettings, 'sync_assets'>,
+ reconnectConnectionId?: string,
): Promise<BankConnection> => {
const { data } = await api.post('/connections/oauth/callback', {
code,
provider,
state,
+ reconnect_connection_id: reconnectConnectionId,
...settings,
})
return data
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index 22e8c3fa..db899b1d 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Verbindung über SimpleFIN",
"description": "SimpleFIN is a read-only bank data protocol. Go to the SimpleFIN Bridge, pick your bank, and copy the setup token back here."
- }
+ },
+ "reconnectTitle": "Mit einem neuen Token erneut verbinden",
+ "reconnectDescription": "Füge ein neues Setup-Token ein, um diese Verbindung direkt zu aktualisieren. Bestehende Konten, Transaktionen, Kategorien und Regeln bleiben erhalten.",
+ "reconnect": "Erneut verbinden"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "US-amerikanische und internationale Banken via SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Bank erfolgreich erneut verbunden"
},
"connections": {
"settings": "Verbindungseinstellungen",
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index dc1684b8..9aa5f0b0 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Connect via SimpleFIN",
"description": "SimpleFIN is a read-only bank data protocol. Go to the SimpleFIN Bridge, pick your bank, and copy the setup token back here."
- }
+ },
+ "reconnectTitle": "Reconnect with a fresh token",
+ "reconnectDescription": "Paste a new setup token to refresh this connection in place. Existing accounts, transactions, categories, and rules are preserved.",
+ "reconnect": "Reconnect"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "US and international banks via SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Bank reconnected successfully"
},
"connections": {
"settings": "Connection settings",
diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.json
index af1b22d8..37648525 100644
--- a/frontend/src/locales/es.json
+++ b/frontend/src/locales/es.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Conectar vía SimpleFIN",
"description": "SimpleFIN es un protocolo de datos bancarios de solo lectura. Ve al SimpleFIN Bridge, elige tu banco y copia el token de configuración aquí."
- }
+ },
+ "reconnectTitle": "Reconectar con un token nuevo",
+ "reconnectDescription": "Pega un token de configuración nuevo para actualizar esta conexión sin reemplazarla. Se conservan cuentas, transacciones, categorías y reglas existentes.",
+ "reconnect": "Reconectar"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "Bancos de EE. UU. e internacionales vía SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Banco reconectado correctamente"
},
"connections": {
"settings": "Configuración de la conexión",
diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.json
index 32ac04c5..e5628352 100644
--- a/frontend/src/locales/it.json
+++ b/frontend/src/locales/it.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Collega tramite SimpleFIN",
"description": "SimpleFIN è un protocollo di dati bancari in sola lettura. Vai su SimpleFIN Bridge, scegli la tua banca e copia qui il token di configurazione."
- }
+ },
+ "reconnectTitle": "Riconnetti con un nuovo token",
+ "reconnectDescription": "Incolla un nuovo token di configurazione per aggiornare questa connessione senza sostituirla. Account, transazioni, categorie e regole esistenti vengono conservati.",
+ "reconnect": "Riconnetti"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "Banche statunitensi e internazionali tramite SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Banca riconnessa correttamente"
},
"connections": {
"settings": "Impostazioni connessione",
diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.json
index 644558a6..c90964ec 100644
--- a/frontend/src/locales/pl.json
+++ b/frontend/src/locales/pl.json
@@ -642,7 +642,10 @@
"simplefin": {
"title": "Połącz przez SimpleFIN",
"description": "SimpleFIN to protokół danych bankowych tylko do odczytu. Przejdź do SimpleFIN Bridge, wybierz swój bank i skopiuj token konfiguracyjny tutaj."
- }
+ },
+ "reconnectTitle": "Połącz ponownie za pomocą nowego tokenu",
+ "reconnectDescription": "Wklej nowy token konfiguracji, aby odświeżyć to połączenie bez jego usuwania. Istniejące konta, transakcje, kategorie i reguły zostaną zachowane.",
+ "reconnect": "Połącz ponownie"
},
"providers": {
"pluggy": {
@@ -654,7 +657,8 @@
"simplefin": {
"description": "Banki w USA i międzynarodowe przez SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Bank połączony ponownie"
},
"connections": {
"settings": "Ustawienia połączenia",
diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.json
index 50af277a..62de0f3b 100644
--- a/frontend/src/locales/pt-BR.json
+++ b/frontend/src/locales/pt-BR.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Conectar via SimpleFIN",
"description": "O SimpleFIN é um protocolo de leitura de dados bancários. Vá ao SimpleFIN Bridge, escolha o seu banco e copie o token de configuração aqui."
- }
+ },
+ "reconnectTitle": "Reconectar com um novo token",
+ "reconnectDescription": "Cole um novo token de configuração para atualizar esta conexão no lugar. Contas, transações, categorias e regras existentes são preservadas.",
+ "reconnect": "Reconectar"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "Bancos dos EUA e internacionais via SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Banco reconectado com sucesso"
},
"connections": {
"settings": "Configurações da conexão",
diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.json
index 8a9e10d6..012ee962 100644
--- a/frontend/src/locales/ru.json
+++ b/frontend/src/locales/ru.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Подключение через SimpleFIN",
"description": "SimpleFIN — это протокол банковских данных только для чтения. Перейдите в SimpleFIN Bridge, выберите свой банк и скопируйте установочный токен сюда."
- }
+ },
+ "reconnectTitle": "Переподключить с новым токеном",
+ "reconnectDescription": "Вставьте новый setup-токен, чтобы обновить это подключение на месте. Существующие счета, транзакции, категории и правила сохранятся.",
+ "reconnect": "Переподключить"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "Банки США и других стран через SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Банк успешно переподключён"
},
"connections": {
"settings": "Настройки подключения",
diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.json
index 799b0361..fd62076f 100644
--- a/frontend/src/locales/uk.json
+++ b/frontend/src/locales/uk.json
@@ -606,7 +606,10 @@
"simplefin": {
"title": "Підключення через SimpleFIN",
"description": "SimpleFIN — це протокол банківських даних лише для читання. Перейдіть до SimpleFIN Bridge, оберіть свій банк і скопіюйте установчий токен сюди."
- }
+ },
+ "reconnectTitle": "Перепідключити з новим токеном",
+ "reconnectDescription": "Вставте новий setup-токен, щоб оновити це підключення на місці. Наявні рахунки, транзакції, категорії та правила буде збережено.",
+ "reconnect": "Перепідключити"
},
"providers": {
"pluggy": {
@@ -618,7 +621,8 @@
"simplefin": {
"description": "Банки США та інших країн через SimpleFIN Bridge"
}
- }
+ },
+ "reconnected": "Банк успішно перепідключено"
},
"connections": {
"settings": "Налаштування підключення",
diff --git a/frontend/src/pages/accounts.tsx b/frontend/src/pages/accounts.tsx
index 0287428d..77d86eca 100644
--- a/frontend/src/pages/accounts.tsx
+++ b/frontend/src/pages/accounts.tsx
@@ -5,6 +5,7 @@ import { Link, useNavigate } from 'react-router-dom'
import { useTranslation } from 'react-i18next'
import { useDisplayLocale, useDateLocale } from '@/hooks/use-display-locale'
import { useQuery, useMutation, useQueryClient } from '@tanstack/react-query'
+import axios from 'axios'
import { accounts, connections, currencies } from '@/lib/api'
import { invalidateFinancialQueries } from '@/lib/invalidate-queries'
import { toast } from 'sonner'
@@ -26,6 +27,7 @@ import {
Pencil,
Trash2,
RefreshCw,
+ TriangleAlert,
Unlink,
Plus,
Settings,
@@ -86,6 +88,7 @@ export default function AccountsPage() {
const [closingAccountId, setClosingAccountId] = useState<string | null>(null)
const [reconnectConnId, setReconnectConnId] = useState<string | null>(null)
const [reconnectItemId, setReconnectItemId] = useState<string | null>(null)
+ const [tokenReconnectConnection, setTokenReconnectConnection] = useState<BankConnection | null>(null)
const { data: accountsList, isLoading: accountsLoading } = useQuery({
queryKey: ['accounts'],
@@ -121,6 +124,10 @@ export default function AccountsPage() {
}
return
}
+ if (providerInfo?.flow_type === 'token') {
+ setTokenReconnectConnection(conn)
+ return
+ }
// Widget flow (Pluggy): re-open the widget with the existing item_id.
setReconnectConnId(conn.id)
setReconnectItemId(conn.external_id)
@@ -143,7 +150,14 @@ export default function AccountsPage() {
toast.info(t('accounts.mergedCount', { count: merged }))
}
},
- onError: () => toast.error(t('accounts.syncError')),
+ onError: (err) => {
+ queryClient.invalidateQueries({ queryKey: ['connections'] })
+ const detail = axios.isAxiosError(err)
+ ? err.response?.data?.detail
+ : null
+ const message = typeof detail === 'string' ? detail : detail?.message
+ toast.error(message || t('accounts.syncError'))
+ },
})
const disconnectMutation = useMutation({
@@ -335,6 +349,8 @@ export default function AccountsPage() {
<div className="space-y-3">
{connectionsList.map((conn) => {
const connAccounts = bankAccounts.filter((a) => a.connection_id === conn.id)
+ const needsReconnect = conn.status !== 'active'
+ const syncPending = syncMutation.isPending && syncMutation.variables === conn.id
return (
<div key={conn.id} className="bg-card rounded-xl border border-border shadow-sm">
{/* Connection header */}
@@ -346,7 +362,11 @@ export default function AccountsPage() {
<p className="text-sm font-semibold text-foreground">{getConnectionName(conn)}</p>
<Badge
variant={conn.status === 'active' ? 'default' : 'secondary'}
- className="text-[10px] px-1.5 py-0 h-4"
+ className={
+ conn.status === 'active'
+ ? 'text-[10px] px-1.5 py-0 h-4'
+ : 'text-[10px] px-1.5 py-0 h-4 border border-amber-500/30 bg-amber-500/10 text-amber-700 dark:text-amber-300'
+ }
>
{conn.status}
</Badge>
@@ -371,11 +391,25 @@ export default function AccountsPage() {
<Button
variant="ghost"
size="sm"
- className="h-8 w-8 p-0 text-muted-foreground hover:text-foreground"
- onClick={() => syncMutation.mutate(conn.id)}
- disabled={syncMutation.isPending && syncMutation.variables === conn.id}
+ className={needsReconnect
+ ? 'relative h-8 w-8 p-0 text-amber-500 hover:bg-amber-500/10 hover:text-amber-600 dark:text-amber-400 dark:hover:text-amber-300'
+ : 'h-8 w-8 p-0 text-muted-foreground hover:text-foreground'}
+ onClick={() => needsReconnect ? handleReconnectClick(conn) : syncMutation.mutate(conn.id)}
+ disabled={syncPending}
+ title={needsReconnect
+ ? conn.status === 'expired'
+ ? t('accounts.connectionExpired')
+ : t('accounts.connectionError')
+ : t('accounts.sync')}
+ aria-label={needsReconnect ? t('accounts.reconnect') : t('accounts.sync')}
>
- <RefreshCw size={14} className={syncMutation.isPending && syncMutation.variables === conn.id ? 'animate-spin' : ''} />
+ <RefreshCw size={14} className={syncPending ? 'animate-spin' : ''} />
+ {needsReconnect && (
+ <TriangleAlert
+ size={10}
+ className="absolute -right-0.5 -top-0.5 rounded-full bg-card text-amber-500"
+ />
+ )}
</Button>
<Button
variant="ghost"
@@ -389,27 +423,6 @@ export default function AccountsPage() {
</div>
)}
</div>
- {/* Reconnect banner */}
- {conn.status !== 'active' && (
- <div className="mx-5 mt-3 flex items-center justify-between rounded-lg border border-amber-200 bg-amber-50 px-4 py-2.5">
- <span className="text-sm text-amber-800">
- {conn.status === 'expired'
- ? t('accounts.connectionExpired')
- : t('accounts.connectionError')}
- </span>
- {canWrite && (
- <Button
- variant="outline"
- size="sm"
- className="border-amber-300 text-amber-700 hover:bg-amber-100 gap-1.5 h-8"
- onClick={() => handleReconnectClick(conn)}
- >
- <RefreshCw size={12} />
- {t('accounts.reconnect')}
- </Button>
- )}
- </div>
- )}
{/* Accounts list */}
{connAccounts.length > 0 ? (
<div className="divide-y divide-muted">
@@ -632,7 +645,7 @@ export default function AccountsPage() {
supportsAssetSync={selectedProvider?.supports_asset_sync ?? false}
/>
- {/* Reconnect Dialog */}
+ {/* Reconnect Dialog — widget-based (Pluggy) */}
<BankConnectDialog
open={!!reconnectConnId}
onClose={() => { setReconnectConnId(null); setReconnectItemId(null) }}
@@ -640,6 +653,14 @@ export default function AccountsPage() {
updateItemId={reconnectItemId ?? undefined}
/>
+ {/* Reconnect Dialog — paste-a-token flow (SimpleFIN) */}
+ <TokenConnectDialog
+ open={!!tokenReconnectConnection}
+ onClose={() => setTokenReconnectConnection(null)}
+ provider={tokenReconnectConnection?.provider ?? ''}
+ reconnectConnectionId={tokenReconnectConnection?.id}
+ />
+
{/* Connection Settings Dialog */}
<ConnectionSettingsDialog
open={!!settingsConnection}