Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

fix: convert enable banking consent validity from seconds to days (#459)

Pedro Magalhãescde11edd9daf
diff --git a/backend/app/providers/enable_banking.py b/backend/app/providers/enable_banking.py
index 44970d27..edb25e9d 100644
--- a/backend/app/providers/enable_banking.py
+++ b/backend/app/providers/enable_banking.py
@@ -299,6 +299,9 @@ class EnableBankingProvider(BankProvider):
inst_country = (item.get("country") or "").upper()
if inst_country:
countries.add(inst_country)
+ if (maximum_consent_validity := item.get("maximum_consent_validity", None)) is not None:
+ maximum_consent_validity = timedelta(seconds=maximum_consent_validity).days
+
institutions.append(
InstitutionData(
name=item.get("name") or "",
@@ -307,7 +310,7 @@ class EnableBankingProvider(BankProvider):
logo=item.get("logo"),
bic=item.get("bic"),
psu_types=list(item.get("psu_types") or []),
- max_consent_days=item.get("maximum_consent_validity"),
+ max_consent_days=maximum_consent_validity,
)
)
institutions.sort(key=lambda i: (i.country, i.display_name.lower()))
diff --git a/backend/tests/test_providers_enable_banking.py b/backend/tests/test_providers_enable_banking.py
index 492d4cb8..25a8207d 100644
--- a/backend/tests/test_providers_enable_banking.py
+++ b/backend/tests/test_providers_enable_banking.py
@@ -167,7 +167,7 @@ async def test_list_institutions_maps_and_dedupes_countries(eb_keys):
"logo": "https://l/revolut.png",
"bic": "REVOLT21",
"psu_types": ["personal"],
- "maximum_consent_validity": 180,
+ "maximum_consent_validity": 15552000,
},
{"name": "Sparkasse", "country": "DE"},
{"name": "BNP Paribas", "country": "FR"},
diff --git a/frontend/src/components/oauth-connect-dialog.tsx b/frontend/src/components/oauth-connect-dialog.tsx
index eb1d0558..f9849526 100644
--- a/frontend/src/components/oauth-connect-dialog.tsx
+++ b/frontend/src/components/oauth-connect-dialog.tsx
@@ -15,6 +15,7 @@ type Institution = {
name: string
display_name: string
country: string
+ max_consent_days?: number | null
logo?: string | null
}
@@ -108,6 +109,7 @@ export function OAuthConnectDialog({ open, onClose, provider, supportsAssetSync
const url = await connections.getOAuthUrl(provider, {
country,
institution_name: institution.name,
+ valid_until_days: institution.max_consent_days,
...(supportsAssetSync ? { sync_assets: syncAssets } : {}),
})
window.location.assign(url)