Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

fix: category group edit (#12)

gmiranda13cfe01ec08cac
diff --git a/backend/app/services/category_group_service.py b/backend/app/services/category_group_service.py
index 8a8a67d3..b37fba20 100644
--- a/backend/app/services/category_group_service.py
+++ b/backend/app/services/category_group_service.py
@@ -77,7 +77,9 @@ async def get_groups(session: AsyncSession, user_id: uuid.UUID) -> list[Category
async def get_group(session: AsyncSession, group_id: uuid.UUID, user_id: uuid.UUID) -> Optional[CategoryGroup]:
result = await session.execute(
- select(CategoryGroup).where(CategoryGroup.id == group_id, CategoryGroup.user_id == user_id)
+ select(CategoryGroup)
+ .where(CategoryGroup.id == group_id, CategoryGroup.user_id == user_id)
+ .options(selectinload(CategoryGroup.categories))
)
return result.scalar_one_or_none()
@@ -86,8 +88,7 @@ async def create_group(session: AsyncSession, user_id: uuid.UUID, data: Category
group = CategoryGroup(user_id=user_id, **data.model_dump())
session.add(group)
await session.commit()
- await session.refresh(group)
- return group
+ return await get_group(session, group.id, user_id)
async def update_group(
@@ -101,8 +102,7 @@ async def update_group(
setattr(group, key, value)
await session.commit()
- await session.refresh(group)
- return group
+ return await get_group(session, group_id, user_id)
async def delete_group(session: AsyncSession, group_id: uuid.UUID, user_id: uuid.UUID) -> bool:
diff --git a/frontend/src/pages/categories.tsx b/frontend/src/pages/categories.tsx
index e65932c3..15d91cad 100644
--- a/frontend/src/pages/categories.tsx
+++ b/frontend/src/pages/categories.tsx
@@ -86,6 +86,7 @@ export default function CategoriesPage() {
const updateGroupMutation = useMutation({
mutationFn: ({ id, ...data }: Partial<CategoryGroup> & { id: string }) => groupsApi.update(id, data),
onSuccess: () => { invalidateAll(); setGroupDialogOpen(false); setEditingGroup(null); toast.success(t('groups.updated')) },
+ onError: () => { toast.error(t('common.error')) },
})
const deleteGroupMutation = useMutation({
mutationFn: (id: string) => groupsApi.delete(id),