Skip to content

Graph-Native Infrastructure for Context and Accountable AI Systems

Merge remote-tracking branch 'upstream/main' into fix/AttributError_in_filter_by_metadata_on_persistent_backend

TaherTadpatri21f5f3d9b3e6
diff --cc semantica/vector_store/vector_store.py
index 239f958f,2b685fe2..a45d40ef
--- a/semantica/vector_store/vector_store.py
+++ b/semantica/vector_store/vector_store.py
@@@ -1123,67 -1171,78 +1170,70 @@@ class VectorStore
def _filter_by_metadata(self, filters: Dict[str, Any], limit: int) -> List[Dict[str, Any]]:
"""Filter decisions by metadata only."""
- if self.backend == "inmemory":
- results = []
-
- for vector_id, metadata in self.metadata.items():
- if _matches_filter(metadata, filters):
- results.append({
- "id": vector_id,
- "metadata": metadata,
- "vector": self.vectors.get(vector_id)
- })
-
- if len(results) >= limit:
- break
-
- return results
- elif self._backend_store is not None and hasattr(self._backend_store, "filter_by_metadata"):
- return self._backend_store.filter_by_metadata(filters=filters, limit=limit)
- else:
+ if self._backend_store is not None:
- # No real backend wrapper implements filter_by_metadata; the only
- # codebase hit is HybridSearch.filter_by_metadata which has a
- # completely different signature (results, MetadataFilter) and is
- # never stored in _backend_store. Silently returning [] here would
- # be wrong — the caller (filter_decisions) would report zero matches
- # for a query that simply isn't supported, indistinguishable from a
- # genuine empty result. This is the same situation as get_vector()
- # and get_metadata() (#843 fix): when a backend exists but cannot
- # fulfil the request, raise NotImplementedError so the caller knows
- # the backend lacks this capability rather than assuming no data.
+ if hasattr(self._backend_store, "filter_by_metadata"):
- return self._backend_store.filter_by_metadata(filters, limit)
++ return self._backend_store.filter_by_metadata(filters=filters, limit=limit)
raise NotImplementedError(
- f"Backend store {type(self._backend_store).__name__ if self._backend_store else self.backend} does not implement filter_by_metadata"
+ f"Backend store {type(self._backend_store).__name__} does not "
+ "implement filter_by_metadata. Metadata-only filtering via "
- "filter_decisions(query=None, ...) is only supported for the "
- "inmemory backend. Pass a query string to use search_decisions() "
++ "filter_decisions(query=None, ...) is only supported for backends "
++ "that implement filter_by_metadata. Pass a query string to use search_decisions() "
+ "instead, which is supported by all backends."
)
+ results = []
+
+ for vector_id, metadata in self.metadata.items():
- match = True
-
- for key, value in filters.items():
- if key not in metadata:
- match = False
- break
-
- if isinstance(value, dict):
- # Handle range filters
- metadata_value = metadata[key]
- if "min" in value and metadata_value < value["min"]:
- match = False
- break
- if "max" in value and metadata_value > value["max"]:
- match = False
- break
- elif isinstance(value, list):
- # Handle list membership
- metadata_value = metadata[key]
- if isinstance(metadata_value, list):
- # Both are lists - check for intersection
- if not set(metadata_value) & set(value):
- match = False
- break
- else:
- # Metadata value is scalar, check if it's in the filter list
- if metadata_value not in value:
- match = False
- break
- else:
- # Handle exact match
- if metadata[key] != value:
- match = False
- break
-
- if match:
++ if _matches_filter(metadata, filters):
+ results.append({
+ "id": vector_id,
+ "metadata": metadata,
- "vector": self.get_vector(vector_id)
++ "vector": self.vectors.get(vector_id)
+ })
+
+ if len(results) >= limit:
+ break
+
+ return results
+
+def _matches_filter(metadata: Dict[str, Any], filters: Dict[str, Any]) -> bool:
+ """Check if metadata dictionary matches filter criteria."""
+ if not filters:
+ return True
+ if metadata is None:
+ return False
+
+ for key, value in filters.items():
+ if key not in metadata:
+ return False
+
+ metadata_value = metadata[key]
+
+ if isinstance(value, dict):
+ # Handle range filters
+ if "min" in value and value["min"] is not None:
+ if metadata_value is None or metadata_value < value["min"]:
+ return False
+ if "max" in value and value["max"] is not None:
+ if metadata_value is None or metadata_value > value["max"]:
+ return False
+ elif isinstance(value, list):
+ # Handle list membership
+ if isinstance(metadata_value, list):
+ if not (set(metadata_value) & set(value)):
+ return False
+ else:
+ if metadata_value not in value:
+ return False
+ else:
+ # Handle exact match
+ if metadata_value != value:
+ return False
+
+ return True
+
+
-
class VectorIndexer:
"""Vector indexing engine."""