Skip to content

Graph-Native Infrastructure for Context and Accountable AI Systems

Fix PolicyException naming conflicts in decision models

KaifAhmad128dc1ed4e904
diff --git a/semantica/context/decision_models.py b/semantica/context/decision_models.py
index ca2de217..f1fb0304 100644
--- a/semantica/context/decision_models.py
+++ b/semantica/context/decision_models.py
@@ -101,7 +101,7 @@ class Decision:
def __post_init__(self):
"""Validate decision data."""
- if self.decision_id is None:
+ if not self.decision_id: # Handle both None and empty string
self.decision_id = str(uuid.uuid4())
if not 0 <= self.confidence <= 1:
raise ValueError("Confidence must be between 0 and 1")
@@ -143,7 +143,7 @@ class DecisionContext:
def __post_init__(self):
"""Validate context data."""
- if self.context_id is None:
+ if not self.context_id: # Handle both None and empty string
self.context_id = str(uuid.uuid4())
def to_dict(self) -> Dict[str, Any]:
@@ -179,7 +179,7 @@ class Policy:
def __post_init__(self):
"""Validate policy data."""
- if self.policy_id is None:
+ if not self.policy_id: # Handle both None and empty string
self.policy_id = str(uuid.uuid4())
def to_dict(self) -> Dict[str, Any]:
@@ -220,7 +220,7 @@ class PolicyException:
def __post_init__(self):
"""Validate exception data."""
- if self.exception_id is None:
+ if not self.exception_id: # Handle both None and empty string
self.exception_id = str(uuid.uuid4())
def to_dict(self) -> Dict[str, Any]:
@@ -256,7 +256,7 @@ class Precedent:
def __post_init__(self):
"""Validate precedent data."""
- if self.precedent_id is None:
+ if not self.precedent_id: # Handle both None and empty string
self.precedent_id = str(uuid.uuid4())
if not 0 <= self.similarity_score <= 1:
raise ValueError("Similarity score must be between 0 and 1")
@@ -294,7 +294,7 @@ class ApprovalChain:
def __post_init__(self):
"""Validate approval data."""
- if self.approval_id is None:
+ if not self.approval_id: # Handle both None and empty string
self.approval_id = str(uuid.uuid4())
valid_methods = ["slack_dm", "zoom_call", "email", "system"]
if self.approval_method not in valid_methods:
diff --git a/tests/context/test_decision_models.py b/tests/context/test_decision_models.py
index 92ec20fd..71cb13d3 100644
--- a/tests/context/test_decision_models.py
+++ b/tests/context/test_decision_models.py
@@ -10,7 +10,7 @@ from datetime import datetime
from typing import List, Dict, Any
from semantica.context.decision_models import (
- Decision, DecisionContext, Policy, Exception, Precedent, ApprovalChain,
+ Decision, DecisionContext, Policy, PolicyException, Precedent, ApprovalChain,
validate_decision, validate_policy, serialize_decision, deserialize_decision,
serialize_policy, deserialize_policy
)
@@ -213,12 +213,12 @@ class TestPolicy:
assert len(policy.policy_id) > 0
-class TestException:
- """Test Exception data model."""
+class TestPolicyException:
+ """Test PolicyException data model."""
- def test_exception_creation(self):
- """Test basic exception creation."""
- exception = Exception(
+ def test_policy_exception_creation(self):
+ """Test basic policy exception creation."""
+ policy_exception = PolicyException(
exception_id="exc_001",
decision_id="decision_001",
policy_id="policy_001",
@@ -229,17 +229,17 @@ class TestException:
metadata={"override_type": "vip_exception"}
)
- assert exception.exception_id == "exc_001"
- assert exception.decision_id == "decision_001"
- assert exception.policy_id == "policy_001"
- assert exception.reason == "Customer is VIP with special arrangements"
- assert exception.approver == "manager_001"
- assert exception.justification == "Long-term customer with excellent history"
- assert exception.metadata["override_type"] == "vip_exception"
+ assert policy_exception.exception_id == "exc_001"
+ assert policy_exception.decision_id == "decision_001"
+ assert policy_exception.policy_id == "policy_001"
+ assert policy_exception.reason == "Customer is VIP with special arrangements"
+ assert policy_exception.approver == "manager_001"
+ assert policy_exception.justification == "Long-term customer with excellent history"
+ assert policy_exception.metadata["override_type"] == "vip_exception"
- def test_exception_auto_id(self):
+ def test_policy_exception_auto_id(self):
"""Test automatic ID generation."""
- exception = Exception(
+ policy_exception = PolicyException(
exception_id="",
decision_id="decision_001",
policy_id="policy_001",
@@ -249,8 +249,8 @@ class TestException:
justification="test justification"
)
- assert exception.exception_id != ""
- assert len(exception.exception_id) > 0
+ assert policy_exception.exception_id != ""
+ assert len(policy_exception.exception_id) > 0
class TestPrecedent:
diff --git a/tests/context/test_decision_query.py b/tests/context/test_decision_query.py
index 4611dbba..f4bd6c8e 100644
--- a/tests/context/test_decision_query.py
+++ b/tests/context/test_decision_query.py
@@ -10,7 +10,7 @@ from datetime import datetime, timedelta
from unittest.mock import Mock, patch
from typing import List, Dict, Any
-from semantica.context.decision_models import Decision, Policy, Exception
+from semantica.context.decision_models import Decision, Policy, PolicyException
from semantica.context.decision_query import DecisionQuery
diff --git a/tests/context/test_policy_engine.py b/tests/context/test_policy_engine.py
index e0ff9077..2728a7bb 100644
--- a/tests/context/test_policy_engine.py
+++ b/tests/context/test_policy_engine.py
@@ -10,7 +10,7 @@ from datetime import datetime, timedelta
from unittest.mock import Mock, patch
from typing import List, Dict, Any
-from semantica.context.decision_models import Policy, Exception
+from semantica.context.decision_models import Policy, PolicyException
from semantica.context.policy_engine import PolicyEngine