Skip to content

Graph-Native Infrastructure for Context and Accountable AI Systems

fix(normalize): apply source_timezone to naive datetimes in convert_to_utc (#2108)

Tymur8caade177e25
diff --git a/semantica/normalize/date_normalizer.py b/semantica/normalize/date_normalizer.py
index a835c207..5b50a183 100644
--- a/semantica/normalize/date_normalizer.py
+++ b/semantica/normalize/date_normalizer.py
@@ -33,6 +33,7 @@ License: MIT
import re
from datetime import datetime, timedelta, timezone
from typing import Any, Dict, List, Optional
+from zoneinfo import ZoneInfo, ZoneInfoNotFoundError
from ..utils.exceptions import ProcessingError, ValidationError
from ..utils.logging import get_logger
@@ -313,7 +314,7 @@ class TimeZoneNormalizer:
This method converts a datetime object to UTC timezone. If the datetime
has no timezone info, it assumes UTC or uses the source_timezone if
- provided.
+ provided. Aware datetimes ignore source_timezone.
Args:
datetime_obj: Datetime object to convert
@@ -322,10 +323,20 @@ class TimeZoneNormalizer:
Returns:
datetime: Datetime object in UTC timezone
+
+ Raises:
+ ValidationError: If source_timezone is unknown or invalid for a
+ naive datetime
"""
if datetime_obj.tzinfo is None:
if source_timezone:
- datetime_obj = self.normalize_timezone(datetime_obj, source_timezone)
+ try:
+ source_tz = ZoneInfo(source_timezone)
+ except (ZoneInfoNotFoundError, ValueError, TypeError) as e:
+ raise ValidationError(
+ f"Invalid source timezone: {source_timezone!r}"
+ ) from e
+ datetime_obj = datetime_obj.replace(tzinfo=source_tz)
else:
datetime_obj = datetime_obj.replace(tzinfo=timezone.utc)
diff --git a/tests/normalize/test_date_normalizer.py b/tests/normalize/test_date_normalizer.py
index 9c1bb889..31b5f287 100644
--- a/tests/normalize/test_date_normalizer.py
+++ b/tests/normalize/test_date_normalizer.py
@@ -1,3 +1,5 @@
+import os
+import time
import unittest
from datetime import datetime, timedelta, timezone
from unittest.mock import patch
@@ -7,6 +9,7 @@ from semantica.normalize.date_normalizer import (
RelativeDateProcessor,
TimeZoneNormalizer,
)
+from semantica.utils.exceptions import ValidationError
class TestDateNormalizer(unittest.TestCase):
@@ -65,6 +68,56 @@ class TestTimeZoneNormalizer(unittest.TestCase):
normalized.tzinfo.utcoffset(normalized), timezone.utc.utcoffset(None)
)
+ def test_convert_to_utc_source_timezone_winter(self):
+ dt = datetime(2026, 3, 1, 7, 30)
+ self.assertEqual(
+ self.tz_normalizer.convert_to_utc(dt, "America/New_York"),
+ datetime(2026, 3, 1, 12, 30, tzinfo=timezone.utc),
+ )
+
+ def test_convert_to_utc_source_timezone_summer(self):
+ dt = datetime(2026, 7, 1, 7, 30)
+ self.assertEqual(
+ self.tz_normalizer.convert_to_utc(dt, "America/New_York"),
+ datetime(2026, 7, 1, 11, 30, tzinfo=timezone.utc),
+ )
+
+ def test_convert_to_utc_aware_ignores_source_timezone(self):
+ dt = datetime(2026, 3, 1, 7, 30, tzinfo=timezone(timedelta(hours=2)))
+ for source_timezone in ("America/New_York", "Nope/Zone"):
+ with self.subTest(source_timezone=source_timezone):
+ self.assertEqual(
+ self.tz_normalizer.convert_to_utc(dt, source_timezone),
+ datetime(2026, 3, 1, 5, 30, tzinfo=timezone.utc),
+ )
+
+ @unittest.skipUnless(hasattr(time, "tzset"), "time.tzset is not available")
+ def test_convert_to_utc_unknown_timezone(self):
+ # A non-UTC host zone, so a naive result read as local time would show up
+ self.addCleanup(time.tzset)
+ with patch.dict(os.environ, {"TZ": "Asia/Kolkata"}):
+ time.tzset()
+ with self.assertRaisesRegex(ValidationError, "Nope/Zone"):
+ self.tz_normalizer.convert_to_utc(
+ datetime(2026, 3, 1, 7, 30), "Nope/Zone"
+ )
+
+ def test_convert_to_utc_invalid_timezone(self):
+ for source_timezone in ("../etc", 123):
+ with self.subTest(source_timezone=source_timezone):
+ with self.assertRaises(ValidationError) as error:
+ self.tz_normalizer.convert_to_utc(
+ datetime(2026, 3, 1, 7, 30), source_timezone
+ )
+ self.assertIn(repr(source_timezone), str(error.exception))
+
+ def test_convert_to_utc_without_source_timezone(self):
+ dt = datetime(2026, 3, 1, 7, 30)
+ self.assertEqual(
+ self.tz_normalizer.convert_to_utc(dt),
+ datetime(2026, 3, 1, 7, 30, tzinfo=timezone.utc),
+ )
+
class TestRelativeDateProcessor(unittest.TestCase):
def setUp(self):