Skip to content

Graph-Native Infrastructure for Context and Accountable AI Systems

fix(vector_store): sync the facade mirror on backend update_vectors (#1847)

Younes Berianea948fd0488ca
diff --git a/semantica/vector_store/vector_store.py b/semantica/vector_store/vector_store.py
index f4246838..496daafa 100644
--- a/semantica/vector_store/vector_store.py
+++ b/semantica/vector_store/vector_store.py
@@ -854,12 +854,29 @@ class VectorStore:
# Delegate to backend store if available
if self._backend_store:
if hasattr(self._backend_store, 'update'):
- return self._backend_store.update(ids=vector_ids, vectors=new_vectors, metadata=metadata, **options)
+ result = self._backend_store.update(ids=vector_ids, vectors=new_vectors, metadata=metadata, **options)
elif hasattr(self._backend_store, 'update_vectors'):
- return self._backend_store.update_vectors(vector_ids, new_vectors, **options)
+ result = self._backend_store.update_vectors(vector_ids, new_vectors, **options)
else:
raise NotImplementedError(f"Backend store {type(self._backend_store).__name__} does not have update or update_vectors method")
+ # A backend that rejects the update keeps its old values, so
+ # leave the mirror untouched and pass the result through.
+ if result is False:
+ return result
+
+ # Keep the facade mirror in step with the backend, as
+ # delete_vectors does, so save() persists the updated values.
+ with self._inmemory_lock:
+ for vec_id, new_vec in zip(vector_ids, new_vectors):
+ if vec_id in self.vectors:
+ self.vectors[vec_id] = new_vec
+ if metadata:
+ for vec_id, meta in zip(vector_ids, metadata):
+ if vec_id in self.metadata:
+ self.metadata[vec_id] = meta
+ return result
+
with self._inmemory_lock:
for vec_id, new_vec in zip(vector_ids, new_vectors):
if vec_id in self.vectors:
diff --git a/tests/vector_store/test_vector_store.py b/tests/vector_store/test_vector_store.py
index f7a8b99d..715051dd 100644
--- a/tests/vector_store/test_vector_store.py
+++ b/tests/vector_store/test_vector_store.py
@@ -300,3 +300,68 @@ def test_backend_mirroring_and_save(tmp_path):
vs.delete_vectors(ids)
assert ids[0] not in vs.vectors
assert ids[0] not in vs.metadata
+
+
+def test_update_vectors_syncs_backend_mirror_before_save(tmp_path):
+ """update_vectors() on a backend store must refresh the facade mirror.
+
+ save() serialises self.vectors / self.metadata, so a stale mirror makes it
+ persist the pre-update values (#1833).
+ """
+ import os
+
+ class FakeBackend:
+ def add(self, vectors, metadata, **options):
+ return [f"id{i}" for i in range(len(vectors))]
+
+ def update(self, ids, vectors, metadata=None, **options):
+ return True
+
+ vs = VectorStore(backend="inmemory", dimension=2)
+ vs._backend_store = FakeBackend()
+
+ ids = vs.store_vectors(
+ [np.array([0.1, 0.2], dtype=np.float32)], metadata=[{"label": "original"}]
+ )
+
+ new_vec = np.array([0.9, 0.9], dtype=np.float32)
+ assert vs.update_vectors(ids, [new_vec], metadata=[{"label": "updated"}]) is True
+
+ assert np.array_equal(vs.vectors[ids[0]], new_vec)
+ assert vs.metadata[ids[0]] == {"label": "updated"}
+
+ vs.save(str(tmp_path))
+ with open(os.path.join(str(tmp_path), "store_data.json"), encoding="utf-8") as f:
+ saved = json.load(f)
+ assert saved["vectors"][ids[0]] == pytest.approx([0.9, 0.9])
+ assert saved["metadata"][ids[0]] == {"label": "updated"}
+
+
+def test_update_vectors_leaves_mirror_when_backend_rejects(tmp_path):
+ """If the backend update returns False, the mirror must keep the originals."""
+ import os
+
+ class RejectingBackend:
+ def add(self, vectors, metadata, **options):
+ return [f"id{i}" for i in range(len(vectors))]
+
+ def update(self, ids, vectors, metadata=None, **options):
+ return False
+
+ vs = VectorStore(backend="inmemory", dimension=2)
+ vs._backend_store = RejectingBackend()
+
+ original = np.array([0.1, 0.2], dtype=np.float32)
+ ids = vs.store_vectors([original], metadata=[{"label": "original"}])
+
+ new_vec = np.array([0.9, 0.9], dtype=np.float32)
+ assert vs.update_vectors(ids, [new_vec], metadata=[{"label": "updated"}]) is False
+
+ assert np.array_equal(vs.vectors[ids[0]], original)
+ assert vs.metadata[ids[0]] == {"label": "original"}
+
+ vs.save(str(tmp_path))
+ with open(os.path.join(str(tmp_path), "store_data.json"), encoding="utf-8") as f:
+ saved = json.load(f)
+ assert saved["vectors"][ids[0]] == pytest.approx([0.1, 0.2])
+ assert saved["metadata"][ids[0]] == {"label": "original"}