Graph-Native Infrastructure for Context and Accountable AI Systems
Python agent-memoryaiai-governanceai-infrastructureartificial-intelligencecontext-engineeringcontext-graphsdata-engineeringdecision-intelligencedeveloper-toolsexplainable-aigenerative-aigraph-ragknowledge-graphllmontologyprovenancepythonreasoningsemantic-search
fix(reasoning): log unify_condition regex errors for observability
江俊杰a94cec3b3698
diff --git a/semantica/reasoning/rete_engine.py b/semantica/reasoning/rete_engine.pyindex 8a8f715c..5eca9fc9 100644--- a/semantica/reasoning/rete_engine.py+++ b/semantica/reasoning/rete_engine.py@@ -41,6 +41,8 @@ from ..utils.logging import get_loggerfrom ..utils.progress_tracker import get_progress_trackerfrom .reasoner import Fact, Rule+logger = get_logger("rete_engine")+def unify_condition(condition: Any,@@ -95,7 +97,25 @@ def unify_condition(try:match = re.match(p_regex, fact_str)- except re.error:+ except re.error as e:+ logger.warning(+ "unify_condition failed to compile/match condition "+ "%r (regex: %r) against fact %r: %s",+ pattern,+ p_regex,+ fact_str,+ e,+ )+ return None+ except Exception as e: # noqa: BLE001 - mirror Reasoner._match_pattern+ logger.warning(+ "unify_condition unexpected error matching condition "+ "%r (regex: %r) against fact %r: %s",+ pattern,+ p_regex,+ fact_str,+ e,+ )return Noneif not match:return Nonediff --git a/tests/reasoning/test_rete_engine.py b/tests/reasoning/test_rete_engine.pyindex f34f4de8..f2faec28 100644--- a/tests/reasoning/test_rete_engine.py+++ b/tests/reasoning/test_rete_engine.py@@ -6,8 +6,11 @@ whole only fires rules whose conditions actually unify with the facts."""import itertools+import reimport unittest+from unittest import mock+from semantica.reasoning import rete_enginefrom semantica.reasoning.reasoner import Fact, Rulefrom semantica.reasoning.rete_engine import (AlphaNode,@@ -43,6 +46,33 @@ class TestUnifyCondition(unittest.TestCase):self.assertEqual(unify_condition("Loves(?x, ?x)", loves_self), {"x": "John"})self.assertIsNone(unify_condition("Loves(?x, ?x)", loves_other))+ def test_regex_error_logs_warning_and_returns_none(self):+ """A regex compilation error is logged with context and yields None."""+ fact = Fact("f6", "Person", ["John"])+ with mock.patch.object(+ rete_engine.re,+ "match",+ side_effect=re.error("bad pattern"),+ ), self.assertLogs("semantica.rete_engine", level="WARNING") as captured:+ result = unify_condition("Person(?x)", fact)+ self.assertIsNone(result)+ joined = "\n".join(captured.output)+ self.assertIn("Person(?x)", joined)+ self.assertIn("Person(John)", joined)+ self.assertIn("bad pattern", joined)++ def test_unexpected_error_logs_warning_and_returns_none(self):+ """An unexpected error is also logged and swallowed as None."""+ fact = Fact("f7", "Person", ["John"])+ with mock.patch.object(+ rete_engine.re,+ "match",+ side_effect=RuntimeError("boom"),+ ), self.assertLogs("semantica.rete_engine", level="WARNING") as captured:+ result = unify_condition("Person(?x)", fact)+ self.assertIsNone(result)+ self.assertIn("boom", "\n".join(captured.output))+class TestAlphaNode(unittest.TestCase):def test_matches_stores_bindings(self):