Skip to content

Graph-Native Infrastructure for Context and Accountable AI Systems

refactor(explorer): move isSafeUrl out of MarkdownContentViewer (#1119) (#1194)

pravit-ampc7d608570c4b
diff --git a/explorer/src/workspaces/GraphWorkspace/MarkdownContentViewer.tsx b/explorer/src/workspaces/GraphWorkspace/MarkdownContentViewer.tsx
index f00d3dc5..77d7b6a6 100644
--- a/explorer/src/workspaces/GraphWorkspace/MarkdownContentViewer.tsx
+++ b/explorer/src/workspaces/GraphWorkspace/MarkdownContentViewer.tsx
@@ -3,6 +3,7 @@ import ReactMarkdown from "react-markdown";
import remarkGfm from "remark-gfm";
import { Check, Copy, Code2, Eye, ExternalLink, Image as ImageIcon } from "lucide-react";
import { GRAPH_THEME } from "./graphTheme";
+import { isSafeUrl } from "./markdownUrlSafety";
export interface MarkdownContentViewerProps {
content?: string | null;
@@ -10,25 +11,6 @@ export interface MarkdownContentViewerProps {
defaultMode?: "preview" | "source";
}
-export function isSafeUrl(url?: string): boolean {
- if (!url) return false;
- const trimmed = url.trim();
- // Reject whitespace-only strings — new URL("", base) would resolve to the base
- // protocol and produce a false positive. This guards direct callers of the exported
- // function; markdown parsers normalise whitespace-only destinations to "" which
- // already fails the !url check above.
- if (!trimmed) return false;
- if (trimmed.startsWith("//")) return false;
- if (trimmed.startsWith("#")) return true;
- if (trimmed.startsWith("/")) return true;
- try {
- const parsed = new URL(trimmed, "http://localhost");
- return ["http:", "https:", "mailto:"].includes(parsed.protocol);
- } catch {
- return false;
- }
-}
-
export function MarkdownContentViewer({
content,
className,
diff --git a/explorer/src/workspaces/GraphWorkspace/markdownUrlSafety.ts b/explorer/src/workspaces/GraphWorkspace/markdownUrlSafety.ts
new file mode 100644
index 00000000..3944a86b
--- /dev/null
+++ b/explorer/src/workspaces/GraphWorkspace/markdownUrlSafety.ts
@@ -0,0 +1,29 @@
+/**
+ * URL-safety predicate for the Markdown content viewer.
+ *
+ * Extracted into a pure module so the check can be unit-tested without
+ * importing the MarkdownContentViewer React component, and so the component
+ * module exports only components (react-refresh/only-export-components,
+ * issue #1119). The behaviour is unchanged from the original in-component
+ * implementation: only http, https, mailto, in-document fragments, and
+ * root-relative paths are permitted.
+ */
+
+export function isSafeUrl(url?: string): boolean {
+ if (!url) return false;
+ const trimmed = url.trim();
+ // Reject whitespace-only strings — new URL("", base) would resolve to the base
+ // protocol and produce a false positive. This guards direct callers of the exported
+ // function; markdown parsers normalise whitespace-only destinations to "" which
+ // already fails the !url check above.
+ if (!trimmed) return false;
+ if (trimmed.startsWith("//")) return false;
+ if (trimmed.startsWith("#")) return true;
+ if (trimmed.startsWith("/")) return true;
+ try {
+ const parsed = new URL(trimmed, "http://localhost");
+ return ["http:", "https:", "mailto:"].includes(parsed.protocol);
+ } catch {
+ return false;
+ }
+}
diff --git a/explorer/tests/markdownContentViewer.test.ts b/explorer/tests/markdownContentViewer.test.ts
index aa89f3cb..0435578a 100644
--- a/explorer/tests/markdownContentViewer.test.ts
+++ b/explorer/tests/markdownContentViewer.test.ts
@@ -5,7 +5,8 @@ import { renderToString } from "react-dom/server";
(globalThis as any).React = React;
-import { isSafeUrl, MarkdownContentViewer } from "../src/workspaces/GraphWorkspace/MarkdownContentViewer.tsx";
+import { MarkdownContentViewer } from "../src/workspaces/GraphWorkspace/MarkdownContentViewer.tsx";
+import { isSafeUrl } from "../src/workspaces/GraphWorkspace/markdownUrlSafety.ts";
test("isSafeUrl permits safe http, https, and mailto URLs and relative paths", () => {
assert.equal(isSafeUrl("https://example.com"), true);