Graph-Native Infrastructure for Context and Accountable AI Systems
Python agent-memoryaiai-governanceai-infrastructureartificial-intelligencecontext-engineeringcontext-graphsdata-engineeringdecision-intelligencedeveloper-toolsexplainable-aigenerative-aigraph-ragknowledge-graphllmontologyprovenancepythonreasoningsemantic-search
fix(vector-store): fix get_vector/get_metadata crash on persistent backends (#843)
Sameer6305c8b59b47f58d
diff --git a/semantica/vector_store/faiss_store.py b/semantica/vector_store/faiss_store.pyindex 2ebf37e8..41045ec5 100644--- a/semantica/vector_store/faiss_store.py+++ b/semantica/vector_store/faiss_store.py@@ -85,9 +85,15 @@ class FAISSIndex:return Noneidx = self.vector_ids.index(vector_id)- # Note: FAISS doesn't directly support retrieval by index in all cases- # This is a simplified approach- return None+ try:+ return self.index.reconstruct(idx)+ except Exception:+ # Some FAISS indices (e.g. IVFPQ without make_direct_map) do not support reconstruct+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ raise NotImplementedError("FAISS does not store metadata natively. Please use a secondary metadata store.")def save(self, path: Union[str, Path]):"""Save index to disk."""@@ -445,6 +451,18 @@ class FAISSStore:self.logger.info("Index optimization completed")return True+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ if self.index:+ return self.index.get_vector(vector_id)+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ if self.index:+ return self.index.get_metadata(vector_id)+ return None+def get_stats(self) -> Dict[str, Any]:"""Get index statistics."""if self.index is None:diff --git a/semantica/vector_store/milvus_store.py b/semantica/vector_store/milvus_store.pyindex 4f8b6f93..700da668 100644--- a/semantica/vector_store/milvus_store.py+++ b/semantica/vector_store/milvus_store.py@@ -523,6 +523,20 @@ class MilvusStore:)raise+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ raise NotImplementedError(+ "MilvusStore generates its own INT64 primary keys via auto_id=True and drops string IDs "+ "during insertion, making direct ID lookup impossible."+ )++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ raise NotImplementedError(+ "MilvusStore generates its own INT64 primary keys via auto_id=True and drops string IDs "+ "during insertion, making direct ID lookup impossible."+ )+def get_stats(self, collection_name: Optional[str] = None) -> Dict[str, Any]:"""Get collection statistics."""if self.collection is None and collection_name:diff --git a/semantica/vector_store/pgvector_store.py b/semantica/vector_store/pgvector_store.pyindex 6a646cd8..e2d16810 100644--- a/semantica/vector_store/pgvector_store.py+++ b/semantica/vector_store/pgvector_store.py@@ -631,6 +631,28 @@ class PgVectorStore:except Exception as e:raise ProcessingError("Failed to get vectors") from e+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ try:+ results = self.get_vectors([vector_id])+ if results and len(results) > 0:+ return results[0].get("vector")+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get vector {vector_id}: {e}")+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ try:+ results = self.get_vectors([vector_id])+ if results and len(results) > 0:+ return results[0].get("metadata")+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get metadata for {vector_id}: {e}")+ return None+def create_index(self,index_type: str = "hnsw",diff --git a/semantica/vector_store/pinecone_store.py b/semantica/vector_store/pinecone_store.pyindex f1cc5135..cc395ee7 100644--- a/semantica/vector_store/pinecone_store.py+++ b/semantica/vector_store/pinecone_store.py@@ -608,6 +608,28 @@ class PineconeStore:return self.index.delete_vectors(vector_ids, namespace, **options)+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ try:+ res = self.fetch_vectors([vector_id])+ if "vectors" in res and vector_id in res["vectors"]:+ return np.array(res["vectors"][vector_id]["values"])+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get vector {vector_id}: {e}")+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ try:+ res = self.fetch_vectors([vector_id])+ if "vectors" in res and vector_id in res["vectors"]:+ return res["vectors"][vector_id].get("metadata", {})+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get metadata for {vector_id}: {e}")+ return None+def fetch_vectors(self, vector_ids: List[str], namespace: str = "", **options) -> Dict[str, Any]:diff --git a/semantica/vector_store/qdrant_store.py b/semantica/vector_store/qdrant_store.pyindex 88e5b397..9cbb7950 100644--- a/semantica/vector_store/qdrant_store.py+++ b/semantica/vector_store/qdrant_store.py@@ -491,6 +491,44 @@ class QdrantStore:)raise+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ if self.collection is None or not QDRANT_AVAILABLE:+ return None++ try:+ results = self.client.retrieve(+ collection_name=self.collection.collection_name,+ ids=[vector_id],+ with_vectors=True,+ with_payload=False+ )+ if results and results[0].vector:+ return np.array(results[0].vector)+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get vector {vector_id}: {e}")+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ if self.collection is None or not QDRANT_AVAILABLE:+ return None++ try:+ results = self.client.retrieve(+ collection_name=self.collection.collection_name,+ ids=[vector_id],+ with_vectors=False,+ with_payload=True+ )+ if results and results[0].payload is not None:+ return results[0].payload+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get metadata for {vector_id}: {e}")+ return None+def delete_vectors(self, point_ids: List[Union[str, int]], **options) -> Dict[str, Any]:diff --git a/semantica/vector_store/sqlite_vec_store.py b/semantica/vector_store/sqlite_vec_store.pyindex 0ef7d9fc..57483808 100644--- a/semantica/vector_store/sqlite_vec_store.py+++ b/semantica/vector_store/sqlite_vec_store.py@@ -592,6 +592,28 @@ class SQLiteVecStore:except Exception as e:raise ProcessingError("Failed to get vectors") from e+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ try:+ results = self.get_vectors([vector_id])+ if results and len(results) > 0:+ return results[0].get("vector")+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get vector {vector_id}: {e}")+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ try:+ results = self.get_vectors([vector_id])+ if results and len(results) > 0:+ return results[0].get("metadata")+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get metadata for {vector_id}: {e}")+ return None+def create_index(self,index_type: str = "hnsw",diff --git a/semantica/vector_store/vector_store.py b/semantica/vector_store/vector_store.pyindex 86f9c07b..505e64be 100644--- a/semantica/vector_store/vector_store.py+++ b/semantica/vector_store/vector_store.py@@ -567,8 +567,8 @@ class VectorStore:# Save Python-level datadata = {- "vectors": self.vectors,- "metadata": self.metadata,+ "vectors": getattr(self, "vectors", {}),+ "metadata": getattr(self, "metadata", {}),"config": self.config,"backend": self.backend,"dimension": self.dimension@@ -759,11 +759,21 @@ class VectorStore:def get_vector(self, vector_id: str) -> Optional[np.ndarray]:"""Get vector by ID."""- return self.vectors.get(vector_id)+ if self.backend == "inmemory":+ return self.vectors.get(vector_id)+ elif self._backend_store and hasattr(self._backend_store, "get_vector"):+ return self._backend_store.get_vector(vector_id)+ else:+ raise NotImplementedError(f"Backend store {type(self._backend_store).__name__} does not implement get_vector")def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:"""Get metadata for vector."""- return self.metadata.get(vector_id)+ if self.backend == "inmemory":+ return self.metadata.get(vector_id)+ elif self._backend_store and hasattr(self._backend_store, "get_metadata"):+ return self._backend_store.get_metadata(vector_id)+ else:+ raise NotImplementedError(f"Backend store {type(self._backend_store).__name__} does not implement get_metadata")def initialize_decision_pipeline(self,diff --git a/semantica/vector_store/weaviate_store.py b/semantica/vector_store/weaviate_store.pyindex 9dd4e9ff..76605d6f 100644--- a/semantica/vector_store/weaviate_store.py+++ b/semantica/vector_store/weaviate_store.py@@ -418,6 +418,35 @@ class WeaviateStore:)raise ProcessingError(f"Failed to add objects: {str(e)}")+ def get_vector(self, vector_id: str) -> Optional[np.ndarray]:+ """Get vector by ID."""+ if self.collection is None or not WEAVIATE_AVAILABLE:+ return None++ try:+ # Weaviate expects a valid UUID string+ obj = self.collection.query.fetch_object_by_id(vector_id, include_vector=True)+ if obj and obj.vector:+ return np.array(obj.vector)+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get vector {vector_id}: {e}")+ return None++ def get_metadata(self, vector_id: str) -> Optional[Dict[str, Any]]:+ """Get metadata by ID."""+ if self.collection is None or not WEAVIATE_AVAILABLE:+ return None++ try:+ obj = self.collection.query.fetch_object_by_id(vector_id)+ if obj and obj.properties:+ return obj.properties+ return None+ except Exception as e:+ self.logger.warning(f"Failed to get metadata for {vector_id}: {e}")+ return None+def query_vectors(self,query_vector: np.ndarray,diff --git a/tests/vector_store/test_decision_embedding_pipeline.py b/tests/vector_store/test_decision_embedding_pipeline.pyindex 0572517c..4340693f 100644--- a/tests/vector_store/test_decision_embedding_pipeline.py+++ b/tests/vector_store/test_decision_embedding_pipeline.py@@ -11,6 +11,7 @@ import numpy as npfrom unittest.mock import Mock, patch, MagicMockfrom semantica.vector_store.decision_embedding_pipeline import DecisionEmbeddingPipeline+from semantica.vector_store import VectorStoreclass TestDecisionEmbeddingPipeline:@@ -393,6 +394,52 @@ class TestDecisionEmbeddingPipelineEdgeCases:assert all("decision_data" in result for result in results)assert all("vector_id" in result for result in results)+class TestVectorStoreRetrieval:+ """Test get_vector and get_metadata on real backends."""++ def test_inmemory_retrieval(self):+ """Test exact dict behavior for inmemory backend."""+ vs = VectorStore(backend="inmemory")+ vs.store_vectors([np.array([0.1, 0.2, 0.3], dtype=np.float32)], ids=["test1"], metadata=[{"foo": "bar"}])++ vec = vs.get_vector("vec_0")+ meta = vs.get_metadata("vec_0")++ assert vec is not None+ np.testing.assert_array_almost_equal(vec, np.array([0.1, 0.2, 0.3], dtype=np.float32))+ assert meta == {"foo": "bar"}++ def test_faiss_retrieval(self):+ """Test reconstruction from FAISS."""+ try:+ import faiss+ except ImportError:+ pytest.skip("FAISS not installed")++ vs = VectorStore(backend="faiss", config={"dimension": 3})+ vs.store_vectors([np.array([0.1, 0.2, 0.3], dtype=np.float32)], ids=["test1"])++ vec = vs.get_vector("test1")+ assert vec is not None+ np.testing.assert_array_almost_equal(vec, np.array([0.1, 0.2, 0.3], dtype=np.float32))++ with pytest.raises(NotImplementedError, match="does not store metadata"):+ vs.get_metadata("test1")++ def test_cloud_backends_untested(self):+ """+ Note: The following backends are not tested locally as they require+ live external services (Docker containers or API keys):+ - QdrantStore+ - PineconeStore+ - MilvusStore+ - WeaviateStore+ - PgVectorStore++ Their implementations rely directly on official client SDKs (e.g. client.retrieve,+ index.fetch) to ensure correctness in production.+ """+ passif __name__ == "__main__":pytest.main([__file__])