Graph-Native Infrastructure for Context and Accountable AI Systems
Python agent-memoryaiai-governanceai-infrastructureartificial-intelligencecontext-engineeringcontext-graphsdata-engineeringdecision-intelligencedeveloper-toolsexplainable-aigenerative-aigraph-ragknowledge-graphllmontologyprovenancepythonreasoningsemantic-search
fix(context): return VectorStore hits from AgentMemory.retrieve (#1736)
Chaoqid2a4ed4a02e8
diff --git a/semantica/context/agent_memory.py b/semantica/context/agent_memory.pyindex b7689ba7..fc75297a 100644--- a/semantica/context/agent_memory.py+++ b/semantica/context/agent_memory.py@@ -521,32 +521,38 @@ class AgentMemory:query=query, limit=max_results * 2)- for result in vector_results:- memory_id = result.id+ with self._memory_lock:+ vector_to_memory = {+ vector_id: memory_id+ for memory_id, vector_ids in self._vector_ids.items()+ for vector_id in vector_ids+ }+ for result in vector_results:+ memory_id = vector_to_memory.get(str(result.id), result.id)++ # Skip if already found in short-term+ if memory_id in seen_ids:+ continue++ if memory_id in self.memory_items:+ memory_item = self.memory_items[memory_id]- # Skip if already found in short-term- if memory_id in seen_ids:+ # Apply filters+ if not self._matches_filters(memory_item, filters):continue- if memory_id in self.memory_items:- memory_item = self.memory_items[memory_id]-- # Apply filters- if not self._matches_filters(memory_item, filters):- continue-- results.append(- {- "memory_id": memory_id,- "content": memory_item.content,- "score": result.score,- "timestamp": memory_item.timestamp.isoformat(),- "metadata": memory_item.metadata,- "entities": memory_item.entities,- "relationships": memory_item.relationships,- }- )- seen_ids.add(memory_id)+ results.append(+ {+ "memory_id": memory_id,+ "content": memory_item.content,+ "score": result.score,+ "timestamp": memory_item.timestamp.isoformat(),+ "metadata": memory_item.metadata,+ "entities": memory_item.entities,+ "relationships": memory_item.relationships,+ }+ )+ seen_ids.add(memory_id)except Exception as e:self.logger.warning(f"Vector retrieval failed: {e}")diff --git a/tests/context/test_agent_memory_vector_retrieval.py b/tests/context/test_agent_memory_vector_retrieval.pynew file mode 100644index 00000000..7bd6326f--- /dev/null+++ b/tests/context/test_agent_memory_vector_retrieval.py@@ -0,0 +1,66 @@+"""AgentMemory.retrieve returns the memories a VectorStore finds (#1724)."""++import pytest++from semantica.context import AgentMemory+from semantica.vector_store import VectorStore++REACTOR = "The reactor coolant pump tripped on Tuesday"+REVENUE = "Quarterly revenue grew by twelve percent"+QUERY = "nuclear plant outage"+++def vector_store():+ return VectorStore(backend="inmemory")+++def memory(vector_store):+ memory = AgentMemory(vector_store=vector_store)+ memory.store(REACTOR)+ memory.store(REVENUE)+ return memory+++def test_retrieve_returns_vector_hits_without_keyword_overlap(memory):+ results = memory.retrieve(QUERY)++ assert REACTOR in {r["content"] for r in results}+ assert {r["memory_id"] for r in results} <= set(memory.memory_items)+++def test_retrieve_skips_vectors_that_are_not_memories(vector_store, memory):+ vector_store.store_vectors(+ vectors=[vector_store.embed("nuclear plant outage report")],+ metadata=[{"type": "decision"}],+ )++ results = memory.retrieve(QUERY)++ assert results+ assert {r["memory_id"] for r in results} <= set(memory.memory_items)+++class _IntIdStore:+ def __init__(self):+ self.vectors = []++ def embed(self, text):+ return [1.0, 1.0]++ def store_vectors(self, vectors, metadata):+ self.vectors.extend(vectors)+ return [len(self.vectors) - 1]++ def search_vectors(self, query_vector, k):+ return [{"id": i, "score": 1.0} for i in range(len(self.vectors))][:k]+++def test_retrieve_maps_integer_vector_ids():+ memory = AgentMemory(vector_store=_IntIdStore())+ memory.store(REACTOR)++ results = memory.retrieve(QUERY)++ assert [r["content"] for r in results] == [REACTOR]