Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

fix(frontend:shares): duplicate children in recurseChildrenShares

johaven09d7b6d37d00
diff --git a/frontend/src/app/applications/shares/components/dialogs/shared-children-dialog.component.ts b/frontend/src/app/applications/shares/components/dialogs/shared-children-dialog.component.ts
index 3e3c3820..0aa41c8d 100644
--- a/frontend/src/app/applications/shares/components/dialogs/shared-children-dialog.component.ts
+++ b/frontend/src/app/applications/shares/components/dialogs/shared-children-dialog.component.ts
@@ -162,20 +162,12 @@ export class SharedChildrenDialogComponent implements OnInit {
private recurseChildrenShares(shares: ShareChildModel[], parent: ShareChildModel) {
for (const s of shares) {
if (s.parentId === parent.id) {
- if (typeof parent.children === 'undefined') {
- parent.children = [s]
- } else {
- parent.children.push(s)
- }
+ parent.children = parent.children ?? []
+ parent.children.push(s)
this.recurseChildrenShares(shares, s)
- } else if (parent.id === 0) {
- if (!s.parentId) {
- if (typeof parent.children === 'undefined') {
- parent.children = [s]
- } else {
- parent.children.push(s)
- }
- }
+ } else if (parent.id === 0 && !s.parentId) {
+ parent.children = parent.children ?? []
+ parent.children.push(s)
this.recurseChildrenShares(shares, s)
}
}