Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

fix(backend:websocket): use Fastify cookie parser for authentication

johaven38dbceaeef06
diff --git a/backend/src/infrastructure/websocket/adapters/web-socket.adapter.spec.ts b/backend/src/infrastructure/websocket/adapters/web-socket.adapter.spec.ts
index 6881ffbc..ce83fafe 100644
--- a/backend/src/infrastructure/websocket/adapters/web-socket.adapter.spec.ts
+++ b/backend/src/infrastructure/websocket/adapters/web-socket.adapter.spec.ts
@@ -9,6 +9,7 @@ describe(WebSocketAdapter.name, () => {
const token = 'signed-token'
const identity = { id: 1, login: 'foo' }
let adapter: WebSocketAdapter
+ let fastify: { parseCookie: ReturnType<typeof vi.fn> }
let jwtService: { verify: ReturnType<typeof vi.fn> }
let usersManager: { fromAuthToken: ReturnType<typeof vi.fn> }
let socket: Socket
@@ -21,8 +22,12 @@ describe(WebSocketAdapter.name, () => {
usersManager = {
fromAuthToken: vi.fn(async (user: UserModel): Promise<UserModel | null> => user)
}
+ fastify = {
+ parseCookie: vi.fn(() => ({ [configuration.auth.token.ws.name]: token }))
+ }
adapter = Object.create(WebSocketAdapter.prototype)
Object.assign(adapter, {
+ fastify,
jwtService,
usersManager,
logger: {
@@ -55,6 +60,7 @@ describe(WebSocketAdapter.name, () => {
await Reflect.apply(Reflect.get(adapter, 'authenticateSocket'), adapter, [socket, next])
+ expect(fastify.parseCookie).toHaveBeenCalledWith(`${configuration.auth.token.ws.name}=${token}`)
expect(jwtService.verify).toHaveBeenCalledWith(token, {
secret: configuration.auth.token.ws.secret
})
diff --git a/backend/src/infrastructure/websocket/adapters/web-socket.adapter.ts b/backend/src/infrastructure/websocket/adapters/web-socket.adapter.ts
index e202af50..f14c26b6 100644
--- a/backend/src/infrastructure/websocket/adapters/web-socket.adapter.ts
+++ b/backend/src/infrastructure/websocket/adapters/web-socket.adapter.ts
@@ -3,7 +3,7 @@ import { JwtService } from '@nestjs/jwt'
import { NestFastifyApplication } from '@nestjs/platform-fastify'
import { IoAdapter } from '@nestjs/platform-socket.io'
import { WsException } from '@nestjs/websockets'
-import { parse } from 'cookie'
+import { type FastifyInstance } from 'fastify'
import cluster from 'node:cluster'
import { Namespace, ServerOptions, Socket } from 'socket.io'
import { USERS_WS } from '../../../applications/users/constants/websocket'
@@ -20,6 +20,7 @@ import { RedisAdapter } from './redis.adapter'
export class WebSocketAdapter extends IoAdapter {
private adapter: RedisAdapter | ClusterAdapter
private readonly app: NestFastifyApplication
+ private readonly fastify: FastifyInstance
private readonly logger: Logger = new Logger(WebSocketAdapter.name)
private readonly jwtService: JwtService
private readonly usersManager: UsersManager
@@ -27,6 +28,7 @@ export class WebSocketAdapter extends IoAdapter {
constructor(app: NestFastifyApplication) {
super(app)
this.app = app
+ this.fastify = app.getHttpAdapter().getInstance()
this.jwtService = app.get<JwtService>(JwtService)
this.usersManager = app.get<UsersManager>(UsersManager)
}
@@ -75,7 +77,7 @@ export class WebSocketAdapter extends IoAdapter {
}
private async authenticateSocket(socket: Socket, next: (err?: Error) => void) {
- const cookies = socket.request.headers.cookie ? parse(socket.request.headers.cookie) : {}
+ const cookies = socket.request.headers.cookie ? this.fastify.parseCookie(socket.request.headers.cookie) : {}
const token = cookies[configuration.auth.token.ws.name]
if (!token) {
this.onAuthError('Authorization is missing', socket, next)