Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

fix(backend:sync): update path filter length validation and add pattern length constant

johaven43554716a862
diff --git a/backend/src/applications/sync/constants/sync.ts b/backend/src/applications/sync/constants/sync.ts
index fff402e7..bc5fea08 100644
--- a/backend/src/applications/sync/constants/sync.ts
+++ b/backend/src/applications/sync/constants/sync.ts
@@ -6,7 +6,8 @@ export const SYNC_CHECKSUM_ALG = 'sha512-256'
export const SYNC_DIFF_DONE = 'done'
export const SYNC_FILE_NAME_PREFIX = '.sync-in.'
export const SYNC_MAX_PATH_FILTERS = 100
-export const SYNC_MAX_PATH_FILTER_LENGTH = 200
+export const SYNC_MAX_PATH_FILTER_LENGTH = 1024
+export const SYNC_MAX_PATH_FILTER_PATTERN_LENGTH = SYNC_MAX_PATH_FILTERS * SYNC_MAX_PATH_FILTER_LENGTH + (SYNC_MAX_PATH_FILTERS - 1)
export const SYNC_MAX_PATH_FILTER_REPETITIONS = 25
export enum SYNC_REPOSITORY {
diff --git a/backend/src/applications/sync/utils/functions.spec.ts b/backend/src/applications/sync/utils/functions.spec.ts
index f2932d7b..1f8001c3 100644
--- a/backend/src/applications/sync/utils/functions.spec.ts
+++ b/backend/src/applications/sync/utils/functions.spec.ts
@@ -1,4 +1,5 @@
import { BadRequestException } from '@nestjs/common'
+import { SYNC_MAX_PATH_FILTER_PATTERN_LENGTH } from '../constants/sync'
import { transformPathFilters } from './functions'
describe(transformPathFilters.name, () => {
@@ -16,7 +17,7 @@ describe(transformPathFilters.name, () => {
})
it('rejects path filter patterns that are too long', () => {
- const transform = () => transformPathFilters('a'.repeat(201))
+ const transform = () => transformPathFilters('a'.repeat(SYNC_MAX_PATH_FILTER_PATTERN_LENGTH + 1))
expect(transform).toThrow(BadRequestException)
expect(transform).toThrow('Path filter pattern is too long')
diff --git a/backend/src/applications/sync/utils/functions.ts b/backend/src/applications/sync/utils/functions.ts
index c3b014c4..7f9501c5 100644
--- a/backend/src/applications/sync/utils/functions.ts
+++ b/backend/src/applications/sync/utils/functions.ts
@@ -1,7 +1,7 @@
import { BadRequestException } from '@nestjs/common'
import path from 'node:path'
import safeRegex from 'safe-regex2'
-import { SYNC_FILE_NAME_PREFIX, SYNC_MAX_PATH_FILTER_LENGTH, SYNC_MAX_PATH_FILTER_REPETITIONS } from '../constants/sync'
+import { SYNC_FILE_NAME_PREFIX, SYNC_MAX_PATH_FILTER_PATTERN_LENGTH, SYNC_MAX_PATH_FILTER_REPETITIONS } from '../constants/sync'
export function getSyncTmpFilePath(rPath: string): string {
return `${path.dirname(rPath)}/${SYNC_FILE_NAME_PREFIX}${path.basename(rPath)}`
@@ -12,7 +12,7 @@ export function transformPathFilters(value: unknown): RegExp | null {
return null
}
- if (value.length > SYNC_MAX_PATH_FILTER_LENGTH) {
+ if (value.length > SYNC_MAX_PATH_FILTER_PATTERN_LENGTH) {
throw new BadRequestException('Path filter pattern is too long')
}