Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

fix(backend:websocket): allow cluster workers to exit gracefully

johaven90de7766f6da
diff --git a/backend/src/infrastructure/websocket/adapters/cluster.adapter.spec.ts b/backend/src/infrastructure/websocket/adapters/cluster.adapter.spec.ts
new file mode 100644
index 00000000..4724cdc7
--- /dev/null
+++ b/backend/src/infrastructure/websocket/adapters/cluster.adapter.spec.ts
@@ -0,0 +1,20 @@
+import { IoAdapter } from '@nestjs/platform-socket.io'
+import { ClusterAdapter } from './cluster.adapter'
+
+describe(ClusterAdapter.name, () => {
+ afterEach(() => vi.restoreAllMocks())
+
+ it('should allow NestJS to close the Socket.IO server', async () => {
+ const close = vi.fn((callback: () => void) => callback())
+ const server = { adapter: vi.fn(), close }
+ vi.spyOn(IoAdapter.prototype, 'createIOServer').mockReturnValue(server)
+ const clusterAdapter = new ClusterAdapter()
+
+ const ioServer = clusterAdapter.createIOServer(0)
+
+ expect(ioServer.close).toBe(close)
+ expect(server.adapter).toHaveBeenCalledOnce()
+ await expect(clusterAdapter.close(ioServer)).resolves.toBeUndefined()
+ expect(close).toHaveBeenCalledOnce()
+ })
+})
diff --git a/backend/src/infrastructure/websocket/adapters/cluster.adapter.ts b/backend/src/infrastructure/websocket/adapters/cluster.adapter.ts
index f55e236c..462ede84 100644
--- a/backend/src/infrastructure/websocket/adapters/cluster.adapter.ts
+++ b/backend/src/infrastructure/websocket/adapters/cluster.adapter.ts
@@ -7,8 +7,6 @@ import { ServerOptions } from 'socket.io'
export class ClusterAdapter extends IoAdapter {
createIOServer(port: number, options?: ServerOptions): any {
const server = super.createIOServer(port, options)
- // Prevent the connection from closing too early when NestJS shutdown hooks are enabled, which can cause errors on exit
- server.close = () => void 0
const adapter: ReturnType<typeof createAdapter> = createAdapter()
server.adapter(adapter)
return server