Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.
TypeScript cloud-alternativecollaborationcollaborative-editingdropboxfile-serverfile-sharingfile-storagefile-syncfull-text-searchhomelabnextcloudon-premiseopen-sourceprivacy-firstprivate-cloudrealtimesecureself-hostedstorage-serverwebdav
fix(backend:files): remove duplicate extension on compressed archives introduced by path-traversal security patch
johaven9deeafcd2cac
diff --git a/backend/src/applications/files/services/files-manager.service.ts b/backend/src/applications/files/services/files-manager.service.tsindex b3032f2d..909bae06 100644--- a/backend/src/applications/files/services/files-manager.service.ts+++ b/backend/src/applications/files/services/files-manager.service.ts@@ -480,7 +480,8 @@ export class FilesManager {// If it is used in other services in the future, make sure to refactor accordingly to sanitize inputs properly.const srcPath = dirName(space.realPath)// todo: a guest link tasksPath should be in specific directory (guest link has no home)- const dstPath = await uniqueFilePathFromDir(path.join(dto.compressInDirectory ? srcPath : user.tasksPath, `${dto.name}.${dto.extension}`))+ const archiveExt = dto.name.endsWith(dto.extension) ? '' : `.${dto.extension}`+ const dstPath = await uniqueFilePathFromDir(path.join(dto.compressInDirectory ? srcPath : user.tasksPath, `${dto.name}${archiveExt}`))const archive: Archiver = archiver('tar', {gzip: dto.extension === tarGzExtension,gzipOptions: {