Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

perf(backend:files): disable sharp cache

7185a4b94a1ba02b
diff --git a/backend/src/applications/files/services/files-manager.service.ts b/backend/src/applications/files/services/files-manager.service.ts
index cb46d033..c413a698 100644
--- a/backend/src/applications/files/services/files-manager.service.ts
+++ b/backend/src/applications/files/services/files-manager.service.ts
@@ -10,6 +10,7 @@ import archiver, { Archiver, ArchiverError } from 'archiver'
import { AxiosResponse } from 'axios'
import fs from 'node:fs'
import path from 'node:path'
+import { Readable } from 'node:stream'
import { pipeline } from 'node:stream/promises'
import { extract as extractTar } from 'tar'
import { FastifyAuthenticatedRequest } from '../../../authentication/interfaces/auth-request.interface'
@@ -573,7 +574,7 @@ export class FilesManager {
}
}
- async generateThumbnail(space: SpaceEnv, size: number): Promise<Buffer> {
+ async generateThumbnail(space: SpaceEnv, size: number): Promise<Readable> {
if (!(await isPathExists(space.realPath))) {
throw new FileError(HttpStatus.NOT_FOUND, 'Location not found')
}
diff --git a/backend/src/applications/files/services/files-methods.service.ts b/backend/src/applications/files/services/files-methods.service.ts
index 4db053bf..0f369a91 100644
--- a/backend/src/applications/files/services/files-methods.service.ts
+++ b/backend/src/applications/files/services/files-methods.service.ts
@@ -7,7 +7,6 @@
import { HttpException, HttpStatus, Injectable, Logger, StreamableFile } from '@nestjs/common'
import { FastifyReply } from 'fastify'
import path from 'node:path'
-import { Readable } from 'node:stream'
import { pngMimeType } from '../../../common/image'
import { FastifySpaceRequest } from '../../spaces/interfaces/space-request.interface'
import { SpaceEnv } from '../../spaces/models/space-env.model'
@@ -149,7 +148,7 @@ export class FilesMethods {
async genThumbnail(space: SpaceEnv, size: number): Promise<StreamableFile> {
try {
- const pngStream = Readable.from(await this.filesManager.generateThumbnail(space, size))
+ const pngStream = await this.filesManager.generateThumbnail(space, size)
return new StreamableFile(pngStream, { type: pngMimeType })
} catch (e) {
this.handleError(space, this.genThumbnail.name, e)
diff --git a/backend/src/common/image.ts b/backend/src/common/image.ts
index fb7aeb3c..fd311d30 100644
--- a/backend/src/common/image.ts
+++ b/backend/src/common/image.ts
@@ -4,16 +4,18 @@
* See the LICENSE file for licensing details
*/
-import sharp from 'sharp'
import { Resvg } from '@resvg/resvg-js'
import fs from 'node:fs/promises'
import path from 'node:path'
+import { Readable } from 'node:stream'
+import sharp from 'sharp'
export const pngMimeType = 'image/png'
export const svgMimeType = 'image/svg+xml'
+sharp.cache(false)
-export async function generateThumbnail(filePath: string, size: number) {
- const image = sharp(filePath).rotate()
+export async function generateThumbnail(filePath: string, size: number): Promise<Readable> {
+ const image = sharp(filePath, { autoOrient: true })
let { width, height } = await image.metadata()
if (!width || !height) throw new Error('Invalid image dimensions')
@@ -31,7 +33,7 @@ export async function generateThumbnail(filePath: string, size: number) {
}
}
- return image.resize(width, height, { fit: 'inside' }).png({ compressionLevel: 0 }).toBuffer()
+ return image.resize(width, height, { fit: 'inside' }).png({ compressionLevel: 0 })
}
export async function generateAvatar(initials: string): Promise<Buffer> {