Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.
TypeScript cloud-alternativecollaborationcollaborative-editingdropboxfile-serverfile-sharingfile-storagefile-syncfull-text-searchhomelabnextcloudon-premiseopen-sourceprivacy-firstprivate-cloudrealtimesecureself-hostedstorage-serverwebdav
chore(backend:files): improve downloadFile typing with getContentInfo overload
johavenb7f373deb633
diff --git a/backend/src/applications/files/interfaces/download-file.interface.ts b/backend/src/applications/files/interfaces/download-file.interface.tsnew file mode 100644index 00000000..8cb6487d--- /dev/null+++ b/backend/src/applications/files/interfaces/download-file.interface.ts@@ -0,0 +1,12 @@+import type { SpaceEnv } from '../../spaces/models/space-env.model'++export interface DownloadFileContentInfo {+ contentLength: number | null+ contentType: string+ lastModified: string | undefined+}++export interface DownloadFileOptions {+ space?: SpaceEnv+ getContentInfo?: boolean+}diff --git a/backend/src/applications/files/utils/download-file.ts b/backend/src/applications/files/utils/download-file.tsindex 9ef5f998..9dd89215 100644--- a/backend/src/applications/files/utils/download-file.ts+++ b/backend/src/applications/files/utils/download-file.ts@@ -7,7 +7,8 @@ import { HttpStatus } from '@nestjs/common'import { FileTaskEvent } from '../events/file-events'import { FILE_OPERATION } from '../constants/operations'import { writeFromStream } from './files'-import { DownloadFileDto } from '../dto/file-operations.dto'+import type { DownloadFileDto } from '../dto/file-operations.dto'+import type { DownloadFileContentInfo, DownloadFileOptions } from '../interfaces/download-file.interface'const parts = [// IPv4 loopback (127.0.0.0/8)@@ -39,8 +40,20 @@ export async function downloadFile(http: HttpService,downloadDto: DownloadFileDto,dstPath: string,- options?: { space?: SpaceEnv; getContentInfo?: boolean }-) {+ options: { space?: SpaceEnv; getContentInfo: true }+): Promise<DownloadFileContentInfo>+export async function downloadFile(+ http: HttpService,+ downloadDto: DownloadFileDto,+ dstPath: string,+ options?: { space?: SpaceEnv; getContentInfo?: false | undefined }+): Promise<void>+export async function downloadFile(+ http: HttpService,+ downloadDto: DownloadFileDto,+ dstPath: string,+ options?: DownloadFileOptions+): Promise<void | DownloadFileContentInfo> {// dto must be validated by the callerconst headRes: AxiosResponse = await http.axiosRef({ method: HTTP_METHOD.HEAD, url: downloadDto.url, maxRedirects: 1 })if (regExpPrivateIP.test(headRes.request.socket.remoteAddress)) {@@ -51,7 +64,11 @@ export async function downloadFile(// attempt to retrieve the Content-Length headerconst contentLength = 'content-length' in headRes.headers ? Number(headRes.headers['content-length']) || null : nullif (options?.getContentInfo) {- return { contentLength: contentLength, contentType: `${headRes.headers['content-type']}`, lastModified: headRes.headers['last-modified'] }+ return {+ contentLength: contentLength,+ contentType: `${headRes.headers['content-type']}`,+ lastModified: headRes.headers['last-modified'] as string | undefined+ } satisfies DownloadFileContentInfo}if (!contentLength) {