Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

fix(backend:config): do not lowercase env var values

johavencb73ab028734
diff --git a/backend/src/app.service.spec.ts b/backend/src/app.service.spec.ts
index 518e2e1d..da198fcd 100644
--- a/backend/src/app.service.spec.ts
+++ b/backend/src/app.service.spec.ts
@@ -53,19 +53,19 @@ describe(AppService.name, () => {
expect(conf.logger.stdout).toBe(true)
expect(conf.logger.colorize).toBe(true)
const tmpSecretFile = path.join(os.tmpdir(), 'secret')
- fs.writeFileSync(tmpSecretFile, 'foobar8888')
- process.env[`${ENVIRONMENT_PREFIX}APPLICATIONS_FILES_ONLYOFFICE_SECRET`] = 'foobar'
+ fs.writeFileSync(tmpSecretFile, 'fooBAR8888')
+ process.env[`${ENVIRONMENT_PREFIX}APPLICATIONS_FILES_ONLYOFFICE_SECRET`] = 'fooBAR'
process.env[`${ENVIRONMENT_PREFIX}LOGGER_STDOUT`] = 'false'
process.env[`${ENVIRONMENT_PREFIX}LOGGER_COLORIZE`] = '"false"'
process.env[`${ENVIRONMENT_PREFIX}APPLICATIONS_FILES_MAXUPLOADSIZE`] = '8888'
// docker compose secret file
process.env[`${ENVIRONMENT_PREFIX}AUTH_TOKEN_ACCESS_SECRET_FILE`] = tmpSecretFile
conf = exportConfiguration(true)
- expect(conf.applications.files.onlyoffice.secret).toBe('foobar')
+ expect(conf.applications.files.onlyoffice.secret).toBe('fooBAR')
expect(conf.logger.stdout).toBe(false)
expect(conf.logger.colorize).toBe(false)
expect(conf.applications.files.maxUploadSize).toBe(8888)
- expect(conf.auth.token.access.secret).toBe('foobar8888')
+ expect(conf.auth.token.access.secret).toBe('fooBAR8888')
// cleanup secret file
fs.promises.rm(tmpSecretFile, { force: true }).catch((e) => {
console.error(e)
diff --git a/backend/src/configuration/config.loader.ts b/backend/src/configuration/config.loader.ts
index dd712a60..ea3e11e0 100644
--- a/backend/src/configuration/config.loader.ts
+++ b/backend/src/configuration/config.loader.ts
@@ -73,8 +73,8 @@ function hasEnvConfig(): boolean {
* Parse a raw env-string into boolean, number or leave as string.
*/
function parseEnvValue(value: string): any {
- // remove quotes & convert to lowercase
- value = value.replace(/^"+|"+$/g, '').toLowerCase()
+ // remove first and last quote if exists
+ value = value.replace(/^"(.*)"$/, '$1')
if (value === 'true') return true
if (value === 'false') return false
if (!isNaN(Number(value))) return Number(value)