Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.
TypeScript cloud-alternativecollaborationcollaborative-editingdropboxfile-serverfile-sharingfile-storagefile-syncfull-text-searchhomelabnextcloudon-premiseopen-sourceprivacy-firstprivate-cloudrealtimesecureself-hostedstorage-serverwebdav
fix(backend:users): sanitize group and app password names for safe route params
johavend1b21a80032e
diff --git a/backend/src/applications/users/dto/create-or-update-group.dto.ts b/backend/src/applications/users/dto/create-or-update-group.dto.tsindex 17c14dd8..5a36b644 100644--- a/backend/src/applications/users/dto/create-or-update-group.dto.ts+++ b/backend/src/applications/users/dto/create-or-update-group.dto.ts@@ -1,11 +1,13 @@import { Transform } from 'class-transformer'-import { IsEnum, IsInt, IsOptional, IsString } from 'class-validator'+import { IsEnum, IsInt, IsOptional, IsString, MinLength } from 'class-validator'+import { sanitizeName } from '../../files/utils/files'import { GROUP_VISIBILITY } from '../constants/group'export class UserCreateOrUpdateGroupDto {@IsOptional()@IsString()- @Transform(({ value }) => (value ? value.trim() : ''))+ @Transform(({ value }) => (value ? sanitizeName(value.trim()) : ''))+ @MinLength(1)name?: string@IsOptional()diff --git a/backend/src/applications/users/services/users-manager.service.ts b/backend/src/applications/users/services/users-manager.service.tsindex 1e13e217..473f408c 100755--- a/backend/src/applications/users/services/users-manager.service.ts+++ b/backend/src/applications/users/services/users-manager.service.ts@@ -14,7 +14,7 @@ import { comparePassword, hashPassword } from '../../../common/functions'import { generateAvatar, pngMimeType, svgMimeType } from '../../../common/image'import { createLightSlug, genPassword } from '../../../common/shared'import { configuration, serverConfig } from '../../../configuration/config.environment'-import { isPathExists, moveFiles } from '../../files/utils/files'+import { isPathExists, moveFiles, sanitizeName } from '../../files/utils/files'import { NOTIFICATION_APP, NOTIFICATION_APP_EVENT } from '../../notifications/constants/notifications'import { NotificationsManager } from '../../notifications/services/notifications-manager.service'import { GROUP_TYPE } from '../constants/group'@@ -234,14 +234,15 @@ export class UsersManager {async generateAppPassword(user: UserModel, userAppPasswordDto: UserAppPasswordDto): Promise<UserAppPassword> {const secrets = await this.usersQueries.getUserSecrets(user.id)- const slugName = createLightSlug(userAppPasswordDto.name)+ const slugName = createLightSlug(sanitizeName(userAppPasswordDto.name))+ if (!slugName) throw new HttpException('Invalid name', HttpStatus.BAD_REQUEST)if (Array.isArray(secrets.appPasswords) && secrets.appPasswords.find((p: UserAppPassword) => p.name === slugName)) {throw new HttpException('Name already used', HttpStatus.BAD_REQUEST)}secrets.appPasswords = Array.isArray(secrets.appPasswords) ? secrets.appPasswords : []const clearPassword = genPassword(24)const appPassword: UserAppPassword = {- name: createLightSlug(userAppPasswordDto.name),+ name: slugName,app: userAppPasswordDto.app,expiration: userAppPasswordDto.expiration,password: await hashPassword(clearPassword),