Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.
TypeScript cloud-alternativecollaborationcollaborative-editingdropboxfile-serverfile-sharingfile-storagefile-syncfull-text-searchhomelabnextcloudon-premiseopen-sourceprivacy-firstprivate-cloudrealtimesecureself-hostedstorage-serverwebdav
test(backend:comments): improve coverage of comments-controller.spec.ts
johavene188840905b6
diff --git a/backend/src/applications/comments/comments.controller.spec.ts b/backend/src/applications/comments/comments.controller.spec.tsindex 789edb99..c81713a8 100644--- a/backend/src/applications/comments/comments.controller.spec.ts+++ b/backend/src/applications/comments/comments.controller.spec.ts@@ -21,7 +21,22 @@ import { CommentsManager } from './services/comments-manager.service'import { CommentsQueries } from './services/comments-queries.service'describe(CommentsController.name, () => {- let controller: CommentsController+ let commentsController: CommentsController+ let commentsManager: jest.Mocked<CommentsManager>++ const user: any = { id: 'user-1' }+ const space: any = { id: 'space-1' }++ const commentsSample = [{ id: 'c1' }, { id: 'c2' }] as any+ const commentSample = { id: 'c1', text: 'hello' } as any++ const commentsManagerMock: jest.Mocked<CommentsManager> = {+ getComments: jest.fn(),+ createComment: jest.fn(),+ updateComment: jest.fn(),+ deleteComment: jest.fn(),+ getRecents: jest.fn()+ } as anybeforeAll(async () => {const module: TestingModule = await Test.createTestingModule({@@ -31,7 +46,7 @@ describe(CommentsController.name, () => {{ provide: DB_TOKEN_PROVIDER, useValue: {} },{ provide: Cache, useValue: {} },ContextManager,- CommentsManager,+ { provide: CommentsManager, useValue: commentsManagerMock },CommentsQueries,SpacesManager,SpacesQueries,@@ -43,10 +58,81 @@ describe(CommentsController.name, () => {]}).compile()- controller = module.get<CommentsController>(CommentsController)+ commentsController = module.get<CommentsController>(CommentsController)+ commentsManager = module.get(CommentsManager)+ })++ beforeEach(() => {+ jest.clearAllMocks()})it('should be defined', () => {- expect(controller).toBeDefined()+ expect(commentsController).toBeDefined()+ })++ it('getFromSpace calls CommentsManager.getComments and returns the list', async () => {+ commentsManager.getComments.mockResolvedValueOnce(commentsSample)++ const res = await commentsController.getFromSpace(user, space)++ expect(commentsManager.getComments).toHaveBeenCalledTimes(1)+ expect(commentsManager.getComments).toHaveBeenCalledWith(user, space)+ expect(res).toEqual(commentsSample)+ })++ it('createFromSpace calls CommentsManager.createComment and returns the created comment', async () => {+ const dto: any = { text: 'new comment' }+ commentsManager.createComment.mockResolvedValueOnce(commentSample)++ const res = await commentsController.createFromSpace(user, space, dto)++ expect(commentsManager.createComment).toHaveBeenCalledTimes(1)+ expect(commentsManager.createComment).toHaveBeenCalledWith(user, space, dto)+ expect(res).toEqual(commentSample)+ })++ it('updateFromSpace calls CommentsManager.updateComment and returns the updated comment', async () => {+ const dto: any = { id: 'c1', text: 'updated' }+ const updated = { id: 'c1', text: 'updated' } as any+ commentsManager.updateComment.mockResolvedValueOnce(updated)++ const res = await commentsController.updateFromSpace(user, space, dto)++ expect(commentsManager.updateComment).toHaveBeenCalledTimes(1)+ expect(commentsManager.updateComment).toHaveBeenCalledWith(user, space, dto)+ expect(res).toEqual(updated)+ })++ it('deleteFromSpace calls CommentsManager.deleteComment', async () => {+ const dto: any = { id: 'c1' }+ commentsManager.deleteComment.mockResolvedValueOnce(undefined)++ await expect(commentsController.deleteFromSpace(user, space, dto)).resolves.toBeUndefined()++ expect(commentsManager.deleteComment).toHaveBeenCalledTimes(1)+ expect(commentsManager.deleteComment).toHaveBeenCalledWith(user, space, dto)+ })++ it('getRecents calls CommentsManager.getRecents with the provided limit', async () => {+ const recents = [{ id: 'r1' }] as any+ commentsManager.getRecents.mockResolvedValueOnce(recents)++ const res = await commentsController.getRecents(user, 5 as any)++ expect(commentsManager.getRecents).toHaveBeenCalledTimes(1)+ expect(commentsManager.getRecents).toHaveBeenCalledWith(user, 5)+ expect(res).toEqual(recents)+ })++ it('getRecents uses the default limit (10) when not provided', async () => {+ const recents = [{ id: 'r2' }] as any+ commentsManager.getRecents.mockResolvedValueOnce(recents)++ // Call with undefined to trigger the parameter default value+ const res = await commentsController.getRecents(user, undefined as any)++ expect(commentsManager.getRecents).toHaveBeenCalledTimes(1)+ expect(commentsManager.getRecents).toHaveBeenCalledWith(user, 10)+ expect(res).toEqual(recents)})})