Skip to content

Sync-in · Sovereign platform for file storage, sharing, synchronization, and collaboration.

fix(frontend:drag): prevent drag-and-drop actions in the shares list and ensure proper drag event handling

johavenf19ab4f7ed97
diff --git a/frontend/src/app/applications/spaces/components/spaces-browser.component.ts b/frontend/src/app/applications/spaces/components/spaces-browser.component.ts
index fb1a993e..2bd11979 100644
--- a/frontend/src/app/applications/spaces/components/spaces-browser.component.ts
+++ b/frontend/src/app/applications/spaces/components/spaces-browser.component.ts
@@ -835,7 +835,7 @@ export class SpacesBrowserComponent implements OnInit, AfterViewInit, OnDestroy
private initEventHandlers() {
this.zone.runOutsideAngular(() => {
this.eventDragOverHandler = this.renderer.listen(this.scrollView.element.nativeElement, 'dragover', (ev): boolean | void => {
- if (this.isTrashRepo && !this.moveFromDrag) {
+ if (this.inSharesList || (this.isTrashRepo && !this.moveFromDrag)) {
ev.preventDefault()
return false
}
@@ -849,6 +849,9 @@ export class SpacesBrowserComponent implements OnInit, AfterViewInit, OnDestroy
}
})
this.eventDragStartHandler = this.renderer.listen(this.scrollView.element.nativeElement, 'dragstart', (ev) => {
+ if (this.inSharesList) {
+ ev.preventDefault()
+ }
if (ev.target.parentElement.nodeName === 'TD' || ev.target.parentElement.nodeName === 'DIV') {
const f: FileModel =
this.scrollView.viewPortItems[
@@ -893,7 +896,7 @@ export class SpacesBrowserComponent implements OnInit, AfterViewInit, OnDestroy
this.moveFromDrag = false
})
this.eventDropHandler = this.renderer.listen(this.scrollView.element.nativeElement, 'drop', (ev): boolean | void => {
- if (this.isTrashRepo && !this.moveFromDrag) {
+ if (this.inSharesList || (this.isTrashRepo && !this.moveFromDrag)) {
ev.preventDefault()
return false
}
diff --git a/frontend/src/app/layout/layout.component.ts b/frontend/src/app/layout/layout.component.ts
index 4e48aa88..69ba9088 100644
--- a/frontend/src/app/layout/layout.component.ts
+++ b/frontend/src/app/layout/layout.component.ts
@@ -48,6 +48,16 @@ export class LayoutComponent implements OnDestroy {
}
}
+ @HostListener('dragover', ['$event'])
+ onDragOver(event: DragEvent) {
+ event.preventDefault()
+ }
+
+ @HostListener('drop', ['$event'])
+ onDrop(event: DragEvent) {
+ event.preventDefault()
+ }
+
toggleLeftSideBar(status: number) {
// 1: open / 2: collapse / 3: toggle
if (status === 1) {