Skip to content

SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.

refactor(query-builder): drop stale bar-panel data-source override (#13218)

Abhi kumar0036cda4f18a
diff --git a/frontend/src/components/QueryBuilderV2/QueryBuilderV2.tsx b/frontend/src/components/QueryBuilderV2/QueryBuilderV2.tsx
index 98065e7f66..486fd1488a 100644
--- a/frontend/src/components/QueryBuilderV2/QueryBuilderV2.tsx
+++ b/frontend/src/components/QueryBuilderV2/QueryBuilderV2.tsx
@@ -1,14 +1,9 @@
import { memo, useCallback, useEffect, useMemo, useRef } from 'react';
import { TelemetrytypesSignalDTO } from 'api/generated/services/sigNoz.schemas';
-import { PANEL_TYPES } from 'constants/queryBuilder';
import { Formula } from 'container/QueryBuilder/components/Formula';
import { QueryBuilderProps } from 'container/QueryBuilder/QueryBuilder.interfaces';
import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';
-import { getBuilderVariant } from 'lib/query/queryMode';
-import {
- BuilderVariant,
- IBuilderTraceOperator,
-} from 'types/api/queryBuilder/queryBuilderData';
+import { IBuilderTraceOperator } from 'types/api/queryBuilder/queryBuilderData';
import { DataSource } from 'types/common/queryBuilder';
import { QueryBuilderField } from './queryBuilderFields.types';
@@ -64,20 +59,8 @@ export const QueryBuilderV2 = memo(function QueryBuilderV2({
[config],
);
- const isAIQuery =
- getBuilderVariant(currentQuery.builder) === BuilderVariant.AI;
-
useEffect(() => {
if (currentDataSource !== initialDataSource || newPanelType !== panelType) {
- // AI queries are traces-only; BAR must not force metrics on them.
- if (isAIQuery) {
- handleSetConfig(newPanelType, DataSource.TRACES);
- return;
- }
- if (newPanelType === PANEL_TYPES.BAR) {
- handleSetConfig(PANEL_TYPES.BAR, DataSource.METRICS);
- return;
- }
handleSetConfig(newPanelType, currentDataSource);
}
}, [
@@ -86,7 +69,6 @@ export const QueryBuilderV2 = memo(function QueryBuilderV2({
initialDataSource,
currentDataSource,
newPanelType,
- isAIQuery,
]);
useEffect(() => {
diff --git a/frontend/src/components/QueryBuilderV2/__tests__/QueryBuilderV2.config.test.tsx b/frontend/src/components/QueryBuilderV2/__tests__/QueryBuilderV2.config.test.tsx
new file mode 100644
index 0000000000..95ad5e3ad2
--- /dev/null
+++ b/frontend/src/components/QueryBuilderV2/__tests__/QueryBuilderV2.config.test.tsx
@@ -0,0 +1,109 @@
+import { initialQueriesMap, PANEL_TYPES } from 'constants/queryBuilder';
+import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';
+import { render } from 'tests/test-utils';
+import { QueryMode } from 'types/api/queryBuilder/queryBuilderData';
+import type { Query } from 'types/api/queryBuilder/queryBuilderData';
+import { DataSource } from 'types/common/queryBuilder';
+
+import { QueryBuilderV2 } from '../QueryBuilderV2';
+
+jest.mock('hooks/queryBuilder/useQueryBuilder');
+jest.mock('../QueryV2/QueryV2', () => ({ QueryV2: (): null => null }));
+jest.mock('../QueryV2/QueryFooter/QueryFooter', () => (): null => null);
+
+const mockedUseQueryBuilder = jest.mocked(useQueryBuilder);
+
+const aiQuery: Query = {
+ ...initialQueriesMap.traces,
+ builder: {
+ ...initialQueriesMap.traces.builder,
+ queryData: initialQueriesMap.traces.builder.queryData.map((query) => ({
+ ...query,
+ builderQueryType: QueryMode.AI_QUERY_BUILDER,
+ })),
+ },
+};
+
+function mockContext({
+ panelType = null,
+ initialDataSource = null,
+ currentQuery = initialQueriesMap.metrics,
+}: {
+ panelType?: PANEL_TYPES | null;
+ initialDataSource?: DataSource | null;
+ currentQuery?: Query;
+}): jest.Mock {
+ const handleSetConfig = jest.fn();
+ mockedUseQueryBuilder.mockReturnValue({
+ currentQuery,
+ panelType,
+ initialDataSource,
+ handleSetConfig,
+ addNewBuilderQuery: jest.fn(),
+ addNewFormula: jest.fn(),
+ addTraceOperator: jest.fn(),
+ handleRunQuery: jest.fn(),
+ } as unknown as ReturnType<typeof useQueryBuilder>);
+ return handleSetConfig;
+}
+
+describe('QueryBuilderV2 provider config sync', () => {
+ it('leaves the data source unset for a bar panel without a static config', () => {
+ const handleSetConfig = mockContext({});
+
+ render(<QueryBuilderV2 panelType={PANEL_TYPES.BAR} version="v3" />);
+
+ expect(handleSetConfig).toHaveBeenCalledWith(PANEL_TYPES.BAR, null);
+ });
+
+ it('syncs the static data source', () => {
+ const handleSetConfig = mockContext({});
+
+ render(
+ <QueryBuilderV2
+ version="v3"
+ panelType={PANEL_TYPES.BAR}
+ config={{ initialDataSource: DataSource.LOGS, queryVariant: 'static' }}
+ />,
+ );
+
+ expect(handleSetConfig).toHaveBeenCalledWith(
+ PANEL_TYPES.BAR,
+ DataSource.LOGS,
+ );
+ });
+
+ it('keeps an AI query on traces for a bar panel', () => {
+ const handleSetConfig = mockContext({ currentQuery: aiQuery });
+
+ render(
+ <QueryBuilderV2
+ version="v3"
+ panelType={PANEL_TYPES.BAR}
+ config={{ initialDataSource: DataSource.TRACES, queryVariant: 'static' }}
+ />,
+ );
+
+ expect(handleSetConfig).toHaveBeenCalledWith(
+ PANEL_TYPES.BAR,
+ DataSource.TRACES,
+ );
+ });
+
+ it('does not reset the config when the provider already matches', () => {
+ const handleSetConfig = mockContext({
+ panelType: PANEL_TYPES.TIME_SERIES,
+ initialDataSource: DataSource.TRACES,
+ });
+
+ render(
+ <QueryBuilderV2
+ version="v3"
+ panelType={PANEL_TYPES.TIME_SERIES}
+ config={{ initialDataSource: DataSource.TRACES, queryVariant: 'static' }}
+ />,
+ );
+
+ expect(handleSetConfig).not.toHaveBeenCalled();
+ });
+});