SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.
TypeScript apmapplication-monitoringdistributed-tracinggogood-first-issuejaegerloglogsmetricsmonitoringnextjsobservabilityopen-sourceopentelemetryprometheusreactreactjsself-hostedtracingtypescript
feat(saved-views): saved views and quick filters VQA fixes (#13232)
Aditya Singh070343a6c016
diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/constants.ts b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/constants.tsnew file mode 100644index 0000000000..a297289e06--- /dev/null+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/constants.ts@@ -0,0 +1 @@+export const DEFAULT_VISIBLE_ITEMS_COUNT = 10;diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/useCheckboxDisclosure.ts b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/useCheckboxDisclosure.tsindex 6e38d50794..2b65138782 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/useCheckboxDisclosure.ts+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/useCheckboxDisclosure.ts@@ -2,10 +2,9 @@ import { useMemo, useState } from 'react';import { IQuickFiltersConfig } from 'components/QuickFilters/types';import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';+import { DEFAULT_VISIBLE_ITEMS_COUNT } from './constants';import { isKeyMatch } from './utils';-const DEFAULT_VISIBLE_ITEMS_COUNT = 10;-interface UseCheckboxDisclosureProps {filter: IQuickFiltersConfig;activeQueryIndex: number;diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.module.scss b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.module.scssindex eaeb60a44f..7567b88fbe 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.module.scss+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.module.scss@@ -6,44 +6,6 @@border-bottom: 1px solid var(--l1-border);}-.sectionActions {- width: 0;- overflow: hidden;- opacity: 0;- transform: translateX(4px);- pointer-events: none;- transition:- opacity 0.16s ease,- transform 0.16s ease,- width 0s linear 0.16s;-}--.checkboxFilter:hover .sectionActions,-.sectionActions.sectionActionsPinned {- width: auto;- opacity: 1;- transform: translateX(0);- pointer-events: auto;- transition:- opacity 0.16s ease,- transform 0.16s ease;-}--.sectionActionsPinned .sectionActionHoverOnly {- opacity: 0;- transform: translateX(4px);- pointer-events: none;- transition:- opacity 0.16s ease,- transform 0.16s ease;-}--.checkboxFilter:hover .sectionActionsPinned .sectionActionHoverOnly {- opacity: 1;- transform: translateX(0);- pointer-events: auto;-}-.search {--input-background: var(--l2-background);--input-hover-background: var(--l2-background);diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.testUtils.tsx b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.testUtils.tsxindex a3ed683d93..28ae5a17f3 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.testUtils.tsx+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.testUtils.tsx@@ -11,6 +11,7 @@ import {QuickFiltersSource,} from '../../../types';import CheckboxFilterV2 from './CheckboxFilterV2';+import { DEFAULT_VISIBLE_ITEMS_COUNT } from '../constants';export const DEFAULT_FILTER: IQuickFiltersConfig = {type: FiltersType.CHECKBOX,@@ -30,6 +31,13 @@ export const DEFAULT_USE_FIELD_APIS: QuickFilterCheckboxUseFieldApis = {existingQuery: null,};+// Enough extra values to push a section past the count that shows its search box.+// Named to sort last, so a test's own values stay within the first page.+export const EXTRA_VALUES = Array.from(+ { length: DEFAULT_VISIBLE_ITEMS_COUNT },+ (_, index) => `zz-extra-value-${index + 1}`,+);+export function mockFieldsValuesAPI(response: {relatedValues?: (string | null)[];stringValues?: (string | null)[];diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.tsx b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.tsxindex c8d2a1640f..af27037cef 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.tsx+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2.tsx@@ -1,7 +1,6 @@import { useEffect, useMemo, useRef, useState } from 'react';import { Input } from '@signozhq/ui/input';import { Skeleton } from 'antd';-import classNames from 'classnames';import { Typography } from '@signozhq/ui/typography';import { LoaderCircle } from '@signozhq/icons';import {@@ -17,6 +16,7 @@ import { Query } from 'types/api/queryBuilder/queryBuilderData';import { NON_SELECTED_OPERATORS } from '../checkboxFilterQuery';import useActiveQueryIndex from 'components/QuickFilters/hooks/useActiveQueryIndex';+import { DEFAULT_VISIBLE_ITEMS_COUNT } from '../constants';import useCheckboxDisclosure from '../useCheckboxDisclosure';import useCheckboxFilterActions from '../useCheckboxFilterActions';import useCheckboxFilterState from '../useCheckboxFilterState';@@ -45,14 +45,8 @@ export default function CheckboxFilterV2(const { source, filter, onFilterChange, onQuickFilterChange, useFieldApis } =props;const [searchText, setSearchText] = useState<string>('');- const [isSearchOpen, setIsSearchOpen] = useState<boolean>(false);const [userToggleState, setUserToggleState] = useState<boolean | null>(null);- const handleToggleSearch = (): void => {- setIsSearchOpen((prev) => !prev);- setSearchText('');- };-const { currentQuery } = useQueryBuilder();const activeQueryIndex = useActiveQueryIndex(source);@@ -121,6 +115,14 @@ export default function CheckboxFilterV2(setSearchText(args[0] as string);}, DEBOUNCE_DELAY);+ const handleToggleOpen = (): void => {+ if (isOpen) {+ setSearchTextDebounced.cancel();+ setSearchText('');+ }+ onToggleOpen();+ };+const currentFilterOp = useMemo(() => {const filterSync = currentQuery?.builder.queryData?.[activeQueryIndex@@ -166,19 +168,22 @@ export default function CheckboxFilterV2(relatedExclusions,});+ // Kept while a search is typed, so narrowing the list does not remove the box,+ // and while a refetch still shows the previous, narrowed results.+ const wasSearchShown = useRef(false);+ const isSearchShown =+ searchText !== '' ||+ totalCount > DEFAULT_VISIBLE_ITEMS_COUNT ||+ (isFetching && wasSearchShown.current);+ wasSearchShown.current = isSearchShown;+return (<div className={styles.checkboxFilter} data-testid="checkbox-filter-v2"><CheckboxFilterV2Headertitle={filter.title}isOpen={isOpen}- actionsClassName={classNames(styles.sectionActions, {- [styles.sectionActionsPinned]: isSearchOpen,- })}- resetActionClassName={- isSearchOpen ? styles.sectionActionHoverOnly : undefined- }- onToggleOpen={onToggleOpen}- onToggleSearch={handleToggleSearch}+ canReset={isSomeFilterPresentForCurrentAttribute}+ onToggleOpen={handleToggleOpen}onClear={onClear}/>{isOpen && isLoading && !hasLoadedOnce.current && (@@ -188,10 +193,9 @@ export default function CheckboxFilterV2()}{isOpen && (!isLoading || hasLoadedOnce.current) && (<>- {isSearchOpen && (+ {isSearchShown && (<section className={styles.search}><Input- autoFocusplaceholder="Filter values"onChange={(e): void => setSearchTextDebounced(e.target.value)}disabled={isFilterDisabled}diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2Header.tsx b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2Header.tsxindex 0361288536..8d4cc12dc2 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2Header.tsx+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/CheckboxFilterV2Header.tsx@@ -1,31 +1,25 @@import { useState } from 'react';import { Tooltip } from '@signozhq/ui/tooltip';import { Typography } from '@signozhq/ui/typography';-import { ChevronDown, ChevronRight, Search, Undo2 } from '@signozhq/icons';+import { ChevronDown, ChevronRight, Undo2 } from '@signozhq/icons';import { SectionActionButton } from '../../shared/SectionActionButton/SectionActionButton';-import classNames from 'classnames';-import styles from './CheckboxFilterV2Header.module.scss';interface CheckboxFilterHeaderProps {title: string;isOpen: boolean;- actionsClassName?: string;- resetActionClassName?: string;+ canReset: boolean;onToggleOpen: () => void;- onToggleSearch: () => void;onClear: () => void;}export function CheckboxFilterV2Header({title,isOpen,- actionsClassName,- resetActionClassName,+ canReset,onToggleOpen,- onToggleSearch,onClear,}: CheckboxFilterHeaderProps): JSX.Element {const [isTitleTruncated, setIsTitleTruncated] = useState(false);@@ -64,21 +58,14 @@ export function CheckboxFilterV2Header({)}<Tooltip title={isTitleTruncated ? title : undefined}>{titleText}</Tooltip></section>- {isOpen && (- <section className={classNames(styles.rightAction, actionsClassName)}>+ {isOpen && canReset && (+ <section className={styles.rightAction}><SectionActionButtonicon={<Undo2 size={14} />}- className={resetActionClassName}tooltip="Reset"onClick={onClear}testId="checkbox-filter-clear-all"/>- <SectionActionButton- icon={<Search size={14} />}- tooltip="Search"- onClick={onToggleSearch}- testId="checkbox-filter-search-toggle"- /></section>)}</section>diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.interactions.test.tsx b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.interactions.test.tsxindex e249b50bb6..7daf8b71c6 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.interactions.test.tsx+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.interactions.test.tsx@@ -10,6 +10,7 @@ import {buildQueryBuilderOverrides,DEFAULT_FILTER,DEFAULT_USE_FIELD_APIS,+ EXTRA_VALUES,getFilterFromCall,mockFieldsValuesAPI,renderWithFilter,@@ -49,7 +50,7 @@ describe('CheckboxFilterV2 - interactions', () => {const values =searchTextReceived === ''- ? ['production', 'staging', 'development']+ ? ['production', 'staging', 'development', ...EXTRA_VALUES]: ['production'];return res(@@ -79,7 +80,6 @@ describe('CheckboxFilterV2 - interactions', () => {await screen.findByTestId('checkbox-value-row-production');expect(screen.getByTestId('checkbox-value-row-staging')).toBeInTheDocument();- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));const searchInput = screen.getByTestId('checkbox-filter-search');await user.type(searchInput, 'prod');@@ -92,6 +92,41 @@ describe('CheckboxFilterV2 - interactions', () => {screen.queryByTestId('checkbox-value-row-staging'),).not.toBeInTheDocument();});+ expect(screen.getByTestId('checkbox-filter-search')).toBeInTheDocument();+ });++ it('shows no search box when every value fits', async () => {+ mockFieldsValuesAPI({ stringValues: EXTRA_VALUES });++ render(+ <CheckboxFilterV2+ filter={DEFAULT_FILTER}+ source={QuickFiltersSource.TRACES_EXPLORER}+ useFieldApis={DEFAULT_USE_FIELD_APIS}+ />,+ );++ await screen.findByTestId(`checkbox-value-row-${EXTRA_VALUES[0]}`);++ expect(+ screen.queryByTestId('checkbox-filter-search'),+ ).not.toBeInTheDocument();+ });++ it('shows the search box once there are more values than fit', async () => {+ mockFieldsValuesAPI({ stringValues: ['production', ...EXTRA_VALUES] });++ render(+ <CheckboxFilterV2+ filter={DEFAULT_FILTER}+ source={QuickFiltersSource.TRACES_EXPLORER}+ useFieldApis={DEFAULT_USE_FIELD_APIS}+ />,+ );++ await expect(+ screen.findByTestId('checkbox-filter-search'),+ ).resolves.toBeInTheDocument();});it('filters values via search while preserving existingQuery context', async () => {@@ -111,7 +146,7 @@ describe('CheckboxFilterV2 - interactions', () => {data: {values: {relatedValues: ['production'],- stringValues: ['staging', 'development'],+ stringValues: ['staging', 'development', ...EXTRA_VALUES],numberValues: [],},},@@ -163,7 +198,6 @@ describe('CheckboxFilterV2 - interactions', () => {// Related values now appear in "Related" section (no badge, uses divider instead)expect(screen.getByTestId('section-divider-related')).toBeInTheDocument();- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));const searchInput = screen.getByTestId('checkbox-filter-search');await user.type(searchInput, 'prod');@@ -191,7 +225,10 @@ describe('CheckboxFilterV2 - interactions', () => {data: {values: {relatedValues: [],- stringValues: searchText === '' ? ['prod', 'staging'] : ['prod-match'],+ stringValues:+ searchText === ''+ ? ['prod', 'staging', ...EXTRA_VALUES]+ : ['prod-match'],numberValues: [],},},@@ -213,7 +250,6 @@ describe('CheckboxFilterV2 - interactions', () => {await screen.findByTestId('checkbox-value-row-prod');- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));const searchInput = screen.getByTestId('checkbox-filter-search');await user.type(searchInput, 'prod');@@ -239,7 +275,8 @@ describe('CheckboxFilterV2 - interactions', () => {data: {values: {relatedValues: [],- stringValues: searchText === '' ? ['prod', 'staging'] : [],+ stringValues:+ searchText === '' ? ['prod', 'staging', ...EXTRA_VALUES] : [],numberValues: [],},},@@ -258,7 +295,6 @@ describe('CheckboxFilterV2 - interactions', () => {await screen.findByTestId('checkbox-value-row-prod');- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));const searchInput = screen.getByTestId('checkbox-filter-search');await user.type(searchInput, 'xyz-no-match');@@ -335,7 +371,9 @@ describe('CheckboxFilterV2 - interactions', () => {const relatedValues =searchText === '' ? ['pod-a-v1', 'pod-b-v1', 'pod-c-v1'] : ['pod-a-v1']; // filtered to match 'pod-a'const stringValues =- searchText === '' ? ['pod-a-v2', 'pod-b-v2', 'pod-c-v2'] : ['pod-a-v2']; // filtered to match 'pod-a'+ searchText === ''+ ? ['pod-a-v2', 'pod-b-v2', 'pod-c-v2', ...EXTRA_VALUES]+ : ['pod-a-v2']; // filtered to match 'pod-a'return res(ctx.status(200),@@ -366,7 +404,6 @@ describe('CheckboxFilterV2 - interactions', () => {await screen.findByTestId('checkbox-value-row-pod-a-v1');- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));const searchInput = screen.getByTestId('checkbox-filter-search');await user.type(searchInput, 'pod-a');@@ -501,6 +538,56 @@ describe('CheckboxFilterV2 - interactions', () => {expect(header).toHaveAttribute('data-state', 'open');await screen.findByTestId('checkbox-value-row-production');});++ it('clears the search when the filter is collapsed', async () => {+ const user = userEvent.setup();+ const values = Array.from(+ { length: 12 },+ (_, i) => `value-${String(i).padStart(2, '0')}`,+ );++ server.use(+ rest.get('http://localhost/api/v1/fields/values', (req, res, ctx) => {+ const searchText = req.url.searchParams.get('searchText') || '';+ return res(+ ctx.status(200),+ ctx.json({+ status: 'success',+ data: {+ values: {+ relatedValues: [],+ stringValues: values.filter((value) => value.includes(searchText)),+ numberValues: [],+ },+ },+ }),+ );+ }),+ );++ render(+ <CheckboxFilterV2+ filter={DEFAULT_FILTER}+ source={QuickFiltersSource.TRACES_EXPLORER}+ useFieldApis={DEFAULT_USE_FIELD_APIS}+ />,+ );++ await screen.findByTestId('checkbox-value-row-value-00');+ await user.type(screen.getByTestId('checkbox-filter-search'), '11');+ await waitFor(() =>+ expect(+ screen.queryByTestId('checkbox-value-row-value-00'),+ ).not.toBeInTheDocument(),+ );++ const header = screen.getByTestId('checkbox-filter-header');+ await user.click(header);+ await user.click(header);++ await screen.findByTestId('checkbox-value-row-value-00');+ expect(screen.getByTestId('checkbox-filter-search')).toHaveValue('');+ });});describe('show more functionality', () => {@@ -596,30 +683,7 @@ describe('CheckboxFilterV2 - interactions', () => {expect(screen.getByTestId('checkbox-filter-clear-all')).toBeInTheDocument();});- it('shows the reset action when expanded even with no active filter', async () => {- mockFieldsValuesAPI({- stringValues: ['production'],- });-- render(- <CheckboxFilterV2- filter={DEFAULT_FILTER}- source={QuickFiltersSource.TRACES_EXPLORER}- useFieldApis={DEFAULT_USE_FIELD_APIS}- />,- );-- await screen.findByTestId('checkbox-value-row-production');-- // Reset is always available on an expanded section now (hover-gated via- // CSS), not conditional on an active filter.- expect(screen.getByTestId('checkbox-filter-clear-all')).toBeInTheDocument();- });-- it('does not dispatch on clear when the key has no filter', async () => {- const user = userEvent.setup();- const onFilterChange = jest.fn();-+ it('hides reset when the section has no filter applied', async () => {mockFieldsValuesAPI({stringValues: ['production'],});@@ -629,27 +693,14 @@ describe('CheckboxFilterV2 - interactions', () => {filter={DEFAULT_FILTER}source={QuickFiltersSource.TRACES_EXPLORER}useFieldApis={DEFAULT_USE_FIELD_APIS}- onFilterChange={onFilterChange}/>,- undefined,- {- queryBuilderOverrides: buildQueryBuilderOverrides({- builder: {- queryData: [- {- filters: { items: [], op: 'AND' },- filter: { expression: '' },- },- ],- },- }),- },);await screen.findByTestId('checkbox-value-row-production');- await user.click(screen.getByTestId('checkbox-filter-clear-all'));- expect(onFilterChange).not.toHaveBeenCalled();+ expect(+ screen.queryByTestId('checkbox-filter-clear-all'),+ ).not.toBeInTheDocument();});it('calls onFilterChange when clear clicked', async () => {diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.states.test.tsx b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.states.test.tsxindex 133c5e191a..a4c065403f 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.states.test.tsx+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2.states.test.tsx@@ -9,6 +9,7 @@ import CheckboxFilterV2 from '../CheckboxFilterV2';import {DEFAULT_FILTER,DEFAULT_USE_FIELD_APIS,+ EXTRA_VALUES,mockFieldsValuesAPI,mockFieldsValuesAPILoading,setupServer,@@ -89,7 +90,7 @@ describe('CheckboxFilterV2 - states', () => {data: {values: {relatedValues: [],- stringValues: ['production', 'staging'],+ stringValues: ['production', 'staging', ...EXTRA_VALUES],numberValues: [],},},@@ -110,7 +111,6 @@ describe('CheckboxFilterV2 - states', () => {await screen.findByTestId('checkbox-value-row-production');- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));const searchInput = screen.getByTestId('checkbox-filter-search');await user.type(searchInput, 'prod');diff --git a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2Header.test.tsx b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2Header.test.tsxindex 5d1316234d..61df6dc55f 100644--- a/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2Header.test.tsx+++ b/frontend/src/components/QuickFilters/FilterRenderers/Checkbox/v2/__tests__/CheckboxFilterV2Header.test.tsx@@ -7,8 +7,8 @@ describe('CheckboxFilterV2Header', () => {const defaultProps = {title: 'Environment',isOpen: false,+ canReset: true,onToggleOpen: jest.fn(),- onToggleSearch: jest.fn(),onClear: jest.fn(),};@@ -30,12 +30,9 @@ describe('CheckboxFilterV2Header', () => {expect(header).toHaveAttribute('data-state', 'closed');});- it('does not render the section actions when collapsed', () => {+ it('does not render reset when collapsed', () => {render(<CheckboxFilterV2Header {...defaultProps} isOpen={false} />);- expect(- screen.queryByTestId('checkbox-filter-search-toggle'),- ).not.toBeInTheDocument();expect(screen.queryByTestId('checkbox-filter-clear-all'),).not.toBeInTheDocument();@@ -50,14 +47,19 @@ describe('CheckboxFilterV2Header', () => {expect(header).toHaveAttribute('data-state', 'open');});- it('renders both search and reset actions when expanded', () => {+ it('renders reset when the section has a filter applied', () => {render(<CheckboxFilterV2Header {...defaultProps} isOpen />);- expect(- screen.getByTestId('checkbox-filter-search-toggle'),- ).toBeInTheDocument();expect(screen.getByTestId('checkbox-filter-clear-all')).toBeInTheDocument();});++ it('hides reset when there is nothing to reset', () => {+ render(<CheckboxFilterV2Header {...defaultProps} isOpen canReset={false} />);++ expect(+ screen.queryByTestId('checkbox-filter-clear-all'),+ ).not.toBeInTheDocument();+ });});describe('interactions', () => {@@ -99,25 +101,6 @@ describe('CheckboxFilterV2Header', () => {expect(onToggleOpen).toHaveBeenCalledTimes(1);});- it('calls onToggleSearch on search click without toggling open', async () => {- const user = userEvent.setup();- const onToggleSearch = jest.fn();- const onToggleOpen = jest.fn();- render(- <CheckboxFilterV2Header- {...defaultProps}- isOpen- onToggleSearch={onToggleSearch}- onToggleOpen={onToggleOpen}- />,- );-- await user.click(screen.getByTestId('checkbox-filter-search-toggle'));-- expect(onToggleSearch).toHaveBeenCalledTimes(1);- expect(onToggleOpen).not.toHaveBeenCalled();- });-it('calls onClear on reset click without toggling open', async () => {const user = userEvent.setup();const onClear = jest.fn();diff --git a/frontend/src/components/QuickFilters/QuickFiltersLayout/QuickFiltersLayout.tsx b/frontend/src/components/QuickFilters/QuickFiltersLayout/QuickFiltersLayout.tsxindex 3082ebaf6c..35c52a9d84 100644--- a/frontend/src/components/QuickFilters/QuickFiltersLayout/QuickFiltersLayout.tsx+++ b/frontend/src/components/QuickFilters/QuickFiltersLayout/QuickFiltersLayout.tsx@@ -9,6 +9,7 @@ import { useSavedViewEnabled } from 'hooks/useSavedViewEnabled';import QuickFilters from '../QuickFilters';import { SIDEBAR_TOOLTIP_DELAY_MS } from './constants';+import { useCloseOnOutsidePress } from './useCloseOnOutsidePress';import styles from './QuickFiltersLayout.module.scss';@@ -61,12 +62,20 @@ function QuickFiltersLayout({const isSliding = hasQuickFilters && isViewsListOpen;+ const openViews = (): void => setIsViewsListOpen(true);+ const toggleViews = (): void => setIsViewsListOpen((isOpen) => !isOpen);+ const closeViews = (): void => setIsViewsListOpen(false);+ const markSidebarPress = useCloseOnOutsidePress(+ showSidebar && isSliding,+ closeViews,+ );+const savedViewsHeader = hasSavedViews ? (<SavedViewsHeader{...savedViewProps}- onOpenViews={- isViewsListVisible ? undefined : (): void => setIsViewsListOpen(true)- }+ onOpenViews={isViewsListVisible ? undefined : openViews}+ isViewsOpen={isViewsListOpen}+ onToggleViews={isViewsListPinned ? undefined : toggleViews}onCollapse={hasQuickFilters ? undefined : onToggleFilters}/>) : undefined;@@ -77,6 +86,7 @@ function QuickFiltersLayout({{showSidebar && (<asideclassName={cx(styles.sidebar, { [styles.isStatic]: !hasQuickFilters })}+ onPointerDownCapture={markSidebarPress}data-testid="quick-filters-layout-filters"><TooltipProvider delay={SIDEBAR_TOOLTIP_DELAY_MS}>@@ -98,9 +108,7 @@ function QuickFiltersLayout({{hasSavedViews && isViewsListVisible && (<SavedViewsPanel{...savedViewProps}- onClose={- isViewsListPinned ? undefined : (): void => setIsViewsListOpen(false)- }+ onClose={isViewsListPinned ? undefined : closeViews}/>)}</div>diff --git a/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx b/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsxindex 5b6b2cd45e..199ad84031 100644--- a/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx+++ b/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx@@ -218,6 +218,62 @@ describe('QuickFiltersLayout', () => {expect(screen.getByTestId('saved-views-open')).toBeInTheDocument();});+ it('opens and closes the panel from the view name', async () => {+ render(+ <QuickFiltersLayout+ showFilters+ quickFilterProps={quickFilterProps}+ savedViewProps={savedViewProps}+ >+ <div>content</div>+ </QuickFiltersLayout>,+ );+ const user = userEvent.setup();+ const toggle = await screen.findByTestId('saved-views-name-toggle');++ expect(toggle).toHaveAttribute('aria-expanded', 'false');+ await user.click(toggle);++ expect(screen.getByTestId('saved-views-panel')).toBeInTheDocument();+ expect(drawer()).toHaveClass('isOpen');+ expect(toggle).toHaveAttribute('aria-expanded', 'true');++ await user.click(toggle);++ expect(screen.queryByTestId('saved-views-panel')).not.toBeInTheDocument();+ expect(drawer()).not.toHaveClass('isOpen');+ });++ it('closes the panel on a click outside the sidebar, not inside it', async () => {+ render(+ <>+ <button type="button" data-testid="page-tab">+ Pipelines+ </button>+ <QuickFiltersLayout+ showFilters+ quickFilterProps={quickFilterProps}+ savedViewProps={savedViewProps}+ >+ <div data-testid="page-content">content</div>+ </QuickFiltersLayout>+ </>,+ );+ const user = userEvent.setup();++ await user.click(await screen.findByTestId('saved-views-name-toggle'));+ await user.click(screen.getByTestId('saved-views-panel-header'));+ expect(screen.getByTestId('saved-views-panel')).toBeInTheDocument();++ await user.click(screen.getByTestId('page-tab'));+ expect(screen.queryByTestId('saved-views-panel')).not.toBeInTheDocument();+ expect(drawer()).not.toHaveClass('isOpen');++ await user.click(await screen.findByTestId('saved-views-name-toggle'));+ await user.click(screen.getByTestId('page-content'));+ expect(screen.queryByTestId('saved-views-panel')).not.toBeInTheDocument();+ });+it('hands the source to the header and the panel', async () => {render(<QuickFiltersLayout@@ -258,6 +314,9 @@ describe('QuickFiltersLayout', () => {expect(screen.getByTestId('saved-views-header')).toBeInTheDocument();expect(screen.getByTestId('saved-views-panel')).toBeInTheDocument();expect(screen.queryByTestId('saved-views-open')).not.toBeInTheDocument();+ expect(+ screen.queryByTestId('saved-views-name-toggle'),+ ).not.toBeInTheDocument();expect(screen.queryByTestId('saved-views-panel-header'),).not.toBeInTheDocument();diff --git a/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/useCloseOnOutsidePress.test.tsx b/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/useCloseOnOutsidePress.test.tsxnew file mode 100644index 0000000000..791f8cb7e6--- /dev/null+++ b/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/useCloseOnOutsidePress.test.tsx@@ -0,0 +1,63 @@+import { createPortal } from 'react-dom';+import { render, screen, userEvent } from 'tests/test-utils';++import { useCloseOnOutsidePress } from '../useCloseOnOutsidePress';++function Harness({+ enabled,+ onClose,+}: {+ enabled: boolean;+ onClose: () => void;+}): JSX.Element {+ const markInside = useCloseOnOutsidePress(enabled, onClose);++ return (+ <>+ <div onPointerDownCapture={markInside}>+ <button type="button" data-testid="inside">+ inside+ </button>+ {createPortal(+ <button type="button" data-testid="portal">+ menu item+ </button>,+ document.body,+ )}+ </div>+ <button type="button" data-testid="outside">+ outside+ </button>+ </>+ );+}++describe('useCloseOnOutsidePress', () => {+ it('closes on a press outside', async () => {+ const onClose: jest.MockedFunction<() => void> = jest.fn();+ render(<Harness enabled onClose={onClose} />);++ await userEvent.click(screen.getByTestId('outside'));++ expect(onClose).toHaveBeenCalledTimes(1);+ });++ it('stays open on a press inside, including a portal rendered from inside', async () => {+ const onClose: jest.MockedFunction<() => void> = jest.fn();+ render(<Harness enabled onClose={onClose} />);++ await userEvent.click(screen.getByTestId('inside'));+ await userEvent.click(screen.getByTestId('portal'));++ expect(onClose).not.toHaveBeenCalled();+ });++ it('does nothing while disabled', async () => {+ const onClose: jest.MockedFunction<() => void> = jest.fn();+ render(<Harness enabled={false} onClose={onClose} />);++ await userEvent.click(screen.getByTestId('outside'));++ expect(onClose).not.toHaveBeenCalled();+ });+});diff --git a/frontend/src/components/QuickFilters/QuickFiltersLayout/useCloseOnOutsidePress.ts b/frontend/src/components/QuickFilters/QuickFiltersLayout/useCloseOnOutsidePress.tsnew file mode 100644index 0000000000..c17e999916--- /dev/null+++ b/frontend/src/components/QuickFilters/QuickFiltersLayout/useCloseOnOutsidePress.ts@@ -0,0 +1,39 @@+import { useCallback, useEffect, useRef } from 'react';++/**+ * Calls `onClose` on any press outside the element given the returned handler as+ * `onPointerDownCapture`. Menus and dialogs rendered in portals still count as+ * inside: React events follow the component tree, so their presses reach the+ * handler before the document listener runs.+ */+export function useCloseOnOutsidePress(+ enabled: boolean,+ onClose: () => void,+): () => void {+ const isPressInside = useRef(false);+ const onCloseRef = useRef(onClose);+ onCloseRef.current = onClose;++ useEffect(() => {+ if (!enabled) {+ return undefined;+ }+ isPressInside.current = false;++ const handlePointerDown = (): void => {+ if (isPressInside.current) {+ isPressInside.current = false;+ return;+ }+ onCloseRef.current();+ };++ document.addEventListener('pointerdown', handlePointerDown);+ return (): void =>+ document.removeEventListener('pointerdown', handlePointerDown);+ }, [enabled]);++ return useCallback((): void => {+ isPressInside.current = true;+ }, []);+}diff --git a/frontend/src/container/SavedViews/SavedViewsHeader.tsx b/frontend/src/container/SavedViews/SavedViewsHeader.tsxindex 6f9e79c675..6a185c60fd 100644--- a/frontend/src/container/SavedViews/SavedViewsHeader.tsx+++ b/frontend/src/container/SavedViews/SavedViewsHeader.tsx@@ -12,6 +12,7 @@ import {SavedViewCreatePermission,SavedViewListPermission,} from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';+import { useAuthZ } from 'lib/authz/hooks/useAuthZ/useAuthZ';import {MY_VIEW_NAME,@@ -25,6 +26,7 @@ import { useSaveNewView } from './hooks/useSaveNewView';import { useSavedViewActions } from './hooks/useSavedViewActions';import SaveChangesMenu from './SaveChangesMenu';import SavedViewsIconButton from './SavedViewsIconButton';+import SavedViewsNameToggle from './SavedViewsNameToggle';import SaveViewModal from './SaveViewModal';import { SaveViewModalMode } from './types';@@ -33,11 +35,16 @@ import styles from './SavedViewsHeader.module.scss';function SavedViewsHeader({source,onOpenViews,+ isViewsOpen = false,+ onToggleViews,onCollapse,}: {source: SavedviewtypesSourceDTO;// Absent while the list is on screen.onOpenViews?: () => void;+ isViewsOpen?: boolean;+ // Absent while the list is pinned open.+ onToggleViews?: () => void;onCollapse?: () => void;}): JSX.Element {const {@@ -50,6 +57,11 @@ function SavedViewsHeader({} = useActiveSavedView(source);const { viewKey } = useGetSavedViewParams();const readPermission = buildSavedViewReadPermission(viewKey);+ const { isLoading: isCheckingList, deniedPermissions: deniedList } = useAuthZ(+ [SavedViewListPermission],+ { enabled: !!onToggleViews },+ );+ const canListViews = !isCheckingList && deniedList.length === 0;const { revertView, clearView, createView, updateView, isSaving } =useSavedViewActions(source);@@ -83,6 +95,9 @@ function SavedViewsHeader({name = SAVED_VIEW_LOAD_FAILED_NAME;}const isDirty = !isError && !!view && hasUnsavedChanges;+ // Same gates as the All views button; an open panel can always be closed.+ const canToggleViews =+ isViewsOpen || (canListViews && !isDirty && !isReadDenied);const nameChip = (<span@@ -123,10 +138,17 @@ function SavedViewsHeader({className={styles.skeleton}testId="saved-views-loading"/>- ) : isReadDenied ? (- <AuthZTooltip checks={[readPermission]}>{nameChip}</AuthZTooltip>) : (- <Tooltip title={errorMessage ?? name}>{nameChip}</Tooltip>+ <SavedViewsNameToggle+ isOpen={isViewsOpen}+ onToggle={canToggleViews ? onToggleViews : undefined}+ >+ {isReadDenied ? (+ <AuthZTooltip checks={[readPermission]}>{nameChip}</AuthZTooltip>+ ) : (+ <Tooltip title={errorMessage ?? name}>{nameChip}</Tooltip>+ )}+ </SavedViewsNameToggle>)}</div>diff --git a/frontend/src/container/SavedViews/SavedViewsNameToggle.module.scss b/frontend/src/container/SavedViews/SavedViewsNameToggle.module.scssnew file mode 100644index 0000000000..fe70f4f098--- /dev/null+++ b/frontend/src/container/SavedViews/SavedViewsNameToggle.module.scss@@ -0,0 +1,14 @@+.toggle {+ display: flex;+ min-width: 0;+ --button-height: auto;+ // A flex label lets the chip shrink and use its own ellipsis.+ --button-label-display: flex;+}++// The chip inherits its type from the button; doubled to outrank the button's+// size rule so the chip reads the same as when it is not a toggle.+.toggle.toggle > button {+ font: inherit;+ letter-spacing: inherit;+}diff --git a/frontend/src/container/SavedViews/SavedViewsNameToggle.tsx b/frontend/src/container/SavedViews/SavedViewsNameToggle.tsxnew file mode 100644index 0000000000..a0f0f05efe--- /dev/null+++ b/frontend/src/container/SavedViews/SavedViewsNameToggle.tsx@@ -0,0 +1,36 @@+import { ReactElement } from 'react';+import { Button } from '@signozhq/ui/button';++import styles from './SavedViewsNameToggle.module.scss';++function SavedViewsNameToggle({+ isOpen,+ onToggle,+ children,+}: {+ isOpen: boolean;+ onToggle?: () => void;+ children: ReactElement;+}): JSX.Element {+ if (!onToggle) {+ return children;+ }++ return (+ <span className={styles.toggle}>+ <Button+ variant="link"+ color="secondary"+ size="sm"+ textOverflow="hidden"+ onClick={onToggle}+ aria-expanded={isOpen}+ testId="saved-views-name-toggle"+ >+ {children}+ </Button>+ </span>+ );+}++export default SavedViewsNameToggle;diff --git a/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsxindex 639db39c02..778fd62088 100644--- a/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsx+++ b/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsx@@ -52,6 +52,7 @@ function renderHeader(<SavedViewsHeadersource={SavedviewtypesSourceDTO.traces}onOpenViews={jest.fn()}+ onToggleViews={jest.fn()}/>,url,);@@ -262,4 +263,46 @@ describe('SavedViews - AuthZ', () => {expect(screen.queryAllByText(message).length).toBeGreaterThan(0),);});++ describe('view name toggle', () => {+ it('toggles the views from the name when list is allowed', async () => {+ mockSavedViewsApi([]);+ renderHeader(explorerUrl(PATH, {}));++ await expect(+ screen.findByTestId('saved-views-name-toggle'),+ ).resolves.toBeInTheDocument();+ });++ it('leaves the name plain without list, the All views button says why', async () => {+ mockSavedViewsApi([]);+ server.use(setupAuthzDeny(SavedViewListPermission));+ renderHeader(explorerUrl(PATH, {}));++ await waitFor(() =>+ expect(screen.getByTestId('saved-views-open')).toHaveAttribute(+ 'aria-disabled',+ 'true',+ ),+ );+ expect(+ screen.queryByTestId('saved-views-name-toggle'),+ ).not.toBeInTheDocument();+ });++ it('leaves the name plain on a view it cannot read', async () => {+ mockSavedViewsApi([errors]);+ server.use(setupAuthzDeny(buildSavedViewReadPermission(errors.id)));+ renderHeader(viewUrl(PATH, errors));++ await waitFor(() =>+ expect(screen.getByTestId('saved-views-name')).toHaveTextContent(+ 'No view access',+ ),+ );+ expect(+ screen.queryByTestId('saved-views-name-toggle'),+ ).not.toBeInTheDocument();+ });+ });});diff --git a/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsxindex 4966a45bfd..e4e7d4c976 100644--- a/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx+++ b/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx@@ -30,11 +30,14 @@ const PATH = ROUTES.TRACES_EXPLORER;function renderHeader(url: string,+ isViewsOpen = false,): ReturnType<typeof renderWithExplorerProviders> {return renderWithExplorerProviders(<SavedViewsHeadersource={SavedviewtypesSourceDTO.traces}onOpenViews={jest.fn()}+ isViewsOpen={isViewsOpen}+ onToggleViews={jest.fn()}/>,url,);@@ -45,8 +48,9 @@ const isModalOpen = (): boolean => !!screen.queryByTestId('save-view-modal');async function openDirtyView(view: ReturnType<typeof makeView>,+ isViewsOpen = false,): Promise<ReturnType<typeof renderWithExplorerProviders>> {- const rendered = renderHeader(viewUrl(PATH, view));+ const rendered = renderHeader(viewUrl(PATH, view), isViewsOpen);await waitFor(() =>expect(screen.getByTestId('saved-views-name')).toHaveTextContent(view.spec.displayName,@@ -226,4 +230,36 @@ describe('SavedViewsHeader saving', () => {);expect(requests.created).toHaveLength(0);});++ describe('view name toggle with unsaved changes', () => {+ const errors = makeView({ id: 'view-1', displayName: 'Errors' });++ it('stops opening the views from the name once the view changes', async () => {+ mockSavedViewsApi([errors]);+ const { history } = renderHeader(viewUrl(PATH, errors));+ await screen.findByTestId('saved-views-name-toggle');++ act(() => {+ history.push(+ explorerUrl(PATH, {+ query: queryWith(DataSource.TRACES, 'has_error = false'),+ panelType: PANEL_TYPES.LIST,+ viewKey: errors.id,+ }),+ );+ });+ await screen.findByTestId('saved-views-discard');++ expect(+ screen.queryByTestId('saved-views-name-toggle'),+ ).not.toBeInTheDocument();+ });++ it('still closes open views from the name', async () => {+ mockSavedViewsApi([errors]);+ await openDirtyView(errors, true);++ expect(screen.getByTestId('saved-views-name-toggle')).toBeInTheDocument();+ });+ });});