SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.
TypeScript apmapplication-monitoringdistributed-tracinggogood-first-issuejaegerloglogsmetricsmonitoringnextjsobservabilityopen-sourceopentelemetryprometheusreactreactjsself-hostedtracingtypescript
feat(alert-channel-integrations): improve the existing go tests (#12526)
Nikhil Mantri2dcd4d9a6681
diff --git a/pkg/alertmanager/alertmanagernotify/email/email_test.go b/pkg/alertmanager/alertmanagernotify/email/email_test.goindex f7dd5c5ea9..7a0a3e30f1 100644--- a/pkg/alertmanager/alertmanagernotify/email/email_test.go+++ b/pkg/alertmanager/alertmanagernotify/email/email_test.go@@ -223,9 +223,7 @@ func TestEmailNotifyWithErrors(t *testing.T) {}c, err := loadEmailTestConfiguration(cfgFile)- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)for _, tc := range []struct {title string@@ -288,11 +286,6 @@ func TestEmailNotifyWithErrors(t *testing.T) {},} {t.Run(tc.title, func(t *testing.T) {- if len(tc.errMsg) == 0 {- t.Fatal("please define the expected error message")- return- }-emailCfg := &config.EmailConfig{Smarthost: c.Smarthost,To: emailTo,@@ -309,15 +302,15 @@ func TestEmailNotifyWithErrors(t *testing.T) {_, retry, err := notifyEmail(t, emailCfg, c.Server)require.Error(t, err)- require.Contains(t, err.Error(), tc.errMsg)- require.False(t, retry)+ assert.Contains(t, err.Error(), tc.errMsg)+ assert.False(t, retry)e, err := c.Server.getLastEmail(t)require.NoError(t, err)if tc.hasEmail {- require.NotNil(t, e)+ assert.NotNil(t, e)} else {- require.Nil(t, e)+ assert.Nil(t, e)}})}@@ -331,9 +324,7 @@ func TestEmailNotifyWithDoneContext(t *testing.T) {}c, err := loadEmailTestConfiguration(cfgFile)- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)ctx, cancel := context.WithCancel(context.Background())cancel()@@ -350,7 +341,7 @@ func TestEmailNotifyWithDoneContext(t *testing.T) {c.Server,)require.Error(t, err)- require.Contains(t, err.Error(), "establish connection to server")+ assert.Contains(t, err.Error(), "establish connection to server")}// TestEmailNotifyWithoutAuthentication sends an email to an instance of@@ -363,9 +354,7 @@ func TestEmailNotifyWithoutAuthentication(t *testing.T) {}c, err := loadEmailTestConfiguration(cfgFile)- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)mail, _, err := notifyEmail(t,@@ -390,7 +379,7 @@ func TestEmailNotifyWithoutAuthentication(t *testing.T) {}headers = append(headers, k)}- require.True(t, foundMsgID, "Couldn't find 'message-id' in %v", headers)+ assert.True(t, foundMsgID, "Couldn't find 'message-id' in %v", headers)}// TestEmailNotifyWithSTARTTLS connects to the server, upgrades the connection@@ -406,9 +395,7 @@ func TestEmailNotifyWithSTARTTLS(t *testing.T) {}c, err := loadEmailTestConfiguration(cfgFile)- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)trueVar := true_, _, err = notifyEmail(@@ -437,9 +424,7 @@ func TestEmailNotifyWithAuthentication(t *testing.T) {}c, err := loadEmailTestConfiguration(cfgFile)- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)td := t.TempDir()fileWithCorrectPassword, err := os.CreateTemp(td, "smtp-password-correct")@@ -583,13 +568,13 @@ func TestEmailNotifyWithAuthentication(t *testing.T) {e, retry, err := notifyEmail(t, emailCfg, c.Server)if len(tc.errMsg) > 0 {require.Error(t, err)- require.Contains(t, err.Error(), tc.errMsg)- require.Equal(t, tc.retry, retry)+ assert.Contains(t, err.Error(), tc.errMsg)+ assert.Equal(t, tc.retry, retry)return}require.NoError(t, err)- require.Equal(t, "1 firing alert(s)", e.Subject)+ assert.Equal(t, "1 firing alert(s)", e.Subject)getAddresses := func(addresses []map[string]string) []string {res := make([]string, 0, len(addresses))@@ -600,19 +585,21 @@ func TestEmailNotifyWithAuthentication(t *testing.T) {}to := getAddresses(e.To)from := getAddresses(e.From)- require.Equal(t, strings.Split(emailCfg.To, ","), to)- require.Equal(t, strings.Split(emailCfg.From, ","), from)+ assert.Equal(t, strings.Split(emailCfg.To, ","), to)+ assert.Equal(t, strings.Split(emailCfg.From, ","), from)if len(emailCfg.HTML) > 0 {- require.Equal(t, emailCfg.HTML, *e.HTML)+ require.NotNil(t, e.HTML)+ assert.Equal(t, emailCfg.HTML, *e.HTML)} else {- require.Nil(t, e.HTML)+ assert.Nil(t, e.HTML)}if len(emailCfg.Text) > 0 {- require.Equal(t, emailCfg.Text, *e.Text)+ require.NotNil(t, e.Text)+ assert.Equal(t, emailCfg.Text, *e.Text)} else {- require.Nil(t, e.Text)+ assert.Nil(t, e.Text)}})}@@ -624,7 +611,7 @@ func TestEmailConfigNoAuthMechs(t *testing.T) {}_, err := email.auth("")require.Error(t, err)- require.Equal(t, "unknown auth mechanism: ", err.Error())+ assert.Equal(t, "unknown auth mechanism: ", err.Error())}func TestEmailConfigMissingAuthParam(t *testing.T) {@@ -634,19 +621,19 @@ func TestEmailConfigMissingAuthParam(t *testing.T) {}_, err := email.auth("CRAM-MD5")require.Error(t, err)- require.Equal(t, "missing secret for CRAM-MD5 auth mechanism", err.Error())+ assert.Equal(t, "missing secret for CRAM-MD5 auth mechanism", err.Error())_, err = email.auth("PLAIN")require.Error(t, err)- require.Equal(t, "missing password for PLAIN auth mechanism", err.Error())+ assert.Equal(t, "missing password for PLAIN auth mechanism", err.Error())_, err = email.auth("LOGIN")require.Error(t, err)- require.Equal(t, "missing password for LOGIN auth mechanism", err.Error())+ assert.Equal(t, "missing password for LOGIN auth mechanism", err.Error())_, err = email.auth("PLAIN LOGIN")require.Error(t, err)- require.Equal(t, "missing password for PLAIN auth mechanism\nmissing password for LOGIN auth mechanism", err.Error())+ assert.Equal(t, "missing password for PLAIN auth mechanism\nmissing password for LOGIN auth mechanism", err.Error())}func TestEmailNoUsernameCustomError(t *testing.T) {@@ -655,7 +642,7 @@ func TestEmailNoUsernameCustomError(t *testing.T) {}a, err := email.auth("CRAM-MD5")require.ErrorIs(t, err, errNoAuthUsernameConfigured)- require.Nil(t, a)+ assert.Nil(t, a)}// TestEmailRejected simulates the failure of an otherwise valid message submission which fails at a later point than@@ -720,7 +707,7 @@ func TestEmailRejected(t *testing.T) {// Send the alert to mock SMTP server.retry, err := e.Notify(context.Background(), firingAlert)require.ErrorContains(t, err, "501 5.5.4 Rejected!")- require.True(t, retry)+ assert.True(t, retry)require.NoError(t, srv.Shutdown(ctx))require.Eventuallyf(t, func() bool {@@ -789,9 +776,7 @@ func TestEmailNotifyWithThreading(t *testing.T) {}c, err := loadEmailTestConfiguration(cfgFile)- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)for _, tc := range []struct {name string@@ -836,22 +821,22 @@ func TestEmailNotifyWithThreading(t *testing.T) {referencesValue := mail.Headers["references"]inReplyToValue := mail.Headers["in-reply-to"]- require.NotEmpty(t, referencesValue, "References header not found in %v", mail.Headers)- require.NotEmpty(t, inReplyToValue, "In-Reply-To header not found in %v", mail.Headers)+ assert.NotEmpty(t, referencesValue, "References header not found in %v", mail.Headers)+ assert.NotEmpty(t, inReplyToValue, "In-Reply-To header not found in %v", mail.Headers)- require.Equal(t, referencesValue, inReplyToValue, "References and In-Reply-To should match")+ assert.Equal(t, referencesValue, inReplyToValue, "References and In-Reply-To should match")// Verify the format: <alert-HASH-DATE@alertmanager>- require.Contains(t, referencesValue, "<alert-")- require.Contains(t, referencesValue, "@alertmanager>")+ assert.Contains(t, referencesValue, "<alert-")+ assert.Contains(t, referencesValue, "@alertmanager>")if tc.wantDatePart {today := time.Now().Format("2006-01-02")- require.Contains(t, referencesValue, today, "threading header should contain today's date")+ assert.Contains(t, referencesValue, today, "threading header should contain today's date")} else {// With thread_by_date: none, there should be no date// (empty string between hash and @).- require.Contains(t, referencesValue, "-@alertmanager>", "threading header should have empty date part")+ assert.Contains(t, referencesValue, "-@alertmanager>", "threading header should have empty date part")}})}@@ -904,14 +889,14 @@ func TestEmailGetPassword(t *testing.T) {require.Error(t, err)if errors.Asc(err, errors.CodeInternal) {_, _, errMsg, _, _, _ := errors.Unwrapb(err)- require.Contains(t, errMsg, tc.errMsg)+ assert.Contains(t, errMsg, tc.errMsg)} else {- require.Contains(t, err.Error(), tc.errMsg)+ assert.Contains(t, err.Error(), tc.errMsg)}- require.Empty(t, password)+ assert.Empty(t, password)} else {require.NoError(t, err)- require.Equal(t, "secret", password)+ assert.Equal(t, "secret", password)}})}@@ -962,11 +947,11 @@ func TestEmailGetSecret(t *testing.T) {secret, err := email.getAuthSecret()if len(tc.errMsg) > 0 {require.Error(t, err)- require.Contains(t, err.Error(), tc.errMsg)- require.Empty(t, secret)+ assert.Contains(t, err.Error(), tc.errMsg)+ assert.Empty(t, secret)} else {require.NoError(t, err)- require.Equal(t, "secret", secret)+ assert.Equal(t, "secret", secret)}})}@@ -1032,7 +1017,7 @@ func TestEmailImplicitTLS(t *testing.T) {useImplicitTLS = cfg.Smarthost.Port == "465"}- require.Equal(t, tt.expectImplicit, useImplicitTLS,+ assert.Equal(t, tt.expectImplicit, useImplicitTLS,"Expected useImplicitTLS=%v for port=%s with forceImplicitTLS=%v",tt.expectImplicit, tt.port, tt.forceImplicitTLS)})@@ -1074,8 +1059,8 @@ func TestPrepareContent(t *testing.T) {ctx := context.Background()subject, htmlBody, err := n.prepareContent(ctx, alerts)require.NoError(t, err)- require.Equal(t, "subj", subject)- require.Equal(t, "<div><p>line one</p>\n</div><div><p>line two</p>\n</div>", htmlBody)+ assert.Equal(t, "subj", subject)+ assert.Equal(t, "<div><p>line one</p>\n</div><div><p>line two</p>\n</div>", htmlBody)})t.Run("custom title template; default body HTML template", func(t *testing.T) {@@ -1103,8 +1088,8 @@ func TestPrepareContent(t *testing.T) {ctx := context.Background()subject, htmlBody, err := n.prepareContent(ctx, alerts)require.NoError(t, err)- require.Equal(t, "Status: firing", htmlBody)- require.Equal(t, "fixed from firing", subject)+ assert.Equal(t, "Status: firing", htmlBody)+ assert.Equal(t, "fixed from firing", subject)})t.Run("default template without HTML", func(t *testing.T) {@@ -1125,8 +1110,8 @@ func TestPrepareContent(t *testing.T) {ctx := context.Background()subject, htmlBody, err := n.prepareContent(ctx, alerts)require.NoError(t, err)- require.Equal(t, "", htmlBody)- require.Equal(t, "the email subject", subject)+ assert.Equal(t, "", htmlBody)+ assert.Equal(t, "the email subject", subject)})t.Run("custom title template; custom body template", func(t *testing.T) {@@ -1160,11 +1145,11 @@ func TestPrepareContent(t *testing.T) {ctx := context.Background()subject, htmlBody, err := n.prepareContent(ctx, alerts)require.NoError(t, err)- require.Contains(t, htmlBody, "<!DOCTYPE html>")- require.Contains(t, htmlBody, "<p>line two</p>")- require.NotContains(t, htmlBody, "Well, what are you?")- require.Equal(t, subject, "fixed from firing")- require.NotContains(t, subject, "subject")+ assert.Contains(t, htmlBody, "<!DOCTYPE html>")+ assert.Contains(t, htmlBody, "<p>line two</p>")+ assert.NotContains(t, htmlBody, "Well, what are you?")+ assert.Equal(t, "fixed from firing", subject)+ assert.NotContains(t, subject, "subject")})}diff --git a/pkg/alertmanager/alertmanagernotify/msteamsv2/msteamsv2_test.go b/pkg/alertmanager/alertmanagernotify/msteamsv2/msteamsv2_test.goindex a29148a5d5..28fab85099 100644--- a/pkg/alertmanager/alertmanagernotify/msteamsv2/msteamsv2_test.go+++ b/pkg/alertmanager/alertmanagernotify/msteamsv2/msteamsv2_test.go@@ -22,6 +22,7 @@ import (commoncfg "github.com/prometheus/common/config""github.com/prometheus/common/model""github.com/prometheus/common/promslog"+ "github.com/stretchr/testify/assert""github.com/stretchr/testify/require"test "github.com/SigNoz/signoz/pkg/alertmanager/alertmanagernotify/alertmanagernotifytest"@@ -54,7 +55,7 @@ func TestMSTeamsV2Retry(t *testing.T) {for statusCode, expected := range test.RetryTests(test.DefaultRetryCodes()) {actual, _ := notifier.retrier.Check(statusCode, nil)- require.Equal(t, expected, actual, "retry - error on status %d", statusCode)+ assert.Equal(t, expected, actual, "retry - error on status %d", statusCode)}}@@ -110,7 +111,7 @@ func TestNotifier_Notify_WithReason(t *testing.T) {} else {var reasonError *notify.ErrorWithReasonrequire.ErrorAs(t, err, &reasonError)- require.Equal(t, tt.expectedReason, reasonError.Reason)+ assert.Equal(t, tt.expectedReason, reasonError.Reason)}})}@@ -133,7 +134,6 @@ func TestMSTeamsV2Templating(t *testing.T) {cfg *config.MSTeamsV2ConfigtitleLink string- retry boolerrMsg string}{{@@ -143,7 +143,6 @@ func TestMSTeamsV2Templating(t *testing.T) {Text: `{{ template "msteams.default.text" . }}`,},titleLink: `{{ template "msteamsv2.default.titleLink" . }}`,- retry: false,},{title: "title with templating errors",@@ -185,12 +184,12 @@ func TestMSTeamsV2Templating(t *testing.T) {},}...)if tc.errMsg == "" {- require.NoError(t, err)+ assert.NoError(t, err)} else {require.Error(t, err)- require.Contains(t, err.Error(), tc.errMsg)+ assert.Contains(t, err.Error(), tc.errMsg)}- require.Equal(t, tc.retry, ok)+ assert.False(t, ok)})}}@@ -250,14 +249,14 @@ func TestPrepareContent(t *testing.T) {}blocks, err := notifier.prepareContent(ctx, alerts)require.NoError(t, err)- require.NotEmpty(t, blocks)+ require.Len(t, blocks, 2)// First block should be the title with color (firing = red)- require.Equal(t, "Bolder", blocks[0].Weight)- require.Equal(t, colorRed, blocks[0].Color)+ assert.Equal(t, "Bolder", blocks[0].Weight)+ assert.Equal(t, colorRed, blocks[0].Color)// verify title text- require.Equal(t, "Alertname: test", blocks[0].Text)+ assert.Equal(t, "Alertname: test", blocks[0].Text)// verify body text- require.Equal(t, "Firing alert: test", blocks[1].Text)+ assert.Equal(t, "Firing alert: test", blocks[1].Text)})t.Run("custom template - per-alert color", func(t *testing.T) {@@ -305,16 +304,15 @@ func TestPrepareContent(t *testing.T) {}blocks, err := notifier.prepareContent(ctx, alerts)require.NoError(t, err)- require.NotEmpty(t, blocks)// total 3 blocks: title and 2 body blocks- require.True(t, len(blocks) == 3)+ require.Len(t, blocks, 3)// First block: title color is overall color of the alerts- require.Equal(t, colorRed, blocks[0].Color)+ assert.Equal(t, colorRed, blocks[0].Color)// verify title text- require.Equal(t, "Custom Title", blocks[0].Text)+ assert.Equal(t, "Custom Title", blocks[0].Text)// Body blocks should have per-alert color- require.Equal(t, colorRed, blocks[1].Color) // firing- require.Equal(t, colorGreen, blocks[2].Color) // resolved+ assert.Equal(t, colorRed, blocks[1].Color) // firing+ assert.Equal(t, colorGreen, blocks[2].Color) // resolved})}diff --git a/pkg/alertmanager/alertmanagernotify/opsgenie/opsgenie_test.go b/pkg/alertmanager/alertmanagernotify/opsgenie/opsgenie_test.goindex 887ec266cb..6b935fc445 100644--- a/pkg/alertmanager/alertmanagernotify/opsgenie/opsgenie_test.go+++ b/pkg/alertmanager/alertmanagernotify/opsgenie/opsgenie_test.go@@ -21,6 +21,7 @@ import (commoncfg "github.com/prometheus/common/config""github.com/prometheus/common/model""github.com/prometheus/common/promslog"+ "github.com/stretchr/testify/assert""github.com/stretchr/testify/require""github.com/prometheus/alertmanager/config"@@ -49,7 +50,7 @@ func TestOpsGenieRetry(t *testing.T) {retryCodes := append(test.DefaultRetryCodes(), http.StatusTooManyRequests)for statusCode, expected := range test.RetryTests(retryCodes) {actual, _ := notifier.retrier.Check(statusCode, nil)- require.Equal(t, expected, actual, "error on status %d", statusCode)+ assert.Equal(t, expected, actual, "error on status %d", statusCode)}}@@ -103,9 +104,7 @@ func TestGettingOpsGegineApikeyFromFile(t *testing.T) {func TestOpsGenie(t *testing.T) {u, err := url.Parse("https://opsgenie/api")- if err != nil {- t.Fatalf("failed to parse URL: %v", err)- }+ require.NoError(t, err)logger := promslog.NewNopLogger()tmpl := test.CreateTmpl(t)@@ -236,10 +235,10 @@ func TestOpsGenie(t *testing.T) {req, retry, err := notifier.createRequests(ctx, alert1)require.NoError(t, err)require.Len(t, req, 1)- require.True(t, retry)- require.Equal(t, expectedURL, req[0].URL)- require.Equal(t, "GenieKey http://am", req[0].Header.Get("Authorization"))- require.Equal(t, tc.expectedEmptyAlertBody, readBody(t, req[0]))+ assert.True(t, retry)+ assert.Equal(t, expectedURL, req[0].URL)+ assert.Equal(t, "GenieKey http://am", req[0].Header.Get("Authorization"))+ assert.Equal(t, tc.expectedEmptyAlertBody, readBody(t, req[0]))// Fully defined alert.alert2 := &types.Alert{@@ -266,15 +265,15 @@ func TestOpsGenie(t *testing.T) {}req, retry, err = notifier.createRequests(ctx, alert2)require.NoError(t, err)- require.True(t, retry)+ assert.True(t, retry)require.Len(t, req, 1)- require.Equal(t, tc.expectedBody, readBody(t, req[0]))+ assert.Equal(t, tc.expectedBody, readBody(t, req[0]))// Broken API Key Template.tc.cfg.APIKey = "{{ kaput "_, _, err = notifier.createRequests(ctx, alert2)require.Error(t, err)- require.Equal(t, "template: :1: function \"kaput\" not defined", err.Error())+ assert.Equal(t, "template: :1: function \"kaput\" not defined", err.Error())})}}@@ -307,7 +306,7 @@ func TestOpsGenieWithUpdate(t *testing.T) {require.NoError(t, err)requests, retry, err := notifierWithUpdate.createRequests(ctx, alert)require.NoError(t, err)- require.True(t, retry)+ assert.True(t, retry)require.Len(t, requests, 3)body0 := readBody(t, requests[0])@@ -316,13 +315,13 @@ func TestOpsGenieWithUpdate(t *testing.T) {key, _ := notify.ExtractGroupKey(ctx)alias := key.Hash()- require.Equal(t, "https://test-opsgenie-url/v2/alerts", requests[0].URL.String())- require.NotEmpty(t, body0)+ assert.Equal(t, "https://test-opsgenie-url/v2/alerts", requests[0].URL.String())+ assert.NotEmpty(t, body0)- require.Equal(t, requests[1].URL.String(), fmt.Sprintf("https://test-opsgenie-url/v2/alerts/%s/message?identifierType=alias", alias))- require.JSONEq(t, `{"message":"new message"}`, body1)- require.Equal(t, requests[2].URL.String(), fmt.Sprintf("https://test-opsgenie-url/v2/alerts/%s/description?identifierType=alias", alias))- require.JSONEq(t, `{"description":"new description"}`, body2)+ assert.Equal(t, requests[1].URL.String(), fmt.Sprintf("https://test-opsgenie-url/v2/alerts/%s/message?identifierType=alias", alias))+ assert.JSONEq(t, `{"message":"new message"}`, body1)+ assert.Equal(t, requests[2].URL.String(), fmt.Sprintf("https://test-opsgenie-url/v2/alerts/%s/description?identifierType=alias", alias))+ assert.JSONEq(t, `{"description":"new description"}`, body2)}func TestOpsGenieApiKeyFile(t *testing.T) {@@ -341,7 +340,8 @@ func TestOpsGenieApiKeyFile(t *testing.T) {require.NoError(t, err)requests, _, err := notifierWithUpdate.createRequests(ctx)require.NoError(t, err)- require.Equal(t, "GenieKey my_secret_api_key", requests[0].Header.Get("Authorization"))+ require.Len(t, requests, 1)+ assert.Equal(t, "GenieKey my_secret_api_key", requests[0].Header.Get("Authorization"))}func TestPrepareContent(t *testing.T) {@@ -377,8 +377,8 @@ func TestPrepareContent(t *testing.T) {title, desc, prepErr := notifier.prepareContent(ctx, alerts)require.NoError(t, prepErr)- require.Equal(t, "Firing alert: test", title)- require.Equal(t, "Check runbook for more details", desc)+ assert.Equal(t, "Firing alert: test", title)+ assert.Equal(t, "Check runbook for more details", desc)})t.Run("custom template", func(t *testing.T) {@@ -431,9 +431,9 @@ func TestPrepareContent(t *testing.T) {title, desc, err := notifier.prepareContent(ctx, alerts)require.NoError(t, err)- require.Equal(t, "High request throughput for payment", title)+ assert.Equal(t, "High request throughput for payment", title)// Each alert body wrapped in <div>, separated by <hr>- require.Equal(t, "<div><p>Alert firing in NS: potter-the-harry</p>\n</div><hr><div><p>Alert firing in NS: smart-the-rat</p>\n</div>", desc)+ assert.Equal(t, "<div><p>Alert firing in NS: potter-the-harry</p>\n</div><hr><div><p>Alert firing in NS: smart-the-rat</p>\n</div>", desc)})}diff --git a/pkg/alertmanager/alertmanagernotify/pagerduty/pagerduty_test.go b/pkg/alertmanager/alertmanagernotify/pagerduty/pagerduty_test.goindex 4cea24e116..d434ebc612 100644--- a/pkg/alertmanager/alertmanagernotify/pagerduty/pagerduty_test.go+++ b/pkg/alertmanager/alertmanagernotify/pagerduty/pagerduty_test.go@@ -25,6 +25,7 @@ import (commoncfg "github.com/prometheus/common/config""github.com/prometheus/common/model""github.com/prometheus/common/promslog"+ "github.com/stretchr/testify/assert""github.com/stretchr/testify/require""github.com/prometheus/alertmanager/config"@@ -54,7 +55,7 @@ func TestPagerDutyRetryV1(t *testing.T) {retryCodes := append(test.DefaultRetryCodes(), http.StatusForbidden)for statusCode, expected := range test.RetryTests(retryCodes) {actual, _ := notifier.retrier.Check(statusCode, nil)- require.Equal(t, expected, actual, "retryv1 - error on status %d", statusCode)+ assert.Equal(t, expected, actual, "retryv1 - error on status %d", statusCode)}}@@ -74,7 +75,7 @@ func TestPagerDutyRetryV2(t *testing.T) {retryCodes := append(test.DefaultRetryCodes(), http.StatusTooManyRequests)for statusCode, expected := range test.RetryTests(retryCodes) {actual, _ := notifier.retrier.Check(statusCode, nil)- require.Equal(t, expected, actual, "retryv2 - error on status %d", statusCode)+ assert.Equal(t, expected, actual, "retryv2 - error on status %d", statusCode)}}@@ -349,12 +350,12 @@ func TestPagerDutyTemplating(t *testing.T) {require.Error(t, err)if errors.Asc(err, errors.CodeInternal) {_, _, errMsg, _, _, _ := errors.Unwrapb(err)- require.Contains(t, errMsg, tc.errMsg)+ assert.Contains(t, errMsg, tc.errMsg)} else {- require.Contains(t, err.Error(), tc.errMsg)+ assert.Contains(t, err.Error(), tc.errMsg)}}- require.Equal(t, tc.retry, ok)+ assert.Equal(t, tc.retry, ok)})}}@@ -393,7 +394,7 @@ func TestErrDetails(t *testing.T) {} {t.Run("", func(t *testing.T) {err := errDetails(tc.status, tc.body)- require.Contains(t, err, tc.exp)+ assert.Contains(t, err, tc.exp)})}}@@ -427,7 +428,7 @@ func TestEventSizeEnforcement(t *testing.T) {encodedV1, err := notifierV1.encodeMessage(context.Background(), msgV1)require.NoError(t, err)- require.Contains(t, encodedV1.String(), `"details":{"error":"Custom details have been removed because the original event exceeds the maximum size of 512KB"}`)+ assert.Contains(t, encodedV1.String(), `"details":{"error":"Custom details have been removed because the original event exceeds the maximum size of 512KB"}`)// V2 MessagesmsgV2 := &pagerDutyMessage{@@ -451,7 +452,7 @@ func TestEventSizeEnforcement(t *testing.T) {encodedV2, err := notifierV2.encodeMessage(context.Background(), msgV2)require.NoError(t, err)- require.Contains(t, encodedV2.String(), `"custom_details":{"error":"Custom details have been removed because the original event exceeds the maximum size of 512KB"}`)+ assert.Contains(t, encodedV2.String(), `"custom_details":{"error":"Custom details have been removed because the original event exceeds the maximum size of 512KB"}`)}func TestPagerDutyEmptySrcHref(t *testing.T) {@@ -543,8 +544,9 @@ func TestPagerDutyEmptySrcHref(t *testing.T) {}}- require.Equal(t, expectedImages, event.Images)- require.Equal(t, expectedLinks, event.Links)+ // Handler runs on the server's goroutine — require is illegal here.+ assert.Equal(t, expectedImages, event.Images)+ assert.Equal(t, expectedLinks, event.Links)},))defer server.Close()@@ -644,7 +646,7 @@ func TestPagerDutyTimeout(t *testing.T) {},}_, err = pd.Notify(ctx, alert)- require.Equal(t, tt.wantErr, err != nil)+ assert.Equal(t, tt.wantErr, err != nil)})}}@@ -899,11 +901,12 @@ func TestRenderDetails(t *testing.T) {tmpl: test.CreateTmpl(t),}got, err := n.renderDetails(tt.args.data)- if (err != nil) != tt.wantErr {- t.Errorf("renderDetails() error = %v, wantErr %v", err, tt.wantErr)- return+ if tt.wantErr {+ require.Error(t, err)+ } else {+ require.NoError(t, err)}- require.Equal(t, tt.want, got)+ assert.Equal(t, tt.want, got)})}}@@ -944,7 +947,7 @@ func TestPrepareContent(t *testing.T) {title, err := notifier.prepareTitle(ctx, alerts)require.NoError(t, err)- require.Equal(t, "HighCPU for Payment service (FIRING)", title)+ assert.Equal(t, "HighCPU for Payment service (FIRING)", title)})t.Run("custom template uses $variable annotation for title", func(t *testing.T) {@@ -980,6 +983,6 @@ func TestPrepareContent(t *testing.T) {title, err := notifier.prepareTitle(ctx, alerts)require.NoError(t, err)- require.Equal(t, "HighCPU on api-server is in resolved state", title)+ assert.Equal(t, "HighCPU on api-server is in resolved state", title)})}diff --git a/pkg/alertmanager/alertmanagernotify/slack/slack_test.go b/pkg/alertmanager/alertmanagernotify/slack/slack_test.goindex b684634a5a..f92ec4b0b3 100644--- a/pkg/alertmanager/alertmanagernotify/slack/slack_test.go+++ b/pkg/alertmanager/alertmanagernotify/slack/slack_test.go@@ -23,6 +23,7 @@ import (commoncfg "github.com/prometheus/common/config""github.com/prometheus/common/model""github.com/prometheus/common/promslog"+ "github.com/stretchr/testify/assert""github.com/stretchr/testify/require""github.com/prometheus/alertmanager/config"@@ -50,7 +51,7 @@ func TestSlackRetry(t *testing.T) {for statusCode, expected := range test.RetryTests(test.DefaultRetryCodes()) {actual, _ := notifier.retrier.Check(statusCode, nil)- require.Equal(t, expected, actual, "error on status %d", statusCode)+ assert.Equal(t, expected, actual, "error on status %d", statusCode)}}@@ -232,15 +233,15 @@ func TestNotifier_Notify_WithReason(t *testing.T) {},}retry, err := notifier.Notify(ctx, alert1)- require.Equal(t, tt.expectedRetry, retry)+ assert.Equal(t, tt.expectedRetry, retry)if tt.noError {require.NoError(t, err)} else {var reasonError *notify.ErrorWithReasonrequire.ErrorAs(t, err, &reasonError)- require.Equal(t, tt.expectedReason, reasonError.Reason)- require.Contains(t, err.Error(), tt.expectedErr)- require.Contains(t, err.Error(), "channelname")+ assert.Equal(t, tt.expectedReason, reasonError.Reason)+ assert.Contains(t, err.Error(), tt.expectedErr)+ assert.Contains(t, err.Error(), "channelname")}})}@@ -296,7 +297,7 @@ func TestSlackTimeout(t *testing.T) {},}_, err = notifier.Notify(ctx, alert)- require.Equal(t, tt.wantErr, err != nil)+ assert.Equal(t, tt.wantErr, err != nil)})}}@@ -350,14 +351,14 @@ func TestPrepareContent(t *testing.T) {require.NoError(t, err)require.Len(t, atts, 1)- require.Equal(t, "HighCPU (FIRING)", atts[0].Title)- require.Equal(t, "Alert: HighCPU - severity critical", atts[0].Text)+ assert.Equal(t, "HighCPU (FIRING)", atts[0].Title)+ assert.Equal(t, "Alert: HighCPU - severity critical", atts[0].Text)// Color is templated — firing alert should be "danger"- require.Equal(t, "danger", atts[0].Color)+ assert.Equal(t, "danger", atts[0].Color)// No BlockKit blocks for default template- require.Nil(t, atts[0].Blocks)+ assert.Nil(t, atts[0].Blocks)// Default markdownIn when config has none- require.Equal(t, []string{"fallback", "pretext", "text"}, atts[0].MrkdwnIn)+ assert.Equal(t, []string{"fallback", "pretext", "text"}, atts[0].MrkdwnIn)})t.Run("custom template produces 1+N attachments with per-alert color", func(t *testing.T) {@@ -428,10 +429,10 @@ func TestPrepareContent(t *testing.T) {require.Len(t, atts, 3)// First attachment: title-only, no color, no blocks- require.Equal(t, "[firing] HighCPU — api-server", atts[0].Title)- require.Empty(t, atts[0].Color)- require.Nil(t, atts[0].Blocks)- require.Equal(t, "https://alertmanager.signoz.com", atts[0].TitleLink)+ assert.Equal(t, "[firing] HighCPU — api-server", atts[0].Title)+ assert.Empty(t, atts[0].Color)+ assert.Nil(t, atts[0].Blocks)+ assert.Equal(t, "https://alertmanager.signoz.com", atts[0].TitleLink)expectedFiringBody := "*HighCPU*\n\n" +"*Service:* _api-server_\n*Instance:* _i-0abc123_\n*Region:* _us-east-1_\n*Method:* _GET_\n\n" +@@ -446,16 +447,16 @@ func TestPrepareContent(t *testing.T) {"*Status:* resolved | *Severity:* critical\n\n"// Second attachment: firing alert body rendered as slack mrkdwn text, red color- require.Nil(t, atts[1].Blocks)- require.Equal(t, "#FF0000", atts[1].Color)- require.Equal(t, []string{"text"}, atts[1].MrkdwnIn)- require.Equal(t, expectedFiringBody, atts[1].Text)+ assert.Nil(t, atts[1].Blocks)+ assert.Equal(t, "#FF0000", atts[1].Color)+ assert.Equal(t, []string{"text"}, atts[1].MrkdwnIn)+ assert.Equal(t, expectedFiringBody, atts[1].Text)// Third attachment: resolved alert body rendered as slack mrkdwn text, green color- require.Nil(t, atts[2].Blocks)- require.Equal(t, "#00FF00", atts[2].Color)- require.Equal(t, []string{"text"}, atts[2].MrkdwnIn)- require.Equal(t, expectedResolvedBody, atts[2].Text)+ assert.Nil(t, atts[2].Blocks)+ assert.Equal(t, "#00FF00", atts[2].Color)+ assert.Equal(t, []string{"text"}, atts[2].MrkdwnIn)+ assert.Equal(t, expectedResolvedBody, atts[2].Text)})t.Run("default template with fields and actions", func(t *testing.T) {@@ -498,49 +499,45 @@ func TestPrepareContent(t *testing.T) {// prepareContent does not populate fields/actions — that's done by// addFieldsAndActions which is called from Notify.- require.Nil(t, atts[0].Fields)- require.Nil(t, atts[0].Actions)+ assert.Nil(t, atts[0].Fields)+ assert.Nil(t, atts[0].Actions)// Simulate what Notify does after prepareContentnotifier.addFieldsAndActions(&atts[0], tmplText)// Verify fieldsrequire.Len(t, atts[0].Fields, 2)- require.Equal(t, "Severity", atts[0].Fields[0].Title)- require.Equal(t, "critical", atts[0].Fields[0].Value)- require.True(t, *atts[0].Fields[0].Short)- require.Equal(t, "Service", atts[0].Fields[1].Title)- require.Equal(t, "api-server", atts[0].Fields[1].Value)+ assert.Equal(t, "Severity", atts[0].Fields[0].Title)+ assert.Equal(t, "critical", atts[0].Fields[0].Value)+ require.NotNil(t, atts[0].Fields[0].Short)+ assert.True(t, *atts[0].Fields[0].Short)+ assert.Equal(t, "Service", atts[0].Fields[1].Title)+ assert.Equal(t, "api-server", atts[0].Fields[1].Value)// Verify actionsrequire.Len(t, atts[0].Actions, 1)- require.Equal(t, "button", atts[0].Actions[0].Type)- require.Equal(t, "View Alert", atts[0].Actions[0].Text)- require.Equal(t, "https://alertmanager.signoz.com", atts[0].Actions[0].URL)+ assert.Equal(t, "button", atts[0].Actions[0].Type)+ assert.Equal(t, "View Alert", atts[0].Actions[0].Text)+ assert.Equal(t, "https://alertmanager.signoz.com", atts[0].Actions[0].URL)})}func TestSlackMessageField(t *testing.T) {- // 1. Setup a fake Slack server+ // 1. Setup a fake Slack server. The handler runs on the server's+ // goroutine, so only assert (never require) is safe here.server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {var body map[string]any- if err := json.NewDecoder(r.Body).Decode(&body); err != nil {- t.Fatal(err)- }+ assert.NoError(t, json.NewDecoder(r.Body).Decode(&body))// 2. VERIFY: Top-level text exists- if body["text"] != "My Top Level Message" {- t.Errorf("Expected top-level 'text' to be 'My Top Level Message', got %v", body["text"])- }+ assert.Equal(t, "My Top Level Message", body["text"])// 3. VERIFY: Old attachments still existattachments, ok := body["attachments"].([]any)- if !ok || len(attachments) == 0 {- t.Errorf("Expected attachments to exist")- } else {- first := attachments[0].(map[string]any)- if first["title"] != "Old Attachment Title" {- t.Errorf("Expected attachment title 'Old Attachment Title', got %v", first["title"])+ if assert.True(t, ok, "expected attachments to exist") && assert.NotEmpty(t, attachments) {+ first, ok := attachments[0].(map[string]any)+ if assert.True(t, ok, "expected attachment to be an object") {+ assert.Equal(t, "Old Attachment Title", first["title"])}}@@ -561,21 +558,16 @@ func TestSlackMessageField(t *testing.T) {}tmpl, err := template.FromGlobs([]string{})- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)tmpl.ExternalURL = ulogger := slog.New(slog.DiscardHandler)notifier, err := New(conf, tmpl, logger, newTestTemplater(tmpl))- if err != nil {- t.Fatal(err)- }+ require.NoError(t, err)ctx := context.Background()ctx = notify.WithGroupKey(ctx, "test-group-key")- if _, err := notifier.Notify(ctx); err != nil {- t.Fatal("Notify failed:", err)- }+ _, err = notifier.Notify(ctx)+ require.NoError(t, err, "Notify failed")}diff --git a/pkg/alertmanager/alertmanagernotify/webhook/webhook_test.go b/pkg/alertmanager/alertmanagernotify/webhook/webhook_test.goindex 0f92a5cd73..adb2bf4347 100644--- a/pkg/alertmanager/alertmanagernotify/webhook/webhook_test.go+++ b/pkg/alertmanager/alertmanagernotify/webhook/webhook_test.go@@ -19,6 +19,7 @@ import (commoncfg "github.com/prometheus/common/config""github.com/prometheus/common/model""github.com/prometheus/common/promslog"+ "github.com/stretchr/testify/assert""github.com/stretchr/testify/require""github.com/SigNoz/signoz/pkg/alertmanager/alertmanagertemplate"@@ -39,14 +40,12 @@ func TestWebhookRetry(t *testing.T) {promslog.NewNopLogger(),alertmanagertemplate.New(tmpl, slog.Default()),)- if err != nil {- require.NoError(t, err)- }+ require.NoError(t, err)t.Run("test retry status code", func(t *testing.T) {for statusCode, expected := range test.RetryTests(test.DefaultRetryCodes()) {actual, _ := notifier.retrier.Check(statusCode, nil)- require.Equal(t, expected, actual, "error on status %d", statusCode)+ assert.Equal(t, expected, actual, "error on status %d", statusCode)}})@@ -73,7 +72,8 @@ func TestWebhookRetry(t *testing.T) {} {t.Run("", func(t *testing.T) {_, err = notifier.retrier.Check(tc.status, tc.body)- require.Equal(t, tc.exp, err.Error())+ require.Error(t, err)+ assert.Equal(t, tc.exp, err.Error())})}})@@ -83,16 +83,16 @@ func TestWebhookTruncateAlerts(t *testing.T) {alerts := make([]*types.Alert, 10)truncatedAlerts, numTruncated := truncateAlerts(0, alerts)- require.Len(t, truncatedAlerts, 10)- require.EqualValues(t, 0, numTruncated)+ assert.Len(t, truncatedAlerts, 10)+ assert.EqualValues(t, 0, numTruncated)truncatedAlerts, numTruncated = truncateAlerts(4, alerts)- require.Len(t, truncatedAlerts, 4)- require.EqualValues(t, 6, numTruncated)+ assert.Len(t, truncatedAlerts, 4)+ assert.EqualValues(t, 6, numTruncated)truncatedAlerts, numTruncated = truncateAlerts(100, alerts)- require.Len(t, truncatedAlerts, 10)- require.EqualValues(t, 0, numTruncated)+ assert.Len(t, truncatedAlerts, 10)+ assert.EqualValues(t, 0, numTruncated)}func TestWebhookRedactedURL(t *testing.T) {@@ -219,10 +219,10 @@ func TestWebhookURLTemplating(t *testing.T) {if tc.expectError {require.Error(t, err)- require.Contains(t, err.Error(), tc.expectedErrMsg)+ assert.Contains(t, err.Error(), tc.expectedErrMsg)} else {require.NoError(t, err)- require.Equal(t, tc.expectedPath, calledURL)+ assert.Equal(t, tc.expectedPath, calledURL)}})}