SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.
TypeScript apmapplication-monitoringdistributed-tracinggogood-first-issuejaegerloglogsmetricsmonitoringnextjsobservabilityopen-sourceopentelemetryprometheusreactreactjsself-hostedtracingtypescript
chore(lint): satisfy golangci-lint v2.12.2 and de-flake http middleware tests (#12383)
Tushar Vats302a40e8dff1
diff --git a/pkg/alertmanager/alertmanagertemplate/preprocessor.go b/pkg/alertmanager/alertmanagertemplate/preprocessor.goindex b5a813d454..b62fa207ec 100644--- a/pkg/alertmanager/alertmanagertemplate/preprocessor.go+++ b/pkg/alertmanager/alertmanagertemplate/preprocessor.go@@ -24,7 +24,7 @@ type fieldPath string// Slices and interfaces are not surfaced. Pointer fields are dereferenced.func extractFieldMappings(data any) []fieldPath {val := reflect.ValueOf(data)- if val.Kind() == reflect.Ptr {+ if val.Kind() == reflect.Pointer {if val.IsNil() {return nil}@@ -60,7 +60,7 @@ func collectFieldMappings(val reflect.Value, prefix string) []fieldPath {}ft := field.Type- if ft.Kind() == reflect.Ptr {+ if ft.Kind() == reflect.Pointer {ft = ft.Elem()}@@ -73,7 +73,7 @@ func collectFieldMappings(val reflect.Value, prefix string) []fieldPath {if ft.Kind() == reflect.Struct && ft.String() != "time.Time" {paths = append(paths, fieldPath(key))fv := val.Field(i)- if fv.Kind() == reflect.Ptr {+ if fv.Kind() == reflect.Pointer {if fv.IsNil() {continue}@@ -95,7 +95,7 @@ func collectFieldMappings(val reflect.Value, prefix string) []fieldPath {// flattened OTel-style label keys like "service.name" resolve naturally.func structRootSet(data any) map[string]bool {val := reflect.ValueOf(data)- if val.Kind() == reflect.Ptr {+ if val.Kind() == reflect.Pointer {if val.IsNil() {return nil}@@ -121,7 +121,7 @@ func structRootSet(data any) map[string]bool {continue}ft := field.Type- if ft.Kind() == reflect.Ptr {+ if ft.Kind() == reflect.Pointer {ft = ft.Elem()}if ft.Kind() == reflect.Struct && ft.String() != "time.Time" {diff --git a/pkg/http/middleware/cache_test.go b/pkg/http/middleware/cache_test.goindex 3adeee06bb..30b3473c4b 100644--- a/pkg/http/middleware/cache_test.go+++ b/pkg/http/middleware/cache_test.go@@ -27,8 +27,12 @@ func TestCache(t *testing.T) {}go func() {- require.NoError(t, server.Serve(listener))+ _ = server.Serve(listener)}()+ t.Cleanup(func() { _ = server.Close() })++ client := &http.Client{Transport: &http.Transport{}}+ t.Cleanup(client.CloseIdleConnections)testCases := []struct {name string@@ -45,7 +49,7 @@ func TestCache(t *testing.T) {req, err := http.NewRequest("GET", "http://"+listener.Addr().String(), nil)require.NoError(t, err)- res, err := http.DefaultClient.Do(req)+ res, err := client.Do(req)require.NoError(t, err)defer func() {require.NoError(t, res.Body.Close())diff --git a/pkg/http/middleware/timeout_test.go b/pkg/http/middleware/timeout_test.goindex 565f626738..54aa712c61 100644--- a/pkg/http/middleware/timeout_test.go+++ b/pkg/http/middleware/timeout_test.go@@ -34,8 +34,12 @@ func TestTimeout(t *testing.T) {}go func() {- require.NoError(t, server.Serve(listener))+ _ = server.Serve(listener)}()+ t.Cleanup(func() { _ = server.Close() })++ client := &http.Client{Transport: &http.Transport{}}+ t.Cleanup(client.CloseIdleConnections)testCases := []struct {name string@@ -70,7 +74,7 @@ func TestTimeout(t *testing.T) {require.NoError(t, err)req.Header.Add(headerName, tc.header)- res, err := http.DefaultClient.Do(req)+ res, err := client.Do(req)require.NoError(t, err)defer func() {require.NoError(t, res.Body.Close())diff --git a/pkg/instrumentation/loghandler/exception.go b/pkg/instrumentation/loghandler/exception.goindex 161ad540b9..bc2f3384f7 100644--- a/pkg/instrumentation/loghandler/exception.go+++ b/pkg/instrumentation/loghandler/exception.go@@ -5,6 +5,7 @@ import ("log/slog""github.com/SigNoz/signoz/pkg/errors"+ "github.com/SigNoz/signoz/pkg/types/instrumentationtypes")type exception struct{}@@ -35,9 +36,9 @@ func (h *exception) Wrap(next LogHandler) LogHandler {t, c, m, _, _, _ := errors.Unwrapb(foundErr)newRecord.AddAttrs(- slog.String("exception.type", t.String()),- slog.String("exception.code", c.String()),- slog.String("exception.message", m),+ slog.String(instrumentationtypes.ExceptionType, t.String()),+ slog.String(instrumentationtypes.ExceptionCode, c.String()),+ slog.String(instrumentationtypes.ExceptionMessage, m),)// Use the stacktrace captured at error creation time if available.@@ -45,7 +46,7 @@ func (h *exception) Wrap(next LogHandler) LogHandler {Stacktrace() string}if st, ok := foundErr.(stacktracer); ok && st.Stacktrace() != "" {- newRecord.AddAttrs(slog.String("exception.stacktrace", st.Stacktrace()))+ newRecord.AddAttrs(slog.String(instrumentationtypes.ExceptionStacktrace, st.Stacktrace()))}return next.Handle(ctx, newRecord)diff --git a/pkg/instrumentation/loghandler/source.go b/pkg/instrumentation/loghandler/source.goindex 7d809d9cc4..43caa02299 100644--- a/pkg/instrumentation/loghandler/source.go+++ b/pkg/instrumentation/loghandler/source.go@@ -4,6 +4,8 @@ import ("context""log/slog""runtime"++ "github.com/SigNoz/signoz/pkg/types/instrumentationtypes")type source struct{}@@ -17,9 +19,9 @@ func (h *source) Wrap(next LogHandler) LogHandler {if record.PC != 0 {frame, _ := runtime.CallersFrames([]uintptr{record.PC}).Next()record.AddAttrs(- slog.String("code.filepath", frame.File),- slog.String("code.function", frame.Function),- slog.Int("code.lineno", frame.Line),+ slog.String(instrumentationtypes.CodeFilePath, frame.File),+ slog.String(instrumentationtypes.CodeFunctionName, frame.Function),+ slog.Int(instrumentationtypes.CodeLineNumber, frame.Line),)}diff --git a/pkg/querier/consume.go b/pkg/querier/consume.goindex 909aee69d8..34ee097ca1 100644--- a/pkg/querier/consume.go+++ b/pkg/querier/consume.go@@ -286,7 +286,7 @@ func isNumericKind(t reflect.Type) bool {if t == nil {return false}- for t.Kind() == reflect.Ptr || t.Kind() == reflect.UnsafePointer {+ for t.Kind() == reflect.Pointer || t.Kind() == reflect.UnsafePointer {t = t.Elem()}switch t.Kind() {@@ -367,7 +367,7 @@ func derefValue(v any) any {val := reflect.ValueOf(v)- for val.Kind() == reflect.Ptr {+ for val.Kind() == reflect.Pointer {if val.IsNil() {return nil}diff --git a/pkg/querier/format.go b/pkg/querier/format.goindex 8350f1e694..aea2a1391a 100644--- a/pkg/querier/format.go+++ b/pkg/querier/format.go@@ -61,7 +61,7 @@ func getPointerValue(v any) any {// Use reflection to check if the pointer is nilrv := reflect.ValueOf(v)- if rv.Kind() == reflect.Ptr && rv.IsNil() {+ if rv.Kind() == reflect.Pointer && rv.IsNil() {return nil}diff --git a/pkg/statementbuilder/metricsstatementbuilder/statement_builder.go b/pkg/statementbuilder/metricsstatementbuilder/statement_builder.goindex 35bb5ef12a..fb5a6d8a3a 100644--- a/pkg/statementbuilder/metricsstatementbuilder/statement_builder.go+++ b/pkg/statementbuilder/metricsstatementbuilder/statement_builder.go@@ -4,6 +4,7 @@ import ("context""fmt""log/slog"+ "slices""time""github.com/SigNoz/signoz/pkg/factory"@@ -16,7 +17,6 @@ import ("github.com/SigNoz/signoz/pkg/types/telemetrytypes""github.com/SigNoz/signoz/pkg/valuer""github.com/huandu/go-sqlbuilder"- "golang.org/x/exp/slices")const (diff --git a/pkg/telemetrymetadata/body_json_metadata.go b/pkg/telemetrymetadata/body_json_metadata.goindex 1f2e4990bd..ff97aa0841 100644--- a/pkg/telemetrymetadata/body_json_metadata.go+++ b/pkg/telemetrymetadata/body_json_metadata.go@@ -366,7 +366,7 @@ func derefValue(v any) any {}val := reflect.ValueOf(v)- for val.Kind() == reflect.Ptr {+ for val.Kind() == reflect.Pointer {if val.IsNil() {return nil}diff --git a/pkg/types/instrumentationtypes/keys.go b/pkg/types/instrumentationtypes/keys.goindex c546b890ee..f8af7ef83d 100644--- a/pkg/types/instrumentationtypes/keys.go+++ b/pkg/types/instrumentationtypes/keys.go@@ -2,14 +2,26 @@ package instrumentationtypesimport semconv "go.opentelemetry.io/collector/semconv/v1.6.1"-// Log comment / context keys for query observability.+// Log attribute and log comment / context keys for observability.// Names align with OpenTelemetry semantic conventions where applicable// (https://pkg.go.dev/go.opentelemetry.io/otel/semconv); custom keys are namespaced.const (// CodeFunctionName is the fully-qualified function or method name (OTel code.function.name).CodeFunctionName = semconv.AttributeCodeFunction+ // CodeFilePath is the source file path of the call site.+ CodeFilePath = semconv.AttributeCodeFilepath+ // CodeLineNumber is the source line number of the call site.+ CodeLineNumber = semconv.AttributeCodeLineNumber// CodeNamespace is the logical module or component name (e.g. "dashboard", "anomaly").CodeNamespace = semconv.AttributeCodeNamespace+ // ExceptionType is the error type (errors.typ).+ ExceptionType = semconv.AttributeExceptionType+ // ExceptionCode is the error code (errors.code); SigNoz-specific, no OTel equivalent.+ ExceptionCode = "exception.code"+ // ExceptionMessage is the error message.+ ExceptionMessage = semconv.AttributeExceptionMessage+ // ExceptionStacktrace is the stacktrace captured at error creation time.+ ExceptionStacktrace = semconv.AttributeExceptionStacktrace// TelemetrySignal is the telemetry signal type: "traces", "logs", or "metrics".TelemetrySignal = "telemetry.signal"// QueryDuration is the query time-range bucket label (e.g. "<1h", "<24h").diff --git a/pkg/types/querybuildertypes/querybuildertypesv5/resp.go b/pkg/types/querybuildertypes/querybuildertypesv5/resp.goindex c28fe923c7..d73075583a 100644--- a/pkg/types/querybuildertypes/querybuildertypesv5/resp.go+++ b/pkg/types/querybuildertypes/querybuildertypesv5/resp.go@@ -404,7 +404,7 @@ func sanitizeValue(v any) any {result[keyStr] = sanitizeValue(rv.MapIndex(key).Interface())}return result- case reflect.Ptr:+ case reflect.Pointer:if rv.IsNil() {return nil}