SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.
TypeScript apmapplication-monitoringdistributed-tracinggogood-first-issuejaegerloglogsmetricsmonitoringnextjsobservabilityopen-sourceopentelemetryprometheusreactreactjsself-hostedtracingtypescript
fix(querier): use collector-stamped insert time for last_observed stats (#12455)
Tushar Vatsb2ff5ef99c24
diff --git a/pkg/querier/collect.go b/pkg/querier/collect.goindex 1ac9e2b9d6..26ce2a20fa 100644--- a/pkg/querier/collect.go+++ b/pkg/querier/collect.go@@ -23,7 +23,11 @@ func (q *querier) Collect(ctx context.Context, _ valuer.UUID) (map[string]any, etraces uint64tracesLastSeenAt time.Time)- if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*), max(timestamp) FROM %s", tracesTable)).Scan(&traces, &tracesLastSeenAt); err == nil {+ tracesLastSeenExpr := "max(timestamp)"+ if q.hasColumn(ctx, tracestelemetryschema.DBName, tracestelemetryschema.SpanIndexV3TableName, "inserted_at") {+ tracesLastSeenExpr = "max(inserted_at)"+ }+ if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*), %s FROM %s", tracesLastSeenExpr, tracesTable)).Scan(&traces, &tracesLastSeenAt); err == nil {stats["telemetry.traces.count"] = tracesif tracesLastSeenAt.Unix() != 0 {stats["telemetry.traces.last_observed.time"] = tracesLastSeenAt.UTC()@@ -37,7 +41,11 @@ func (q *querier) Collect(ctx context.Context, _ valuer.UUID) (map[string]any, elogs uint64logsLastSeenAt time.Time)- if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*), fromUnixTimestamp64Nano(max(timestamp)) FROM %s", logsTable)).Scan(&logs, &logsLastSeenAt); err == nil {+ logsLastSeenExpr := "fromUnixTimestamp64Nano(max(timestamp))"+ if q.hasColumn(ctx, logstelemetryschema.DBName, logstelemetryschema.LogsV2TableName, "inserted_at") {+ logsLastSeenExpr = "max(inserted_at)"+ }+ if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*), %s FROM %s", logsLastSeenExpr, logsTable)).Scan(&logs, &logsLastSeenAt); err == nil {stats["telemetry.logs.count"] = logsif logsLastSeenAt.Unix() != 0 {stats["telemetry.logs.last_observed.time"] = logsLastSeenAt.UTC()@@ -51,7 +59,11 @@ func (q *querier) Collect(ctx context.Context, _ valuer.UUID) (map[string]any, emetrics uint64metricsLastSeenAt time.Time)- if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*), toDateTime(max(unix_milli) / 1000) FROM %s", metricsTable)).Scan(&metrics, &metricsLastSeenAt); err == nil {+ metricsLastSeenExpr := "toDateTime(max(unix_milli) / 1000)"+ if q.hasColumn(ctx, metricstelemetryschema.DBName, metricstelemetryschema.SamplesV4TableName, "inserted_at_unix_milli") {+ metricsLastSeenExpr = "fromUnixTimestamp64Milli(max(inserted_at_unix_milli))"+ }+ if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, fmt.Sprintf("SELECT COUNT(*), %s FROM %s", metricsLastSeenExpr, metricsTable)).Scan(&metrics, &metricsLastSeenAt); err == nil {stats["telemetry.metrics.count"] = metricsif metricsLastSeenAt.Unix() != 0 {stats["telemetry.metrics.last_observed.time"] = metricsLastSeenAt.UTC()@@ -63,3 +75,12 @@ func (q *querier) Collect(ctx context.Context, _ valuer.UUID) (map[string]any, ereturn stats, nil}++func (q *querier) hasColumn(ctx context.Context, database, table, column string) bool {+ var exists bool+ if err := q.telemetryStore.ClickhouseDB().QueryRow(ctx, "SELECT hasColumnInTable(?, ?, ?)", database, table, column).Scan(&exists); err != nil {+ q.logger.DebugContext(ctx, "failed to check column existence", errors.Attr(err))+ return false+ }+ return exists+}