Skip to content

SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.

feat(saved-views): gate saved views on their permissions (#13027)

Aditya Singhdccd75e1dec7
diff --git a/cmd/authz.go b/cmd/authz.go
index 6c2ea066c9..0265f8af43 100644
--- a/cmd/authz.go
+++ b/cmd/authz.go
@@ -104,6 +104,7 @@ func runGenerateAuthz(_ context.Context) error {
coretypes.NewResourceRef(coretypes.ResourceTelemetryResourceMetrics).String(): true,
coretypes.NewResourceRef(coretypes.ResourceTelemetryResourceMeterMetrics).String(): true,
coretypes.NewResourceRef(coretypes.ResourceMetaResourceQuickFilter).String(): true,
+ coretypes.NewResourceRef(coretypes.ResourceMetaResourceSavedView).String(): true,
}
allowedTypes := map[string]bool{}
diff --git a/frontend/src/api/__tests__/ErrorResponseHandler.test.ts b/frontend/src/api/__tests__/ErrorResponseHandler.test.ts
index ee417d112f..cd93cf8680 100644
--- a/frontend/src/api/__tests__/ErrorResponseHandler.test.ts
+++ b/frontend/src/api/__tests__/ErrorResponseHandler.test.ts
@@ -9,12 +9,14 @@ describe('ErrorResponseHandler', () => {
.spyOn(console, 'error')
.mockImplementation(() => undefined);
- expect(ErrorResponseHandler(new CanceledError() as AxiosError)).toEqual({
- statusCode: 500,
- payload: null,
- error: 'Something went wrong',
- message: null,
- });
+ expect(ErrorResponseHandler(new CanceledError() as AxiosError)).toStrictEqual(
+ {
+ statusCode: 500,
+ payload: null,
+ error: 'Something went wrong',
+ message: null,
+ },
+ );
expect(consoleError).not.toHaveBeenCalled();
consoleError.mockRestore();
diff --git a/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx b/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx
index 8fc9f2df3b..ec8911eb25 100644
--- a/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx
+++ b/frontend/src/components/QuickFilters/QuickFiltersLayout/__tests__/QuickFiltersLayout.test.tsx
@@ -1,7 +1,7 @@
import { Button } from '@signozhq/ui/button';
import { SavedviewtypesSourceDTO } from 'api/generated/services/sigNoz.schemas';
import { useSavedViewEnabled } from 'hooks/useSavedViewEnabled';
-import { render, screen, userEvent } from 'tests/test-utils';
+import { render, screen, userEvent, waitFor } from 'tests/test-utils';
import { QuickFiltersSource } from '../../types';
import QuickFiltersLayout from '../QuickFiltersLayout';
@@ -197,6 +197,11 @@ describe('QuickFiltersLayout', () => {
expect(screen.queryByTestId('saved-views-panel')).not.toBeInTheDocument();
expect(drawer()).not.toHaveClass('isOpen');
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-open')).not.toHaveAttribute(
+ 'aria-busy',
+ ),
+ );
await user.click(screen.getByTestId('saved-views-open'));
expect(screen.getByTestId('saved-views-panel')).toBeInTheDocument();
@@ -227,6 +232,11 @@ describe('QuickFiltersLayout', () => {
'data-source',
SavedviewtypesSourceDTO.traces,
);
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-open')).not.toHaveAttribute(
+ 'aria-busy',
+ ),
+ );
await userEvent.setup().click(screen.getByTestId('saved-views-open'));
expect(screen.getByTestId('saved-views-panel')).toHaveAttribute(
'data-source',
diff --git a/frontend/src/container/RolesSettings/hooks/__tests__/useRolePermissions.test.ts b/frontend/src/container/RolesSettings/hooks/__tests__/useRolePermissions.test.ts
index 9d4379f40a..97d6b19759 100644
--- a/frontend/src/container/RolesSettings/hooks/__tests__/useRolePermissions.test.ts
+++ b/frontend/src/container/RolesSettings/hooks/__tests__/useRolePermissions.test.ts
@@ -329,7 +329,7 @@ describe('transformTransactionGroupsToResourcePermissions', () => {
it('returns all resources from RESOURCE_ORDER even with empty transaction groups', () => {
const result = transformTransactionGroupsToResourcePermissions([]);
- expect(result).toHaveLength(11);
+ expect(result).toHaveLength(12);
expect(result.map((r) => r.resourceKind)).toStrictEqual([
'factor-api-key',
'dashboard',
@@ -339,6 +339,7 @@ describe('transformTransactionGroupsToResourcePermissions', () => {
'metrics',
'quick-filter',
'role',
+ 'saved-view',
'serviceaccount',
'subscription',
'traces',
@@ -422,7 +423,7 @@ describe('createEmptyRolePermissions', () => {
it('creates permissions for all resources in RESOURCE_ORDER', () => {
const result = createEmptyRolePermissions();
- expect(result).toHaveLength(11);
+ expect(result).toHaveLength(12);
expect(result.map((r) => r.resourceKind)).toStrictEqual([
'factor-api-key',
'dashboard',
@@ -432,6 +433,7 @@ describe('createEmptyRolePermissions', () => {
'metrics',
'quick-filter',
'role',
+ 'saved-view',
'serviceaccount',
'subscription',
'traces',
diff --git a/frontend/src/container/RolesSettings/permissions.config.ts b/frontend/src/container/RolesSettings/permissions.config.ts
index 73e1760900..ed4f193f4e 100644
--- a/frontend/src/container/RolesSettings/permissions.config.ts
+++ b/frontend/src/container/RolesSettings/permissions.config.ts
@@ -10,6 +10,7 @@ import {
Logs,
Receipt,
Shield,
+ TowerControl,
} from '@signozhq/icons';
import permissionsType from 'lib/authz/hooks/useAuthZ/permissions.type';
@@ -95,6 +96,14 @@ export const RESOURCE_PANELS: Record<AuthZResource, ResourcePanelConfig> = {
'Type quick filter ID, separate multiple with comma or space',
docsAnchor: 'quick-filter',
},
+ 'saved-view': {
+ label: 'Saved Views',
+ description: 'Saved views in the logs, traces, metrics and meter explorers.',
+ icon: TowerControl,
+ selectorPlaceholder:
+ 'Type saved view ID, separate multiple with comma or space',
+ docsAnchor: 'saved-view',
+ },
logs: {
label: 'Logs',
description: 'Log data collected across the workspace.',
diff --git a/frontend/src/container/SavedViews/SaveChangesMenu.tsx b/frontend/src/container/SavedViews/SaveChangesMenu.tsx
index bf204bfdde..8123ea5f04 100644
--- a/frontend/src/container/SavedViews/SaveChangesMenu.tsx
+++ b/frontend/src/container/SavedViews/SaveChangesMenu.tsx
@@ -1,41 +1,50 @@
import { useMemo } from 'react';
import { Check } from '@signozhq/icons';
-import { Dropdown, type DropdownItemType } from '@signozhq/ui/dropdown';
+import AuthZDropdown from 'lib/authz/components/AuthZDropdown/AuthZDropdown';
+import type { AuthZDropdownItemType } from 'lib/authz/components/AuthZDropdown/types';
+import {
+ buildSavedViewUpdatePermission,
+ SavedViewCreatePermission,
+} from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
import SavedViewsIconButton from './SavedViewsIconButton';
import { SaveChangesMenuProps } from './types';
function SaveChangesMenu({
+ viewId,
disabled,
onSaveAsNew,
onUpdate,
}: SaveChangesMenuProps): JSX.Element {
- const items = useMemo<DropdownItemType[]>(
+ const items = useMemo<AuthZDropdownItemType[]>(
() => [
{
type: 'item',
value: 'save-as-new',
label: 'Save as new view',
+ checks: [SavedViewCreatePermission],
onClick: onSaveAsNew,
},
{
type: 'item',
value: 'update',
label: 'Update selected view',
+ checks: [buildSavedViewUpdatePermission(viewId)],
onClick: onUpdate,
},
],
- [onSaveAsNew, onUpdate],
+ [viewId, onSaveAsNew, onUpdate],
);
return (
- <Dropdown
+ <AuthZDropdown
items={items}
nativeButton
align="end"
side="bottom"
disabled={disabled}
disabledTooltip="Saving the view"
+ testId="saved-views-save-changes"
>
<SavedViewsIconButton
title="Save changes"
@@ -43,7 +52,7 @@ function SaveChangesMenu({
color="warning"
testId="saved-views-save-changes"
/>
- </Dropdown>
+ </AuthZDropdown>
);
}
diff --git a/frontend/src/container/SavedViews/SavedViewsEmptyState.tsx b/frontend/src/container/SavedViews/SavedViewsEmptyState.tsx
index aa0ebe5f13..87efc5df09 100644
--- a/frontend/src/container/SavedViews/SavedViewsEmptyState.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsEmptyState.tsx
@@ -1,7 +1,8 @@
import { useState } from 'react';
import { Plus } from '@signozhq/icons';
-import { Button } from '@signozhq/ui/button';
import { Typography } from '@signozhq/ui/typography';
+import AuthZButton from 'lib/authz/components/AuthZButton/AuthZButton';
+import { SavedViewCreatePermission } from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
import SaveViewModal from './SaveViewModal';
import { SavedViewsEmptyStateProps } from './types';
@@ -31,7 +32,8 @@ function SavedViewsEmptyState({
<Typography.Text className={styles.stateText}>
Save the current view to open it later.
</Typography.Text>
- <Button
+ <AuthZButton
+ checks={[SavedViewCreatePermission]}
variant="outlined"
color="secondary"
size="sm"
@@ -40,7 +42,7 @@ function SavedViewsEmptyState({
testId="saved-views-list-create"
>
Create view
- </Button>
+ </AuthZButton>
{isModalOpen && (
<SaveViewModal
mode="create"
diff --git a/frontend/src/container/SavedViews/SavedViewsHeader.tsx b/frontend/src/container/SavedViews/SavedViewsHeader.tsx
index 2d59b00f07..c1b7aa00bf 100644
--- a/frontend/src/container/SavedViews/SavedViewsHeader.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsHeader.tsx
@@ -5,9 +5,17 @@ import { Skeleton } from '@signozhq/ui/skeleton';
import { toast } from '@signozhq/ui/sonner';
import { Tooltip } from '@signozhq/ui/tooltip';
import { SavedviewtypesSourceDTO } from 'api/generated/services/sigNoz.schemas';
+import { useGetSavedViewParams } from 'hooks/saveViews/useGetSavedViewParams';
+import AuthZTooltip from 'lib/authz/components/AuthZTooltip/AuthZTooltip';
+import {
+ buildSavedViewReadPermission,
+ SavedViewCreatePermission,
+ SavedViewListPermission,
+} from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
import {
MY_VIEW_NAME,
+ SAVED_VIEW_FORBIDDEN_NAME,
SAVED_VIEW_LOAD_FAILED_NAME,
SAVED_VIEW_TOAST_POSITION,
} from './constants';
@@ -31,8 +39,16 @@ function SavedViewsHeader({
onOpenViews?: () => void;
onCollapse?: () => void;
}): JSX.Element {
- const { view, isLoading, isError, hasUnsavedChanges } =
- useActiveSavedView(source);
+ const {
+ view,
+ isLoading,
+ isError,
+ isReadDenied,
+ errorMessage,
+ hasUnsavedChanges,
+ } = useActiveSavedView(source);
+ const { viewKey } = useGetSavedViewParams();
+ const readPermission = buildSavedViewReadPermission(viewKey);
const { revertView, clearView, createView, updateView, isSaving } =
useSavedViewActions(source);
@@ -49,11 +65,27 @@ function SavedViewsHeader({
const openSaveAsNew = useCallback((): void => setModalMode('saveAsNew'), []);
const closeModal = useCallback((): void => setModalMode(null), []);
- const name = isError
- ? SAVED_VIEW_LOAD_FAILED_NAME
- : (view?.spec.displayName ?? MY_VIEW_NAME);
+ let name = view?.spec.displayName ?? MY_VIEW_NAME;
+ if (isReadDenied) {
+ name = SAVED_VIEW_FORBIDDEN_NAME;
+ } else if (isError) {
+ name = SAVED_VIEW_LOAD_FAILED_NAME;
+ }
const isDirty = !isError && !!view && hasUnsavedChanges;
+ const nameChip = (
+ <span
+ className={cx(styles.name, {
+ [styles.isDirty]: isDirty,
+ [styles.isError]: isError,
+ })}
+ data-testid="saved-views-name"
+ >
+ {isDirty && <span className={styles.dot} />}
+ <span className={styles.nameText}>{name}</span>
+ </span>
+ );
+
return (
<div
className={cx(styles.header, {
@@ -68,6 +100,7 @@ function SavedViewsHeader({
<SavedViewsIconButton
title="All views"
icon={<List size={14} />}
+ checks={[SavedViewListPermission]}
onClick={onOpenViews}
testId="saved-views-open"
/>
@@ -79,19 +112,10 @@ function SavedViewsHeader({
className={styles.skeleton}
testId="saved-views-loading"
/>
+ ) : isReadDenied ? (
+ <AuthZTooltip checks={[readPermission]}>{nameChip}</AuthZTooltip>
) : (
- <Tooltip title={name}>
- <span
- className={cx(styles.name, {
- [styles.isDirty]: isDirty,
- [styles.isError]: isError,
- })}
- data-testid="saved-views-name"
- >
- {isDirty && <span className={styles.dot} />}
- <span className={styles.nameText}>{name}</span>
- </span>
- </Tooltip>
+ <Tooltip title={errorMessage ?? name}>{nameChip}</Tooltip>
)}
</div>
@@ -102,6 +126,7 @@ function SavedViewsHeader({
icon={<Plus size={14} />}
disabled={isLoading}
disabledTooltip="Loading views"
+ checks={[SavedViewCreatePermission]}
onClick={(): void => setModalMode('create')}
testId="saved-views-create"
/>
@@ -117,6 +142,7 @@ function SavedViewsHeader({
{view && isDirty && (
<>
<SaveChangesMenu
+ viewId={view.id}
disabled={isSaving}
onSaveAsNew={openSaveAsNew}
onUpdate={(): void => {
diff --git a/frontend/src/container/SavedViews/SavedViewsIconButton.tsx b/frontend/src/container/SavedViews/SavedViewsIconButton.tsx
index 485baa35e8..65fa097396 100644
--- a/frontend/src/container/SavedViews/SavedViewsIconButton.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsIconButton.tsx
@@ -1,6 +1,7 @@
import { forwardRef } from 'react';
import { Button, type VariantColorType } from '@signozhq/ui/button';
import { Tooltip } from '@signozhq/ui/tooltip';
+import AuthZButton from 'lib/authz/components/AuthZButton/AuthZButton';
import { SavedViewsIconButtonProps } from './types';
@@ -25,11 +26,33 @@ const SavedViewsIconButton = forwardRef<
color = 'secondary',
disabled,
disabledTooltip,
+ checks,
onClick,
...triggerProps
},
ref,
): JSX.Element {
+ if (checks?.length) {
+ return (
+ <Tooltip title={title}>
+ <AuthZButton
+ checks={checks}
+ {...VARIANT_COLORS[color]}
+ size="sm"
+ icon
+ aria-label={title}
+ disabled={disabled}
+ // AuthZButton skips its checks while a block reason is set.
+ disabledTooltip={disabled ? disabledTooltip : undefined}
+ onClick={onClick}
+ testId={testId}
+ >
+ {icon}
+ </AuthZButton>
+ </Tooltip>
+ );
+ }
+
return (
<Tooltip title={title}>
<Button
diff --git a/frontend/src/container/SavedViews/SavedViewsList.module.scss b/frontend/src/container/SavedViews/SavedViewsList.module.scss
index b8f6c1e5fe..71518209ed 100644
--- a/frontend/src/container/SavedViews/SavedViewsList.module.scss
+++ b/frontend/src/container/SavedViews/SavedViewsList.module.scss
@@ -41,7 +41,7 @@
.row {
display: flex;
align-items: center;
- gap: var(--spacing-2);
+ gap: var(--spacing-4);
height: var(--spacing-16);
padding-right: var(--spacing-4);
border-radius: var(--radius-2);
@@ -71,7 +71,7 @@
.row:hover .rowMenu,
.row:focus-within .rowMenu,
-.rowMenu:has([data-state='open']) {
+.rowMenu:has([data-popup-open]) {
width: auto;
opacity: 1;
}
diff --git a/frontend/src/container/SavedViews/SavedViewsList.tsx b/frontend/src/container/SavedViews/SavedViewsList.tsx
index a7502effdb..083298b3b1 100644
--- a/frontend/src/container/SavedViews/SavedViewsList.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsList.tsx
@@ -40,8 +40,14 @@ function SavedViewsList({
const saveNewView = useSaveNewView(createView);
const { createdByMe, createdByOthers, isLoading, isError, refetch } =
useSavedViewsList(source, search);
- const { copyViewLink, renameView, deleteView, isRenaming, isDeleting } =
- useSavedViewRowActions(source);
+ const {
+ copyViewLink,
+ copyViewId,
+ renameView,
+ deleteView,
+ isRenaming,
+ isDeleting,
+ } = useSavedViewRowActions(source);
const [pendingAction, setPendingAction] =
useState<PendingSavedViewAction | null>(null);
const listRef = useRef<HTMLDivElement>(null);
@@ -79,10 +85,14 @@ function SavedViewsList({
copyViewLink(view);
return;
}
+ if (key === 'copyId') {
+ copyViewId(view);
+ return;
+ }
closeHoverCard();
setPendingAction({ key, view });
},
- [copyViewLink, closeHoverCard],
+ [copyViewLink, copyViewId, closeHoverCard],
);
const closePendingAction = useCallback((): void => setPendingAction(null), []);
diff --git a/frontend/src/container/SavedViews/SavedViewsListRow.tsx b/frontend/src/container/SavedViews/SavedViewsListRow.tsx
index 0606610e39..ce0de9b4f1 100644
--- a/frontend/src/container/SavedViews/SavedViewsListRow.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsListRow.tsx
@@ -1,6 +1,8 @@
import cx from 'classnames';
import { Undo2 } from '@signozhq/icons';
-import { Button } from '@signozhq/ui/button';
+import AuthZButton from 'lib/authz/components/AuthZButton/AuthZButton';
+import { buildSavedViewReadPermission } from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
+import { useAuthZ } from 'lib/authz/hooks/useAuthZ/useAuthZ';
import SavedViewsRowButton from './SavedViewsRowButton';
import SavedViewsRowMenu from './SavedViewsRowMenu';
@@ -17,17 +19,26 @@ function SavedViewsListRow({
hover,
}: SavedViewsListRowProps): JSX.Element {
const name = view.spec.displayName;
+ const readPermission = buildSavedViewReadPermission(view.id);
+ // Same cached check as the button; gates the hover card.
+ const { isLoading, deniedPermissions } = useAuthZ([readPermission]);
+ const canRead = !isLoading && deniedPermissions.length === 0;
return (
<div
className={cx(styles.row, { [styles.isActive]: isActive })}
data-testid="saved-views-row"
data-view-id={view.id}
- onMouseEnter={(event): void => hover.onRowEnter(view, event.currentTarget)}
+ onMouseEnter={(event): void => {
+ if (canRead) {
+ hover.onRowEnter(view, event.currentTarget);
+ }
+ }}
onMouseLeave={hover.onRowLeave}
>
<div className={styles.rowName}>
- <Button
+ <AuthZButton
+ checks={[readPermission]}
size="md"
variant="ghost"
color="secondary"
@@ -41,7 +52,7 @@ function SavedViewsListRow({
testId="saved-views-row-name"
>
{name}
- </Button>
+ </AuthZButton>
</div>
{isActive && (
<SavedViewsRowButton
@@ -54,6 +65,7 @@ function SavedViewsListRow({
)}
<span className={styles.rowMenu}>
<SavedViewsRowMenu
+ viewId={view.id}
onAction={(key): void => onAction(view, key)}
onOpen={hover.onMenuOpen}
/>
diff --git a/frontend/src/container/SavedViews/SavedViewsPanel.tsx b/frontend/src/container/SavedViews/SavedViewsPanel.tsx
index d232044787..fca237c605 100644
--- a/frontend/src/container/SavedViews/SavedViewsPanel.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsPanel.tsx
@@ -4,6 +4,9 @@ import { Input } from '@signozhq/ui/input';
import { Typography } from '@signozhq/ui/typography';
import { SavedviewtypesSourceDTO } from 'api/generated/services/sigNoz.schemas';
+import { AuthZGuardContent } from 'lib/authz/components/AuthZGuard/AuthZGuardContent';
+import { SavedViewListPermission } from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
+
import SavedViewsIconButton from './SavedViewsIconButton';
import SavedViewsList from './SavedViewsList';
@@ -39,16 +42,20 @@ function SavedViewsPanel({
/>
</div>
)}
- <div className={styles.search}>
- <Input
- value={search}
- onChange={(event): void => setSearch(event.target.value)}
- placeholder="Search..."
- aria-label="Search views"
- testId="saved-views-search"
- />
- </div>
- <SavedViewsList source={source} search={search} />
+ <AuthZGuardContent checks={[SavedViewListPermission]}>
+ <>
+ <div className={styles.search}>
+ <Input
+ value={search}
+ onChange={(event): void => setSearch(event.target.value)}
+ placeholder="Search..."
+ aria-label="Search views"
+ testId="saved-views-search"
+ />
+ </div>
+ <SavedViewsList source={source} search={search} />
+ </>
+ </AuthZGuardContent>
</div>
);
}
diff --git a/frontend/src/container/SavedViews/SavedViewsRowMenu.tsx b/frontend/src/container/SavedViews/SavedViewsRowMenu.tsx
index fdded7f08b..57abf40d78 100644
--- a/frontend/src/container/SavedViews/SavedViewsRowMenu.tsx
+++ b/frontend/src/container/SavedViews/SavedViewsRowMenu.tsx
@@ -1,16 +1,18 @@
import { useMemo } from 'react';
import { Ellipsis } from '@signozhq/icons';
-import { Dropdown, type DropdownItemType } from '@signozhq/ui/dropdown';
+import AuthZDropdown from 'lib/authz/components/AuthZDropdown/AuthZDropdown';
+import type { AuthZDropdownItemType } from 'lib/authz/components/AuthZDropdown/types';
import { SAVED_VIEW_ROW_ACTIONS } from './constants';
import SavedViewsRowButton from './SavedViewsRowButton';
import { SavedViewsRowMenuProps } from './types';
function SavedViewsRowMenu({
+ viewId,
onAction,
onOpen,
}: SavedViewsRowMenuProps): JSX.Element {
- const items = useMemo<DropdownItemType[]>(
+ const items = useMemo<AuthZDropdownItemType[]>(
() =>
SAVED_VIEW_ROW_ACTIONS.flatMap(
({
@@ -19,7 +21,8 @@ function SavedViewsRowMenu({
icon: Icon,
danger,
hasDividerBefore,
- }): DropdownItemType[] => [
+ buildPermission,
+ }): AuthZDropdownItemType[] => [
...(hasDividerBefore
? [{ type: 'separator' as const, value: `separator-${key}` }]
: []),
@@ -29,15 +32,16 @@ function SavedViewsRowMenu({
label,
prefix: <Icon size={14} />,
danger,
+ checks: buildPermission ? [buildPermission(viewId)] : undefined,
onClick: (): void => onAction(key),
},
],
),
- [onAction],
+ [viewId, onAction],
);
return (
- <Dropdown
+ <AuthZDropdown
items={items}
nativeButton
side="right"
@@ -47,6 +51,7 @@ function SavedViewsRowMenu({
onOpen();
}
}}
+ testId="saved-views-row-menu"
>
<SavedViewsRowButton
icon={<Ellipsis size={14} />}
@@ -54,7 +59,7 @@ function SavedViewsRowMenu({
tooltip="More options"
testId="saved-views-row-menu"
/>
- </Dropdown>
+ </AuthZDropdown>
);
}
diff --git a/frontend/src/container/SavedViews/__tests__/SavedViewHoverCard.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViewHoverCard.test.tsx
index 517e5b7e0a..405224ea9d 100644
--- a/frontend/src/container/SavedViews/__tests__/SavedViewHoverCard.test.tsx
+++ b/frontend/src/container/SavedViews/__tests__/SavedViewHoverCard.test.tsx
@@ -1,4 +1,10 @@
-import { act, fireEvent, screen, within } from '@testing-library/react';
+import {
+ act,
+ fireEvent,
+ screen,
+ waitFor,
+ within,
+} from '@testing-library/react';
import { SavedviewtypesSourceDTO } from 'api/generated/services/sigNoz.schemas';
import { initialQueriesMap, PANEL_TYPES } from 'constants/queryBuilder';
import ROUTES from 'constants/routes';
@@ -12,6 +18,7 @@ import {
import SavedViewsPanel from '../SavedViewsPanel';
import { mockSavedViewsApi } from './savedViewsApiMock';
import {
+ expectUsable,
explorerUrl,
makeView,
queryWith,
@@ -110,6 +117,11 @@ async function renderPanel(
dataSource,
);
await screen.findByTestId('saved-views-list');
+ await waitFor(() =>
+ screen
+ .getAllByTestId('saved-views-row-name')
+ .forEach((name) => expectUsable(name)),
+ );
jest.useFakeTimers();
}
@@ -140,6 +152,10 @@ describe('SavedViewHoverCard', () => {
});
afterEach(() => {
+ // useAuthZ batches checks on a timer; left pending, it blocks later checks.
+ act(() => {
+ jest.runOnlyPendingTimers();
+ });
jest.useRealTimers();
});
diff --git a/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsx
new file mode 100644
index 0000000000..639db39c02
--- /dev/null
+++ b/frontend/src/container/SavedViews/__tests__/SavedViews.authz.test.tsx
@@ -0,0 +1,265 @@
+import { fireEvent, screen, waitFor, within } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { SavedviewtypesSourceDTO } from 'api/generated/services/sigNoz.schemas';
+import { PANEL_TYPES } from 'constants/queryBuilder';
+import ROUTES from 'constants/routes';
+import {
+ buildSavedViewDeletePermission,
+ buildSavedViewReadPermission,
+ buildSavedViewUpdatePermission,
+ SavedViewCreatePermission,
+ SavedViewListPermission,
+} from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
+import {
+ AUTHZ_CHECK_URL,
+ setupAuthzDeny,
+} from 'lib/authz/utils/authz-test-utils';
+import { server } from 'mocks-server/server';
+import { rest } from 'msw';
+import { DataSource } from 'types/common/queryBuilder';
+
+import SavedViewsHeader from '../SavedViewsHeader';
+import SavedViewsPanel from '../SavedViewsPanel';
+import { API, mockSavedViewsApi } from './savedViewsApiMock';
+import {
+ explorerUrl,
+ makeView,
+ MENU_CHECK_TIMEOUT,
+ queryWith,
+ renderWithExplorerProviders,
+ viewUrl,
+} from './savedViewsTestUtils';
+
+const PATH = ROUTES.TRACES_EXPLORER;
+
+const errors = makeView({ id: 'view-1', displayName: 'Errors' });
+const slow = makeView({ id: 'view-2', displayName: 'Slow spans' });
+
+function renderPanel(url = explorerUrl(PATH, {})): void {
+ renderWithExplorerProviders(
+ <SavedViewsPanel
+ source={SavedviewtypesSourceDTO.traces}
+ onClose={jest.fn()}
+ />,
+ url,
+ );
+}
+
+function renderHeader(
+ url: string,
+): ReturnType<typeof renderWithExplorerProviders> {
+ return renderWithExplorerProviders(
+ <SavedViewsHeader
+ source={SavedviewtypesSourceDTO.traces}
+ onOpenViews={jest.fn()}
+ />,
+ url,
+ );
+}
+
+const rowNamed = (name: string): HTMLElement =>
+ screen
+ .getAllByTestId('saved-views-row')
+ .find((row) => row.textContent?.includes(name)) as HTMLElement;
+
+async function openRowMenu(name: string): Promise<void> {
+ await screen.findAllByTestId('saved-views-row');
+ fireEvent.click(within(rowNamed(name)).getByTestId('saved-views-row-menu'));
+}
+
+// Resolves once the row's check is back, so its state is final.
+async function settledRow(testId: string): Promise<HTMLElement> {
+ await waitFor(
+ () => expect(screen.getByTestId(testId)).not.toHaveAttribute('data-loading'),
+ MENU_CHECK_TIMEOUT,
+ );
+ return screen.getByTestId(testId);
+}
+
+describe('SavedViews - AuthZ', () => {
+ beforeEach(() => {
+ localStorage.clear();
+ });
+
+ afterEach(() => {
+ server.resetHandlers();
+ });
+
+ it('shows the denied callout instead of the list without list', async () => {
+ mockSavedViewsApi([errors]);
+ server.use(setupAuthzDeny(SavedViewListPermission));
+ renderPanel();
+
+ await expect(
+ screen.findByText(/not authorized/i),
+ ).resolves.toBeInTheDocument();
+ expect(screen.queryByTestId('saved-views-list')).toBeNull();
+ expect(screen.queryByTestId('saved-views-search')).toBeNull();
+ });
+
+ it('disables only the views it cannot read', async () => {
+ mockSavedViewsApi([errors, slow]);
+ server.use(setupAuthzDeny(buildSavedViewReadPermission(errors.id)));
+ renderPanel();
+
+ await screen.findAllByTestId('saved-views-row');
+ const nameOf = (view: string): HTMLElement =>
+ within(rowNamed(view)).getByTestId('saved-views-row-name');
+ await waitFor(() =>
+ expect(nameOf('Errors')).toHaveAttribute('aria-disabled', 'true'),
+ );
+ await waitFor(() =>
+ expect(nameOf('Slow spans')).not.toHaveAttribute('aria-busy'),
+ );
+ expect(nameOf('Slow spans')).not.toHaveAttribute('aria-disabled', 'true');
+ });
+
+ it('keeps the row menu on a view it cannot read', async () => {
+ mockSavedViewsApi([errors]);
+ server.use(setupAuthzDeny(buildSavedViewReadPermission(errors.id)));
+ renderPanel();
+
+ await openRowMenu('Errors');
+
+ await expect(
+ settledRow('saved-views-row-menu-item-delete'),
+ ).resolves.not.toHaveAttribute('data-disabled');
+ await expect(
+ settledRow('saved-views-row-menu-item-editDetails'),
+ ).resolves.not.toHaveAttribute('data-disabled');
+ await expect(
+ settledRow('saved-views-row-menu-item-copyLink'),
+ ).resolves.not.toHaveAttribute('data-disabled');
+ });
+
+ it('disables creating without create', async () => {
+ mockSavedViewsApi([]);
+ server.use(setupAuthzDeny(SavedViewCreatePermission));
+ renderPanel();
+ renderHeader(explorerUrl(PATH, {}));
+
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-list-create')).toHaveAttribute(
+ 'aria-disabled',
+ 'true',
+ ),
+ );
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-create')).toHaveAttribute(
+ 'aria-disabled',
+ 'true',
+ ),
+ );
+ });
+
+ it('keeps create disabled while the check is pending', async () => {
+ mockSavedViewsApi([]);
+ server.use(
+ rest.post(AUTHZ_CHECK_URL, (_req, res, ctx) => res(ctx.delay('infinite'))),
+ );
+ renderHeader(explorerUrl(PATH, {}));
+
+ const create = screen.getByTestId('saved-views-create');
+ expect(create).toHaveAttribute('aria-busy', 'true');
+ await userEvent.click(create);
+ expect(screen.queryByTestId('save-view-name')).toBeNull();
+ });
+
+ it('disables edit details without update and delete without delete', async () => {
+ mockSavedViewsApi([errors]);
+ server.use(
+ setupAuthzDeny(
+ buildSavedViewUpdatePermission(errors.id),
+ buildSavedViewDeletePermission(errors.id),
+ ),
+ );
+ renderPanel();
+
+ await openRowMenu('Errors');
+
+ await expect(
+ settledRow('saved-views-row-menu-item-editDetails'),
+ ).resolves.toHaveAttribute('data-disabled');
+ await expect(
+ settledRow('saved-views-row-menu-item-delete'),
+ ).resolves.toHaveAttribute('data-disabled');
+ await expect(
+ settledRow('saved-views-row-menu-item-copyLink'),
+ ).resolves.not.toHaveAttribute('data-disabled');
+ });
+
+ it('disables updating the open view without update, keeping save as new', async () => {
+ mockSavedViewsApi([errors]);
+ server.use(setupAuthzDeny(buildSavedViewUpdatePermission(errors.id)));
+ const { history } = renderHeader(viewUrl(PATH, errors));
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-name')).toHaveTextContent('Errors'),
+ );
+
+ history.push(
+ explorerUrl(PATH, {
+ query: queryWith(DataSource.TRACES, 'has_error = false'),
+ panelType: PANEL_TYPES.LIST,
+ viewKey: errors.id,
+ }),
+ );
+ await userEvent.click(await screen.findByTestId('saved-views-save-changes'));
+
+ await expect(
+ settledRow('saved-views-save-changes-item-update'),
+ ).resolves.toHaveAttribute('data-disabled');
+ await expect(
+ settledRow('saved-views-save-changes-item-save-as-new'),
+ ).resolves.not.toHaveAttribute('data-disabled');
+ });
+
+ it('says no access when the check denies read, even if the server returns the view', async () => {
+ mockSavedViewsApi([errors]);
+ server.use(setupAuthzDeny(buildSavedViewReadPermission(errors.id)));
+ renderHeader(viewUrl(PATH, errors));
+
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-name')).toHaveTextContent(
+ 'No view access',
+ ),
+ );
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-name')).toHaveAttribute(
+ 'data-denied-permissions',
+ ),
+ );
+ await userEvent.setup().hover(screen.getByTestId('saved-views-name'));
+
+ await waitFor(() =>
+ expect(
+ screen.queryAllByText(/is not authorized to perform read:saved-view:view-1/)
+ .length,
+ ).toBeGreaterThan(0),
+ );
+ });
+
+ it('treats a 403 the check allowed as a failed load, showing the server message', async () => {
+ const message = 'saved-view:read is missing, ask an admin for it';
+ mockSavedViewsApi([errors]);
+ server.use(
+ rest.get(`${API}/:id`, (_req, res, ctx) =>
+ res(
+ ctx.status(403),
+ ctx.json({ status: 'error', error: { code: 'forbidden', message } }),
+ ),
+ ),
+ );
+ renderHeader(viewUrl(PATH, errors));
+
+ await waitFor(() =>
+ expect(screen.getByTestId('saved-views-name')).toHaveTextContent(
+ 'View failed to load',
+ ),
+ );
+ await userEvent.setup().hover(screen.getByTestId('saved-views-name'));
+
+ await waitFor(() =>
+ expect(screen.queryAllByText(message).length).toBeGreaterThan(0),
+ );
+ });
+});
diff --git a/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.columns.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.columns.test.tsx
index c272abba1b..a1e9cfc0cf 100644
--- a/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.columns.test.tsx
+++ b/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.columns.test.tsx
@@ -9,7 +9,9 @@ import { usePreferenceContext } from 'providers/preferences/context/PreferenceCo
import SavedViewsHeader from '../SavedViewsHeader';
import { mockSavedViewsApi } from './savedViewsApiMock';
import {
+ expectRowUsable,
makeView,
+ MENU_CHECK_TIMEOUT,
renderWithExplorerProviders,
viewUrl,
} from './savedViewsTestUtils';
@@ -115,9 +117,11 @@ describe('SavedViewsHeader columns', () => {
await userEvent.click(screen.getByTestId('add-column'));
await waitFor(() => expect(isDirty()).toBe(true));
await userEvent.click(screen.getByTestId('saved-views-save-changes'));
- await userEvent.click(
- await screen.findByRole('menuitem', { name: 'Update selected view' }),
+ const update = await screen.findByTestId(
+ 'saved-views-save-changes-item-update',
);
+ await waitFor(() => expectRowUsable(update), MENU_CHECK_TIMEOUT);
+ await userEvent.click(update);
await waitFor(() => expect(isDirty()).toBe(false));
await userEvent.click(screen.getByTestId('add-column'));
diff --git a/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx
index 3b992b37ba..4966a45bfd 100644
--- a/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx
+++ b/frontend/src/container/SavedViews/__tests__/SavedViewsHeader.save.test.tsx
@@ -9,8 +9,11 @@ import { DataSource } from 'types/common/queryBuilder';
import SavedViewsHeader from '../SavedViewsHeader';
import {
+ expectRowUsable,
+ expectUsable,
explorerUrl,
makeView,
+ MENU_CHECK_TIMEOUT,
queryWith,
renderWithExplorerProviders,
urlParam,
@@ -67,9 +70,21 @@ async function openDirtyView(
return rendered;
}
+const SAVE_MENU_ITEM_TEST_IDS: Record<string, string> = {
+ 'Save as new view': 'saved-views-save-changes-item-save-as-new',
+ 'Update selected view': 'saved-views-save-changes-item-update',
+};
+
async function chooseFromSaveMenu(item: string): Promise<void> {
await userEvent.click(screen.getByTestId('saved-views-save-changes'));
- await userEvent.click(await screen.findByRole('menuitem', { name: item }));
+ const menuItem = await screen.findByTestId(SAVE_MENU_ITEM_TEST_IDS[item]);
+ await waitFor(() => expectRowUsable(menuItem), MENU_CHECK_TIMEOUT);
+ await userEvent.click(menuItem);
+}
+
+async function clickCreate(): Promise<void> {
+ await waitFor(() => expectUsable(screen.getByTestId('saved-views-create')));
+ await userEvent.click(screen.getByTestId('saved-views-create'));
}
async function submitName(name: string): Promise<void> {
@@ -87,7 +102,7 @@ describe('SavedViewsHeader saving', () => {
const requests = mockSavedViewsApi([], { createdId: 'view-new' });
const { history } = renderHeader(explorerUrl(PATH, {}));
- await userEvent.click(screen.getByTestId('saved-views-create'));
+ await clickCreate();
expect(within(modal()).getByText('Create new view')).toBeInTheDocument();
expect(screen.getByTestId('save-view-submit')).toHaveAttribute(
@@ -130,7 +145,7 @@ describe('SavedViewsHeader saving', () => {
const requests = mockSavedViewsApi([], { createStatus: 500 });
const { history } = renderHeader(explorerUrl(PATH, {}));
- await userEvent.click(screen.getByTestId('saved-views-create'));
+ await clickCreate();
await submitName('Slow checkout');
await waitFor(() => expect(toast.error).toHaveBeenCalled());
@@ -145,7 +160,7 @@ describe('SavedViewsHeader saving', () => {
const requests = mockSavedViewsApi([]);
renderHeader(explorerUrl(PATH, {}));
- await userEvent.click(screen.getByTestId('saved-views-create'));
+ await clickCreate();
await userEvent.type(screen.getByTestId('save-view-name'), 'Draft');
await userEvent.click(screen.getByTestId('save-view-cancel'));
diff --git a/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.list.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.list.test.tsx
index 1b4930db1b..16fc49c487 100644
--- a/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.list.test.tsx
+++ b/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.list.test.tsx
@@ -8,6 +8,7 @@ import ROUTES from 'constants/routes';
import SavedViewsPanel from '../SavedViewsPanel';
import { mockSavedViewsApi } from './savedViewsApiMock';
import {
+ expectUsable,
explorerUrl,
makeView,
renderWithExplorerProviders,
@@ -84,9 +85,9 @@ describe('SavedViewsPanel list', () => {
const { history } = renderPanel();
await screen.findByTestId('saved-views-list');
- await userEvent.click(
- within(row('Slow spans')).getByTestId('saved-views-row-name'),
- );
+ const name = within(row('Slow spans')).getByTestId('saved-views-row-name');
+ await waitFor(() => expectUsable(name));
+ await userEvent.click(name);
await waitFor(() =>
expect(urlParam(history, QueryParams.viewKey)).toBe(
@@ -161,7 +162,9 @@ describe('SavedViewsPanel list', () => {
const requests = mockSavedViewsApi([], { createdId: 'view-new' });
const { history } = renderPanel();
- await userEvent.click(await screen.findByTestId('saved-views-list-create'));
+ const create = await screen.findByTestId('saved-views-list-create');
+ await waitFor(() => expectUsable(create));
+ await userEvent.click(create);
await userEvent.type(screen.getByTestId('save-view-name'), 'First view');
await userEvent.click(screen.getByTestId('save-view-submit'));
diff --git a/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.rowMenu.test.tsx b/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.rowMenu.test.tsx
index fed141b797..b9086ecb96 100644
--- a/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.rowMenu.test.tsx
+++ b/frontend/src/container/SavedViews/__tests__/SavedViewsPanel.rowMenu.test.tsx
@@ -9,8 +9,10 @@ import SavedViewsHeader from '../SavedViewsHeader';
import SavedViewsPanel from '../SavedViewsPanel';
import { mockSavedViewsApi } from './savedViewsApiMock';
import {
+ expectRowUsable,
explorerUrl,
makeView,
+ MENU_CHECK_TIMEOUT,
renderWithExplorerProviders,
urlParam,
viewUrl,
@@ -58,13 +60,22 @@ const row = (name: string): HTMLElement =>
.getAllByTestId('saved-views-row')
.find((element) => element.textContent?.includes(name)) as HTMLElement;
+const ROW_MENU_ITEM_TEST_IDS: Record<string, string> = {
+ 'Copy link': 'saved-views-row-menu-item-copyLink',
+ 'Copy ID': 'saved-views-row-menu-item-copyId',
+ 'Edit details': 'saved-views-row-menu-item-editDetails',
+ Delete: 'saved-views-row-menu-item-delete',
+};
+
async function chooseFromRowMenu(
viewName: string,
item: string,
): Promise<void> {
await screen.findByTestId('saved-views-list');
fireEvent.click(within(row(viewName)).getByTestId('saved-views-row-menu'));
- fireEvent.click(await screen.findByRole('menuitem', { name: item }));
+ const menuItem = await screen.findByTestId(ROW_MENU_ITEM_TEST_IDS[item]);
+ await waitFor(() => expectRowUsable(menuItem), MENU_CHECK_TIMEOUT);
+ fireEvent.click(menuItem);
}
const chip = (): HTMLElement => screen.getByTestId('saved-views-name');
@@ -76,21 +87,38 @@ describe('SavedViewsPanel row menu', () => {
jest.mocked(toast.success).mockClear();
});
- it('offers copy link, edit details and delete', async () => {
+ it('offers copy link, copy id, edit details and delete', async () => {
mockSavedViewsApi([errors]);
renderPanelWithHeader();
await screen.findByTestId('saved-views-list');
fireEvent.click(within(row('Errors')).getByTestId('saved-views-row-menu'));
- const items = await screen.findAllByRole('menuitem');
- expect(items.map((item) => item.textContent)).toStrictEqual([
+ await screen.findByTestId(ROW_MENU_ITEM_TEST_IDS['Copy link']);
+ const items = Object.values(ROW_MENU_ITEM_TEST_IDS).map(
+ (testId) => screen.getByTestId(testId).textContent,
+ );
+ expect(items).toStrictEqual([
'Copy link',
+ 'Copy ID',
'Edit details',
'Delete',
]);
});
+ it('copies the view id', async () => {
+ mockSavedViewsApi([errors, slow]);
+ renderPanelWithHeader();
+
+ await chooseFromRowMenu('Slow spans', 'Copy ID');
+
+ expect(mockCopy).toHaveBeenCalledWith(slow.id);
+ expect(toast.success).toHaveBeenCalledWith(
+ 'View ID copied',
+ expect.anything(),
+ );
+ });
+
it('copies a link that opens the view with its query and tab', async () => {
mockSavedViewsApi([errors, slow]);
renderPanelWithHeader();
diff --git a/frontend/src/container/SavedViews/__tests__/savedViewsApiMock.ts b/frontend/src/container/SavedViews/__tests__/savedViewsApiMock.ts
index 3622b34a92..c43c22d9f2 100644
--- a/frontend/src/container/SavedViews/__tests__/savedViewsApiMock.ts
+++ b/frontend/src/container/SavedViews/__tests__/savedViewsApiMock.ts
@@ -1,4 +1,5 @@
import { SavedviewtypesSavedViewDTO } from 'api/generated/services/sigNoz.schemas';
+import { setupAuthzAdmin } from 'lib/authz/utils/authz-test-utils';
import { server } from 'mocks-server/server';
import { rest } from 'msw';
@@ -13,6 +14,7 @@ export interface Requests {
}
// Mutates `views` on create, update and delete, so a refetch sees the change.
+// Grants every permission; a later server.use overrides it.
export function mockSavedViewsApi(
views: SavedviewtypesSavedViewDTO[],
{
@@ -30,6 +32,7 @@ export function mockSavedViewsApi(
const requests: Requests = { created: [], updated: [], deleted: [] };
let failedLists = 0;
server.use(
+ setupAuthzAdmin(),
rest.get(API, (req, res, ctx) => {
if (failedLists < listFailures) {
failedLists += 1;
diff --git a/frontend/src/container/SavedViews/__tests__/savedViewsTestUtils.tsx b/frontend/src/container/SavedViews/__tests__/savedViewsTestUtils.tsx
index 60e86d570f..0a5292aee4 100644
--- a/frontend/src/container/SavedViews/__tests__/savedViewsTestUtils.tsx
+++ b/frontend/src/container/SavedViews/__tests__/savedViewsTestUtils.tsx
@@ -251,3 +251,20 @@ export function renderWithExplorerProviders(
export function urlParam(history: MemoryHistory, key: string): string | null {
return new URLSearchParams(history.location.search).get(key);
}
+
+// The ui Button marks a pending check with aria-busy and a block with
+// aria-disabled, never the disabled attribute.
+export function expectUsable(element: HTMLElement): void {
+ expect(element).not.toHaveAttribute('aria-busy');
+ expect(element).not.toHaveAttribute('aria-disabled', 'true');
+}
+
+// A menu checks its rows on first open; on a loaded CI runner that outlasts
+// waitFor's 1s default.
+export const MENU_CHECK_TIMEOUT = { timeout: 5000 };
+
+// A menu row waiting on its check is data-loading, not yet data-disabled.
+export function expectRowUsable(row: HTMLElement): void {
+ expect(row).not.toHaveAttribute('data-loading');
+ expect(row).not.toHaveAttribute('data-disabled');
+}
diff --git a/frontend/src/container/SavedViews/constants.ts b/frontend/src/container/SavedViews/constants.ts
index 28b4f1cca4..4a4ce0cf8f 100644
--- a/frontend/src/container/SavedViews/constants.ts
+++ b/frontend/src/container/SavedViews/constants.ts
@@ -1,9 +1,13 @@
-import { Link, PenLine, Trash2 } from '@signozhq/icons';
+import { Copy, Link, PenLine, Trash2 } from '@signozhq/icons';
import {
SavedviewtypesSchemaVersionDTO,
SavedviewtypesSourceDTO,
} from 'api/generated/services/sigNoz.schemas';
import { QueryParams } from 'constants/query';
+import {
+ buildSavedViewDeletePermission,
+ buildSavedViewUpdatePermission,
+} from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
import { DataSource } from 'types/common/queryBuilder';
import { SavedViewRowActionConfig, SaveViewModalMode } from './types';
@@ -30,6 +34,8 @@ export const MY_VIEW_NAME = 'My view';
export const SAVED_VIEW_LOAD_FAILED_NAME = 'View failed to load';
+export const SAVED_VIEW_FORBIDDEN_NAME = 'No view access';
+
export const SAVED_VIEWS_LIST_LOADING_ROWS = 4;
export const SAVED_VIEW_HOVER_CARD_OPEN_DELAY_MS = 1000;
@@ -47,13 +53,20 @@ export const SAVE_VIEW_MODAL_TITLE: Record<SaveViewModalMode, string> = {
export const SAVED_VIEW_ROW_ACTIONS: SavedViewRowActionConfig[] = [
{ key: 'copyLink', label: 'Copy link', icon: Link },
- { key: 'editDetails', label: 'Edit details', icon: PenLine },
+ { key: 'copyId', label: 'Copy ID', icon: Copy },
+ {
+ key: 'editDetails',
+ label: 'Edit details',
+ icon: PenLine,
+ buildPermission: buildSavedViewUpdatePermission,
+ },
{
key: 'delete',
label: 'Delete',
icon: Trash2,
danger: true,
hasDividerBefore: true,
+ buildPermission: buildSavedViewDeletePermission,
},
];
diff --git a/frontend/src/container/SavedViews/hooks/useActiveSavedView.ts b/frontend/src/container/SavedViews/hooks/useActiveSavedView.ts
index f371840a9b..edd89673fc 100644
--- a/frontend/src/container/SavedViews/hooks/useActiveSavedView.ts
+++ b/frontend/src/container/SavedViews/hooks/useActiveSavedView.ts
@@ -6,7 +6,10 @@ import useOptionsMenu from 'container/OptionsMenu/useOptionsMenu';
import { useGetCompositeQueryParam } from 'hooks/queryBuilder/useGetCompositeQueryParam';
import { useQueryBuilder } from 'hooks/queryBuilder/useQueryBuilder';
import { useGetSavedViewParams } from 'hooks/saveViews/useGetSavedViewParams';
+import { buildSavedViewReadPermission } from 'lib/authz/hooks/useAuthZ/permissions/saved-view.permissions';
+import { useAuthZ } from 'lib/authz/hooks/useAuthZ/useAuthZ';
import { DataSource } from 'types/common/queryBuilder';
+import { toAPIError } from 'utils/errorUtils';
import { SAVED_VIEW_OPTIONS_DATA_SOURCE } from '../constants';
import { UseActiveSavedViewResult } from '../types';
@@ -23,11 +26,19 @@ export function useActiveSavedView(
dataSource: optionsDataSource ?? DataSource.LOGS,
});
- const { data, isLoading, isError } = useGetSavedView(
+ const { isLoading: isCheckingRead, deniedPermissions } = useAuthZ(
+ [buildSavedViewReadPermission(viewKey)],
+ { enabled: !!viewKey },
+ );
+ const isReadDenied = !!viewKey && deniedPermissions.length > 0;
+
+ const canFetch = !!viewKey && !isCheckingRead && !isReadDenied;
+
+ const { data, isLoading, isError, error } = useGetSavedView(
{ id: viewKey },
- { query: { enabled: !!viewKey } },
+ { query: { enabled: canFetch } },
);
- const view = viewKey ? data?.data : undefined;
+ const view = canFetch ? data?.data : undefined;
// The query builder stages the url query a render later. Until the ids
// match, keep the last answer for this view; another view starts clean.
@@ -68,10 +79,17 @@ export function useActiveSavedView(
lastResult.current = { viewId: view?.id, hasUnsavedChanges };
}, [view?.id, hasUnsavedChanges]);
+ const errorMessage =
+ viewKey && isError && error
+ ? toAPIError(error, '').getErrorMessage() || undefined
+ : undefined;
+
return {
view,
- isLoading: !!viewKey && isLoading,
- isError: !!viewKey && isError,
+ isLoading: !!viewKey && (isCheckingRead || isLoading),
+ isError: !!viewKey && (isError || isReadDenied),
+ isReadDenied,
+ errorMessage,
hasUnsavedChanges,
};
}
diff --git a/frontend/src/container/SavedViews/hooks/useSavedViewRowActions.ts b/frontend/src/container/SavedViews/hooks/useSavedViewRowActions.ts
index f794fdf39b..64b04ad50e 100644
--- a/frontend/src/container/SavedViews/hooks/useSavedViewRowActions.ts
+++ b/frontend/src/container/SavedViews/hooks/useSavedViewRowActions.ts
@@ -59,6 +59,14 @@ export function useSavedViewRowActions(
[pathname, copyToClipboard],
);
+ const copyViewId = useCallback(
+ (view: SavedviewtypesSavedViewDTO): void => {
+ copyToClipboard(view.id);
+ toast.success('View ID copied', { position: SAVED_VIEW_TOAST_POSITION });
+ },
+ [copyToClipboard],
+ );
+
const renameView = useCallback(
async (
view: SavedviewtypesSavedViewDTO,
@@ -101,5 +109,12 @@ export function useSavedViewRowActions(
[deleteSavedView, source, queryClient],
);
- return { copyViewLink, renameView, deleteView, isRenaming, isDeleting };
+ return {
+ copyViewLink,
+ copyViewId,
+ renameView,
+ deleteView,
+ isRenaming,
+ isDeleting,
+ };
}
diff --git a/frontend/src/container/SavedViews/stories/SavedViews.stories.mocks.tsx b/frontend/src/container/SavedViews/stories/SavedViews.stories.mocks.tsx
new file mode 100644
index 0000000000..3a04a22e41
--- /dev/null
+++ b/frontend/src/container/SavedViews/stories/SavedViews.stories.mocks.tsx
@@ -0,0 +1,218 @@
+/**
+ * AI-owned. Generated and maintained by the `signoz-page-story` skill.
+ * Do not hand-edit: regenerate instead.
+ */
+
+import { rest, type RequestHandler } from 'msw';
+import remove from 'api/browser/localstorage/remove';
+import {
+ type AuthtypesTransactionDTO,
+ type SavedviewtypesSavedViewDTO,
+ SavedviewtypesSourceDTO,
+ type SavedviewtypesUpdatableSavedViewDTO,
+} from 'api/generated/services/sigNoz.schemas';
+import { LOCALSTORAGE } from 'constants/localStorage';
+import {
+ AUTHZ_CHECK_URL,
+ authzMockResponse,
+} from 'lib/authz/utils/authz-test-utils';
+
+import { accessFor } from '@/storybook/access/access';
+import {
+ choiceControl,
+ countControl,
+ toggleControl,
+} from '@/storybook/controls/controls';
+import { defineStoryMocks } from '@/storybook/controls/defineStoryMocks';
+import type { MockControlValues, StoryMocks } from '@/storybook/controls/types';
+import { authzMocks, type AuthzArgs } from '@/storybook/globals/authzMocks';
+import { respondWith } from '@/storybook/runtime/responseState';
+
+import {
+ createdSavedView,
+ OPEN_VIEW_ERRORS,
+ OPEN_VIEWS,
+ type OpenView,
+ SAVED_VIEW_SOURCES,
+ SAVED_VIEWS_MAX,
+ savedViewById,
+ savedViewResponse,
+ savedViewRoute,
+ savedViewsListResponse,
+ type SavedViewSource,
+ unreadableViewId,
+} from './__story_mockdata__/savedViews';
+
+const API = 'http://localhost/api/v2/saved_views';
+
+const LIST = 'Saved Views · list';
+const VIEW = 'Saved Views · open view';
+
+const controls = {
+ source: choiceControl<SavedViewSource>('Source', {
+ group: VIEW,
+ description: 'Which explorer the views belong to.',
+ options: SAVED_VIEW_SOURCES,
+ value: SavedviewtypesSourceDTO.traces,
+ }),
+ openView: choiceControl<OpenView>('Open view', {
+ group: VIEW,
+ description:
+ 'The `viewKey` the explorer url carries. `unsaved-changes` stages a query that differs from the view, which swaps in the ✓ save menu; `forbidden`, `failed` and `not-found` are the 403, 500 and 404 the view fetch answers with; each shows View failed to load.',
+ options: OPEN_VIEWS,
+ value: 'none',
+ }),
+ unreadableView: toggleControl('Unreadable view', {
+ group: VIEW,
+ description:
+ 'Denies `read` on the first view created by others alone, on top of the Access controls: its row greys out, and with Open view on `created-by-others` the header shows No view access.',
+ value: false,
+ }),
+ createdByMe: countControl('Created by me', {
+ group: LIST,
+ value: 3,
+ max: SAVED_VIEWS_MAX,
+ }),
+ createdByOthers: countControl('Created by others', {
+ group: LIST,
+ description: 'Both at 0 is the empty state, with its Create view button.',
+ value: 4,
+ max: SAVED_VIEWS_MAX,
+ }),
+};
+
+type SavedViewsValues = MockControlValues<typeof controls>;
+
+type WrittenView = Pick<SavedviewtypesSavedViewDTO, 'spec' | 'source'>;
+
+const viewDenied = (
+ transaction: AuthtypesTransactionDTO,
+ deniedId: string,
+): boolean =>
+ transaction.relation === 'read' &&
+ transaction.object.resource.kind === 'saved-view' &&
+ transaction.object.selector === deniedId;
+
+const definition = defineStoryMocks({
+ controls,
+ handlers: (
+ values: SavedViewsValues & AuthzArgs,
+ response,
+ ): RequestHandler[] => {
+ const { source, openView, createdByMe, createdByOthers } = values;
+
+ // What the panel writes stays in this handler set until a control changes.
+ const created: SavedviewtypesSavedViewDTO[] = [];
+ const updated = new Map<string, WrittenView>();
+ const deleted = new Set<string>();
+
+ const current = (
+ view: SavedviewtypesSavedViewDTO,
+ ): SavedviewtypesSavedViewDTO => ({ ...view, ...updated.get(view.id) });
+
+ const findView = (id: string): SavedviewtypesSavedViewDTO | undefined => {
+ const view = created.find((item) => item.id === id) ?? savedViewById(id);
+
+ return view && !deleted.has(id) ? current(view) : undefined;
+ };
+
+ const openError = OPEN_VIEW_ERRORS[openView];
+
+ return [
+ rest.post(API, async (req, res, ctx) => {
+ const body = (await req.json()) as SavedviewtypesUpdatableSavedViewDTO;
+ const id = `storybook-${source}-created-${created.length + 1}`;
+
+ created.push(createdSavedView(source, id, body.spec));
+
+ return res(ctx.status(201), ctx.json({ status: 'success', data: { id } }));
+ }),
+
+ rest.get(
+ API,
+ response.json(() => {
+ const list = savedViewsListResponse(source, createdByMe, createdByOthers);
+
+ return {
+ ...list,
+ data: [...(list.data ?? []), ...created]
+ .filter((view) => !deleted.has(view.id))
+ .map(current),
+ };
+ }),
+ ),
+
+ rest.get(`${API}/:id`, (req, res, ctx) => {
+ if (openError) {
+ return res(ctx.status(openError.status), ctx.json(openError.body));
+ }
+
+ const view = findView(String(req.params.id));
+
+ if (!view) {
+ return res(ctx.status(404), ctx.json(OPEN_VIEW_ERRORS['not-found']?.body));
+ }
+
+ return response.json(() => savedViewResponse(view))(req, res, ctx);
+ }),
+
+ rest.put(`${API}/:id`, async (req, res, ctx) => {
+ const body = (await req.json()) as SavedviewtypesUpdatableSavedViewDTO;
+
+ updated.set(String(req.params.id), {
+ spec: body.spec,
+ source: body.source,
+ });
+
+ return res(ctx.status(204));
+ }),
+
+ rest.delete(`${API}/:id`, (req, res, ctx) => {
+ deleted.add(String(req.params.id));
+
+ return res(ctx.status(204));
+ }),
+
+ ...(values.unreadableView
+ ? [
+ rest.post(
+ AUTHZ_CHECK_URL,
+ respondWith(values.authzState, async (req) => {
+ const payload = (await req.json()) as AuthtypesTransactionDTO[];
+ const granted = accessFor(
+ values.access,
+ values.permissions,
+ values.revoked,
+ );
+ const deniedId = unreadableViewId(source);
+
+ return authzMockResponse(
+ payload,
+ payload.map(
+ (transaction) =>
+ !viewDenied(transaction, deniedId) && granted.allows(transaction),
+ ),
+ );
+ }),
+ ),
+ ]
+ : []),
+ ];
+ },
+ config: ({ source, openView }) => ({
+ route: savedViewRoute(source, openView),
+ }),
+ effect: () => {
+ remove(LOCALSTORAGE.LAST_USED_SAVED_VIEWS);
+ },
+});
+
+/**
+ * The per-view read denial answers `authz/check` in place of the global access
+ * mocks, so it reads their controls as well as its own to answer every other
+ * check the way they would.
+ */
+export const savedViewsMocks: StoryMocks<typeof controls> = {
+ ...definition,
+ read: (args) => ({ ...authzMocks.read(args), ...definition.read(args) }),
+};
diff --git a/frontend/src/container/SavedViews/stories/SavedViews.stories.tsx b/frontend/src/container/SavedViews/stories/SavedViews.stories.tsx
new file mode 100644
index 0000000000..a6d015c1f8
--- /dev/null
+++ b/frontend/src/container/SavedViews/stories/SavedViews.stories.tsx
@@ -0,0 +1,114 @@
+import type { Meta, StoryObj } from '@storybook/react-vite';
+import { TooltipProvider } from '@signozhq/ui/tooltip';
+import { SIDEBAR_TOOLTIP_DELAY_MS } from 'components/QuickFilters/QuickFiltersLayout/constants';
+import { expect, screen, userEvent, waitFor, within } from 'storybook/test';
+
+import { storyMocks } from '@/storybook/controls/defineStoryMocks';
+import { withCanvas } from '@/storybook/decorators/withCanvas';
+import type { PageStoryArgs } from '@/storybook/runtime/resolveStory';
+
+import SavedViewsHeader from '../SavedViewsHeader';
+import SavedViewsPanel from '../SavedViewsPanel';
+import { savedViewsMocks } from './SavedViews.stories.mocks';
+
+type SavedViewsArgs = PageStoryArgs<typeof savedViewsMocks>;
+
+const componentStory = storyMocks(savedViewsMocks);
+
+/** The panel fetches the list and checks every row's permissions before it settles. */
+const untilLoaded = { timeout: 15_000 };
+
+/**
+ * The saved views sidebar of an explorer without quick filters: the header with
+ * the open view and its actions, above the list of views created by the user
+ * and by others. Every action is gated on the `saved-view` authz permissions
+ * (list, create, and read, update and delete per view).
+ *
+ * Route: the explorer of the Source control, with the Open view control's
+ * `viewKey`.
+ */
+const meta = {
+ title: 'Components/Saved Views',
+ tags: ['authz', 'play'],
+ component: SavedViewsPanel,
+ decorators: [
+ withCanvas({
+ width: 280,
+ height: 640,
+ padding: 0,
+ display: 'flex',
+ flexDirection: 'column',
+ borderRight: '1px solid var(--l1-border)',
+ }),
+ ],
+ render: ({ source }): JSX.Element => (
+ <TooltipProvider delay={SIDEBAR_TOOLTIP_DELAY_MS}>
+ <SavedViewsHeader source={source} />
+ <SavedViewsPanel source={source} />
+ </TooltipProvider>
+ ),
+ ...componentStory,
+ parameters: { ...componentStory.parameters },
+} satisfies Meta<SavedViewsArgs>;
+
+export default meta;
+
+type Story = StoryObj<SavedViewsArgs>;
+
+/** Traces views created by the user and by others, with no view open. */
+export const Default: Story = {};
+
+/** A workspace with no views yet: the empty state offers Create view. */
+export const Empty: Story = {
+ args: { createdByMe: 0, createdByOthers: 0 },
+};
+
+/**
+ * A view open with a query that differs from what it saved: the name carries
+ * the unsaved dot, and ✓ and discard replace Clear view.
+ */
+export const UnsavedChanges: Story = {
+ args: { openView: 'unsaved-changes' },
+};
+
+/** Without `list` on saved views, the panel shows the permission callout. */
+export const NoAccess: Story = {
+ args: { revoked: ['list:saved-view'] },
+};
+
+/**
+ * The first row's menu. Edit details and Delete follow `update` and `delete` on
+ * that view, so revoking either disables its item.
+ */
+export const RowMenu: Story = {
+ play: async ({ canvasElement }): Promise<void> => {
+ const [row] = await within(canvasElement).findAllByTestId(
+ 'saved-views-row',
+ undefined,
+ untilLoaded,
+ );
+
+ await userEvent.click(within(row).getByTestId('saved-views-row-menu'));
+ await screen.findByRole('menu', undefined, untilLoaded);
+ },
+};
+
+/**
+ * The ✓ menu on a view with unsaved changes. Save as new view follows `create`
+ * and Update selected view follows `update` on the open view.
+ */
+export const SaveChangesMenu: Story = {
+ args: { openView: 'unsaved-changes' },
+ play: async ({ canvasElement }): Promise<void> => {
+ const trigger = await waitFor(async () => {
+ const button = within(canvasElement).getByTestId('saved-views-save-changes');
+
+ await expect(button).not.toHaveAttribute('aria-busy');
+
+ return button;
+ }, untilLoaded);
+
+ await userEvent.click(trigger);
+ await screen.findByRole('menu', undefined, untilLoaded);
+ },
+};
diff --git a/frontend/src/container/SavedViews/stories/__story_mockdata__/savedViews.ts b/frontend/src/container/SavedViews/stories/__story_mockdata__/savedViews.ts
new file mode 100644
index 0000000000..c47422ac30
--- /dev/null
+++ b/frontend/src/container/SavedViews/stories/__story_mockdata__/savedViews.ts
@@ -0,0 +1,309 @@
+/**
+ * AI-owned. Generated and maintained by the `signoz-page-story` skill.
+ * Do not hand-edit: regenerate instead.
+ */
+
+import type {
+ GetSavedView200,
+ ListSavedViews200,
+ RenderErrorResponseDTO,
+ SavedviewtypesSavedViewDTO,
+} from 'api/generated/services/sigNoz.schemas';
+import {
+ SavedviewtypesSchemaVersionDTO,
+ SavedviewtypesSourceDTO,
+} from 'api/generated/services/sigNoz.schemas';
+import { QueryParams } from 'constants/query';
+import {
+ initialQueriesMap,
+ initialQueryMeterWithType,
+ PANEL_TYPES,
+} from 'constants/queryBuilder';
+import ROUTES from 'constants/routes';
+import { getSavedViewQuery } from 'container/SavedViews/utils/getSavedViewQuery';
+import { toSavedViewSpec } from 'container/SavedViews/utils/toSavedViewSpec';
+import { createAppContextMock } from 'tests/fixtures/appContextMock';
+import type { Query } from 'types/api/queryBuilder/queryBuilderData';
+import { USER_ROLES } from 'types/roles';
+
+export const SAVED_VIEW_SOURCES = [
+ SavedviewtypesSourceDTO.traces,
+ SavedviewtypesSourceDTO.logs,
+ SavedviewtypesSourceDTO.metrics,
+ SavedviewtypesSourceDTO.meter,
+] as const;
+
+export type SavedViewSource = (typeof SAVED_VIEW_SOURCES)[number];
+
+export const OPEN_VIEWS = [
+ 'none',
+ 'created-by-me',
+ 'created-by-others',
+ 'unsaved-changes',
+ 'forbidden',
+ 'failed',
+ 'not-found',
+] as const;
+
+export type OpenView = (typeof OPEN_VIEWS)[number];
+
+export const SAVED_VIEWS_MAX = 8;
+
+/** The user the story app context signs in as, so "Created by me" follows it. */
+const STORY_USER_EMAIL = createAppContextMock(USER_ROLES.ADMIN).user.email;
+
+const OTHER_AUTHORS = ['[email protected]', '[email protected]', '[email protected]'];
+
+const MY_VIEW_NAMES = [
+ 'Checkout errors',
+ 'Slow payment calls',
+ 'Cart service, production',
+ 'Auth retries',
+ 'Inventory sync',
+ 'Search p99 regressions',
+ 'Webhook failures',
+ 'Cold starts after deploy',
+];
+
+const OTHER_VIEW_NAMES = [
+ 'On-call triage',
+ 'Frontend 5xx',
+ 'Shipping latency by region',
+ 'Kafka consumer lag',
+ 'Staging smoke tests',
+ 'Recommendation timeouts',
+ 'Ad service sampling',
+ 'Email queue backlog',
+];
+
+const EXPRESSIONS = [
+ "service.name = 'checkout' AND has_error = true",
+ "service.name = 'payments'",
+ "service.name = 'cart' AND deployment.environment = 'production'",
+ "service.name = 'auth'",
+ "service.name IN ('inventory', 'catalog')",
+ "service.name = 'search'",
+ "service.name = 'webhooks' AND has_error = true",
+ "deployment.environment = 'production'",
+];
+
+const BASE_QUERY: Record<SavedViewSource, Query> = {
+ traces: initialQueriesMap.traces,
+ logs: initialQueriesMap.logs,
+ metrics: initialQueriesMap.metrics,
+ meter: initialQueryMeterWithType,
+};
+
+const EXPLORER_ROUTE: Record<SavedViewSource, string> = {
+ traces: ROUTES.TRACES_EXPLORER,
+ logs: ROUTES.LOGS_EXPLORER,
+ metrics: ROUTES.METRICS_EXPLORER_EXPLORER,
+ meter: ROUTES.METER_EXPLORER,
+};
+
+const queryWith = (source: SavedViewSource, expression: string): Query => {
+ const base = BASE_QUERY[source];
+
+ return {
+ ...base,
+ builder: {
+ ...base.builder,
+ queryData: [
+ {
+ ...base.builder.queryData[0],
+ filter: { expression },
+ aggregations: [{ expression: 'count()' }],
+ },
+ ],
+ },
+ } as Query;
+};
+
+type Author = 'mine' | 'others';
+
+const viewId = (
+ source: SavedViewSource,
+ author: Author,
+ index: number,
+): string => `storybook-${source}-${author}-${index + 1}`;
+
+/** The view other people made that the per-view read denial applies to. */
+export const unreadableViewId = (source: SavedViewSource): string =>
+ viewId(source, 'others', 0);
+
+const savedView = (
+ source: SavedViewSource,
+ author: Author,
+ index: number,
+): SavedviewtypesSavedViewDTO => {
+ const displayName = (author === 'mine' ? MY_VIEW_NAMES : OTHER_VIEW_NAMES)[
+ index
+ ];
+ const createdBy =
+ author === 'mine'
+ ? STORY_USER_EMAIL
+ : OTHER_AUTHORS[index % OTHER_AUTHORS.length];
+ const id = viewId(source, author, index);
+
+ return {
+ id,
+ name: id,
+ source,
+ schemaVersion: SavedviewtypesSchemaVersionDTO.v2,
+ createdAt: '2026-09-02T08:30:00Z',
+ createdBy,
+ updatedAt: `2026-10-${String(14 - (index % 10)).padStart(2, '0')}T11:42:00Z`,
+ updatedBy: createdBy,
+ spec: toSavedViewSpec({
+ query: queryWith(
+ source,
+ EXPRESSIONS[(index + (author === 'mine' ? 0 : 3)) % EXPRESSIONS.length],
+ ),
+ panelType: PANEL_TYPES.LIST,
+ displayName,
+ }),
+ };
+};
+
+const savedViews = (
+ source: SavedViewSource,
+ author: Author,
+ count: number,
+): SavedviewtypesSavedViewDTO[] =>
+ Array.from({ length: Math.min(count, SAVED_VIEWS_MAX) }, (_, index) =>
+ savedView(source, author, index),
+ );
+
+export const savedViewsListResponse = (
+ source: SavedViewSource,
+ createdByMe: number,
+ createdByOthers: number,
+): ListSavedViews200 => ({
+ status: 'success',
+ data: [
+ ...savedViews(source, 'mine', createdByMe),
+ ...savedViews(source, 'others', createdByOthers),
+ ],
+});
+
+/** Every view the workspace has, whatever the list control trims it to. */
+export const savedViewById = (
+ id: string,
+): SavedviewtypesSavedViewDTO | undefined =>
+ SAVED_VIEW_SOURCES.flatMap((source) => [
+ ...savedViews(source, 'mine', SAVED_VIEWS_MAX),
+ ...savedViews(source, 'others', SAVED_VIEWS_MAX),
+ ]).find((view) => view.id === id);
+
+/** A view the panel itself created, owned by the story user. */
+export const createdSavedView = (
+ source: SavedViewSource,
+ id: string,
+ spec: SavedviewtypesSavedViewDTO['spec'],
+): SavedviewtypesSavedViewDTO => ({
+ ...savedView(source, 'mine', 0),
+ id,
+ name: id,
+ createdAt: '2026-10-16T09:00:00Z',
+ updatedAt: '2026-10-16T09:00:00Z',
+ spec,
+});
+
+export const savedViewResponse = (
+ view: SavedviewtypesSavedViewDTO,
+): GetSavedView200 => ({ status: 'success', data: view });
+
+export const OPEN_VIEW_ERRORS: Partial<
+ Record<OpenView, { status: number; body: RenderErrorResponseDTO }>
+> = {
+ forbidden: {
+ status: 403,
+ body: {
+ status: 'error',
+ error: {
+ code: 'forbidden',
+ message: 'You do not have access to this saved view',
+ errors: [],
+ suggestions: [],
+ type: 'forbidden',
+ },
+ },
+ },
+ failed: {
+ status: 500,
+ body: {
+ status: 'error',
+ error: {
+ code: 'internal',
+ message: 'Failed to load the saved view',
+ errors: [],
+ suggestions: [],
+ type: 'internal',
+ },
+ },
+ },
+ 'not-found': {
+ status: 404,
+ body: {
+ status: 'error',
+ error: {
+ code: 'not_found',
+ message: 'Saved view not found',
+ errors: [],
+ suggestions: [],
+ type: 'not_found',
+ },
+ },
+ },
+};
+
+const openViewId = (source: SavedViewSource, open: OpenView): string | null => {
+ if (open === 'none') {
+ return null;
+ }
+
+ if (open === 'created-by-others' || open === 'forbidden') {
+ return viewId(source, 'others', 0);
+ }
+
+ if (open === 'not-found') {
+ return `storybook-${source}-deleted`;
+ }
+
+ return viewId(source, 'mine', 0);
+};
+
+/**
+ * The explorer url with a view open, its params written the way
+ * `redirectWithQueryBuilderData` writes them. `panelTypes` is left out: the
+ * query builder seeds its panel type from the raw, JSON-quoted param, which no
+ * saved panel type equals, and without it the header compares against `list`.
+ */
+export const savedViewRoute = (
+ source: SavedViewSource,
+ open: OpenView,
+): string => {
+ const params = new URLSearchParams({ relativeTime: '15m' });
+ const id = openViewId(source, open);
+
+ if (id) {
+ const view = savedViewById(id);
+ const query = view
+ ? getSavedViewQuery(view)
+ : queryWith(source, EXPRESSIONS[0]);
+ const staged =
+ open === 'unsaved-changes'
+ ? queryWith(source, `${EXPRESSIONS[0]} AND duration_nano > 500000000`)
+ : query;
+
+ params.set(
+ QueryParams.compositeQuery,
+ encodeURIComponent(
+ JSON.stringify({ ...staged, id: `storybook-staged-${open}` }),
+ ),
+ );
+ params.set(QueryParams.viewKey, JSON.stringify(id));
+ }
+
+ return `${EXPLORER_ROUTE[source]}?${params.toString()}`;
+};
diff --git a/frontend/src/container/SavedViews/types.ts b/frontend/src/container/SavedViews/types.ts
index d97ca53ccc..b95162641e 100644
--- a/frontend/src/container/SavedViews/types.ts
+++ b/frontend/src/container/SavedViews/types.ts
@@ -1,5 +1,6 @@
import { ReactElement, ReactNode } from 'react';
import type { Link } from '@signozhq/icons';
+import type { BrandedPermission } from 'lib/authz/hooks/useAuthZ/types';
import {
SavedviewtypesSavedViewDTO,
SavedviewtypesSourceDTO,
@@ -41,6 +42,8 @@ export interface UseActiveSavedViewResult {
view: SavedviewtypesSavedViewDTO | undefined;
isLoading: boolean;
isError: boolean;
+ isReadDenied: boolean;
+ errorMessage: string | undefined;
hasUnsavedChanges: boolean;
}
@@ -70,6 +73,7 @@ export interface SaveViewModalProps {
}
export interface SaveChangesMenuProps {
+ viewId: string;
disabled: boolean;
onSaveAsNew: () => void;
onUpdate: () => void;
@@ -82,6 +86,7 @@ export interface SavedViewsIconButtonProps {
color?: 'secondary' | 'warning';
disabled?: boolean;
disabledTooltip?: ReactNode;
+ checks?: BrandedPermission[];
onClick?: () => void;
}
@@ -116,7 +121,11 @@ export interface SavedViewsListRowProps {
hover: SavedViewsListRowHoverProps;
}
-export type SavedViewRowActionKey = 'copyLink' | 'editDetails' | 'delete';
+export type SavedViewRowActionKey =
+ | 'copyLink'
+ | 'copyId'
+ | 'editDetails'
+ | 'delete';
export interface SavedViewRowActionConfig {
key: SavedViewRowActionKey;
@@ -124,10 +133,11 @@ export interface SavedViewRowActionConfig {
icon: typeof Link;
danger?: boolean;
hasDividerBefore?: boolean;
+ buildPermission?: (id: string) => BrandedPermission;
}
export interface PendingSavedViewAction {
- key: Exclude<SavedViewRowActionKey, 'copyLink'>;
+ key: Exclude<SavedViewRowActionKey, 'copyLink' | 'copyId'>;
view: SavedviewtypesSavedViewDTO;
}
@@ -140,6 +150,7 @@ export interface SavedViewsRowButtonProps {
}
export interface SavedViewsRowMenuProps {
+ viewId: string;
onAction: (key: SavedViewRowActionKey) => void;
onOpen: () => void;
}
@@ -152,6 +163,7 @@ export interface DeleteSavedViewDialogProps {
export interface UseSavedViewRowActionsResult {
copyViewLink: (view: SavedviewtypesSavedViewDTO) => void;
+ copyViewId: (view: SavedviewtypesSavedViewDTO) => void;
renameView: (
view: SavedviewtypesSavedViewDTO,
displayName: string,
diff --git a/frontend/src/lib/authz/hooks/useAuthZ/permissions.type.ts b/frontend/src/lib/authz/hooks/useAuthZ/permissions.type.ts
index 8204871acc..b5f22658c2 100644
--- a/frontend/src/lib/authz/hooks/useAuthZ/permissions.type.ts
+++ b/frontend/src/lib/authz/hooks/useAuthZ/permissions.type.ts
@@ -23,6 +23,11 @@ export default {
type: 'metaresource',
allowedVerbs: ['list', 'read', 'update'],
},
+ {
+ kind: 'saved-view',
+ type: 'metaresource',
+ allowedVerbs: ['create', 'delete', 'list', 'read', 'update'],
+ },
{
kind: 'subscription',
type: 'metaresource',
diff --git a/frontend/src/lib/authz/hooks/useAuthZ/permissions/saved-view.permissions.ts b/frontend/src/lib/authz/hooks/useAuthZ/permissions/saved-view.permissions.ts
new file mode 100644
index 0000000000..7132335206
--- /dev/null
+++ b/frontend/src/lib/authz/hooks/useAuthZ/permissions/saved-view.permissions.ts
@@ -0,0 +1,15 @@
+import type { BrandedPermission } from '../types';
+import { buildPermission } from '../utils';
+
+export const SavedViewListPermission = buildPermission('list', 'saved-view:*');
+export const SavedViewCreatePermission = buildPermission(
+ 'create',
+ 'saved-view:*',
+);
+
+export const buildSavedViewReadPermission = (id: string): BrandedPermission =>
+ buildPermission('read', `saved-view:${id}`);
+export const buildSavedViewUpdatePermission = (id: string): BrandedPermission =>
+ buildPermission('update', `saved-view:${id}`);
+export const buildSavedViewDeletePermission = (id: string): BrandedPermission =>
+ buildPermission('delete', `saved-view:${id}`);