Skip to content

SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.

chore: enable ai 011y processors by default (#12912)

Nityananda Gohainea8f95ee087c
diff --git a/pkg/modules/llmpricingrule/impllmpricingrule/module.go b/pkg/modules/llmpricingrule/impllmpricingrule/module.go
index 4036b0ea09..c7ebe8118f 100644
--- a/pkg/modules/llmpricingrule/impllmpricingrule/module.go
+++ b/pkg/modules/llmpricingrule/impllmpricingrule/module.go
@@ -7,12 +7,10 @@ import (
"time"
"github.com/SigNoz/signoz/pkg/errors"
- "github.com/SigNoz/signoz/pkg/flagger"
"github.com/SigNoz/signoz/pkg/modules/llmpricingrule"
"github.com/SigNoz/signoz/pkg/querier"
"github.com/SigNoz/signoz/pkg/query-service/agentConf"
"github.com/SigNoz/signoz/pkg/types/aiobservabilitytypes"
- "github.com/SigNoz/signoz/pkg/types/featuretypes"
"github.com/SigNoz/signoz/pkg/types/llmpricingruletypes"
"github.com/SigNoz/signoz/pkg/types/opamptypes"
qbtypes "github.com/SigNoz/signoz/pkg/types/querybuildertypes/querybuildertypesv5"
@@ -26,11 +24,10 @@ const unmappedModelsLookback = time.Hour
type module struct {
store llmpricingruletypes.Store
querier querier.Querier
- flagger flagger.Flagger
}
-func NewModule(store llmpricingruletypes.Store, flagger flagger.Flagger, querier querier.Querier) llmpricingrule.Module {
- return &module{store: store, flagger: flagger, querier: querier}
+func NewModule(store llmpricingruletypes.Store, querier querier.Querier) llmpricingrule.Module {
+ return &module{store: store, querier: querier}
}
func (module *module) List(ctx context.Context, orgID valuer.UUID, offset, limit int, search string, isOverride *bool) ([]*llmpricingruletypes.LLMPricingRule, int, error) {
@@ -123,16 +120,6 @@ func (module *module) AgentFeatureType() agentConf.AgentFeatureType {
func (module *module) RecommendAgentConfig(orgID valuer.UUID, currentConfYaml []byte, configVersion *opamptypes.AgentConfigVersion) ([]byte, string, error) {
ctx := context.Background()
- // Skip the llm pricing processor unless AI observability is enabled for the org.
- evalCtx := featuretypes.NewFlaggerEvaluationContext(orgID)
- enabled, err := module.flagger.Boolean(ctx, flagger.FeatureEnableAIObservability, evalCtx)
- if err != nil {
- return nil, "", err
- }
- if !enabled {
- return currentConfYaml, "", nil
- }
-
rules, err := module.getEnabledRules(ctx, orgID)
if err != nil {
return nil, "", err
diff --git a/pkg/modules/spanmapper/implspanmapper/module.go b/pkg/modules/spanmapper/implspanmapper/module.go
index 02d77e5480..e442b7d179 100644
--- a/pkg/modules/spanmapper/implspanmapper/module.go
+++ b/pkg/modules/spanmapper/implspanmapper/module.go
@@ -6,10 +6,8 @@ import (
"github.com/SigNoz/signoz/pkg/errors"
"github.com/SigNoz/signoz/pkg/factory"
- "github.com/SigNoz/signoz/pkg/flagger"
"github.com/SigNoz/signoz/pkg/modules/spanmapper"
"github.com/SigNoz/signoz/pkg/query-service/agentConf"
- "github.com/SigNoz/signoz/pkg/types/featuretypes"
"github.com/SigNoz/signoz/pkg/types/opamptypes"
"github.com/SigNoz/signoz/pkg/types/spantypes"
"github.com/SigNoz/signoz/pkg/valuer"
@@ -21,15 +19,13 @@ const maxTestSpans = 100
type module struct {
store spantypes.SpanMapperStore
- flagger flagger.Flagger
registry spantypes.SpanMapperGroupRegistry
settings factory.ScopedProviderSettings
}
-func NewModule(store spantypes.SpanMapperStore, flagger flagger.Flagger, registry spantypes.SpanMapperGroupRegistry, providerSettings factory.ProviderSettings) spanmapper.Module {
+func NewModule(store spantypes.SpanMapperStore, registry spantypes.SpanMapperGroupRegistry, providerSettings factory.ProviderSettings) spanmapper.Module {
return &module{
store: store,
- flagger: flagger,
registry: registry,
settings: factory.NewScopedProviderSettings(providerSettings, "github.com/SigNoz/signoz/pkg/modules/spanmapper/implspanmapper"),
}
@@ -149,16 +145,6 @@ func (module *module) AgentFeatureType() agentConf.AgentFeatureType {
func (module *module) RecommendAgentConfig(orgID valuer.UUID, currentConfYaml []byte, configVersion *opamptypes.AgentConfigVersion) ([]byte, string, error) {
ctx := context.Background()
- // Skip the llm pricing processor unless AI observability is enabled for the org.
- evalCtx := featuretypes.NewFlaggerEvaluationContext(orgID)
- enabled, err := module.flagger.Boolean(ctx, flagger.FeatureEnableAIObservability, evalCtx)
- if err != nil {
- return nil, "", err
- }
- if !enabled {
- return currentConfYaml, "", nil
- }
-
enabledMappers, err := module.listEnabledGroupsWithMappers(ctx, orgID)
if err != nil {
return nil, "", err
@@ -169,7 +155,7 @@ func (module *module) RecommendAgentConfig(orgID valuer.UUID, currentConfYaml []
return nil, "", err
}
- serialized, err := json.Marshal(enabled)
+ serialized, err := json.Marshal(enabledMappers)
if err != nil {
return nil, "", err
}
diff --git a/pkg/modules/spanmapper/implspanmapper/module_test.go b/pkg/modules/spanmapper/implspanmapper/module_test.go
index 1e56cb7280..6a7b660a78 100644
--- a/pkg/modules/spanmapper/implspanmapper/module_test.go
+++ b/pkg/modules/spanmapper/implspanmapper/module_test.go
@@ -55,7 +55,7 @@ func newTestModule(t *testing.T, sqlStore sqlstore.SQLStore, definitions ...span
registry, err := spantypes.NewSpanMapperGroupRegistry(definitions)
require.NoError(t, err)
- return NewModule(NewStore(sqlStore), nil, registry, factorytest.NewSettings()).(*module)
+ return NewModule(NewStore(sqlStore), registry, factorytest.NewSettings()).(*module)
}
func newTestDefinition(t *testing.T, version int, body string) spantypes.SpanMapperGroupDefinition {
diff --git a/pkg/signoz/handler_test.go b/pkg/signoz/handler_test.go
index 13ea21c37c..19df4184a1 100644
--- a/pkg/signoz/handler_test.go
+++ b/pkg/signoz/handler_test.go
@@ -64,7 +64,7 @@ func TestNewHandlers(t *testing.T) {
retentionGetter := implretention.NewGetter(implretention.NewStore(sqlstore))
spanMapperRegistry, err := implspanmapper.NewSystemGroupRegistry()
require.NoError(t, err)
- spanMapperModule := implspanmapper.NewModule(implspanmapper.NewStore(sqlstore), flagger, spanMapperRegistry, providerSettings)
+ spanMapperModule := implspanmapper.NewModule(implspanmapper.NewStore(sqlstore), spanMapperRegistry, providerSettings)
modules := NewModules(sqlstore, tokenizer, emailing, providerSettings, orgGetter, alertmanager, nil, nil, nil, nil, nil, nil, nil, queryParser, Config{}, dashboardModule, userGetter, userRoleStore, nil, nil, nil, retentionGetter, flagger, tagModule, nil, spanMapperModule)
querierHandler := querier.NewHandler(providerSettings, nil, nil)
diff --git a/pkg/signoz/module.go b/pkg/signoz/module.go
index d591d14c74..7a7e78b693 100644
--- a/pkg/signoz/module.go
+++ b/pkg/signoz/module.go
@@ -163,7 +163,7 @@ func NewModules(
CloudIntegration: cloudIntegrationModule,
TraceDetail: impltracedetail.NewModule(impltracedetail.NewTraceStore(telemetryStore), providerSettings, config.TraceDetail),
SpanMapper: spanMapper,
- LLMPricingRule: impllmpricingrule.NewModule(impllmpricingrule.NewStore(sqlstore), fl, querier),
+ LLMPricingRule: impllmpricingrule.NewModule(impllmpricingrule.NewStore(sqlstore), querier),
Tag: tagModule,
}
}
diff --git a/pkg/signoz/module_test.go b/pkg/signoz/module_test.go
index 5b477786c3..42de89b28a 100644
--- a/pkg/signoz/module_test.go
+++ b/pkg/signoz/module_test.go
@@ -71,7 +71,7 @@ func TestNewModules(t *testing.T) {
spanMapperRegistry, err := implspanmapper.NewSystemGroupRegistry()
require.NoError(t, err)
- spanMapperModule := implspanmapper.NewModule(implspanmapper.NewStore(sqlstore), flagger, spanMapperRegistry, providerSettings)
+ spanMapperModule := implspanmapper.NewModule(implspanmapper.NewStore(sqlstore), spanMapperRegistry, providerSettings)
modules := NewModules(sqlstore, tokenizer, emailing, providerSettings, orgGetter, alertmanager, nil, nil, nil, nil, nil, nil, nil, queryParser, Config{}, dashboardModule, userGetter, userRoleStore, serviceAccount, serviceAccountGetter, implcloudintegration.NewModule(), retentionGetter, flagger, tagModule, implmetricreductionrule.NewModule(), spanMapperModule)
diff --git a/pkg/signoz/signoz.go b/pkg/signoz/signoz.go
index 6a0d01bd44..6696dbccd0 100644
--- a/pkg/signoz/signoz.go
+++ b/pkg/signoz/signoz.go
@@ -533,7 +533,7 @@ func New(
if err != nil {
return nil, err
}
- spanMapperModule := implspanmapper.NewModule(implspanmapper.NewStore(sqlstore), flagger, spanMapperRegistry, providerSettings)
+ spanMapperModule := implspanmapper.NewModule(implspanmapper.NewStore(sqlstore), spanMapperRegistry, providerSettings)
modules := NewModules(sqlstore, tokenizer, emailing, providerSettings, orgGetter, alertmanager, analytics, querier, telemetrystore, telemetryMetadataStore, authNs, authz, cache, queryParser, config, dashboard, userGetter, userRoleStore, serviceAccount, serviceAccountGetter, cloudIntegrationModule, retentionGetter, flagger, tagModule, metricReductionRuleModule, spanMapperModule)
diff --git a/pkg/types/llmpricingruletypes/processorconfig.go b/pkg/types/llmpricingruletypes/processorconfig.go
index 057a1beaaf..5385f85a28 100644
--- a/pkg/types/llmpricingruletypes/processorconfig.go
+++ b/pkg/types/llmpricingruletypes/processorconfig.go
@@ -61,8 +61,12 @@ type LLMPricingRuleProcessorOutputAttrs struct {
func buildProcessorConfig(rules []*LLMPricingRule) *LLMPricingRuleProcessorConfig {
pricingRules := make([]LLMPricingRuleProcessor, 0, len(rules))
for _, r := range rules {
+ // The collector rejects negative prices (providers use them for "unknown").
+ if r.Pricing.Input < 0 || r.Pricing.Output < 0 {
+ continue
+ }
var cache *LLMPricingRuleProcessorCache
- if r.Pricing.Cache != nil {
+ if r.Pricing.Cache != nil && r.Pricing.Cache.Read >= 0 && r.Pricing.Cache.Write >= 0 {
mode := r.Pricing.Cache.Mode.StringValue()
if mode != LLMPricingRuleCacheModeSubtract.StringValue() && mode != LLMPricingRuleCacheModeAdditive.StringValue() {
mode = ""
diff --git a/pkg/types/llmpricingruletypes/processorconfig_test.go b/pkg/types/llmpricingruletypes/processorconfig_test.go
index 04819b708d..21a11aa7c9 100644
--- a/pkg/types/llmpricingruletypes/processorconfig_test.go
+++ b/pkg/types/llmpricingruletypes/processorconfig_test.go
@@ -90,6 +90,15 @@ func TestGenerateCollectorConfigWithLLMPricingProcessor(t *testing.T) {
},
expectedFile: "collector_rule_cache_mode_unknown.yaml",
},
+ // Negative in/out drops the rule; a negative cache price drops only the cache block.
+ {
+ name: "negative_prices",
+ rules: []*LLMPricingRule{
+ makePricingRule("openrouter/auto", []string{"openrouter/auto", "auto"}, LLMPricingRuleCacheModeSubtract, -1, -1, -1, -1),
+ makePricingRule("gpt-4o", []string{"gpt-4o*"}, LLMPricingRuleCacheModeSubtract, 5.0, 15.0, -1, 0),
+ },
+ expectedFile: "collector_rule_without_cache.yaml",
+ },
}
input, err := os.ReadFile(filepath.Join("testdata", "collector_baseline.yaml"))