Skip to content

SigNoz is an open-source, OpenTelemetry-native observability platform for your team and their AI agents. Get logs, metrics, and traces in one tool with features like APM, distributed tracing, log management, infra monitoring, etc. Combined with SigNoz MCP and a native AI teammate (in SigNoz Cloud) it helps you build more resilient apps.

fix(bottom-strip): size pages from the layout instead of the viewport (#12940)

Aditya Singhed1bf7ab89c9
diff --git a/frontend/src/container/Home/Home.styles.scss b/frontend/src/container/Home/Home.styles.scss
index 3422b4e772..89e60c13b0 100644
--- a/frontend/src/container/Home/Home.styles.scss
+++ b/frontend/src/container/Home/Home.styles.scss
@@ -1,7 +1,6 @@
.home-container {
display: flex;
flex-direction: column;
- min-height: 100vh;
overflow-y: auto;
height: 100%;
width: 100%;
diff --git a/frontend/src/container/Licenses/Licenses.styles.scss b/frontend/src/container/Licenses/Licenses.styles.scss
index 32899a5706..4d162f4742 100644
--- a/frontend/src/container/Licenses/Licenses.styles.scss
+++ b/frontend/src/container/Licenses/Licenses.styles.scss
@@ -1,7 +1,4 @@
.licenses-page {
- max-height: 100vh;
- overflow: hidden;
-
.licenses-page-header {
border-bottom: 1px solid var(--l1-border);
background: var(--l1-background);
@@ -32,7 +29,6 @@
.licenses-page-content {
flex: 1;
- height: calc(100vh - 48px);
background: var(--l1-background);
padding: 10px 8px;
overflow-y: auto;
diff --git a/frontend/src/container/ListAlertRules/ListAlertRules.module.scss b/frontend/src/container/ListAlertRules/ListAlertRules.module.scss
index 55cc837821..97ecaeb730 100644
--- a/frontend/src/container/ListAlertRules/ListAlertRules.module.scss
+++ b/frontend/src/container/ListAlertRules/ListAlertRules.module.scss
@@ -2,7 +2,7 @@
display: flex;
flex-direction: column;
gap: 1rem;
- height: calc(100vh - 62px);
+ flex: 1;
min-height: 400px;
}
diff --git a/frontend/src/container/TriggeredAlerts/TriggeredAlerts.module.scss b/frontend/src/container/TriggeredAlerts/TriggeredAlerts.module.scss
index 6e6fd4ed5f..73652175fb 100644
--- a/frontend/src/container/TriggeredAlerts/TriggeredAlerts.module.scss
+++ b/frontend/src/container/TriggeredAlerts/TriggeredAlerts.module.scss
@@ -2,7 +2,7 @@
display: flex;
flex-direction: column;
gap: 1rem;
- height: calc(100vh - 62px);
+ flex: 1;
min-height: 400px;
padding-top: var(--spacing-8);
}
diff --git a/frontend/src/container/Version/Version.styles.scss b/frontend/src/container/Version/Version.styles.scss
index c2b82e7b94..2dcf931684 100644
--- a/frontend/src/container/Version/Version.styles.scss
+++ b/frontend/src/container/Version/Version.styles.scss
@@ -1,7 +1,4 @@
.version-container {
- max-height: 100vh;
- overflow: hidden;
-
.version-page-header {
border-bottom: 1px solid var(--l1-border);
background: var(--l1-background);
diff --git a/frontend/src/pages/AlertList/AlertList.styles.scss b/frontend/src/pages/AlertList/AlertList.styles.scss
index 1e4c6efbab..5bad3c38cf 100644
--- a/frontend/src/pages/AlertList/AlertList.styles.scss
+++ b/frontend/src/pages/AlertList/AlertList.styles.scss
@@ -1,4 +1,29 @@
.alerts-container {
+ // Hands the page height down to the active tab so its content can bound itself
+ // instead of guessing with 100vh. Child combinators only, nested Tabs
+ // (Configuration) must not be caught.
+ flex: 1;
+ min-height: 0;
+
+ > .ant-tabs-content-holder {
+ display: flex;
+ flex-direction: column;
+
+ > .ant-tabs-content {
+ flex: 1;
+ min-height: 0;
+ display: flex;
+ flex-direction: column;
+
+ > .ant-tabs-tabpane-active {
+ flex: 1;
+ min-height: 0;
+ display: flex;
+ flex-direction: column;
+ }
+ }
+ }
+
.top-level-tab.periscope-tab {
padding: 2px 0;
}
@@ -40,5 +65,9 @@
.alert-rules-container {
margin-top: 10px;
+ flex: 1;
+ min-height: 0;
+ display: flex;
+ flex-direction: column;
}
}
diff --git a/frontend/src/pages/Support/Support.styles.scss b/frontend/src/pages/Support/Support.styles.scss
index 8c6be3b466..016ddc8bb7 100644
--- a/frontend/src/pages/Support/Support.styles.scss
+++ b/frontend/src/pages/Support/Support.styles.scss
@@ -1,7 +1,4 @@
.support-page-container {
- max-height: 100vh;
- overflow: hidden;
-
.support-page-header {
border-bottom: 1px solid var(--l1-border);
background: var(--l1-background);
diff --git a/frontend/src/pages/TraceDetailsV3/TraceDetailsV3.module.scss b/frontend/src/pages/TraceDetailsV3/TraceDetailsV3.module.scss
index 8a15c5f380..b48f3e638e 100644
--- a/frontend/src/pages/TraceDetailsV3/TraceDetailsV3.module.scss
+++ b/frontend/src/pages/TraceDetailsV3/TraceDetailsV3.module.scss
@@ -1,5 +1,6 @@
.root {
- height: calc(100vh);
+ flex: 1;
+ min-height: 0;
display: flex;
flex-direction: column;
}
diff --git a/frontend/src/pages/TracesFunnelDetails/TracesFunnelDetails.styles.scss b/frontend/src/pages/TracesFunnelDetails/TracesFunnelDetails.styles.scss
index f466127b4c..9a9f383a73 100644
--- a/frontend/src/pages/TracesFunnelDetails/TracesFunnelDetails.styles.scss
+++ b/frontend/src/pages/TracesFunnelDetails/TracesFunnelDetails.styles.scss
@@ -1,13 +1,24 @@
.traces-funnel-details {
display: flex;
- // 45px -> height of the tab bar
- height: calc(100vh - 45px);
+ height: 100%;
&__steps-config {
flex-shrink: 0;
width: 600px;
border-right: 1px solid var(--l1-border);
+ // Positioning context for the absolute .steps-footer.
position: relative;
+ display: flex;
+ flex-direction: column;
+
+ // Scoped here so the modal usage of FunnelConfiguration on trace details
+ // stays in normal flow.
+ .funnel-configuration {
+ flex: 1;
+ min-height: 0;
+ display: flex;
+ flex-direction: column;
+ }
}
&__steps-results {
width: 100%;
diff --git a/frontend/src/pages/TracesFunnelDetails/components/FunnelConfiguration/FunnelConfiguration.styles.scss b/frontend/src/pages/TracesFunnelDetails/components/FunnelConfiguration/FunnelConfiguration.styles.scss
index 4c36361e9d..7213643bc8 100644
--- a/frontend/src/pages/TracesFunnelDetails/components/FunnelConfiguration/FunnelConfiguration.styles.scss
+++ b/frontend/src/pages/TracesFunnelDetails/components/FunnelConfiguration/FunnelConfiguration.styles.scss
@@ -4,14 +4,17 @@
flex-direction: column;
justify-content: flex-start;
&.funnel-details-page {
- height: calc(
- 100vh - 170px
- ); // 64px bottom bar + 61px configuration header + 45px page navbar
+ flex: 1;
+ min-height: 0;
+ // .steps-footer is absolute against the config column, so its 64px is
+ // reserved rather than laid out.
+ margin-bottom: 64px;
overflow: auto;
}
}
&__header {
+ flex-shrink: 0;
display: flex;
align-items: center;
justify-content: space-between;