Skip to content

An open-source, privacy-first, self-hosted knowledge workspace where humans and AI agents work together 开源、隐私优先、自托管的知识工作空间,让人与智能体在此协作

13.8 KB
Raw Blame
// SiYuan - https://github.com/siyuan-note/siyuan
// Copyright (c) 2020-present, b3log.org
// SPDX-License-Identifier: AGPL-3.0-or-later

package model

import (
	"errors"
	"testing"

	"github.com/siyuan-note/siyuan/kernel/av"
)

func TestUpdateAttributeViewValuePreservesTargetIdentity(t *testing.T) {
	const (
		targetValueID   = "20260806000000-targetv"
		targetKeyID     = "20260806000001-targetk"
		targetItemID    = "20260806000002-targeti"
		sourceValueID   = "20260806000003-sourcev"
		sourceKeyID     = "20260806000004-sourcek"
		sourceItemID    = "20260806000005-sourcei"
		targetCreatedAt = int64(100)
	)
	target := &av.Value{
		ID:         targetValueID,
		KeyID:      targetKeyID,
		BlockID:    targetItemID,
		Type:       av.KeyTypeBlock,
		IsDetached: true,
		CreatedAt:  targetCreatedAt,
		UpdatedAt:  101,
		Block:      &av.ValueBlock{Content: "target"},
	}
	attrView := &av.AttributeView{
		ID: "20260806000006-avtest1",
		KeyValues: []*av.KeyValues{{
			Key:    &av.Key{ID: targetKeyID, Type: av.KeyTypeBlock},
			Values: []*av.Value{target},
		}},
	}
	source := &av.Value{
		ID:         sourceValueID,
		KeyID:      sourceKeyID,
		BlockID:    sourceItemID,
		Type:       av.KeyTypeBlock,
		IsDetached: true,
		CreatedAt:  200,
		UpdatedAt:  201,
		Block:      &av.ValueBlock{Content: "source"},
	}

	updated, err := updateAttributeViewValue(nil, attrView, targetKeyID, targetItemID, source, false)
	if nil != err {
		t.Fatal(err)
	}
	if updated != target {
		t.Fatal("updated value should keep the target value instance")
	}
	if targetValueID != updated.ID || targetKeyID != updated.KeyID || targetItemID != updated.BlockID ||
		av.KeyTypeBlock != updated.Type || targetCreatedAt != updated.CreatedAt {
		t.Fatalf("target identity was overwritten: %+v", updated)
	}
	if nil == updated.Block || "source" != updated.Block.Content {
		t.Fatalf("source content was not applied: %+v", updated.Block)
	}
	if source.UpdatedAt == updated.UpdatedAt {
		t.Fatalf("source update time was retained: %d", updated.UpdatedAt)
	}
}

func TestUpdateAttributeViewValueRejectsMissingKey(t *testing.T) {
	const itemID = "20260806000002-item001"
	attrView := &av.AttributeView{KeyValues: []*av.KeyValues{
		{
			Key: &av.Key{ID: "20260806000000-existing", Type: av.KeyTypeBlock},
			Values: []*av.Value{{
				BlockID: itemID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}},
		},
	}}

	_, err := updateAttributeViewValue(nil, attrView, "20260806000001-missing", itemID,
		&av.Value{Type: av.KeyTypeText, Text: &av.ValueText{Content: "source"}}, false)
	if !errors.Is(err, av.ErrKeyNotFound) {
		t.Fatalf("missing key returned error [%v]", err)
	}
}

func TestUpdateAttributeViewValueRejectsMissingItem(t *testing.T) {
	const (
		blockKeyID  = "20260806000000-blockky"
		selectKeyID = "20260806000001-selectk"
		itemID      = "20260806000002-item001"
		missingID   = "20260806000003-missing"
	)
	selectKeyValues := &av.KeyValues{Key: &av.Key{ID: selectKeyID, Type: av.KeyTypeSelect}}
	attrView := &av.AttributeView{KeyValues: []*av.KeyValues{
		{
			Key: &av.Key{ID: blockKeyID, Type: av.KeyTypeBlock},
			Values: []*av.Value{{
				BlockID: itemID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}},
		},
		selectKeyValues,
	}}

	_, err := updateAttributeViewValue(nil, attrView, selectKeyID, missingID,
		&av.Value{Type: av.KeyTypeSelect, MSelect: []*av.ValueSelect{{Content: "Closed", Color: "4"}}}, false)
	if !errors.Is(err, av.ErrItemNotFound) {
		t.Fatalf("missing item returned error [%v]", err)
	}
	if 0 != len(selectKeyValues.Values) {
		t.Fatalf("missing item created an orphan value: %+v", selectKeyValues.Values)
	}
}

func TestUpdateAttributeViewValueCreatesMissingCellForExistingItem(t *testing.T) {
	const (
		blockKeyID = "20260806000000-blockky"
		textKeyID  = "20260806000001-textkey"
		itemID     = "20260806000002-item001"
	)
	textKeyValues := &av.KeyValues{Key: &av.Key{ID: textKeyID, Type: av.KeyTypeText}}
	attrView := &av.AttributeView{KeyValues: []*av.KeyValues{
		{
			Key: &av.Key{ID: blockKeyID, Type: av.KeyTypeBlock},
			Values: []*av.Value{{
				BlockID: itemID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}},
		},
		textKeyValues,
	}}

	updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID,
		&av.Value{Type: av.KeyTypeText, Text: &av.ValueText{Content: "source"}}, false)
	if nil != err {
		t.Fatal(err)
	}
	if 1 != len(textKeyValues.Values) || textKeyValues.Values[0] != updated {
		t.Fatalf("missing cell was not created: %+v", textKeyValues.Values)
	}
	if itemID != updated.BlockID || textKeyID != updated.KeyID || nil == updated.Text || "source" != updated.Text.Content {
		t.Fatalf("created cell is invalid: %+v", updated)
	}
}

func TestUpdateAttributeViewValueContextIndexesCreatedCells(t *testing.T) {
	const (
		blockKeyID = "20260811190000-blockky"
		textKeyID  = "20260811190001-textkey"
		firstID    = "20260811190002-item001"
		secondID   = "20260811190003-item002"
	)
	textKeyValues := &av.KeyValues{Key: &av.Key{ID: textKeyID, Type: av.KeyTypeText}}
	attrView := &av.AttributeView{KeyValues: []*av.KeyValues{
		{
			Key: &av.Key{ID: blockKeyID, Type: av.KeyTypeBlock},
			Values: []*av.Value{{
				BlockID: firstID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}, {
				BlockID: secondID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}},
		},
		textKeyValues,
	}}
	context := newAttrViewValueUpdateContext(attrView)

	for _, itemID := range []string{firstID, secondID} {
		updated, err := updateAttributeViewValue0(nil, attrView, textKeyID, itemID,
			&av.Value{Type: av.KeyTypeText, Text: &av.ValueText{Content: itemID}}, false, context)
		if nil != err {
			t.Fatal(err)
		}
		if updated != context.values[textKeyID][itemID] || nil == updated.Text || itemID != updated.Text.Content {
			t.Fatalf("created cell is missing from update context: %+v", updated)
		}
	}
	if 2 != len(textKeyValues.Values) {
		t.Fatalf("unexpected text value count: %d", len(textKeyValues.Values))
	}
}

func TestCheckAttrViewCorrectsValueKeyID(t *testing.T) {
	const targetKeyID = "20260806000000-targetk"
	value := &av.Value{KeyID: "20260806000001-sourcek", Type: av.KeyTypeText}
	attrView := &av.AttributeView{KeyValues: []*av.KeyValues{{
		Key:    &av.Key{ID: targetKeyID, Type: av.KeyTypeText},
		Values: []*av.Value{value},
	}}}

	if !checkAttrView(attrView, &av.View{}) {
		t.Fatal("correcting a value key ID should mark the attribute view as changed")
	}
	if targetKeyID != value.KeyID {
		t.Fatalf("value key ID was not corrected: %s", value.KeyID)
	}
}

func TestUpdateAttributeViewTextValuePreservesRichPayloadForUnchangedLegacyWrites(t *testing.T) {
	attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()
	originalRichContent := textValue.Text.Rich.Content

	updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID,
		&av.Value{Type: av.KeyTypeText, Text: &av.ValueText{Content: "old"}}, false)
	if nil != err {
		t.Fatal(err)
	}
	if updated != textValue || nil == updated.Text || "old" != updated.Text.Content || nil == updated.Text.Rich ||
		originalRichContent != updated.Text.Rich.Content {
		t.Fatalf("unchanged legacy write did not preserve rich text: value=%+v text=%+v rich=%+v", updated,
			updated.Text, updated.Text.Rich)
	}
}

func TestUpdateAttributeViewTextValueClearsRichPayloadForChangedLegacyWrites(t *testing.T) {
	attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()

	updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID,
		&av.Value{Type: av.KeyTypeText, Text: &av.ValueText{Content: "plain replacement"}}, false)
	if nil != err {
		t.Fatal(err)
	}
	if updated != textValue || nil == updated.Text || "plain replacement" != updated.Text.Content || nil != updated.Text.Rich {
		t.Fatalf("plain write did not replace rich text: %+v", updated)
	}
}

func TestUpdateAttributeViewTextValueExplicitlyClearsUnchangedRichPayload(t *testing.T) {
	attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()

	updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID, map[string]any{
		"text": map[string]any{
			"content": "old",
			"rich":    nil,
		},
	}, false)
	if nil != err {
		t.Fatal(err)
	}
	if updated != textValue || nil == updated.Text || "old" != updated.Text.Content || nil != updated.Text.Rich {
		t.Fatalf("explicit rich null did not clear formatting: %+v", updated)
	}
}

func TestUpdateAttributeViewTextValueExplicitlyClearsRichWithoutContent(t *testing.T) {
	attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()

	updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID, map[string]any{
		"text": map[string]any{"rich": nil},
	}, false)
	if nil != err {
		t.Fatal(err)
	}
	if updated != textValue || nil == updated.Text || "old" != updated.Text.Content || nil != updated.Text.Rich {
		t.Fatalf("explicit rich null changed the plain text projection: %+v", updated)
	}
}

func TestUpdateAttributeViewTextValuePreservesOmittedFields(t *testing.T) {
	tests := []struct {
		name string
		data any
	}{
		{name: "value fields omitted", data: map[string]any{"type": av.KeyTypeText}},
		{name: "empty text object", data: map[string]any{"text": map[string]any{}}},
	}
	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()
			originalCreatedAt := textValue.CreatedAt

			updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID, test.data, false)
			if nil != err {
				t.Fatal(err)
			}
			if updated != textValue || nil == updated.Text || "old" != updated.Text.Content || nil == updated.Text.Rich ||
				originalCreatedAt != updated.CreatedAt {
				t.Fatalf("partial text update discarded stored fields: %+v", updated)
			}
		})
	}
}

func TestUpdateAttributeViewTextValueNormalizesRichProjection(t *testing.T) {
	attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()

	updated, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID, &av.Value{
		Type: av.KeyTypeText,
		Text: &av.ValueText{
			Content: "untrusted projection",
			Rich: &av.ValueTextRich{
				Spec:    av.ValueTextRichSpec,
				Format:  av.ValueTextRichFormatKramdown,
				Content: "**updated** text",
			},
		},
	}, false)
	if nil != err {
		t.Fatal(err)
	}
	if updated != textValue || nil == updated.Text || "updated text" != updated.Text.Content || nil == updated.Text.Rich {
		t.Fatalf("rich write was not normalized: %+v", updated)
	}
}

func TestUpdateAttributeViewTextValueRejectsInvalidRichPayloadWithoutMutation(t *testing.T) {
	attrView, textValue, textKeyID, itemID := newAttributeViewRichTextUpdateTest()
	originalText := textValue.Text

	_, err := updateAttributeViewValue(nil, attrView, textKeyID, itemID, &av.Value{
		Type: av.KeyTypeText,
		Text: &av.ValueText{Rich: &av.ValueTextRich{
			Spec:    av.ValueTextRichSpec + 1,
			Format:  av.ValueTextRichFormatKramdown,
			Content: "invalid",
		}},
	}, false)
	if nil == err {
		t.Fatal("invalid rich payload was accepted")
	}
	if textValue.Text != originalText || "old" != textValue.Text.Content || nil == textValue.Text.Rich {
		t.Fatalf("invalid rich write mutated the stored value: %+v", textValue)
	}
}

func TestUpdateAttributeViewTextValueRejectsInvalidRichPayloadWithoutCreatingMissingCell(t *testing.T) {
	for _, useContext := range []bool{false, true} {
		name := "without context"
		if useContext {
			name = "with context"
		}
		t.Run(name, func(t *testing.T) {
			const (
				blockKeyID = "20260904130000-blockky"
				textKeyID  = "20260904130001-textkey"
				itemID     = "20260904130002-item001"
			)
			blockValue := &av.Value{
				BlockID: itemID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}
			textKeyValues := &av.KeyValues{Key: &av.Key{ID: textKeyID, Type: av.KeyTypeText}}
			attrView := &av.AttributeView{KeyValues: []*av.KeyValues{
				{Key: &av.Key{ID: blockKeyID, Type: av.KeyTypeBlock}, Values: []*av.Value{blockValue}},
				textKeyValues,
			}}
			var context *attrViewValueUpdateContext
			if useContext {
				context = newAttrViewValueUpdateContext(attrView)
			}

			_, err := updateAttributeViewValue0(nil, attrView, textKeyID, itemID, &av.Value{
				Type: av.KeyTypeText,
				Text: &av.ValueText{Rich: &av.ValueTextRich{
					Spec:    av.ValueTextRichSpec + 1,
					Format:  av.ValueTextRichFormatKramdown,
					Content: "invalid",
				}},
			}, false, context)
			if nil == err {
				t.Fatal("invalid rich payload was accepted")
			}
			if 0 != len(textKeyValues.Values) {
				t.Fatalf("invalid rich write created a missing cell: %+v", textKeyValues.Values)
			}
			if nil != context {
				if 0 != len(context.values[textKeyID]) || nil != context.values[textKeyID][itemID] {
					t.Fatalf("invalid rich write registered a missing cell in the update context: %+v",
						context.values[textKeyID])
				}
				if context.keyValues[textKeyID] != textKeyValues || context.blockValues[itemID] != blockValue {
					t.Fatal("invalid rich write changed existing update context indexes")
				}
			}
		})
	}
}

func newAttributeViewRichTextUpdateTest() (attrView *av.AttributeView, textValue *av.Value, textKeyID, itemID string) {
	const (
		blockKeyID = "20260904120000-blockky"
		keyID      = "20260904120001-textkey"
		rowID      = "20260904120002-item001"
	)
	textValue = &av.Value{
		ID:      "20260904120003-value01",
		KeyID:   keyID,
		BlockID: rowID,
		Type:    av.KeyTypeText,
		Text: &av.ValueText{
			Content: "old",
			Rich: &av.ValueTextRich{
				Spec:    av.ValueTextRichSpec,
				Format:  av.ValueTextRichFormatKramdown,
				Content: `<span data-type="strong">old</span>`,
			},
		},
	}
	attrView = &av.AttributeView{KeyValues: []*av.KeyValues{
		{
			Key: &av.Key{ID: blockKeyID, Type: av.KeyTypeBlock},
			Values: []*av.Value{{
				BlockID: rowID,
				Type:    av.KeyTypeBlock,
				Block:   &av.ValueBlock{},
			}},
		},
		{
			Key:    &av.Key{ID: keyID, Type: av.KeyTypeText},
			Values: []*av.Value{textValue},
		},
	}}
	return attrView, textValue, keyID, rowID
}