Skip to content

An open-source, privacy-first, self-hosted knowledge workspace where humans and AI agents work together 开源、隐私优先、自托管的知识工作空间,让人与智能体在此协作

:bug: Update Windows mmap modification time https://github.com/siyuan-note/siyuan/issues/20575

Daniel0c49d4adae16
diff --git a/kernel/filesys/tree_mmap_test.go b/kernel/filesys/tree_mmap_test.go
new file mode 100644
index 0000000000..66a14afd89
--- /dev/null
+++ b/kernel/filesys/tree_mmap_test.go
@@ -0,0 +1,66 @@
+package filesys
+
+import (
+ "bytes"
+ "os"
+ "path/filepath"
+ "testing"
+ "time"
+
+ "github.com/siyuan-note/dejavu"
+ "github.com/siyuan-note/siyuan/kernel/treenode"
+ "github.com/siyuan-note/siyuan/kernel/util"
+)
+
+func TestTreeAttributeMmapSnapshot(t *testing.T) {
+ box, root, _, _ := setupStalePathTest(t)
+ tree := treenode.NewTree(box, "/"+root+".sy", "/Task", "Task")
+ tree.Root.SetIALAttr("custom-deadline", "2026-10-16")
+ if _, err := WriteTree(tree); err != nil {
+ t.Fatal(err)
+ }
+ file := filepath.Join(util.DataDir, box, tree.Path)
+ old := time.Now().Add(-10 * time.Second).Truncate(time.Second)
+ if err := os.Chtimes(file, old, old); err != nil {
+ t.Fatal(err)
+ }
+ base := t.TempDir()
+ repo, err := dejavu.NewRepo(util.DataDir, filepath.Join(base, "repo"), filepath.Join(base, "history"),
+ filepath.Join(base, "temp"), "device", "device", "windows", []byte("0123456789abcdef0123456789abcdef"), nil, nil)
+ if err != nil {
+ t.Fatal(err)
+ }
+ before, err := repo.Index("before attribute edit", false, nil)
+ if err != nil {
+ t.Fatal(err)
+ }
+ original, err := os.ReadFile(file)
+ if err != nil {
+ t.Fatal(err)
+ }
+ tree.Root.SetIALAttr("custom-deadline", "2026-10-15")
+ if _, err = WriteTree(tree); err != nil {
+ t.Fatal(err)
+ }
+ updated, err := os.ReadFile(file)
+ if err != nil || len(original) != len(updated) || bytes.Equal(original, updated) {
+ t.Fatalf("attribute edit must change content without changing length: %v", err)
+ }
+ after, err := repo.Index("after attribute edit", false, nil)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if before.ID == after.ID {
+ t.Fatal("attribute edit was omitted from the next snapshot")
+ }
+ if err = os.Remove(file); err != nil {
+ t.Fatal(err)
+ }
+ if _, _, err = repo.Checkout(after.ID, nil); err != nil {
+ t.Fatal(err)
+ }
+ restored, err := os.ReadFile(file)
+ if err != nil || !bytes.Equal(restored, updated) {
+ t.Fatalf("snapshot did not restore the updated attribute: %v", err)
+ }
+}
diff --git a/kernel/util/mmap.go b/kernel/util/mmap.go
index 5278827b41..74462a9827 100644
--- a/kernel/util/mmap.go
+++ b/kernel/util/mmap.go
@@ -21,6 +21,8 @@ import (
"errors"
"fmt"
"os"
+ "runtime"
+ "time"
mmap "github.com/edsrzf/mmap-go"
"github.com/siyuan-note/filelock"
@@ -71,6 +73,13 @@ func WriteFileByMmap(filePath string, data []byte) (err error) {
err = errors.New(msg)
return
}
+ // Windows 的映射写入不会自动更新时间,显式标记内容变更以供同步快照识别。
+ if runtime.GOOS == "windows" {
+ now := time.Now()
+ if err = os.Chtimes(filePath, now, now); err != nil {
+ return fmt.Errorf("update file modification time [%s]: %w", filePath, err)
+ }
+ }
return
}
diff --git a/kernel/util/mmap_test.go b/kernel/util/mmap_test.go
index 730aaf8c71..0184e3bb34 100644
--- a/kernel/util/mmap_test.go
+++ b/kernel/util/mmap_test.go
@@ -5,8 +5,41 @@ import (
"os"
"path/filepath"
"testing"
+ "time"
)
+func TestWriteFileByMmapModificationTime(t *testing.T) {
+ file := filepath.Join(t.TempDir(), "data.sy")
+ if err := os.WriteFile(file, []byte("2026-10-16"), 0644); err != nil {
+ t.Fatal(err)
+ }
+ old := time.Now().Add(-10 * time.Second).Truncate(time.Second)
+ if err := os.Chtimes(file, old, old); err != nil {
+ t.Fatal(err)
+ }
+ if err := WriteFileByMmap(file, []byte("2026-10-15")); err != nil {
+ t.Fatal(err)
+ }
+ info, err := os.Stat(file)
+ if err != nil || info.ModTime().Unix() == old.Unix() {
+ t.Fatalf("equal-length write did not update modification time: %v", err)
+ }
+ data, err := os.ReadFile(file)
+ if err != nil || string(data) != "2026-10-15" {
+ t.Fatalf("equal-length write did not persist content: %v", err)
+ }
+ if err = os.Chtimes(file, old, old); err != nil {
+ t.Fatal(err)
+ }
+ if err = WriteFileByMmap(file, data); err != nil {
+ t.Fatal(err)
+ }
+ info, err = os.Stat(file)
+ if err != nil || !info.ModTime().Equal(old) {
+ t.Fatalf("identical write changed modification time: %v", err)
+ }
+}
+
func TestWriteFileByMmapSizeTransitions(t *testing.T) {
file := filepath.Join(t.TempDir(), "data.sy")
large := bytes.Repeat([]byte("a"), os.Getpagesize()*3+17)