An open-source, privacy-first, self-hosted knowledge workspace where humans and AI agents work together 开源、隐私优先、自托管的知识工作空间,让人与智能体在此协作
TypeScript agentic-aiai-agentknowledge-baselocal-firstmarkdownmcpmindmapnote-takingself-hostedsiyuanworkspace
:bug: Clear flashcard review state when reloading decks https://github.com/siyuan-note/siyuan/issues/20988
Daniel7d5179fa5b7c
diff --git a/kernel/model/flashcard.go b/kernel/model/flashcard.goindex 4201c2aa8b..84bae0b521 100644--- a/kernel/model/flashcard.go+++ b/kernel/model/flashcard.go@@ -1185,6 +1185,10 @@ func LoadFlashcards() {}Decks = map[string]*riff.Deck{}+ // Reloaded decks start a new scheduling generation; undo/skip state from the+ // old generation must not overwrite schedules received through synchronization.+ reviewCardCache = map[string]riff.Card{}+ skipCardCache = map[string]riff.Card{}entries, err := os.ReadDir(riffSavePath)if err != nil {diff --git a/kernel/model/flashcard_reload_test.go b/kernel/model/flashcard_reload_test.gonew file mode 100644index 0000000000..b32020a2d3--- /dev/null+++ b/kernel/model/flashcard_reload_test.go@@ -0,0 +1,44 @@+package model++import (+ "testing"++ "github.com/siyuan-note/riff"+ "github.com/siyuan-note/siyuan/kernel/conf"+)++func TestFlashcardReloadInvalidatesReviewState(t *testing.T) {+ fixture := setupFileOperationTest(t)+ Conf.Flashcard.Store(conf.NewFlashcard())+ previousDecks, previousReviews, previousSkipped := Decks, reviewCardCache, skipCardCache+ Decks = map[string]*riff.Deck{}+ t.Cleanup(func() { Decks, reviewCardCache, skipCardCache = previousDecks, previousReviews, previousSkipped })+ deck, err := createDeck0("reload", builtinDeckID)+ if err != nil {+ t.Fatal(err)+ }+ const cardID = "20261027000000-abcdefg"+ deck.AddCard(cardID, fixture.sourceID)+ oldCard := deck.GetCard(cardID).Clone()+ reviewCardCache = map[string]riff.Card{cardID: oldCard}+ skipCardCache = map[string]riff.Card{cardID: oldCard}+ // Represent a newer schedule arriving on disk while the old review UI lives on.+ deck.Review(cardID, riff.Rating(3))+ if err := deck.Save(); err != nil {+ t.Fatal(err)+ }+ reps := deck.GetCard(cardID).GetReps()+ LoadFlashcards()+ if len(reviewCardCache) != 0 || len(skipCardCache) != 0 {+ t.Fatal("deck reload retained undo or skip state from the old generation")+ }+ if got := Decks[deck.ID].GetCard(cardID).GetReps(); got != reps {+ t.Fatalf("reload changed persisted schedule: %d, want %d", got, reps)+ }+ if err := ReviewFlashcard(deck.ID, cardID, riff.Rating(3), []string{cardID}); err != nil {+ t.Fatal(err)+ }+ if got := Decks[deck.ID].GetCard(cardID).GetReps(); got != reps+1 {+ t.Fatalf("continued review restored an old schedule: %d, want %d", got, reps+1)+ }+}