Native iCloud apps for Windows and Linux, built in Rust. Notes, Reminders, Calendar, Contacts, Drive and Photos, offline and in sync with your iPhone.
Rust apple-notesapple-reminderscloudkitcrdtdesktop-appicloudicloud-calendaricloud-driveicloud-notesicloud-photosiphonelinuxlinux-desktoplocal-firstoffline-firstprivacyrusttauritauri-appwindows
Coming back to the window brings it up to date
Yashwanth Kamireddi96420d9f52ce
diff --git a/.uiverify/assert.mjs b/.uiverify/assert.mjsindex 36b0f61..851c290 100644--- a/.uiverify/assert.mjs+++ b/.uiverify/assert.mjs@@ -369,6 +369,52 @@ let failures = 0;await page.close();}+// ── Coming back to the window brings it up to date ────────────────────────────────────+// That is the moment somebody looks for a change they just made on their phone, and between+// background passes the window could be five minutes stale right then. It must refresh on+// return — and not again for every alt-tab, which would only ask Apple the same thing twice.+{+ const page = await ctx.newPage();+ await page.addInitScript(() => {+ window.__passes = 0;+ window.__TAURI_INTERNALS__ = {+ transformCallback: (cb) => cb,+ invoke: async (cmd) => {+ if (cmd === "auth_status") return { hasStoredSession: true, signedIn: true };+ if (cmd === "auth_resume") return true;+ if (cmd === "account_services") return ["reminders"];+ if (cmd === "sync_all") { window.__passes++; return { services: [], asOf: 1, tookMs: 0 }; }+ if (cmd === "sync_status") return { services: [], asOf: 1, tookMs: 0 };+ if (cmd === "plugin:event|listen") return 0;+ return [];+ },+ };+ });+ await page.clock.install();+ await page.goto("http://localhost:4173", { waitUntil: "networkidle" });+ await page.waitForTimeout(300);+ const onOpen = await page.evaluate(() => window.__passes);++ const bounce = () => page.evaluate(() => window.dispatchEvent(new Event("focus")));+ await bounce();+ await page.waitForTimeout(100);+ const tooSoon = (await page.evaluate(() => window.__passes)) - onOpen;++ await page.clock.fastForward(31_000);+ await bounce();+ await page.waitForTimeout(200);+ const later = (await page.evaluate(() => window.__passes)) - onOpen;++ const right = tooSoon === 0 && later === 1;+ console.log(+ right+ ? "PASS coming back refreshes, and alt-tabbing does not hammer"+ : `FAIL returning: ${tooSoon} pass(es) straight away, ${later} after half a minute`+ );+ if (!right) failures++;+ await page.close();+}+// ── An account with nowhere to send a code ────────────────────────────────────────────// No trusted device and no trusted number. The screen must not offer a code that can never// arrive, and must say what would actually help — otherwise it is a dead end with a text boxdiff --git a/src/lib/sync.tsx b/src/lib/sync.tsxindex a2f99fe..712dd0b 100644--- a/src/lib/sync.tsx+++ b/src/lib/sync.tsx@@ -34,6 +34,9 @@ type Sync = {const Context = createContext<Sync | null>(null);+/** The least time between refreshes brought on by coming back to the window. */+export const RETURN_THROTTLE_MS = 30_000;+export function SyncProvider({ children }: { children: ReactNode }) {const [report, setReport] = useState<Refresh | null>(null);const [syncing, setSyncing] = useState(false);@@ -84,9 +87,28 @@ export function SyncProvider({ children }: { children: ReactNode }) {setRevision((n) => n + 1);});+ /*+ * Coming back to the window is when somebody looks for a change they just made on their+ * phone. Between the five-minute background passes it could be up to five minutes stale+ * at exactly that moment, which reads as sync not working at all. So returning to the+ * window refreshes — but not more than once in half a minute, because switching back and+ * forth between two windows is not a reason to ask Apple the same question again.+ */+ let lastFocusPass = Date.now();+ const onReturn = () => {+ if (document.visibilityState === "hidden") return;+ if (Date.now() - lastFocusPass < RETURN_THROTTLE_MS) return;+ lastFocusPass = Date.now();+ void refresh();+ };+ window.addEventListener("focus", onReturn);+ document.addEventListener("visibilitychange", onReturn);+return () => {cancelled = true;void stop.then((off) => off());+ window.removeEventListener("focus", onReturn);+ document.removeEventListener("visibilitychange", onReturn);};}, [refresh]);