Skip to content

Native iCloud apps for Windows and Linux, built in Rust. Notes, Reminders, Calendar, Contacts, Drive and Photos, offline and in sync with your iPhone.

Windows build: Edge runs as Chromium; libheif from vcpkg with its default codecs

Yashwanth Kamireddid2d373b68866
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index 4e251ed..36e6e60 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -38,15 +38,15 @@ jobs:
cache: npm
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- # HEIC decoding: libheif with libde265, decoding only, linked in statically.
+ # HEIC decoding: libheif with its default codecs (libde265 decodes), linked in statically.
- uses: actions/cache@v4
with:
path: C:\vcpkg\installed
- key: vcpkg-libheif-libde265-x64-windows-static-md-v1
+ key: vcpkg-libheif-default-x64-windows-static-md-v1
- name: HEIC decoder
shell: pwsh
run: |
- & "$env:VCPKG_INSTALLATION_ROOT\vcpkg.exe" install "libheif[core,libde265]:x64-windows-static-md"
+ & "$env:VCPKG_INSTALLATION_ROOT\vcpkg.exe" install "libheif:x64-windows-static-md"
"VCPKG_ROOT=$env:VCPKG_INSTALLATION_ROOT" >> $env:GITHUB_ENV
"VCPKGRS_TRIPLET=x64-windows-static-md" >> $env:GITHUB_ENV
- run: npm ci
@@ -115,15 +115,15 @@ jobs:
- uses: Swatinem/rust-cache@v2
with:
workspaces: ". -> target"
- # HEIC decoding: libheif with libde265, decoding only, linked in statically.
+ # HEIC decoding: libheif with its default codecs (libde265 decodes), linked in statically.
- uses: actions/cache@v4
with:
path: C:\vcpkg\installed
- key: vcpkg-libheif-libde265-x64-windows-static-md-v1
+ key: vcpkg-libheif-default-x64-windows-static-md-v1
- name: HEIC decoder
shell: pwsh
run: |
- & "$env:VCPKG_INSTALLATION_ROOT\vcpkg.exe" install "libheif[core,libde265]:x64-windows-static-md"
+ & "$env:VCPKG_INSTALLATION_ROOT\vcpkg.exe" install "libheif:x64-windows-static-md"
"VCPKG_ROOT=$env:VCPKG_INSTALLATION_ROOT" >> $env:GITHUB_ENV
"VCPKGRS_TRIPLET=x64-windows-static-md" >> $env:GITHUB_ENV
- run: npm ci
diff --git a/.uiverify/engine.mjs b/.uiverify/engine.mjs
index a8c993d..98aae59 100644
--- a/.uiverify/engine.mjs
+++ b/.uiverify/engine.mjs
@@ -12,7 +12,8 @@
import { chromium, webkit } from "playwright";
export const engineName = ["webkit", "gtk", "msedge"].includes(process.env.ENGINE) ? process.env.ENGINE : "chromium";
-const base = engineName === "chromium" ? chromium : webkit;
+// Edge is Chromium (the engine WebView2 is); only the two WebKit ports take Playwright's WebKit.
+const base = engineName === "webkit" || engineName === "gtk" ? webkit : chromium;
/**
* In the GTK port the window is a real one on this desktop, and a tiling window manager sizes
* it — Playwright's attempt to resize it is refused ("Failed to resize window"). So a GTK run