Skip to content

Automate browser based workflows with AI

6.7 KB
Raw Blame
"""Tests for skyvern/cli/auth_command.py"""

from __future__ import annotations

import http.server
import threading
import urllib.parse
from pathlib import Path

from skyvern.cli import auth_command
from skyvern.cli.auth_command import _CallbackHandler, _derive_api_base_url, _find_free_port


class TestDeriveApiBaseUrl:
    def test_localhost(self) -> None:
        assert _derive_api_base_url("http://localhost:8080") == "http://localhost:8000"

    def test_localhost_no_port(self) -> None:
        assert _derive_api_base_url("http://localhost") == "http://localhost:8000"

    def test_127_0_0_1(self) -> None:
        assert _derive_api_base_url("http://127.0.0.1:5173") == "http://localhost:8000"

    def test_app_skyvern(self) -> None:
        assert _derive_api_base_url("https://app.skyvern.com") == "https://api.skyvern.com"

    def test_app_skyvern_with_port(self) -> None:
        assert _derive_api_base_url("https://app.skyvern.com:8443") == "https://api.skyvern.com:8443"

    def test_unknown_hostname_returns_input(self) -> None:
        result = _derive_api_base_url("https://staging.skyvern.com")
        assert result == "https://staging.skyvern.com"


class TestFindFreePort:
    def test_returns_bound_socket(self) -> None:
        sock = _find_free_port()
        try:
            port = sock.getsockname()[1]
            assert 1024 <= port <= 65535
            # Socket should still be open (bound)
            assert sock.fileno() != -1
        finally:
            sock.close()


def test_run_signup_defaults_to_cloud_write_path(tmp_path, monkeypatch) -> None:
    class FakeSocket:
        def getsockname(self) -> tuple[str, int]:
            return ("127.0.0.1", 43210)

    class FakeServer:
        def __init__(self, *_args, **_kwargs) -> None:
            self.auth_result = {"api_key": None, "organization_id": None, "email": None}

        def server_activate(self) -> None:
            pass

        def serve_forever(self) -> None:
            pass

        def shutdown(self) -> None:
            pass

    class FakeEvent:
        def wait(self, timeout: int | None = None) -> bool:
            return True

    class FakeThread:
        def __init__(self, target, daemon: bool) -> None:
            self.server = target.__self__

        def start(self) -> None:
            self.server.auth_result = {"api_key": "sk_test", "organization_id": None, "email": None}

    monkeypatch.chdir(tmp_path)
    monkeypatch.setenv("HOME", str(tmp_path / "home"))
    monkeypatch.delenv("SKYVERN_ENV_FILE", raising=False)
    (tmp_path / ".env").write_text("SKYVERN_API_KEY=server-key\n")

    saved: list[tuple[str, str, Path]] = []

    def fake_update_or_add_env_var(key: str, value: str, env_path: Path) -> None:
        saved.append((key, value, Path(env_path)))

    monkeypatch.setattr(auth_command, "_find_free_port", lambda: FakeSocket())
    monkeypatch.setattr(auth_command.http.server, "HTTPServer", FakeServer)
    monkeypatch.setattr(auth_command.threading, "Event", FakeEvent)
    monkeypatch.setattr(auth_command.threading, "Thread", FakeThread)
    monkeypatch.setattr(auth_command.webbrowser, "open", lambda _url: True)
    monkeypatch.setattr("skyvern.cli.llm_setup.update_or_add_env_var", fake_update_or_add_env_var)

    assert auth_command.run_signup(timeout=1) == "sk_test"

    assert {item[2] for item in saved} == {tmp_path / "home" / ".skyvern" / ".env"}


class TestCallbackHandlerStateValidation:
    def _make_server(self, state: str) -> http.server.HTTPServer:
        sock = _find_free_port()
        port = sock.getsockname()[1]
        server = http.server.HTTPServer(("127.0.0.1", port), _CallbackHandler, bind_and_activate=False)
        server.socket = sock
        server.server_activate()
        server.auth_result = {"api_key": None, "organization_id": None, "email": None}  # type: ignore[attr-defined]
        server.received_event = threading.Event()  # type: ignore[attr-defined]
        server.expected_state = state  # type: ignore[attr-defined]
        return server

    def test_valid_state_accepted(self) -> None:
        server = self._make_server("test-nonce-123")
        thread = threading.Thread(target=server.serve_forever, daemon=True)
        thread.start()
        port = server.server_address[1]
        try:
            import http.client

            conn = http.client.HTTPConnection("127.0.0.1", port)
            body = urllib.parse.urlencode(
                {
                    "api_key": "sk_test_key",
                    "organization_id": "o_123",
                    "email": "[email protected]",
                    "state": "test-nonce-123",
                }
            )
            conn.request("POST", "/callback", body=body, headers={"Content-Type": "application/x-www-form-urlencoded"})
            resp = conn.getresponse()
            assert resp.status == 200
            assert server.auth_result["api_key"] == "sk_test_key"  # type: ignore[attr-defined]
            assert server.auth_result["email"] == "[email protected]"  # type: ignore[attr-defined]
            assert server.received_event.wait(timeout=5)  # type: ignore[attr-defined]
            conn.close()
        finally:
            server.shutdown()

    def test_invalid_state_rejected(self) -> None:
        server = self._make_server("correct-nonce")
        thread = threading.Thread(target=server.serve_forever, daemon=True)
        thread.start()
        port = server.server_address[1]
        try:
            import http.client

            conn = http.client.HTTPConnection("127.0.0.1", port)
            body = urllib.parse.urlencode(
                {
                    "api_key": "sk_test_key",
                    "state": "wrong-nonce",
                }
            )
            conn.request("POST", "/callback", body=body, headers={"Content-Type": "application/x-www-form-urlencoded"})
            resp = conn.getresponse()
            assert resp.status == 403
            assert server.auth_result["api_key"] is None  # type: ignore[attr-defined]
            assert not server.received_event.is_set()  # type: ignore[attr-defined]
            conn.close()
        finally:
            server.shutdown()

    def test_missing_api_key_rejected(self) -> None:
        server = self._make_server("test-nonce")
        thread = threading.Thread(target=server.serve_forever, daemon=True)
        thread.start()
        port = server.server_address[1]
        try:
            import http.client

            conn = http.client.HTTPConnection("127.0.0.1", port)
            body = urllib.parse.urlencode({"state": "test-nonce"})
            conn.request("POST", "/callback", body=body, headers={"Content-Type": "application/x-www-form-urlencoded"})
            resp = conn.getresponse()
            assert resp.status == 400
            conn.close()
        finally:
            server.shutdown()