Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
feat(SKY-12490): clean up browser profile folders orphaned by hard-killed local MCP servers (#7580)
Marc Kelechava0889d7d2e915
diff --git a/skyvern/library/local_browser_profile.py b/skyvern/library/local_browser_profile.pyindex 071458c66..d06a102e3 100644--- a/skyvern/library/local_browser_profile.py+++ b/skyvern/library/local_browser_profile.py@@ -349,7 +349,9 @@ def _wait_for_process_with_budget(if process.poll() is None:try:- process.wait(timeout=max(0.0, deadline - time.monotonic()))+ # SIGKILL is asynchronous. Keep the work deadline bounded, but allow the+ # configured stop reserve to reap the child before returning to the caller.+ process.wait(timeout=max(stop_reserve, deadline - time.monotonic()))except subprocess.TimeoutExpired:return Nonereturn Nonediff --git a/tests/unit/test_local_browser_profile.py b/tests/unit/test_local_browser_profile.pyindex ea3e98fde..061e4d8e2 100644--- a/tests/unit/test_local_browser_profile.py+++ b/tests/unit/test_local_browser_profile.py@@ -583,6 +583,32 @@ def test_deletion_child_rejects_same_name_directory_replacement(tmp_path: Path)assert sentinel.read_text() == "replacement data"+def test_wait_for_process_reaps_child_after_forced_stop() -> None:+ process = MagicMock(spec=subprocess.Popen)+ process.pid = 43210+ reaped = False++ def wait_for_exit(timeout: float) -> int:+ nonlocal reaped+ if process.kill.called and timeout >= 0.04:+ reaped = True+ return -9+ if not process.kill.called:+ time.sleep(timeout)+ raise subprocess.TimeoutExpired(cmd="profile-deleter", timeout=timeout)++ process.wait.side_effect = wait_for_exit+ process.poll.side_effect = lambda: -9 if reaped else None++ local_browser_profile._wait_for_process_with_budget(+ process,+ started_at=time.monotonic(),+ budget=0.1,+ )++ assert process.poll() == -9++def test_timed_out_deletion_stops_before_cleanup_returns(tmp_path: Path,monkeypatch: pytest.MonkeyPatch,@@ -590,6 +616,7 @@ def test_timed_out_deletion_stops_before_cleanup_returns(profile_path = tmp_path / "profile"profile_path.mkdir()late_mutation = tmp_path / "late-mutation"+ ready = tmp_path / "ready"children: list[subprocess.Popen[bytes]] = []real_popen = subprocess.Popen@@ -601,15 +628,22 @@ def test_timed_out_deletion_stops_before_cleanup_returns(("import pathlib, signal, sys, time; ""signal.signal(signal.SIGTERM, signal.SIG_IGN); "+ "pathlib.Path(sys.argv[2]).touch(); ""time.sleep(0.5); pathlib.Path(sys.argv[1]).touch()"),str(late_mutation),+ str(ready),],stdin=subprocess.DEVNULL,stdout=subprocess.DEVNULL,stderr=subprocess.DEVNULL,)children.append(child)+ ready_deadline = time.monotonic() + 1+ while not ready.exists():+ assert child.poll() is None+ assert time.monotonic() < ready_deadline+ time.sleep(0.001)return childmonkeypatch.setattr(local_browser_profile, "PROFILE_DELETE_TIMEOUT_SECONDS", 0.1)