Skip to content

Automate browser based workflows with AI

fix timeout for svg and css LLM call (#2662)

Shuchang Zheng09ca00e94896
diff --git a/skyvern/forge/agent_functions.py b/skyvern/forge/agent_functions.py
index 6e0e36643..acb32c8f4 100644
--- a/skyvern/forge/agent_functions.py
+++ b/skyvern/forge/agent_functions.py
@@ -26,6 +26,7 @@ from skyvern.webeye.utils.page import SkyvernFrame
LOG = structlog.get_logger()
+_LLM_CALL_TIMEOUT_SECONDS = 60 # 1m
USELESS_SHAPE_ATTRIBUTE = [SKYVERN_ID_ATTR, "id", "aria-describedby"]
SVG_SHAPE_CONVERTION_ATTEMPTS = 3
CSS_SHAPE_CONVERTION_ATTEMPTS = 1
@@ -212,9 +213,10 @@ async def _convert_svg_to_string(
for retry in range(SVG_SHAPE_CONVERTION_ATTEMPTS):
try:
- json_response = await app.SECONDARY_LLM_API_HANDLER(
- prompt=svg_convert_prompt, step=step, prompt_name="svg-convert"
- )
+ async with asyncio.Timeout(_LLM_CALL_TIMEOUT_SECONDS):
+ json_response = await app.SECONDARY_LLM_API_HANDLER(
+ prompt=svg_convert_prompt, step=step, prompt_name="svg-convert"
+ )
svg_shape = json_response.get("shape", "")
recognized = json_response.get("recognized", False)
if not svg_shape or not recognized:
@@ -236,6 +238,13 @@ async def _convert_svg_to_string(
# set the invalid css shape to cache to avoid retry in the near future
await app.CACHE.set(svg_key, INVALID_SHAPE, ex=timedelta(hours=1))
await asyncio.sleep(3)
+ except asyncio.TimeoutError:
+ LOG.warning(
+ "Timeout to call LLM to parse SVG. Going to stop retrying",
+ element_id=element_id,
+ key=svg_key,
+ )
+ break
except Exception:
LOG.info(
"Failed to convert SVG to string shape by secondary llm. Will retry if haven't met the max try attempt after 3s.",
@@ -358,9 +367,10 @@ async def _convert_css_shape_to_string(
# TODO: we don't retry the css shape conversion today
for retry in range(CSS_SHAPE_CONVERTION_ATTEMPTS):
try:
- json_response = await app.SECONDARY_LLM_API_HANDLER(
- prompt=prompt, screenshots=[screenshot], step=step, prompt_name="css-shape-convert"
- )
+ async with asyncio.Timeout(_LLM_CALL_TIMEOUT_SECONDS):
+ json_response = await app.SECONDARY_LLM_API_HANDLER(
+ prompt=prompt, screenshots=[screenshot], step=step, prompt_name="css-shape-convert"
+ )
css_shape = json_response.get("shape", "")
recognized = json_response.get("recognized", False)
if not css_shape or not recognized:
@@ -382,6 +392,13 @@ async def _convert_css_shape_to_string(
# set the invalid css shape to cache to avoid retry in the near future
await app.CACHE.set(shape_key, INVALID_SHAPE, ex=timedelta(hours=1))
await asyncio.sleep(3)
+ except asyncio.TimeoutError:
+ LOG.warning(
+ "Timeout to call LLM to parse css shape. Going to stop retrying",
+ element_id=element_id,
+ key=shape_key,
+ )
+ break
except Exception:
LOG.info(
"Failed to convert css shape to string shape by secondary llm. Will retry if haven't met the max try attempt after 3s.",
diff --git a/skyvern/forge/sdk/api/llm/api_handler_factory.py b/skyvern/forge/sdk/api/llm/api_handler_factory.py
index 46ef21a0a..7aa1ffc8e 100644
--- a/skyvern/forge/sdk/api/llm/api_handler_factory.py
+++ b/skyvern/forge/sdk/api/llm/api_handler_factory.py
@@ -145,7 +145,9 @@ class LLMAPIHandlerFactory:
ai_suggestion=ai_suggestion,
)
try:
- response = await router.acompletion(model=main_model_group, messages=messages, **parameters)
+ response = await router.acompletion(
+ model=main_model_group, messages=messages, timeout=settings.LLM_CONFIG_TIMEOUT, **parameters
+ )
except litellm.exceptions.APIError as e:
raise LLMProviderErrorRetryableTask(local_llm_key) from e
except litellm.exceptions.ContextWindowExceededError as e: