Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
safely close the tab (#4103)
LawyZheng0ed55ad8bcd5
diff --git a/skyvern/constants.py b/skyvern/constants.pyindex 125d4fcab..3c64afa0c 100644--- a/skyvern/constants.py+++ b/skyvern/constants.py@@ -8,6 +8,7 @@ REPO_ROOT_DIR = SKYVERN_DIR.parentINPUT_TEXT_TIMEOUT = 120000 # 2 minutesPAGE_CONTENT_TIMEOUT = 300 # 5 mins+BROWSER_PAGE_CLOSE_TIMEOUT = 5 # 5 secondsBROWSER_CLOSE_TIMEOUT = 180 # 3 minuteBROWSER_DOWNLOAD_MAX_WAIT_TIME = 120 # 2 minuteBROWSER_DOWNLOAD_TIMEOUT = 600 # 10 minutediff --git a/skyvern/webeye/browser_factory.py b/skyvern/webeye/browser_factory.pyindex e8932eb39..92e91f5d2 100644--- a/skyvern/webeye/browser_factory.py+++ b/skyvern/webeye/browser_factory.py@@ -23,7 +23,13 @@ from playwright.async_api import BrowserContext, ConsoleMessage, Download, Page,from pydantic import BaseModel, PrivateAttrfrom skyvern.config import settings-from skyvern.constants import BROWSER_CLOSE_TIMEOUT, BROWSER_DOWNLOAD_TIMEOUT, NAVIGATION_MAX_RETRY_TIME, SKYVERN_DIR+from skyvern.constants import (+ BROWSER_CLOSE_TIMEOUT,+ BROWSER_DOWNLOAD_TIMEOUT,+ BROWSER_PAGE_CLOSE_TIMEOUT,+ NAVIGATION_MAX_RETRY_TIME,+ SKYVERN_DIR,+)from skyvern.exceptions import (EmptyBrowserContext,FailedToNavigateToUrl,@@ -809,7 +815,11 @@ class BrowserState:closing_pages=closing_pages,)for page in closing_pages:- await page.close()+ try:+ async with asyncio.timeout(BROWSER_PAGE_CLOSE_TIMEOUT):+ await page.close()+ except Exception:+ LOG.warning("Error while closing the page", exc_info=True)return reserved_pages