Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix: prevent final→non-final status overwrite race in update_status (#4928)
Andrew Neilson114b0ecee589
diff --git a/skyvern/webeye/default_persistent_sessions_manager.py b/skyvern/webeye/default_persistent_sessions_manager.pyindex 81be4a584..52eb1737f 100644--- a/skyvern/webeye/default_persistent_sessions_manager.py+++ b/skyvern/webeye/default_persistent_sessions_manager.py@@ -145,16 +145,15 @@ async def update_status()return None- if is_final_status(status):- if is_final_status(persistent_browser_session.status):- LOG.warning(- "Attempted to update browser session status to a final status when it is already final",- browser_session_id=session_id,- organization_id=organization_id,- desired_status=status,- current_status=persistent_browser_session.status,- )- return None+ if is_final_status(persistent_browser_session.status):+ LOG.warning(+ "Attempted to update browser session status when it is already final",+ browser_session_id=session_id,+ organization_id=organization_id,+ desired_status=status,+ current_status=persistent_browser_session.status,+ )+ return NoneLOG.info("Updating browser session status",diff --git a/tests/unit_tests/test_update_status_guard.py b/tests/unit_tests/test_update_status_guard.pynew file mode 100644index 000000000..303d6128f--- /dev/null+++ b/tests/unit_tests/test_update_status_guard.py@@ -0,0 +1,53 @@+"""Tests for the update_status finalization guard in default_persistent_sessions_manager."""++from __future__ import annotations++import sys+from datetime import datetime, timezone+from unittest.mock import AsyncMock, MagicMock++import pytest++# Stub the AWS module to avoid import-time boto session creation.+sys.modules.setdefault("skyvern.forge.sdk.api.aws", MagicMock())++from skyvern.forge.sdk.schemas.persistent_browser_sessions import ( # noqa: E402+ PersistentBrowserSession,+ PersistentBrowserSessionStatus,+)+from skyvern.webeye.default_persistent_sessions_manager import update_status # noqa: E402++SESSION_ID = "sess_1"+ORG_ID = "org_1"+NOW = datetime.now(timezone.utc)+++def _make_session(status: str) -> PersistentBrowserSession:+ return PersistentBrowserSession(+ persistent_browser_session_id=SESSION_ID,+ organization_id=ORG_ID,+ status=status,+ created_at=NOW,+ modified_at=NOW,+ )+++ "desired_status",+ [+ pytest.param(PersistentBrowserSessionStatus.running, id="non-final-to-final"),+ pytest.param(PersistentBrowserSessionStatus.failed, id="final-to-final"),+ ],+)+async def test_rejects_update_when_already_final(desired_status: str):+ """A finalized session must not accept any status update."""+ db = AsyncMock()+ db.get_persistent_browser_session.return_value = _make_session(+ PersistentBrowserSessionStatus.completed,+ )++ result = await update_status(db, SESSION_ID, ORG_ID, desired_status)++ assert result is None+ db.update_persistent_browser_session.assert_not_called()