Skip to content

Automate browser based workflows with AI

Detach a departing CDP client's Fetch-enabled sessions while co-tenants stay connected (SKY-17174) (#8736)

Andrew Neilson2d090daf1bf7
diff --git a/skyvern/forge/sdk/copilot/model_resolver.py b/skyvern/forge/sdk/copilot/model_resolver.py
index a06f39f60..8af44c9fd 100644
--- a/skyvern/forge/sdk/copilot/model_resolver.py
+++ b/skyvern/forge/sdk/copilot/model_resolver.py
@@ -112,6 +112,8 @@ def _router_fallback_models(config: LLMRouterConfig) -> list[dict[str, Any]]:
entry = next((m for m in config.model_list if m.model_name == group), None)
params = entry.litellm_params if entry is not None else {}
hop = {field: params.get(field) for field in _PER_HOP_FIELDS}
+ # LiteLLM's Responses route calls .get on model_info, so None crashes the hop.
+ hop["model_info"] = params.get("model_info") or {}
hop["model"] = str(params.get("model") or group)
hop["base_url"] = params.get("api_base")
hop["timeout"] = params.get("timeout", settings.LLM_CONFIG_TIMEOUT)
@@ -239,6 +241,9 @@ def resolve_model_config(
if config.reasoning_effort:
extra_args["reasoning_effort"] = config.reasoning_effort
+ # LiteLLM's chat parameter check rejects reasoning_effort for GPT-6 even on an explicit Responses route.
+ if config.model_name.startswith(("openai/responses/", "azure/responses/")):
+ extra_args["allowed_openai_params"] = ["reasoning_effort", "service_tier"]
if isinstance(config, LLMConfig) and config.litellm_params:
lp = config.litellm_params
diff --git a/tests/unit/test_copilot_model_resolver.py b/tests/unit/test_copilot_model_resolver.py
index ef39d07e5..6936be48e 100644
--- a/tests/unit/test_copilot_model_resolver.py
+++ b/tests/unit/test_copilot_model_resolver.py
@@ -172,9 +172,38 @@ class TestModelResolver:
"2025-04-01-preview",
{"model_name": "azure/gpt-5.6-terra"},
),
- ("gpt-5.6-terra", None, None, None, None),
+ ("gpt-5.6-terra", None, None, None, {}),
]
+ @pytest.mark.parametrize("model_name", ["openai/responses/gpt-6-sol", "azure/responses/gpt-6-sol"])
+ def test_responses_route_effort_passes_litellms_parameter_check(
+ self, monkeypatch: pytest.MonkeyPatch, model_name: str
+ ) -> None:
+ from litellm.utils import get_optional_params
+
+ from skyvern.schemas.llm import LLMConfig
+
+ config = LLMConfig(
+ model_name=model_name,
+ required_env_vars=[],
+ supports_vision=True,
+ add_assistant_prefix=False,
+ reasoning_effort="medium",
+ pin_reasoning_effort=True,
+ )
+ handler = _install_config(monkeypatch, config, "GPT6_TEST")
+ _, run_config, _, _ = resolve_model_config(handler)
+ assert run_config.model_settings is not None and run_config.model_settings.extra_args is not None
+ extra_args = run_config.model_settings.extra_args
+
+ provider, bare_model = model_name.split("/responses/")
+ get_optional_params(
+ model=bare_model,
+ custom_llm_provider=provider,
+ reasoning_effort=extra_args["reasoning_effort"],
+ allowed_openai_params=extra_args.get("allowed_openai_params"),
+ )
+
def test_router_config_no_main_group_match_falls_back_to_first_entry(self, monkeypatch: pytest.MonkeyPatch) -> None:
from skyvern.schemas.llm import LLMRouterConfig, LLMRouterModelConfig