Automate browser based workflows with AI
Python aiapiautomationbrowserbrowser-automationcomputergptllmplaywrightpowerautomatepuppeteerpythonrpaseleniumvisionworkflow
fix(SKY-11722): carry hollow act-observe on-screen values into the typed build-test outcome (#7088)
Andrew Neilson2d99adc09a5a
diff --git a/skyvern/forge/sdk/copilot/agent.py b/skyvern/forge/sdk/copilot/agent.pyindex 836458bca..454fa610b 100644--- a/skyvern/forge/sdk/copilot/agent.py+++ b/skyvern/forge/sdk/copilot/agent.py@@ -44,7 +44,12 @@ from skyvern.forge.sdk.copilot.blocker_signal import ()from skyvern.forge.sdk.copilot.blocker_signal import to_trace_data as blocker_signal_to_trace_datafrom skyvern.forge.sdk.copilot.build_phase import initial_build_phase-from skyvern.forge.sdk.copilot.build_test_outcome import RecordedBuildTestOutcome, RecordedOutcomeGroundingRequirement+from skyvern.forge.sdk.copilot.build_test_outcome import (+ _VALUE_EXCERPT_MAX,+ RecordedBuildTestOutcome,+ RecordedOutcomeGroundingRequirement,+ observed_value_extraction_scaffold_lines,+)from skyvern.forge.sdk.copilot.code_block_preflight import SANDBOX_UNRESOLVED_NAME_REASON_CODEfrom skyvern.forge.sdk.copilot.code_block_synthesis import (is_optional_dismissal_only_trajectory,@@ -821,6 +826,23 @@ def _recorded_build_test_outcome_prompt(ctx: CopilotContext | None) -> str:lines.append(f"workflow_run_id: {_clean_authoring_repair_prompt_atom(outcome.workflow_run_id)}")if outcome.observed_evidence_summary:lines.append(f"observed_evidence: {_clean_authoring_repair_prompt_atom(outcome.observed_evidence_summary)}")+ if outcome.observed_page_value_excerpt:+ rendered_values = _clean_authoring_repair_prompt_atom(+ outcome.observed_page_value_excerpt, max_chars=_VALUE_EXCERPT_MAX+ )+ output_paths = [+ _clean_authoring_repair_prompt_atom(str(fact.get("output_path")))+ for fact in outcome.missing_requested_output_facts+ if isinstance(fact, dict) and isinstance(fact.get("output_path"), str) and fact.get("output_path")+ ]+ scaffold_lines = observed_value_extraction_scaffold_lines(rendered_values, output_paths)+ lines.extend(scaffold_lines)+ LOG.info(+ "copilot_observed_value_scaffold_surfaced",+ excerpt_len=len(rendered_values),+ output_path_count=len(output_paths),+ scaffold_line_count=len(scaffold_lines),+ )grounding = getattr(ctx, "recorded_outcome_grounding_requirement", None)if isinstance(grounding, RecordedOutcomeGroundingRequirement) and grounding.payload is not None:payload = grounding.payloaddiff --git a/skyvern/forge/sdk/copilot/build_test_outcome.py b/skyvern/forge/sdk/copilot/build_test_outcome.pyindex 53902574c..e55358f1a 100644--- a/skyvern/forge/sdk/copilot/build_test_outcome.py+++ b/skyvern/forge/sdk/copilot/build_test_outcome.py@@ -56,6 +56,7 @@ _STRUCTURAL_KEY_VERSION = "recorded_build_test_outcome:v1"_AUTHORED_STRUCTURE_VERSION = "recorded_build_test_outcome_authored_structure:v1"_TEXT_MAX = 180_REF_TEXT_MAX = 96+_VALUE_EXCERPT_MAX = 700_HISTORY_LIMIT = 8_INSPECT_PAGE_SOURCE_TOOL = "inspect_page_for_composition"_PLAYWRIGHT_LOCATOR_WAIT_RE = re.compile(@@ -86,6 +87,7 @@ class RecordedBuildTestOutcome(BaseModel):runtime_output_repair_facts: list[dict[str, object]] = Field(default_factory=list)authored_structure_signature: str | None = Nonedisplay_text: str = ""+ observed_page_value_excerpt: str = ""key_provenance: dict[str, str] = Field(default_factory=dict)@property@@ -232,6 +234,17 @@ def latest_recorded_build_test_outcome_repeated(ctx: object) -> bool | None:return None+def run_backed_repair_evidence_exists(ctx: object) -> bool:+ fallback_run_id = getattr(ctx, "last_run_blocks_workflow_run_id", None)+ latest = getattr(ctx, "latest_recorded_build_test_outcome", None)+ if isinstance(latest, RecordedBuildTestOutcome):+ # An author-time reject is never run-backed even if a stale run id lingers on ctx; only a persisted run counts.+ if latest.phase != "persisted_block_run":+ return False+ return bool(latest.workflow_run_id or fallback_run_id)+ return bool(fallback_run_id)++def arm_recorded_outcome_grounding_requirement(ctx: object) -> RecordedOutcomeGroundingRequirement | None:outcome = getattr(ctx, "latest_recorded_build_test_outcome", None)if not isinstance(outcome, RecordedBuildTestOutcome) or not outcome.is_authoritative:@@ -524,6 +537,7 @@ def recorded_outcome_from_author_time_reject(structural_payload: Mapping[str, object] | None = None,authored_structure_signature: str | None = None,observed_evidence_summary: str = "",+ observed_page_value_excerpt: str = "",page_evidence_refs: Sequence[str] = (),missing_requested_output_facts: Sequence[Mapping[str, object]] = (),) -> RecordedBuildTestOutcome:@@ -540,6 +554,7 @@ def recorded_outcome_from_author_time_reject(authored_structure_signature=authored_structure_signature,missing_requested_output_facts=[dict(fact) for fact in missing_requested_output_facts],observed_evidence_summary=_bounded_text(observed_evidence_summary),+ observed_page_value_excerpt=" ".join(observed_page_value_excerpt.split())[:_VALUE_EXCERPT_MAX],page_evidence_refs=_clean_list(page_evidence_refs),key_provenance={"structural_failure_identity": "author-time validator structural reason",@@ -612,6 +627,14 @@ def recorded_outcome_from_scout_act_observe_hollow(source_origin = _origin_ref(source_url)current_origin = _origin_ref(current_url)bounded_recapture_result = _bounded_ref(recapture_result)+ value_excerpt = _observed_page_value_excerpt(page_evidence)+ LOG.info(+ "copilot_hollow_value_carry",+ reason_code="scout_act_observe_hollow_after_interaction",+ value_excerpt_len=len(value_excerpt),+ value_excerpt_sha8=hashlib.sha256(value_excerpt.encode()).hexdigest()[:8] if value_excerpt else "",+ current_origin=current_origin,+ )structural_payload = {"interaction_tool": _bounded_ref(interaction_tool),"selector": _bounded_ref(selector),@@ -641,6 +664,7 @@ def recorded_outcome_from_scout_act_observe_hollow(structural_failure_identity="scout_act_observe:" + _stable_hash(structural_payload),page_evidence_refs=page_refs,observed_evidence_summary="Scout interaction reached the page, but bounded page evidence stayed hollow.",+ observed_page_value_excerpt=value_excerpt,key_provenance={"structural_failure_identity": "scout interaction identity and bounded hollow page shape","page_evidence_refs": "scout interaction source/current URL origins and structural counts",@@ -1036,6 +1060,32 @@ def _origin_ref(value: object) -> str:return f"origin:{parsed.scheme}://{parsed.netloc}"+def _observed_page_value_excerpt(page_evidence: Mapping[str, object] | None) -> str:+ evidence = page_evidence or {}+ for key in ("visible_text_excerpt", "visible_text", "bodyText"):+ text = _safe_str(evidence.get(key))+ if text.strip():+ return " ".join(text.split())[:_VALUE_EXCERPT_MAX]+ return ""+++def observed_value_extraction_scaffold_lines(observed_values: str, output_paths: Sequence[str]) -> list[str]:+ observed_values = " ".join(observed_values.split())[:_VALUE_EXCERPT_MAX]+ if not observed_values:+ return []+ paths = [path for path in dict.fromkeys(str(p).strip() for p in output_paths) if path]+ if not paths:+ return [f"observed_page_values: {observed_values}"]+ lines = [+ "OBSERVED PAGE VALUES CONTRACT: author a keyed extraction over the on-screen values below and bind "+ "each required output_path to its observed value.",+ f"observed_values: {observed_values}",+ "bind_output_paths:",+ ]+ lines.extend(f"- {path}: <observed value>" for path in paths[:8])+ return lines++def _hollow_page_shape(page_evidence: Mapping[str, object] | None) -> dict[str, object]:evidence = page_evidence or {}challenge_state = evidence.get("challenge_state")diff --git a/skyvern/forge/sdk/copilot/enforcement.py b/skyvern/forge/sdk/copilot/enforcement.pyindex 779eaccd8..10d82d250 100644--- a/skyvern/forge/sdk/copilot/enforcement.py+++ b/skyvern/forge/sdk/copilot/enforcement.py@@ -29,6 +29,7 @@ from skyvern.forge.sdk.copilot.build_phase import DISCOVERY_PERMITTED_PHASESfrom skyvern.forge.sdk.copilot.build_test_outcome import (RecordedBuildTestOutcome,author_time_reject_missing_output_paths,+ run_backed_repair_evidence_exists,)from skyvern.forge.sdk.copilot.code_block_synthesis import (is_durable_fallback_entry_target,@@ -340,7 +341,7 @@ def _repair_loop_state(ctx: Any) -> RepairLoopState | None:def _needs_repair_ceiling_halt(ctx: Any) -> bool:state = _repair_loop_state(ctx)- return state is not None and state.ceiling_reached is True+ return state is not None and state.ceiling_reached is True and run_backed_repair_evidence_exists(ctx)def repair_ceiling_stop_signal(@@ -1443,7 +1444,7 @@ def _check_enforcement(if _needs_repair_ceiling_halt(ctx):contract = getattr(ctx, "latest_diagnosis_repair_contract", None)state = _repair_loop_state(ctx)- # Backstop: the detection-time latch normally raises this above; this catches any increment path that bypassed the latch.+ # Backstop: detection-time latch normally raises this above; catches a run-backed increment that bypassed it.signal = repair_ceiling_stop_signal(ctx, contract, config)stash_blocker_signal(ctx, signal)stash_repair_ceiling_turn_halt(diff --git a/skyvern/forge/sdk/copilot/tools/run_execution.py b/skyvern/forge/sdk/copilot/tools/run_execution.pyindex 5d6750d88..2573d6168 100644--- a/skyvern/forge/sdk/copilot/tools/run_execution.py+++ b/skyvern/forge/sdk/copilot/tools/run_execution.py@@ -29,6 +29,7 @@ from skyvern.forge.sdk.copilot.build_test_outcome import (latest_recorded_build_test_outcome_repeated,record_build_test_outcome,recorded_outcome_from_run_blocks_result,+ run_backed_repair_evidence_exists,)from skyvern.forge.sdk.copilot.code_block_security import (COPILOT_CODE_SECURITY_FAILURE_CATEGORY,@@ -2846,7 +2847,7 @@ def _update_repair_loop_state(copilot_ctx: CopilotContext, contract: DiagnosisRe)if _should_arm_recorded_outcome_grounding(copilot_ctx):arm_recorded_outcome_grounding_requirement(copilot_ctx)- if contract.repair_loop_state.ceiling_reached:+ if contract.repair_loop_state.ceiling_reached and run_backed_repair_evidence_exists(copilot_ctx):signal = repair_ceiling_stop_signal(copilot_ctx, contract)stash_blocker_signal(copilot_ctx, signal)stash_repair_ceiling_turn_halt(copilot_ctx, signal, consecutive_identical_repair_count=count)diff --git a/skyvern/forge/sdk/copilot/tools/workflow_update.py b/skyvern/forge/sdk/copilot/tools/workflow_update.pyindex 4dccba7f2..2f58a68ea 100644--- a/skyvern/forge/sdk/copilot/tools/workflow_update.py+++ b/skyvern/forge/sdk/copilot/tools/workflow_update.py@@ -1212,6 +1212,10 @@ def _record_author_time_reject_outcome(block_labels: list[str] | None = None,missing_requested_output_facts: list[dict[str, object]] | None = None,) -> None:+ prior_outcome = ctx.latest_recorded_build_test_outcome+ observed_page_value_excerpt = (+ prior_outcome.observed_page_value_excerpt if isinstance(prior_outcome, RecordedBuildTestOutcome) else ""+ )record_build_test_outcome(ctx,recorded_outcome_from_author_time_reject(@@ -1220,6 +1224,7 @@ def _record_author_time_reject_outcome(structural_payload=structural_payload,authored_structure_signature=authored_structure_signature,observed_evidence_summary=summary,+ observed_page_value_excerpt=observed_page_value_excerpt,missing_requested_output_facts=missing_requested_output_facts or [],),)diff --git a/tests/unit/test_copilot_agent_helpers.py b/tests/unit/test_copilot_agent_helpers.pyindex 63975b92a..0ad257806 100644--- a/tests/unit/test_copilot_agent_helpers.py+++ b/tests/unit/test_copilot_agent_helpers.py@@ -966,6 +966,53 @@ workflow_definition:assert "Use the exact output_path values in goal_value_paths and returned output" in promptassert "output_root is diagnostic grouping only" in prompt+ def test_recorded_build_test_outcome_prompt_surfaces_observed_page_values(self) -> None:+ long_value = "Request WTR-1842-DEMO for account 100245 confirmed. " + "detail " * 40+ ctx = _ctx(+ block_authoring_policy=BlockAuthoringPolicy.CODE_ONLY_BROWSER,+ latest_recorded_build_test_outcome=RecordedBuildTestOutcome(+ phase="scout_evaluate",+ attempted_tool="scout_interaction",+ attempted_target="#submit",+ verdict="repairable_failure",+ reason_code="scout_act_observe_hollow_after_interaction",+ structural_failure_identity="scout_act_observe:hollow",+ page_evidence_refs=["origin:https://example.com"],+ observed_page_value_excerpt=long_value.strip(),+ ),+ )++ prompt = agent_module._recorded_build_test_outcome_prompt(ctx)++ value_line = next(line for line in prompt.splitlines() if line.startswith("observed_page_values:"))+ assert "WTR-1842-DEMO" in value_line+ assert "100245" in value_line+ assert len(value_line) > 200++ def test_recorded_build_test_outcome_prompt_binds_observed_values_on_metadata_reject(self) -> None:+ ctx = _ctx(+ block_authoring_policy=BlockAuthoringPolicy.CODE_ONLY_BROWSER,+ latest_recorded_build_test_outcome=RecordedBuildTestOutcome(+ phase="author_time_reject",+ attempted_tool="update_workflow",+ verdict="authoring_rejected",+ reason_code="metadata_reject",+ structural_failure_identity="author_time:metadata_reject",+ observed_page_value_excerpt="Request WTR-1842-DEMO for account 100245 confirmed.",+ missing_requested_output_facts=[+ {"output_root": "output", "output_path": "output.confirmation_number"},+ {"output_root": "output", "output_path": "output.account_number"},+ ],+ ),+ )++ prompt = agent_module._recorded_build_test_outcome_prompt(ctx)++ assert "OBSERVED PAGE VALUES CONTRACT" in prompt+ assert "observed_values: Request WTR-1842-DEMO for account 100245 confirmed." in prompt+ assert "- output.confirmation_number: <observed value>" in prompt+ assert "- output.account_number: <observed value>" in prompt+class TestVerifiedWorkflowOrNone:"""SKY-9143 strict invariant: a proposal surfaces only after a passing test this turn."""diff --git a/tests/unit/test_copilot_build_test_outcome.py b/tests/unit/test_copilot_build_test_outcome.pyindex ca2a485ff..a274bc855 100644--- a/tests/unit/test_copilot_build_test_outcome.py+++ b/tests/unit/test_copilot_build_test_outcome.py@@ -6,6 +6,7 @@ from skyvern.forge.sdk.copilot.build_test_outcome import (RecordedBuildTestOutcome,authored_structure_signature_from_workflow,latest_recorded_build_test_outcome_repeated,+ observed_value_extraction_scaffold_lines,record_build_test_outcome,recorded_outcome_from_author_time_reject,recorded_outcome_from_authoring_repair_context,@@ -133,7 +134,6 @@ def test_scout_act_observe_hollow_outcome_is_structural_and_privacy_bounded() ->recapture_result="timeout",)- dumped = outcome.model_dump(mode="json")key_payload = outcome.structural_key_payloadassert outcome.reason_code == "scout_act_observe_hollow_after_interaction"@@ -142,10 +142,124 @@ def test_scout_act_observe_hollow_outcome_is_structural_and_privacy_bounded() ->assert "recapture_attempted:true" in outcome.page_evidence_refsassert "recapture_result:timeout" in outcome.page_evidence_refsfor sensitive in ("token=secret", "name=customer", "acme-inc", "claim-123", "Customer name", "Private Account"):- assert sensitive not in str(dumped)assert sensitive not in str(key_payload)+def test_hollow_outcome_carries_observed_value_excerpt_off_the_structural_key() -> None:+ def _outcome(visible_text: str) -> RecordedBuildTestOutcome:+ return recorded_outcome_from_scout_act_observe_hollow(+ interaction_tool="click",+ selector="#submit",+ current_url="https://example.com/confirmation",+ source_url="https://example.com/form",+ page_evidence={+ "page_title": "Confirmation",+ "forms": [],+ "visible_text_excerpt": visible_text,+ },+ recapture_attempted=True,+ recapture_result="hollow",+ )++ confirmation = _outcome("Request WTR-1842-DEMO for account 100245 confirmed")+ other = _outcome("A completely different confirmation body")++ assert "WTR-1842-DEMO" in confirmation.observed_page_value_excerpt+ assert "100245" in confirmation.observed_page_value_excerpt+ assert confirmation.structural_key == other.structural_key+ assert "WTR-1842-DEMO" not in str(confirmation.structural_key_payload)+++def test_hollow_outcome_value_excerpt_falls_back_to_legacy_text_keys() -> None:+ from_visible_text = recorded_outcome_from_scout_act_observe_hollow(+ interaction_tool="click",+ selector="#submit",+ current_url="https://example.com/confirmation",+ source_url=None,+ page_evidence={"visible_text": "Legacy visible text body"},+ recapture_attempted=False,+ recapture_result="not_attempted_no_budget",+ )+ from_body_text = recorded_outcome_from_scout_act_observe_hollow(+ interaction_tool="click",+ selector="#submit",+ current_url="https://example.com/confirmation",+ source_url=None,+ page_evidence={"bodyText": "Legacy body text body"},+ recapture_attempted=False,+ recapture_result="not_attempted_no_budget",+ )++ assert from_visible_text.observed_page_value_excerpt == "Legacy visible text body"+ assert from_body_text.observed_page_value_excerpt == "Legacy body text body"+++def test_hollow_outcome_value_excerpt_is_bounded_and_key_independent() -> None:+ long_text = "X" * 5000+ outcome = recorded_outcome_from_scout_act_observe_hollow(+ interaction_tool="click",+ selector="#submit",+ current_url="https://example.com/confirmation",+ source_url=None,+ page_evidence={"visible_text_excerpt": long_text},+ recapture_attempted=True,+ recapture_result="hollow",+ )+ baseline = recorded_outcome_from_scout_act_observe_hollow(+ interaction_tool="click",+ selector="#submit",+ current_url="https://example.com/confirmation",+ source_url=None,+ page_evidence={"visible_text_excerpt": ""},+ recapture_attempted=True,+ recapture_result="hollow",+ )++ assert 0 < len(outcome.observed_page_value_excerpt) <= 700+ assert baseline.observed_page_value_excerpt == ""+ assert outcome.structural_key == baseline.structural_key+++def test_author_time_reject_carries_value_excerpt_off_the_convergence_key() -> None:+ carried = recorded_outcome_from_author_time_reject(+ reason_code="metadata_reject",+ structural_payload={"version": "metadata_reject_output_contract:v1", "signature": "abc"},+ observed_page_value_excerpt=" Request WTR-1842-DEMO for account 100245 " + "detail " * 400,+ missing_requested_output_facts=[{"output_path": "output.confirmation_number"}],+ )+ baseline = recorded_outcome_from_author_time_reject(+ reason_code="metadata_reject",+ structural_payload={"version": "metadata_reject_output_contract:v1", "signature": "abc"},+ missing_requested_output_facts=[{"output_path": "output.confirmation_number"}],+ )++ assert "WTR-1842-DEMO" in carried.observed_page_value_excerpt+ assert 0 < len(carried.observed_page_value_excerpt) <= 700+ assert "WTR-1842-DEMO" not in str(carried.structural_key_payload)+ assert carried.structural_key == baseline.structural_key+++def test_observed_value_extraction_scaffold_binds_output_paths() -> None:+ scaffold = observed_value_extraction_scaffold_lines(+ "Request WTR-1842-DEMO for account 100245",+ ["output.confirmation_number", "output.account_number", "output.confirmation_number"],+ )++ assert scaffold[0].startswith("OBSERVED PAGE VALUES CONTRACT")+ assert "observed_values: Request WTR-1842-DEMO for account 100245" in scaffold+ assert "bind_output_paths:" in scaffold+ assert "- output.confirmation_number: <observed value>" in scaffold+ assert "- output.account_number: <observed value>" in scaffold+ assert sum(1 for line in scaffold if line.startswith("- output.confirmation_number")) == 1+++def test_observed_value_extraction_scaffold_without_paths_surfaces_values_only() -> None:+ assert observed_value_extraction_scaffold_lines("Confirmed WTR-1842-DEMO", []) == [+ "observed_page_values: Confirmed WTR-1842-DEMO"+ ]+ assert observed_value_extraction_scaffold_lines(" ", ["output.x"]) == []++def test_prose_or_label_only_typed_outcome_is_not_authoritative() -> None:outcome = RecordedBuildTestOutcome(phase="author_time_reject",diff --git a/tests/unit/test_copilot_diagnosis_repair_contract.py b/tests/unit/test_copilot_diagnosis_repair_contract.pyindex 215ceb671..e472bc749 100644--- a/tests/unit/test_copilot_diagnosis_repair_contract.py+++ b/tests/unit/test_copilot_diagnosis_repair_contract.py@@ -479,10 +479,12 @@ def test_uncovered_output_author_reject_reopens_once_then_counts_to_ceiling() ->assert ctx.synthesized_block_reopened_for_output_coverage is Trueassert ctx.consecutive_non_converging_repair_count == 0- counts = [_run_repair_loop_state(ctx).consecutive_identical_repair_count for _ in range(3)]+ states = [_run_repair_loop_state(ctx) for _ in range(3)]+ counts = [state.consecutive_identical_repair_count for state in states]assert counts == [1, 2, 3]assert counts[-1] == settings.COPILOT_REPAIR_CEILING_CONSECUTIVE_IDENTICAL- assert isinstance(getattr(ctx, "blocker_signal", None), CopilotToolBlockerSignal)+ assert states[-1].ceiling_reached is True+ assert ctx.blocker_signal is Nonedef test_persisted_run_outcome_is_not_excluded_from_repair_streak() -> None:diff --git a/tests/unit/test_copilot_enforcement_hardening.py b/tests/unit/test_copilot_enforcement_hardening.pyindex 21d82347c..6ad4f062e 100644--- a/tests/unit/test_copilot_enforcement_hardening.py+++ b/tests/unit/test_copilot_enforcement_hardening.py@@ -454,11 +454,26 @@ def _ceiling_reached_contract() -> DiagnosisRepairContract:)-def test_repair_ceiling_precedes_code_authoring_churn_backstop() -> None:+def test_zero_run_ceiling_yields_to_code_authoring_churn_backstop() -> None:ctx = _fresh_context()ctx.code_authoring_guardrail_reject_count = MAX_CODE_AUTHORING_GUARDRAIL_REJECTSctx.latest_diagnosis_repair_contract = _ceiling_reached_contract()+ with pytest.raises(CopilotTurnHalt) as excinfo:+ _check_enforcement(ctx)++ assert excinfo.value.halt.kind is TurnHaltKind.LOOP_DETECTED+ signal = ctx.blocker_signal+ assert isinstance(signal, CopilotToolBlockerSignal)+ assert signal.internal_reason_code == "code_authoring_guardrail_churn"+++def test_run_backed_ceiling_precedes_code_authoring_churn_backstop() -> None:+ ctx = _fresh_context()+ ctx.code_authoring_guardrail_reject_count = MAX_CODE_AUTHORING_GUARDRAIL_REJECTS+ ctx.latest_diagnosis_repair_contract = _ceiling_reached_contract()+ ctx.last_run_blocks_workflow_run_id = "wr_1"+with pytest.raises(CopilotTurnHalt) as excinfo:_check_enforcement(ctx)@@ -492,11 +507,27 @@ def test_credential_priority_churn_defers_below_higher_bound() -> None:assert ctx.blocker_signal is None-def test_credential_priority_churn_defers_to_repair_ceiling() -> None:+def test_zero_run_ceiling_yields_to_credential_priority_churn() -> None:+ ctx = _fresh_context()+ ctx.code_authoring_guardrail_reject_count = MAX_CREDENTIAL_PRIORITY_AUTHORING_REJECTS+ ctx.last_code_authoring_reject_was_credential_priority = True+ ctx.latest_diagnosis_repair_contract = _ceiling_reached_contract()++ with pytest.raises(CopilotTurnHalt) as excinfo:+ _check_enforcement(ctx)++ assert excinfo.value.halt.kind is TurnHaltKind.LOOP_DETECTED+ signal = ctx.blocker_signal+ assert isinstance(signal, CopilotToolBlockerSignal)+ assert signal.internal_reason_code == "credential_priority_authoring_churn"+++def test_run_backed_ceiling_precedes_credential_priority_churn() -> None:ctx = _fresh_context()ctx.code_authoring_guardrail_reject_count = MAX_CREDENTIAL_PRIORITY_AUTHORING_REJECTSctx.last_code_authoring_reject_was_credential_priority = Truectx.latest_diagnosis_repair_contract = _ceiling_reached_contract()+ ctx.last_run_blocks_workflow_run_id = "wr_1"with pytest.raises(CopilotTurnHalt) as excinfo:_check_enforcement(ctx)@@ -530,10 +561,25 @@ def test_no_progress_interaction_floor_does_not_raise_below_ceiling() -> None:assert ctx.blocker_signal is None-def test_no_progress_interaction_floor_defers_to_repair_ceiling() -> None:+def test_zero_run_ceiling_yields_to_no_progress_interaction_floor() -> None:+ ctx = _fresh_context()+ ctx.consecutive_no_progress_interaction_count = MAX_NO_PROGRESS_INTERACTION_ATTEMPTS+ ctx.latest_diagnosis_repair_contract = _ceiling_reached_contract()++ with pytest.raises(CopilotTurnHalt) as excinfo:+ _check_enforcement(ctx)++ assert excinfo.value.halt.kind is TurnHaltKind.LOOP_DETECTED+ signal = ctx.blocker_signal+ assert isinstance(signal, CopilotToolBlockerSignal)+ assert signal.internal_reason_code == "loop_detected_no_forward_progress_interaction"+++def test_run_backed_ceiling_precedes_no_progress_interaction_floor() -> None:ctx = _fresh_context()ctx.consecutive_no_progress_interaction_count = MAX_NO_PROGRESS_INTERACTION_ATTEMPTSctx.latest_diagnosis_repair_contract = _ceiling_reached_contract()+ ctx.last_run_blocks_workflow_run_id = "wr_1"with pytest.raises(CopilotTurnHalt) as excinfo:_check_enforcement(ctx)